r266516 - Replace hardcoded comment at 'lit.site.cfg.in'

Author: alexdenisov Date: Sat Apr 16 01:54:46 2016 New Revision: 266516 URL: http://llvm.org/viewvc/llvm-project?rev=266516&view=rev Log: Replace hardcoded comment at 'lit.site.cfg.in' At the moment almost every lit.site.cfg.in contains two lines comment: ## Autogenerated by LLVM/Clang configu

[clang-tools-extra] r266518 - Replace hardcoded comment at 'lit.site.cfg.in'

Author: alexdenisov Date: Sat Apr 16 02:01:42 2016 New Revision: 266518 URL: http://llvm.org/viewvc/llvm-project?rev=266518&view=rev Log: Replace hardcoded comment at 'lit.site.cfg.in' At the moment almost every lit.site.cfg.in contains two lines comment: ## Autogenerated by LLVM/Clang configu

Re: [PATCH] D11781: Refactored pthread usage in libcxx

rmaprath added a comment. Hi Eric, Thanks for the comments! I'll wait a bit for @espositofulvio in case if he wants to push this, otherwise I'll create a new diff with the suggested changes. For us (ARM), a threads porting layer is important on several RTOSes (where a full-blown pthreads imple

r266525 - Add missing headers (fix build after headers cleanup in LLVM)

Author: mehdi_amini Date: Sat Apr 16 03:14:10 2016 New Revision: 266525 URL: http://llvm.org/viewvc/llvm-project?rev=266525&view=rev Log: Add missing headers (fix build after headers cleanup in LLVM) From: Mehdi Amini Modified: cfe/trunk/include/clang/Lex/LiteralSupport.h Modified: cfe/tru

Re: [PATCH] D11781: Refactored pthread usage in libcxx

theraven added a comment. In http://reviews.llvm.org/D11781#403335, @rmaprath wrote: > For us (ARM), a threads porting layer is important on several RTOSes (where a > full-blown pthreads implementations is not available). I will see if I can > publish one of those porting layer implementations,

Re: [PATCH] D19165: [clang-tidy] Add modernize-increment-bool check.

Prazek added a comment. In http://reviews.llvm.org/D19165#403243, @alexfh wrote: > In http://reviews.llvm.org/D19165#403099, @Prazek wrote: > > > In http://reviews.llvm.org/D19165#402657, @aaron.ballman wrote: > > > > > This strikes me as something the compiler should diagnose instead of a > > >

Re: [PATCH] D11781: Refactored pthread usage in libcxx

rmaprath added a comment. In http://reviews.llvm.org/D11781#403343, @theraven wrote: > In http://reviews.llvm.org/D11781#403335, @rmaprath wrote: > > > For us (ARM), a threads porting layer is important on several RTOSes (where > > a full-blown pthreads implementations is not available). I will

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste updated this revision to Diff 53982. Alexander_Droste added a comment. - added test file to test for note diagnostics - changed BugReportVisitor to detect request usage purely based on state and existence of a request - added test that showcases a triple nonblocking usage of a re

Re: [PATCH] D18309: sourceRange function for MemRegion

Alexander_Droste updated this revision to Diff 53983. Alexander_Droste added a comment. - remove superflous '\param' from header comment http://reviews.llvm.org/D18309 Files: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h lib/StaticAnalyzer/Core/MemRegion.cpp Index: include/cl

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

Alexander_Droste added a comment. > The memory region for the va_list that was obtained from the analyzer in same > case was indeed an element region in the va_list checker. I fixed this issue, > and now it works properly. Then this patch might be ready to commit. :) http://reviews.llvm.org/

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

Alexander_Droste marked 18 inline comments as done. Alexander_Droste added a comment. http://reviews.llvm.org/D16044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste marked 20 inline comments as done. Alexander_Droste added a comment. http://reviews.llvm.org/D12761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11781: Refactored pthread usage in libcxx

espositofulvio added a comment. In http://reviews.llvm.org/D11781#400968, @rmaprath wrote: > Hi, could I know the status of this? I'd like to push this forward. > > @espositofulvio: Are you working on this? (just checking since this has gone > stale for a while). @EricWF: I can create a separate

Re: [PATCH] D11781: Refactored pthread usage in libcxx

rmaprath added a comment. In http://reviews.llvm.org/D11781#403378, @espositofulvio wrote: > In http://reviews.llvm.org/D11781#400968, @rmaprath wrote: > > > Hi, could I know the status of this? I'd like to push this forward. > > > > @espositofulvio: Are you working on this? (just checking since

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

staronj updated the summary for this revision. staronj updated this revision to Diff 53984. staronj added a comment. Check now finds implicit and explicit conversions from integer literal to bool. http://reviews.llvm.org/D18745 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize

Re: [PATCH] D18136: boost-use-to-string check

Prazek added inline comments. Comment at: clang-tidy/boost/UseToStringCheck.cpp:59 @@ +58,3 @@ + + if (CharType.isNull()) +return; alexfh wrote: > When can `CharType` be `isNull()`? Do you have a test case for this? I think it's because of some libstdc++ impl

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Awesome! Thank you for investing SO MUCH time into improving the checker and addressing the review comments. Do you have commit access? Nit: Please, use lower case letters for test name

Re: [PATCH] D18073: Add memory allocating functions

ariccio updated this revision to Diff 53995. ariccio added a comment. So, duh, it turns out I //can// use `_WIN32` to conditionally test. http://reviews.llvm.org/D18073 Files: llvm/tools/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp llvm/tools/clang/test/Analysis/alternative-malloc-ap