majnemer added a subscriber: majnemer.
Comment at: lib/Basic/Targets.cpp:2565-2577
@@ -2569,1 +2564,15 @@
+
+ void setAtomic() {
+if (getTriple().getArch() == llvm::Triple::x86_64) {
+ if (HasCX16)
+MaxAtomicInlineWidth = 128;
+ else
+MaxAtomicInline
Hello,
Here are a few changes that try to address some logic error bugs
reported by running scan-build over the Clang code base.
I have no background in compiler technology and I may have been trying
to fix false positives; here is a quick overview of what scan-build
reported, let me know if the
On 04/02/16 01:55, Ben Langmuir via cfe-commits wrote:
Author: benlangmuir
Date: Wed Feb 3 18:55:24 2016
New Revision: 259734
URL: http://llvm.org/viewvc/llvm-project?rev=259734&view=rev
Log:
Fix predefine for __NSConstantString struct type
Per review feedback the name was wrong and it can be
+1, if possible. There is a if (getLangOpts().ObjC1) block just before this.
2016-04-03 14:21 GMT+03:00 Vassil Vassilev via cfe-commits <
cfe-commits@lists.llvm.org>:
> On 04/02/16 01:55, Ben Langmuir via cfe-commits wrote:
>
>> Author: benlangmuir
>> Date: Wed Feb 3 18:55:24 2016
>> New Revisio
This type and the builtin it supports needs to work in C/C++ as well, not just
Objective-C. Are you running into a problem here, or is it just “weird” to
see it in the AST?
> On Apr 3, 2016, at 5:21 AM, Yaron Keren wrote:
>
> +1, if possible. There is a if (getLangOpts().ObjC1) block just be
I look at many AST dumps for small reduced code so it's mostly weird to see
this in the AST (and takes a bit of screen real estate) as it's not
something that originated in the code.
By now I'm used to ignoring it but would expect NSConstantString would
baffle new clang programmers. It would be nic
etienneb created this revision.
etienneb added reviewers: rnk, alexfh.
etienneb added a subscriber: cfe-commits.
A character within a string literal is not escaped correctly.
In this case, there is no semantic change because the invalid character turn
out to be NUL anyway.
note: "\0x12" is equiv
mgehre added a comment.
Thank you very much for your review. I'm sorry that I'm currently quite busy,
but I will find some time to answer at the end of this week.
http://reviews.llvm.org/D15031
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Isn't readability-implicit-bool-cast¶ should catch such issues? If not, I think
will be good idea to improve that check instead of introducing new one.
http://reviews.llvm.org/D18745
__
AndyG updated this revision to Diff 52513.
AndyG added a comment.
Ok, I've removed support for nested parentheses. Can this go through now?
Thanks.
http://reviews.llvm.org/D17149
Files:
include/clang/Basic/DiagnosticLexKinds.td
lib/Lex/PPMacroExpansion.cpp
test/Preprocessor/feature_test
kzhuravl created this revision.
kzhuravl added a reviewer: arsenm.
kzhuravl added subscribers: cfe-commits, bpurnomo.
Herald added a reviewer: tstellarAMD.
-mamdgpu-debugger-abi=: sets all needed debugger related target
features for given debugger abi
-mamdgpu-debugger-insert-nops: sets +amdgpu-
rsmith added inline comments.
Comment at: lib/Lex/PPMacroExpansion.cpp:1430-1432
@@ +1429,5 @@
+Preprocessor &PP,
+int(*Op)(Token &Tok,
+ Pre
ABataev added a comment.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D17963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:816-822
@@ -801,6 +815,9 @@
+
+ // A DSA refers to this captured region if the parent contexts match.
+ auto *ParentContext = RSI->TheCapturedDecl->getParent();
for (auto I = Stack.rbegin(), EE = Stack.rend();
Carlo,
Again you're talking about performance loss. I don't think that
performance loss violates some parsing/semantic/operation rules. If we
won't pass the argument by value the code will not work properly? OpenMP
4.5 does not specify anything about passing firstprivate args by value
or by ref
15 matches
Mail list logo
