Author: jtsoftware
Date: Tue Mar 22 15:57:51 2016
New Revision: 264092
URL: http://llvm.org/viewvc/llvm-project?rev=264092&view=rev
Log:
D18325: Added mm_malloc module export.
Modified:
cfe/trunk/lib/Headers/module.modulemap
cfe/trunk/test/Headers/xmmintrin.c
Modified: cfe/trunk/lib/Head
EricWF added a comment.
And looking at the current state of the single-threaded test suite this isn't
the only test that needs this fix applied.
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-singlethreaded-x86_64-linux-debian/builds/869
http://reviews.llvm.org/D18347
__
Author: jfb
Date: Tue Mar 22 16:12:48 2016
New Revision: 264098
URL: http://llvm.org/viewvc/llvm-project?rev=264098&view=rev
Log:
Update cxx-features test to C++1z
Forked from the following patch:
http://reviews.llvm.org/D17950
Modified:
cfe/trunk/test/Lexer/cxx-features.cpp
Modified: cfe
rjmccall added a comment.
Yes, you should just stick with your post-processing pass or something like it.
The design of linkonce_odr linkage is that such definitions will only be
emitted when they are actually used. Even with this attribute, a translation
unit that consists solely of:
__att
jfb abandoned this revision.
Comment at: lib/Frontend/InitPreprocessor.cpp:465
@@ +464,3 @@
+ if (LangOpts.CPlusPlus1z) {
+Builder.defineMacro("__cpp_lib_atomic_is_always_lock_free", "201603");
+ }
jfb wrote:
> rsmith wrote:
> > This should be defined by the
davidxl added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:398
@@ -397,2 +397,3 @@
if (PGOReader) {
getModule().setMaximumFunctionCount(PGOReader->getMaximumFunctionCount());
+auto *SummaryMD = PGOReader->getSummary().getMD(getModule().getContext());
jfb added a comment.
As discussed in now-abandoned http://reviews.llvm.org/D17950 I'll implement
everything in libc++. I just have to move the feature test macro to libc++.
http://reviews.llvm.org/D17951
___
cfe-commits mailing list
cfe-commits@lis
vsk added inline comments.
Comment at: test/Profile/profile-summary.c:5
@@ +4,3 @@
+// RUN: %clang %s -o - -mllvm -disable-llvm-optzns -emit-llvm -S
-fprofile-instr-use=%t.profdata | FileCheck %s
+//
+int begin(int i) {
davidxl wrote:
> vsk wrote:
> > ISTM that a
EricWF added a comment.
Re-building clang now so I can test the most recent changes.
Comment at: include/atomic:850
@@ +849,3 @@
+#if defined(__cpp_lib_atomic_is_always_lock_free)
+ static _LIBCPP_CONSTEXPR bool is_always_lock_free =
__atomic_always_lock_free(sizeof(__a_), 0);
eraman updated this revision to Diff 51342.
eraman added a comment.
Address Vedant's comments
http://reviews.llvm.org/D18289
Files:
lib/CodeGen/CodeGenModule.cpp
test/Profile/Inputs/profile-summary.proftext
test/Profile/profile-summary.c
Index: test/Profile/profile-summary.c
eraman marked 2 inline comments as done.
Comment at: lib/CodeGen/CodeGenModule.cpp:398-399
@@ -397,3 +397,4 @@
if (PGOReader) {
getModule().setMaximumFunctionCount(PGOReader->getMaximumFunctionCount());
+getModule().setProfileSummary(PGOReader->getSummary().getMD(VMCon
jfb updated this revision to Diff 51346.
jfb added a comment.
- Define __cpp_lib_atomic_is_always_lock_free in libc++
http://reviews.llvm.org/D17951
Files:
include/atomic
test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp
Index: test/std/atomics/atomics.lockfree/isalwayslockfree.p
jlebar abandoned this revision.
jlebar marked 7 inline comments as done.
jlebar added a comment.
Okay, after much discussion, we've decided to go with --relaxed-constexpr
instead of this. I have a patch for that which seems to mostly work, will send
it out soon.
http://reviews.llvm.org/D18328
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: rsmith, rnk, cfe-commits.
All constexpr functions are implicitly host+device, except for variadic
functions, which are not allowed on the device side.
As part of this change, we now allow you to overload a host+
rsmith added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:142-143
@@ -132,1 +141,4 @@
+ appendParameterTypes(CGT, prefix, FTP, FD, &SynthesizedParams);
+ RequiredArgs Required =
+ RequiredArgs::forPrototypePlus(FTP, StartParams + SynthesizedParams);
CanQualType re
Author: jlebar
Date: Tue Mar 22 17:06:19 2016
New Revision: 264106
URL: http://llvm.org/viewvc/llvm-project?rev=264106&view=rev
Log:
[CUDA] Don't allow templated variadic functions.
Reviewers: tra
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D18373
Modified:
cfe/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264106: [CUDA] Don't allow templated variadic functions.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D18373?vs=51332&id=51354#toc
Repository:
rL LLVM
http://reviews.llvm.o
richard.barton.arm added a comment.
Thanks for the help Eric. I'm just running a new patch now will put the new
patch up when I get back in to office tomorrow.
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
jlebar updated this revision to Diff 51357.
jlebar added a comment.
Actually run the tests, and fix the CUDA overloading test.
http://reviews.llvm.org/D18380
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
lib/Driver/Tools.cpp
lib/Frontend/CompilerInvocatio
rsmith resigned from this audit.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith (Auditor)
dim (Auditor)
http://reviews.llvm.org/rL244063
___
echristo added a comment.
First I'd like to note that the code quality here is really high, most of my
comments are higher level design decisions going with the driver and the
implementation here rather than that.
One meta comment: offload appears to be something that could be used for CUDA
an
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:80
@@ +79,3 @@
+ ResultT operator()(ArrayRef Args) const {
+std::vector InnerArgs;
+for (const ArgT &Ar
tra added a comment.
Now that H/D and HD cal all be in the same overload set, we'll also need
additional tests in CodeGenCUDA/function-overload.cu for cases that now became
legal.
http://reviews.llvm.org/D18380
___
cfe-commits mailing list
cfe-com
jlebar added a comment.
In http://reviews.llvm.org/D18380#381025, @tra wrote:
> Now that H/D and HD cal all be in the same overload set, we'll also need
> additional tests in CodeGenCUDA/function-overload.cu for cases that now
> became legal.
There are lots of tests that used to be compile er
We need tests to demonstrate that we pick correct function when we have mix
of HD+H/D in the overload set.
Existing tests only cover resolution of {HD,HD}, {H,H} {D,D} {H,D} sets
On Tue, Mar 22, 2016 at 4:59 PM, Justin Lebar wrote:
> jlebar added a comment.
>
> In http://reviews.llvm.org/D18380#
jlebar updated this revision to Diff 51366.
jlebar added a comment.
Add tests checking host+device overloading.
http://reviews.llvm.org/D18380
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
lib/Driver/Tools.cpp
lib/Frontend/CompilerInvocation.cpp
lib/Sem
jlebar added a comment.
In http://reviews.llvm.org/D18380#381031, @tra wrote:
> We need tests to demonstrate that we pick correct function when we have mix
> of HD+H/D in the overload set.
> Existing tests only cover resolution of {HD,HD}, {H,H} {D,D} {H,D} sets
Aha, got it. I think adding t
Hi Daniel,
Sorry for the delay, but I've been both away and catching up:
On Wed, Mar 9, 2016 at 4:00 AM Daniel Sanders
wrote:
> > > From: Eric Christopher [echri...@gmail.com]
> > > Sent: 09 March 2016 06:50
> > > To: reviews+d16139+public+275805419034a...@reviews.llvm.org; Bhushan
> Attarde; V
george.burgess.iv updated this revision to Diff 51374.
george.burgess.iv marked an inline comment as done.
george.burgess.iv added a comment.
Addressed all feedback
http://reviews.llvm.org/D17462
Files:
include/clang/CodeGen/CGFunctionInfo.h
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGExprCXX.cp
george.burgess.iv added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:142-143
@@ -132,1 +141,4 @@
+ appendParameterTypes(CGT, prefix, FTP, FD, &SynthesizedParams);
+ RequiredArgs Required =
+ RequiredArgs::forPrototypePlus(FTP, StartParams + SynthesizedParams);
Can
Author: cbieneman
Date: Tue Mar 22 20:47:05 2016
New Revision: 264125
URL: http://llvm.org/viewvc/llvm-project?rev=264125&view=rev
Log:
[Apple Clang] Expose llvm-config from stage2 builds in stage1
This exposes the stage2-llvm-config target though the stage1 build
configuration.
Modified:
c
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaOverload.cpp:10419
@@ -10418,3 +10429,1 @@
- ResultTy) ||
- (!S.getLangOpts().CPlusPlus && TargetType->isVoidPointerType())) {
ahatanak updated this revision to Diff 51376.
ahatanak added a comment.
Added a test in test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp to check expected
patterns are emitted.
http://reviews.llvm.org/D18196
Files:
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/EHScopeStack.h
ahatanak added a comment.
In http://reviews.llvm.org/D18196#375997, @rjmccall wrote:
> You should also check that any back-end peepholes we have in place (null type
> infos to signify a call-terminate landingpad?) aren't disturbed by the
> lifetime intrinsics.
I looked at the back-end passes
george.burgess.iv marked 3 inline comments as done.
Comment at: lib/Sema/SemaOverload.cpp:10419
@@ -10418,3 +10429,1 @@
- ResultTy) ||
- (!S.getLangOpts().CPlusPlus && TargetType->isVoidPointerType())) {
Matches.push_back(std::make
Author: gbiv
Date: Tue Mar 22 21:33:58 2016
New Revision: 264132
URL: http://llvm.org/viewvc/llvm-project?rev=264132&view=rev
Log:
[Sema] Allow implicit conversions of &overloaded_fn in C.
Also includes a minor ``enable_if`` docs update.
Currently, our address-of overload machinery will only all
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264132: [Sema] Allow implicit conversions of &overloaded_fn
in C. (authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D13704?vs=49333&id=51378#toc
Repository:
rL LLVM
http://reviews
jlebar updated this revision to Diff 51384.
jlebar added a comment.
Update test as discussed -- now we check that we're invoking the correct
overloads.
http://reviews.llvm.org/D18380
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
lib/Driver/Tools.cpp
lib/
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Previously we were using the codegen test to ensure that we choose the
right overload. But we can do this within sema, with a bit of
cleverness.
I left the constructor/destructor checks in CodeGen
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Principally, don't hardcode the line numbers of various notes. This
lets us make changes to the test without recomputing linenos everywhere.
Instead, just tell -verify that we may get 0 or more no
flx updated the summary for this revision.
flx updated this revision to Diff 51385.
flx marked 5 inline comments as done.
flx added a comment.
After testing the check against a large corpus I was able to remove the
unnecessary param index check. But I discovered that the check crashed on value
flx added inline comments.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:42
@@ +41,3 @@
+ decl().bind("param"));
+ Finder->addMatcher(
+ functionDecl(isDefinition(), unless(cxxMethodDecl(isOverride())),
alexfh wrote:
> Ca
hvarga added a comment.
Are there any thoughts about this patch?
http://reviews.llvm.org/D17378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 143 of 143 matches
Mail list logo
