baloghadamsoftware updated this revision to Diff 51259.
baloghadamsoftware added a comment.
LibASTMatchersReference.html regenerated
http://reviews.llvm.org/D17986
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unitt
baloghadamsoftware updated this revision to Diff 51263.
baloghadamsoftware added a comment.
LibASTMatchersReference.html updated
http://reviews.llvm.org/D18243
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersTest.cpp
Index
baloghadamsoftware added a comment.
My first thought was also to extend existing checker
misc-assign-operator-signature and rename it to just misc-assign-operator.
However, there is little benefit doing this: the two checkers check different
locations, one checks the signature while the other o
baloghadamsoftware added a comment.
Prerequisites (matchers) are accepted now.
http://reviews.llvm.org/D17987
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:760
@@ +759,3 @@
+ if (CurrentToken->is(tok::kw_export)) {
+// Find the 'from' part of export {...} from '...';
+// The difference here is that "export {...};" should not be treated as
--
Author: vkalintiris
Date: Tue Mar 22 05:41:20 2016
New Revision: 264035
URL: http://llvm.org/viewvc/llvm-project?rev=264035&view=rev
Log:
Fix warning about extra semicolon. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264037: [ASTMatchers] New matcher hasReturnValue added
(authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D17986?vs=51259&id=51266#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: alexfh
Date: Tue Mar 22 06:03:03 2016
New Revision: 264037
URL: http://llvm.org/viewvc/llvm-project?rev=264037&view=rev
Log:
[ASTMatchers] New matcher hasReturnValue added
Summary: A checker (will be uploaded after this patch) needs to check implicit
casts. Existing generic matcher "has"
alexfh added a subscriber: alexfh.
alexfh added a comment.
> the fix must be emphasized in the release notes
It seems like the best time to update the release notes is now, in this patch ;)
http://reviews.llvm.org/D18243
___
cfe-commits mailing
jbcoe added a comment.
Do you have commit access? I can apply this patch for you if not.
http://reviews.llvm.org/D17811
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst marked an inline comment as done.
Comment at: lib/Format/TokenAnnotator.cpp:760
@@ +759,3 @@
+ if (CurrentToken->is(tok::kw_export)) {
+// Find the 'from' part of export {...} from '...';
+// The difference here is that "export {...};" should not be tr
mprobst updated this revision to Diff 51267.
mprobst marked an inline comment as done.
mprobst added a comment.
- Address review comments:
http://reviews.llvm.org/D17440
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Forma
mprobst updated this revision to Diff 51268.
mprobst added a comment.
Rebase diff on current master.
http://reviews.llvm.org/D17440
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
mprobst updated this revision to Diff 51269.
mprobst added a comment.
- Address review comments:
- Add one more explanatory comment.
http://reviews.llvm.org/D17440
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/Form
mprobst marked 3 inline comments as done.
mprobst added a comment.
http://reviews.llvm.org/D17440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp:64
@@ -63,3 +63,3 @@
// bool.
- !match(findAll(callExpr(hasAnyArgument(DeclRef))), *If, *Result.Context)
+
!match(findAll(callExpr(hasAnyArgument(ignoringParenImpCast
alexfh added a comment.
In http://reviews.llvm.org/D17811#380124, @jbcoe wrote:
> Do you have commit access? I can apply this patch for you if not.
He does have commit access.
http://reviews.llvm.org/D17811
___
cfe-commits mailing list
cfe-commit
baloghadamsoftware added inline comments.
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:119
@@ -98,4 +118,3 @@
if (Context.getIntWidth(CastType) == Context.getIntWidth(CalcType)) {
-if (CalcType->isSpecificBuiltinType(BuiltinType::Int) ||
-CalcType->isS
richard.barton.arm created this revision.
richard.barton.arm added reviewers: EricWF, jamesr.
richard.barton.arm added a subscriber: cfe-commits.
Although not testing the annotations feature, the test still needs guarding for
thread-safety otherwise it will not compile at all.
http://reviews.llv
On 03/17/2016 09:06 PM, Reid Kleckner via cfe-commits wrote:
Author: rnk
Date: Thu Mar 17 15:06:58 2016
New Revision: 263740
URL: http://llvm.org/viewvc/llvm-project?rev=263740&view=rev
Log:
Revert "For MS ABI, emit dllexport friend functions defined inline in class"
This reverts commit r263738
danielmarjamaki added a comment.
In http://reviews.llvm.org/D13126#379306, @zaks.anna wrote:
> Why is there such a large jump in the number of warnings reported in the last
> patch iteration?
> It went from "1678 projects where scanned. In total I got 124 warnings" to
> "In 2215 projects it fo
danielmarjamaki added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:84
@@ +83,3 @@
+// Can E value be greater or equal than Val?
+static bool canBeGreaterEqual(CheckerContext &C, const Expr *E,
+ unsigned long long Val)
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
http://reviews.llvm.org/D17955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
danielmarjamaki added inline comments.
Comment at: test/clang-tidy/readability-non-const-parameter.cpp:116-134
@@ +115,21 @@
+
+// CHECK-MESSAGES: :[[@LINE+1]]:18: warning: parameter 'p' can be const
+int return1(int *p) {
+ // CHECK-FIXES: {{^}}int return1(const int *p) {{{$}}
+
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D18149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: aaronballman
Date: Tue Mar 22 08:37:44 2016
New Revision: 264049
URL: http://llvm.org/viewvc/llvm-project?rev=264049&view=rev
Log:
Fix crashes from delayed template parsing code that assumed getBody() would
return non-null.
Patch by Etienne Bergeron.
Added:
clang-tools-extra/trunk/
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r264049, thank you!
http://reviews.llvm.org/D18238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D18262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: aaronballman
Date: Tue Mar 22 08:44:36 2016
New Revision: 264050
URL: http://llvm.org/viewvc/llvm-project?rev=264050&view=rev
Log:
Moving files that were placed in the wrong directory from r264049.
Added:
clang-tools-extra/trunk/test/clang-tidy/cppcoreguidelines-pro-type-member-init-
aaron.ballman added a comment.
When running the tests from this patch locally (Win10, MSVC 2015, debug, x64),
I get:
1>-- Build started: Project: intrinsics_gen, Configuration: Debug x64 --
2>-- Build started: Project: ClangDiagnosticLex, Configuration: Debug x64
--
3>-- Bui
carlo.bertolli added a comment.
Hi Alexey
Thanks for your comment. The suggested change will not work as I intended in my
patch when using the host as a device. This happens when you select the
following options:
-fomptargets=powerpc64le-ibm-linux-gnu -fopenmp-is-device
In this case we generat
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Do you have commit access now?
http://reviews.llvm.org/D17440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
mprobst added a comment.
I've asked for it, but don't have it yet. Feel free to commit on by behalf.
http://reviews.llvm.org/D17440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, Mar 21, 2016 at 11:22 AM, Robert Bolter via cfe-commits
wrote:
> Hi,
>
> First time poster here, Please advise…
Thank you for the patches, and welcome!
One piece of advice: it's easier for code reviewers to review
unrelated patches in separate email chains.
Also, if you use Phab instead
mkuron added a comment.
The three smaller patches into which you divided this one appear to be missing
some things. For example, `AddOpenMPLinkerScript` in //lib/Driver/Tools.cpp//
from this patch appears to still be necessary to get the desired functionality,
but it is not present in any of th
Eugene.Zelenko added a comment.
As user I could tell that it's much easier to have one check which will check
all nuances of particular language construction then multiple checks.
http://reviews.llvm.org/D18265
___
cfe-commits mailing list
cfe-comm
carlo.bertolli updated this revision to Diff 51285.
carlo.bertolli added a comment.
To make clear my comment I an updating the patch following Alexey's comment and
modifying it to make it work.
You can see that now we have the following check:
CGM.getTarget().getTriple().getArch() == llvm::Triple
alexfh accepted this revision.
alexfh added a comment.
LG. Thanks for the fix!
http://reviews.llvm.org/D18262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
LG
http://reviews.llvm.org/D18293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Tue Mar 22 09:32:20 2016
New Revision: 264055
URL: http://llvm.org/viewvc/llvm-project?rev=264055&view=rev
Log:
clang-format: [JS] do not wrap ES6 imports/exports.
"import ... from '...';" and "export ... from '...';" should be treated
the same as goog.require/provide/module
djasper closed this revision.
djasper added a comment.
Submitted as r264055.
http://reviews.llvm.org/D17440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
baloghadamsoftware updated this revision to Diff 51287.
baloghadamsoftware added a comment.
Release notes updated.
http://reviews.llvm.org/D18243
Files:
docs/LibASTMatchersReference.html
docs/ReleaseNotes.rst
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersTest.
sfantao added a comment.
Hi Michael,
In http://reviews.llvm.org/D9888#380225, @mkuron wrote:
> The three smaller patches into which you divided this one appear to be
> missing some things. For example, `AddOpenMPLinkerScript` in
> //lib/Driver/Tools.cpp// from this patch appears to still be ne
alexfh accepted this revision.
alexfh added a comment.
LG
Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:21
@@ +20,3 @@
+
+void recordFixes(const VarDecl &Var, ASTContext &Context,
+ DiagnosticBuilder &Diagnostic) {
nit: Alt
fowles added inline comments.
Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:21
@@ +20,3 @@
+
+void recordFixes(const VarDecl &Var, ASTContext &Context,
+ DiagnosticBuilder &Diagnostic) {
I am inclined to just leave it as is f
fowles updated this revision to Diff 51289.
fowles added a comment.
rebased to latest. Can someone submit this for me I don't have commit bits.
http://reviews.llvm.org/D18149
Files:
clang-tidy/performance/UnnecessaryCopyInitialization.cpp
clang-tidy/performance/UnnecessaryCopyInitializatio
fowles added a subscriber: fowles.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:8
@@ +7,3 @@
+ void nonConstMethod() {}
+ virtual ~ExpensiveToCopyType() {}
+};
you don't actually need to fill in these methods, just declare them
==
alexfh added a comment.
Adding Manuel, who might have better ideas.
In http://reviews.llvm.org/D17981#374904, @rnk wrote:
> In http://reviews.llvm.org/D17981#374553, @etienneb wrote:
>
> > This is a huge difference. I didn't expect dependencies to bring so much
> > code.
> > I'm not a fan of h
I think setting `cc1_env["LLVM_PROFILE_FILE"] = os.devnull` would be simpler.
vedant
> On Mar 21, 2016, at 7:55 PM, Chris Bieneman via cfe-commits
> wrote:
>
> Author: cbieneman
> Date: Mon Mar 21 21:55:40 2016
> New Revision: 264021
>
> URL: http://llvm.org/viewvc/llvm-project?rev=264021&vie
Author: cbieneman
Date: Tue Mar 22 11:27:35 2016
New Revision: 264063
URL: http://llvm.org/viewvc/llvm-project?rev=264063&view=rev
Log:
[Perf-training] Cleanup based on feedback from Sean Silvas
Sean provided feedback based on r257934 on cfe-commits. This change addresses
that feedback.
Modifie
Sean,
All good feedback.
Using print_function was done in r257936 with some other feedback from Bogner.
The rest of your feedback I believe I have addressed in r264063.
-Chris
> On Mar 21, 2016, at 9:21 PM, Sean Silva wrote:
>
>
>
> On Fri, Jan 15, 2016 at 1:21 PM, Chris Bieneman via cfe-c
Author: cbieneman
Date: Tue Mar 22 11:33:23 2016
New Revision: 264064
URL: http://llvm.org/viewvc/llvm-project?rev=264064&view=rev
Log:
[Perf-training] Using os.devnull instead of a temp file
This is based on post-commit feedback from Vedant. Totally didn't know that
existed and worked on Window
I totally didn’t know python had a portable way to do that!
Updated in r264064.
Thanks!
-Chris
> On Mar 22, 2016, at 9:26 AM, Vedant Kumar wrote:
>
> I think setting `cc1_env["LLVM_PROFILE_FILE"] = os.devnull` would be simpler.
>
> vedant
>
>> On Mar 21, 2016, at 7:55 PM, Chris Bieneman via
Author: majnemer
Date: Tue Mar 22 11:44:39 2016
New Revision: 264065
URL: http://llvm.org/viewvc/llvm-project?rev=264065&view=rev
Log:
[MS ABI] Assign an inheritance model for the dest of a member pointer upcast
While we correctly assigned an inheritance model for the source of a
member pointer u
yaxunl marked an inline comment as done.
Comment at: include/clang/Basic/Attr.td:701
@@ -699,1 +700,3 @@
+def OpenCLNoSVM : Attr {
+ let Spellings = [GNU<"nosvm">];
aaron.ballman wrote:
> yaxunl wrote:
> > aaron.ballman wrote:
> > > Since the attribute is ignor
Author: majnemer
Date: Tue Mar 22 12:10:07 2016
New Revision: 264066
URL: http://llvm.org/viewvc/llvm-project?rev=264066&view=rev
Log:
Make build bots happy
BasicBlock's lose their names for some builders, don't mention such
names.
Modified:
cfe/trunk/test/CodeGenCXX/pr27030.cpp
Modified: c
yaxunl updated the summary for this revision.
yaxunl removed rL LLVM as the repository for this revision.
yaxunl updated this revision to Diff 51297.
yaxunl added a comment.
Simplify description of this attribute in AttrDocs since it causes some
confusion.
http://reviews.llvm.org/D18095
Files:
yaxunl added a comment.
If __attribute__((linkonce_odr_linkage)) is not a proper name for explicitly
setting linkage, how about __attribute((linkage=linkonce_odr))? This can be
extended to other linkages too.
http://reviews.llvm.org/D18095
___
cfe
etienneb updated this revision to Diff 51298.
etienneb added a comment.
Rebased + fixing invalid paths.
The diff paths were wrong, invalid diff.
http://reviews.llvm.org/D18293
Files:
clang-tidy/readability/RedundantStringInitCheck.cpp
test/clang-tidy/readability-redundant-string-init-msvc.
LegalizeAdulthood added inline comments.
Comment at: test/clang-tidy/readability-non-const-parameter.cpp:116-134
@@ +115,21 @@
+
+// CHECK-MESSAGES: :[[@LINE+1]]:18: warning: parameter 'p' can be const
+int return1(int *p) {
+ // CHECK-FIXES: {{^}}int return1(const int *p) {{{$}}
LegalizeAdulthood added a comment.
Looks like I forgot to remove brace initializers from the test files. I will
fix that.
Chris Lattner has given me commit access now, so I can commit on my own.
http://reviews.llvm.org/D16529
___
cfe-commits maili
Ugh, templates and friend function definitions strike again!
I think this is where "semantic" vs. "lexical" DeclContexts come into play.
Try doing D->getLexicalDeclContext()->isDependentContext().
On Tue, Mar 22, 2016 at 5:23 AM, Stephan Bergmann
wrote:
> On 03/17/2016 09:06 PM, Reid Kleckner v
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
I think this diff is messed up a little. Could you upload a fixed diff?
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cf
Author: etienneb
Date: Tue Mar 22 12:39:36 2016
New Revision: 264069
URL: http://llvm.org/viewvc/llvm-project?rev=264069&view=rev
Log:
[clang-tidy] Fix redundant-string-init check with msvc 14 headers.
Summary:
The string constructors are not defined using optional parameters and are not
recogni
apaprocki created this revision.
apaprocki added a subscriber: cfe-commits.
This patch adds Clang driver support for the AIX platform. This allows Clang
to be used for compiling code / checking for errors, but does not allow for
building executables, as AIX uses XCOFF and not ELF.
After applyi
sbenza added a comment.
In http://reviews.llvm.org/D17811#380124, @jbcoe wrote:
> Do you have commit access? I can apply this patch for you if not.
I do.
I am waiting on http://reviews.llvm.org/D18275 to fix the problem with using
internal::HasNameMatcher directly.
http://reviews.llvm.org/D1
Author: bogner
Date: Tue Mar 22 12:50:05 2016
New Revision: 264071
URL: http://llvm.org/viewvc/llvm-project?rev=264071&view=rev
Log:
StaticAnalyzer: Avoid an unintentional copy
The range here isn't over references, so using `auto &` here incites a
copy. Switching to `auto *` would do, but we migh
etienneb updated this revision to Diff 51305.
etienneb added a comment.
rebase + fixing invalid paths
http://reviews.llvm.org/D18262
Files:
clang-tidy/ClangTidy.cpp
test/clang-tidy/misc-macro-parentheses-cmdline.cpp
Index: test/clang-tidy/misc-macro-parentheses-cmdline.cpp
Author: etienneb
Date: Tue Mar 22 12:51:27 2016
New Revision: 264073
URL: http://llvm.org/viewvc/llvm-project?rev=264073&view=rev
Log:
[clang-tidy] Skip reporting of not applicable fixes.
Summary:
Invalid source location are causing clang-tidy to crash when manipulating an
invalid file.
Macro d
Anastasia updated this revision to Diff 51303.
Anastasia added a comment.
Thanks to Aleksey Bader for rebasing this patch to ToT and fixing some tests
issues!
http://reviews.llvm.org/D17821
Files:
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/AST/OpenCLI
Author: etienneb
Date: Tue Mar 22 13:00:13 2016
New Revision: 264075
URL: http://llvm.org/viewvc/llvm-project?rev=264075&view=rev
Log:
[clang-tidy] Fix redundant-string-cstr check with msvc 14 headers.
Summary:
The string constructors are not defined using optional parameters and are not
recogni
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:84
@@ +83,3 @@
+// Can E value be greater or equal than Val?
+static bool canBeGreaterEqual(CheckerContext &C, const Expr *E,
+ unsigned long long Val) {
---
On Tue, Mar 22, 2016 at 10:50 AM, Justin Bogner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bogner
> Date: Tue Mar 22 12:50:05 2016
> New Revision: 264071
>
> URL: http://llvm.org/viewvc/llvm-project?rev=264071&view=rev
> Log:
> StaticAnalyzer: Avoid an unintentional copy
>
Jus
srhines accepted this revision.
srhines added a comment.
This revision is now accepted and ready to land.
I think this is trivial enough for me to accept. I also added cfe-commits, so
that they at least have a chance to review/comment.
Repository:
rL LLVM
http://reviews.llvm.org/D18363
__
etienneb created this revision.
etienneb added reviewers: rnk, alexfh.
etienneb added a subscriber: cfe-commits.
There is a silly bug that got introduced after fixing incorrect paths with this
patch:
http://reviews.llvm.org/D18293
The tests was present twice in the file.
http://reviews.llvm.org
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D18365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl:1
@@ -1,2 +1,2 @@
// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only -cl-std=CL2.0
Could you add a test case that fails before your modification here to show that
you
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
http://reviews.llvm.org/D17596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: etienneb
Date: Tue Mar 22 13:21:17 2016
New Revision: 264080
URL: http://llvm.org/viewvc/llvm-project?rev=264080&view=rev
Log:
[clang-tidy] Fix broken test with redundant string init (msvc).
Summary:
There is a silly bug that got introduced after fixing incorrect paths with this
patch:
h
Anastasia accepted this revision.
Anastasia added a comment.
LGTM, apart from small remark on the test!
Comment at: test/Frontend/backend-option.c:2
@@ +1,3 @@
+// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - 2>&1 |
FileCheck %s
+// RUN: %clang_cc1 %s -emit-l
jtsoftware edited reviewers, added: rsmith; removed: probinson, silvas.
jtsoftware updated this revision to Diff 51313.
jtsoftware added a comment.
Right. Also undoing moving stuff around. How about this? Thanks.
http://reviews.llvm.org/D18325
Files:
lib/Headers/module.modulemap
test/Hea
yaxunl marked an inline comment as done.
Comment at: test/Frontend/backend-option.c:2
@@ +1,3 @@
+// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - 2>&1 |
FileCheck %s
+// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - -triple
spir-unknown-unkno
richard.barton.arm updated this revision to Diff 51316.
richard.barton.arm added a comment.
Sorry - not sure what happened there. That looks better for me.
http://reviews.llvm.org/D18347
Files:
test/libcxx/thread/thread.mutex/thread_safety_annotations_not_enabled.pass.cpp
Index:
test/libcxx
EricWF added a comment.
I don't actually understand this change. This test should compile with or
without "-Wthread-safety" warning. This test doesn't actually turn the
annotations on, that's the point. If annotations were actually enabled this
test would fail to compile.
Could you explain the
Thanks!
On Tue, Mar 22, 2016 at 9:34 AM, Chris Bieneman wrote:
> Sean,
>
> All good feedback.
>
> Using print_function was done in r257936 with some other feedback from
> Bogner.
>
> The rest of your feedback I believe I have addressed in r264063.
>
> -Chris
>
> On Mar 21, 2016, at 9:21 PM, Sean
Anastasia added inline comments.
Comment at: test/Frontend/backend-option.c:2
@@ +1,3 @@
+// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - 2>&1 |
FileCheck %s
+// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - -triple
spir-unknown-unknown 2>&1
Hello everyone,
Below are some buildbot numbers for the week of 3/06/2016 - 3/12/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
Hello everyone,
Below are some buildbot numbers for the last week of 3/13/2016 - 3/19/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D18325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
pcc updated this revision to Diff 51324.
pcc added a comment.
- Use llvm.load.relative (http://reviews.llvm.org/D18367)
http://reviews.llvm.org/D18199
Files:
docs/UsersManual.rst
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGVTables.cpp
lib/CodeGen/CGVTables.h
li
rjmccall added a comment.
You still don't actually want linkonce_odr linkage. You don't want the weak
definition to be inlined, so it can't be ODR, and you want to force it to be
emitted in your library, so it can't be linkonce. You just want weak linkage.
There's an existing attribute for t
yaxunl updated this revision to Diff 51326.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Add -x cl to the test when compiling it for spir target.
http://reviews.llvm.org/D17552
Files:
lib/CodeGen/BackendUtil.cpp
test/Frontend/backend-option.c
Index: test/Frontend/backen
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
http://reviews.llvm.org/D18373
Files:
lib/Sema/SemaDecl.cpp
test/SemaCUDA/vararg.cu
Index: test/SemaCUDA/vararg.cu
===
--- test/
yaxunl added a comment.
Sorry my previous example may have caused some confusion.
Previously I said I wanted to override function definitions. However the only
reason we want to add this attribute is so that unused functions will be
dropped by the linker.
http://reviews.llvm.org/D18095
___
rjmccall added a comment.
Does your linker not supported dead-code stripping?
http://reviews.llvm.org/D18095
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
You could also get this effect by somehow making the definitions linkonce_odr
when they're linked in from the library. Or you could simply use the classic
static-archive technique of putting each symbol in its own object file and
linking against the whole thing as a s
tra added inline comments.
Comment at: include/clang/Driver/Action.h:79
@@ +78,3 @@
+OFFLOAD_None = 0x00,
+OFFLOAD_CUDA = 0x01,
+ };
Nit: All-caps CUDA looks weird here. _Cuda may be better choice.
If you can shorten the prefix that would be nice, too. OK
richard.barton.arm added a comment.
Hi Eric
Sorry for the delay - I originally detected the failure while not running in a
totally clean environment with clean sources, but I can reproduce on clean code.
I can reproduce by building with clean clang and libcxx sources:
cmake -DLLVM_PATH=/work/ri
tstellarAMD added a comment.
Hi John,
The problem we are trying to solve here is linking a LLVM bitcode program
(OpenCL kernel in this specific case) with an LLVM bitcode library (OpenCL
builtin library) and having the resulting LLVM bitcode module contain only the
program code and the library
EricWF added a comment.
I think the correct fix is "// UNSUPPORTED: libcpp-has-no-threads"
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 143 matches
Mail list logo
