r263997 - [Perf-training] Adding support for tests to skip the clang driver

2016-03-21 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Mon Mar 21 17:37:14 2016 New Revision: 263997 URL: http://llvm.org/viewvc/llvm-project?rev=263997&view=rev Log: [Perf-training] Adding support for tests to skip the clang driver This patch adds a new set of substitutions to the lit run lines for order files and PGO genera

Re: [PATCH] D18088: Add a new warning to notify users of mismatched SDK and deployment target

2016-03-21 Thread Edoardo Prezioso via cfe-commits
edward-san added a comment. I'm more concerned about some users who might think that option would work also with their favourite sdk (visual studio comes into mind as a common sdk). http://reviews.llvm.org/D18088 ___ cfe-commits mailing list cfe-co

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

2016-03-21 Thread Justin Lebar via cfe-commits
jlebar added inline comments. Comment at: include/clang/Driver/Options.td:383-384 @@ -382,2 +382,4 @@ HelpText<"Enable device-side debug info generation. Disables ptxas optimizations.">; +def cuda_allow_std_complex : Flag<["--"], "cuda-allow-std-complex">, + HelpText<"Allow C

[clang-tools-extra] r264001 - Fixed some cases in the modularize assistant mode where header file names didn't translate to valid module names.

2016-03-21 Thread John Thompson via cfe-commits
Author: jtsoftware Date: Mon Mar 21 18:05:14 2016 New Revision: 264001 URL: http://llvm.org/viewvc/llvm-project?rev=264001&view=rev Log: Fixed some cases in the modularize assistant mode where header file names didn't translate to valid module names. Modified: clang-tools-extra/trunk/modular

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

2016-03-21 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:479-481 @@ +478,5 @@ +return false; + StringRef Filename = FE->getName(); + if (Filename != "complex" && !Filename.endswith("/complex")) +return false; + jlebar wrote: > rsmith wrote: > > I

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

2016-03-21 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:464-465 @@ +463,4 @@ +// without passing -fcuda-allow-std-complex. +// TODO: Output a nvcc-compat warning if you try to use a non-constexpr function +// from -- nvcc only lets you use constexpr functions. +bool Sem

Re: [PATCH] D17950: Implement is_always_lock_free

2016-03-21 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:465 @@ +464,3 @@ + if (LangOpts.CPlusPlus1z) { +Builder.defineMacro("__cpp_lib_atomic_is_always_lock_free", "201603"); + } This should be defined by the relevant library header, not

Re: r263974 - clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting.

2016-03-21 Thread Richard Smith via cfe-commits
Seems to have caused a bot failure: http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/7039 The NOTRIPLE test appears to be picking up the version of MSVC from that installed on the system, so this passes or fails depending on which version of MSVC we find. On Mon, Mar 21, 2016

Re: [PATCH] D17950: Implement is_always_lock_free

2016-03-21 Thread JF Bastien via cfe-commits
jfb added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:465 @@ +464,3 @@ + if (LangOpts.CPlusPlus1z) { +Builder.defineMacro("__cpp_lib_atomic_is_always_lock_free", "201603"); + } rsmith wrote: > This should be defined by the relevant library

Re: [PATCH] D17950: Implement is_always_lock_free

2016-03-21 Thread Richard Smith via cfe-commits
On Mon, Mar 21, 2016 at 4:46 PM, JF Bastien via cfe-commits wrote: > jfb added inline comments. > > > Comment at: lib/Frontend/InitPreprocessor.cpp:465 > @@ +464,3 @@ > + if (LangOpts.CPlusPlus1z) { > +Builder.defineMacro("__cpp_lib_atomic_is_always_lock_free", "201603"); > +

r264007 - Revert r263974, "clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting."

2016-03-21 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Mon Mar 21 18:51:50 2016 New Revision: 264007 URL: http://llvm.org/viewvc/llvm-project?rev=264007&view=rev Log: Revert r263974, "clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting." It seems the test wouldn't expect if default target is *-win32. Modified:

Re: r263974 - clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting.

2016-03-21 Thread NAKAMURA Takumi via cfe-commits
Reverted in r264007. MSVC_NOTRIPLE and MSVC_ORIG were affected by the default target triple. Nico, could you tweak the test to be stable? On Tue, Mar 22, 2016 at 8:43 AM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Seems to have caused a bot failure: > > http://lab.llvm.o

Re: r263974 - clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting.

2016-03-21 Thread Nico Weber via cfe-commits
Thanks, attempting to fix. On Mon, Mar 21, 2016 at 7:43 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Seems to have caused a bot failure: > > http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/7039 > > The NOTRIPLE test appears to be picking up the vers

Re: [PATCH] D18327: [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl.

2016-03-21 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL264008: [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D18327?vs=51220&id=51247#toc Repository: rL LLVM http

Re: [PATCH] D18322: [CUDA] Implement atomicInc and atomicDec builtins

2016-03-21 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL264009: [CUDA] Implement atomicInc and atomicDec builtins (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D18322?vs=51191&id=51248#toc Repository: rL LLVM http://reviews.llvm.

r264008 - [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl.

2016-03-21 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Mar 21 19:09:25 2016 New Revision: 264008 URL: http://llvm.org/viewvc/llvm-project?rev=264008&view=rev Log: [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl. Summary: NFC Reviewers: tra Subscribers: cfe-commits Differential Revision: http://reviews.llvm

r264009 - [CUDA] Implement atomicInc and atomicDec builtins

2016-03-21 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Mar 21 19:09:28 2016 New Revision: 264009 URL: http://llvm.org/viewvc/llvm-project?rev=264009&view=rev Log: [CUDA] Implement atomicInc and atomicDec builtins These functions cannot be implemented as atomicrmw or cmpxchg instructions, so they are implemented as a call to t

Re: r263974 - clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting.

2016-03-21 Thread Nico Weber via cfe-commits
On Mon, Mar 21, 2016 at 8:09 PM, Nico Weber wrote: > Thanks, attempting to fix. > > On Mon, Mar 21, 2016 at 7:43 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Seems to have caused a bot failure: >> >> http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/bui

Re: [PATCH] D18325: export additional header modules from xmmintrin

2016-03-21 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. Comment at: lib/Headers/module.modulemap:48 @@ -47,3 +47,1 @@ - export mmx - export sse2 // note: for hackish dependency header "xmmintrin.h" Did you intentionally remove this comment? Comment

Re: r202683 - Introduce '-fmodules-user-build-path' which accepts the "canonical" path to a user workspace build.

2016-03-21 Thread Argyrios Kyrtzidis via cfe-commits
The long-term intention of this was to separate user modules vs system modules, so that you could have user modules generated in the project-specific build directory while system modules would be in the global directory shared across projects. That way when you deleted the project build director

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

2016-03-21 Thread Ryan Yee via cfe-commits
ryee88 added a comment. Yeah I don't think it's worth it to modify the general case wording to to explicitly call out the degenerate global nested-name-specifier. It'll cause more confusion for the general case. At this point, do we just close the bug and keep the new unit tests? http://revie

r264018 - [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-21 Thread Arpith Chacko Jacob via cfe-commits
Author: arpith Date: Mon Mar 21 20:48:56 2016 New Revision: 264018 URL: http://llvm.org/viewvc/llvm-project?rev=264018&view=rev Log: [OpenMP] Base support for target directive codegen on NVPTX device. Summary: This patch adds base support for codegen of the target directive on the NVPTX device.

r264020 - Visual Studio Native Visualizations for constructors and methods

2016-03-21 Thread Mike Spertus via cfe-commits
Author: mps Date: Mon Mar 21 21:29:22 2016 New Revision: 264020 URL: http://llvm.org/viewvc/llvm-project?rev=264020&view=rev Log: Visual Studio Native Visualizations for constructors and methods With this change, the class struct A { A(int _i); ~A(); int foo(double d); double b

r264021 - [Perf-training] Fixing an issue with multi-threading PGO generation

2016-03-21 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Mon Mar 21 21:55:40 2016 New Revision: 264021 URL: http://llvm.org/viewvc/llvm-project?rev=264021&view=rev Log: [Perf-training] Fixing an issue with multi-threading PGO generation When LIT parallelizes the profraw file generation we need to generate unique temp filenames

Re: r257934 - [CMake] Support generation of linker order files using dtrace

2016-03-21 Thread Sean Silva via cfe-commits
On Fri, Jan 15, 2016 at 1:21 PM, Chris Bieneman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: cbieneman > Date: Fri Jan 15 15:21:12 2016 > New Revision: 257934 > > URL: http://llvm.org/viewvc/llvm-project?rev=257934&view=rev > Log: > [CMake] Support generation of linker order file

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

2016-03-21 Thread Xiuli PAN via cfe-commits
pxli168 updated this revision to Diff 51253. pxli168 added a comment. Add test for spir64. http://reviews.llvm.org/D17596 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/spir_version.cl Index: test/CodeGenOpenCL/spir_version.cl =

r264025 - [Objective-c] Do not set IsExact to true when the receiver is a class.

2016-03-21 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Tue Mar 22 00:00:21 2016 New Revision: 264025 URL: http://llvm.org/viewvc/llvm-project?rev=264025&view=rev Log: [Objective-c] Do not set IsExact to true when the receiver is a class. IsExact shouldn't be set to true in WeakObjectProfileTy::getBaseInfo when the receiver is a

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

2016-03-21 Thread Akira Hatanaka via cfe-commits
Thanks Jordan. r264025. > On Mar 21, 2016, at 1:08 PM, Jordan Rose wrote: > > Yes, that looks good. For bonus points, add a similar test using the new > property syntax > > @property (class) NSBundle *foo2; > > instead of the method. (I expect that version to behave nearly the same, > includ

<    1   2