Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Oh fudge. One last change. The tests need license headers. Just copy it from an existing test. LGTM after that. Thanks again. http://reviews.llvm.org/D14731 __

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

jamesr updated this revision to Diff 50793. jamesr added a comment. Add LLVM license headers to new test files http://reviews.llvm.org/D14731 Files: include/__config include/__mutex_base test/libcxx/test/config.py test/libcxx/thread/thread.mutex/thread_safety_annotations_not_enabled.pas

[libcxx] r263611 - Add clang thread safety annotations to mutex and lock_guard. Patch by jam...@google.com.

Author: ericwf Date: Tue Mar 15 21:30:06 2016 New Revision: 263611 URL: http://llvm.org/viewvc/llvm-project?rev=263611&view=rev Log: Add clang thread safety annotations to mutex and lock_guard. Patch by jam...@google.com. This adds clang thread safety annotations to std::mutex and std::lock_guar

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

EricWF closed this revision. EricWF added a comment. Committed in r263611. http://reviews.llvm.org/D14731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Thanks! I'll see what I can do about it. http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, kkwli0. carlo.bertolli added subscribers: sfantao, arpith-jacob, caomhin, fraggamuffin, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. This patch implements the following aspects: - It ex

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

ryee88 added a comment. Anyone want to pick up this review? http://reviews.llvm.org/D16965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263617 - Reapply: [VFS] Add support for handling path traversals

Author: bruno Date: Tue Mar 15 23:39:38 2016 New Revision: 263617 URL: http://llvm.org/viewvc/llvm-project?rev=263617&view=rev Log: Reapply: [VFS] Add support for handling path traversals This is originally r261551, reverted because of windows bots failing on unittests. Change the current behavio

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:3466 @@ -3465,1 +3465,3 @@ }; + +/// \brief This represents clause 'from' in the '#pragma omp ...' New clauses must be added in separate patches http://reviews.llvm.org/D15944 _

Re: [PATCH] D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:9779-9780 @@ +9778,4 @@ +if (DKind == OMPD_target) { + if(VD && DSAStack->isPrivate(VD)) { +auto DVar = DSAStack->getTopDSA(VD, false); +Diag(ELoc, diag::err_omp_variable_in_map_and_dsa) --

<    1   2