Re: [PATCH] D17412: PR19957: [OpenCL] incorrectly accepts implicit address space conversion with ternary operator

pxli168 added inline comments. Comment at: lib/AST/ASTContext.cpp:7613 @@ +7612,3 @@ +if (getLangOpts().OpenCL) { + if (LHS.getUnqualifiedType() != RHS.getUnqualifiedType() || + LQuals.getCVRQualifiers() != RQuals.getCVRQualifiers()) Anastasia wr

r263541 - Restrict the hack from r263429 to asan and msan.

Author: d0k Date: Tue Mar 15 04:41:39 2016 New Revision: 263541 URL: http://llvm.org/viewvc/llvm-project?rev=263541&view=rev Log: Restrict the hack from r263429 to asan and msan. The other sanitizers don't have backend passes that rely on value names. Avoid paying the compile time cost of names t

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

On Mon, Mar 14, 2016 at 5:50 PM, Richard Smith wrote: > On 14 Mar 2016 6:28 a.m., "Benjamin Kramer via cfe-commits" > wrote: >> >> Author: d0k >> Date: Mon Mar 14 08:23:58 2016 >> New Revision: 263429 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=263429&view=rev >> Log: >> [Frontend] Disable

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki marked 12 inline comments as done. Comment at: docs/clang-tidy/checks/readability-non-const-parameter.rst:6 @@ +5,3 @@ + +Finds function parameters that should be const. When const is used properly, +many mistakes can be avoided. Advantages when using const properl

RE: r257254 - [OpenCL] Pipe type support

It seems we are not printing and dumping the type correctly. Currently we get this if we call PipeType::dump(): PipeType 0x9b14ce0 'pipe' But we should have something like (for 'pipe int p'): PipeType 0x9b14ce0 'pipe int' `-BuiltinType 0x9adeed0 'int' It should be similar to atomic or pointer ty

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki updated this revision to Diff 50705. danielmarjamaki marked 3 inline comments as done. danielmarjamaki added a comment. Fixed review comments http://reviews.llvm.org/D15332 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/NonConstParameterCheck.cpp clang

[PATCH] D18175: Avoid using LookupResult's implicit copy ctor and assignment operator to avoid warnings

myatsina created this revision. myatsina added reviewers: rnk, hintonda, rjmccall, dblaikie. myatsina added a subscriber: cfe-commits. myatsina set the repository for this revision to rL LLVM. The purpose of this patch is to keep the same functionality without using LookupResult's implicit copy c

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

myatsina added a comment. I've uploaded the following review: http://reviews.llvm.org/D18175 http://reviews.llvm.org/D18123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17959: Make it possible for AST plugins to enable themselves by default

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks fine to me. Repository: rL LLVM http://reviews.llvm.org/D17959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

r263546 - Make it possible for AST plugins to enable themselves by default

Author: john.brawn Date: Tue Mar 15 07:51:40 2016 New Revision: 263546 URL: http://llvm.org/viewvc/llvm-project?rev=263546&view=rev Log: Make it possible for AST plugins to enable themselves by default Currently when an AST plugin is loaded it must then be enabled by passing -plugin pluginname or

Re: [PATCH] D17959: Make it possible for AST plugins to enable themselves by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL263546: Make it possible for AST plugins to enable themselves by default (authored by john.brawn). Changed prior to commit: http://reviews.llvm.org/D17959?vs=50037&id=50717#toc Repository: rL LLVM h

Re: [PATCH] D15729: Load compiler plugins in ASTUnit, too

kfunk updated this revision to Diff 50720. kfunk added a comment. Remove unrelated hunk http://reviews.llvm.org/D15729 Files: include/clang/Frontend/CompilerInstance.h lib/Frontend/ASTUnit.cpp lib/Frontend/CompilerInstance.cpp lib/FrontendTool/ExecuteCompilerInvocation.cpp unittests/F

Re: [PATCH] D15729: Load compiler plugins in ASTUnit, too

bkramer accepted this revision. bkramer added a comment. This looks good, thanks for the patch. When this goes in please watch the windows buildbots as plugin support on windows is somewhat broken and we may have to disable tests there. Also, while this is a strict improvement and should go in

[PATCH] D18182: [test] Don't use UNSUPPORTED in FileCheck prefixes

gparker42 created this revision. gparker42 added a reviewer: rjmccall. gparker42 added a subscriber: cfe-commits. lit uses "UNSUPPORTED" for its own purposes and may be confused if that text appears elsewhere in the test file. http://reviews.llvm.org/D18182 Files: test/Driver/arc.c test/Dr

Re: [PATCH] D18149: Add check for unneeded copies of locals

alexfh added a comment. Please always add 'cfe-commits' to Subscribers when you send a patch for review (I've added it now). Substantial comments later. http://reviews.llvm.org/D18149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D18149: Add check for unneeded copies of locals

alexfh added a comment. Thank you for the patch! Looks mostly good, a few style nits. Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:21 @@ -20,2 +20,3 @@ using namespace ::clang::ast_matchers; +using clang::tidy::decl_ref_expr_utils::isOnlyUsedAsConst; -

[PATCH] D18186: Myriad: pass -mcpu flag to moviCompile, no default

dougk created this revision. dougk added a reviewer: jyknight. dougk added a subscriber: cfe-commits. http://reviews.llvm.org/D18186 Files: lib/Driver/Tools.cpp test/Driver/myriad-toolchain.c Index: test/Driver/myriad-toolchain.c ==

r263552 - [OpenMP] Base support for target directive codegen on NVPTX device.

Author: arpith Date: Tue Mar 15 10:24:52 2016 New Revision: 263552 URL: http://llvm.org/viewvc/llvm-project?rev=263552&view=rev Log: [OpenMP] Base support for target directive codegen on NVPTX device. Summary: This patch adds base support for codegen of the target directive on the NVPTX device.

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

This revision was automatically updated to reflect the committed changes. Closed by commit rL263552: [OpenMP] Base support for target directive codegen on NVPTX device. (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D17877?vs=50143&id=50737#toc Repository: rL LLVM ht

Re: [PATCH] D18186: Myriad: pass -mcpu flag to moviCompile, no default

dougk updated this revision to Diff 50739. dougk added a comment. also moviAsm http://reviews.llvm.org/D18186 Files: lib/Driver/Tools.cpp test/Driver/myriad-toolchain.c Index: test/Driver/myriad-toolchain.c === --- test/Driver

[PATCH] D18187: [libcxx] Remove localization tests for Russian month names

Hahnfeld created this revision. Hahnfeld added a reviewer: EricWF. Hahnfeld added a subscriber: cfe-commits. Commit `f49839299a085505eb673544744b61d2d9cdd1db` in glibc-2.14 changed the locales to the currently required format. However, they were again changed in commit `55bdd2866f23b28422d969060

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

a.sidorin updated this revision to Diff 50741. a.sidorin added a comment. An attempt to fix ParenListExpr test on Windows http://reviews.llvm.org/D14286 Files: include/clang/AST/Type.h lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp unittests/AST/CMakeLists.txt Index: unittes

Re: [PATCH] D18187: [libcxx] Remove localization tests for Russian month names

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. It seems like we are not losing test coverage with these removals. And they have caused us a ton of pain. I agree lets just get rid of them! LGTM. http://reviews.llvm.org/D18187

[libcxx] r263554 - [libcxx] Remove localization tests for Russian month names

Author: hahnfeld Date: Tue Mar 15 10:55:58 2016 New Revision: 263554 URL: http://llvm.org/viewvc/llvm-project?rev=263554&view=rev Log: [libcxx] Remove localization tests for Russian month names Commit f49839299a085505eb673544744b61d2d9cdd1db in glibc-2.14 changed the locales to the currently requ

Re: [PATCH] D18187: [libcxx] Remove localization tests for Russian month names

This revision was automatically updated to reflect the committed changes. Closed by commit rL263554: [libcxx] Remove localization tests for Russian month names (authored by Hahnfeld). Changed prior to commit: http://reviews.llvm.org/D18187?vs=50738&id=50742#toc Repository: rL LLVM http://re

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

EricWF added inline comments. Comment at: test/libcxx/thread/thread.mutex/thread_safety_access_guarded_without_lock.fail.cpp:1 @@ +1,2 @@ +#if !defined(__clang__) || !__has_attribute(acquire_capability) +// This test is only meaningful on versions of clang that understand thread

r263555 - Reverted http://reviews.llvm.org/D17877 to fix tests.

Author: arpith Date: Tue Mar 15 11:19:13 2016 New Revision: 263555 URL: http://llvm.org/viewvc/llvm-project?rev=263555&view=rev Log: Reverted http://reviews.llvm.org/D17877 to fix tests. Removed: cfe/trunk/test/OpenMP/nvptx_target_codegen.cpp Modified: cfe/trunk/lib/CodeGen/CGOpenMPRunti

r263556 - Myriad: Pass -mcpu to movi{Compile,Asm}

Author: dougk Date: Tue Mar 15 11:41:31 2016 New Revision: 263556 URL: http://llvm.org/viewvc/llvm-project?rev=263556&view=rev Log: Myriad: Pass -mcpu to movi{Compile,Asm} Differential Revision: http://reviews.llvm.org/D18186 Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver

Re: [PATCH] D18186: Myriad: pass -mcpu flag to moviCompile, no default

This revision was automatically updated to reflect the committed changes. Closed by commit rL263556: Myriad: Pass -mcpu to movi{Compile,Asm} (authored by dougk). Changed prior to commit: http://reviews.llvm.org/D18186?vs=50739&id=50748#toc Repository: rL LLVM http://reviews.llvm.org/D18186

Re: [PATCH] D18175: Avoid using LookupResult's implicit copy ctor and assignment operator to avoid warnings

rjmccall added a comment. You can't call getFoundDecl() if !isSingleResult(). You should add a test case that actually tests the possibility that this lookup will fail. Repository: rL LLVM http://reviews.llvm.org/D18175 ___ cfe-commits mailing

[PATCH] D18191: [clang-tidy] Add check for function parameters that are const& to builtin types

sdowney created this revision. sdowney added a reviewer: alexfh. sdowney added a subscriber: cfe-commits. Add a check for const& to builtin types. Add FixIt replacing, for example, 'const& int i' with 'int i'. http://reviews.llvm.org/D18191 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/m

Re: [PATCH] D14000: [CUDA] Allow code generation for functions with target attributes that don't match compilation mode.

jingyue added a comment. Is this patch obsolete? Are you still trying to push it in? http://reviews.llvm.org/D14000 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18175: Avoid using LookupResult's implicit copy ctor and assignment operator to avoid warnings

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rL LLVM http://reviews.llvm.org/D18175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

Re: [PATCH] D17947: [Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a

beanz added a comment. Ping. http://reviews.llvm.org/D17947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263567 - [Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a

Author: cbieneman Date: Tue Mar 15 13:08:20 2016 New Revision: 263567 URL: http://llvm.org/viewvc/llvm-project?rev=263567&view=rev Log: [Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a Summary: isTarget*() calls are order-dependent. This is because iOS Sim *is* iOS. This means checks for

Re: [PATCH] D17947: [Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a

This revision was automatically updated to reflect the committed changes. Closed by commit rL263567: [Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D17947?vs=50055&id=50755#toc Repository: rL LLVM http://rev

[PATCH] D18193: [ARM] Add more ARM Cortex-R8 regression tests to Clang.

pbarrio created this revision. pbarrio added reviewers: rengolin, bsmith. pbarrio added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. This patch adds Clang tests for Cortex-R8 related to FP capabilities and hardware integer divide. http://reviews.llvm.org/D18193 Files:

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

faisalv updated this revision to Diff 50757. faisalv added a comment. Added some more comments (hopefully didn't go overboard). Thanks again for reviewing Richard! http://reviews.llvm.org/D18139 Files: include/clang/AST/LambdaCapture.h include/clang/Basic/DiagnosticParseKinds.td include/

r263568 - Fix a bot I broke.

Author: cbieneman Date: Tue Mar 15 13:17:48 2016 New Revision: 263568 URL: http://llvm.org/viewvc/llvm-project?rev=263568&view=rev Log: Fix a bot I broke. The builtin library isn't added by the driver unless it exists, so we shouldn't check for it. I've marked this as a FIXME, because we probabl

Re: [PATCH] D18175: Avoid using LookupResult's implicit copy ctor and assignment operator to avoid warnings

rjmccall added a comment. Ignore Dave and fix the problem, please. :) Repository: rL LLVM http://reviews.llvm.org/D18175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

rjmccall added a comment. Making UnresolvedSet copyable / movable seems reasonable to me. http://reviews.llvm.org/D18123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

rjmccall added a comment. It's languished because the idea itself has unavoidable problems with incomplete types. http://reviews.llvm.org/D18035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

r263570 - [CMake] Defaulting CLANG_VENDOR to PACKAGE_VENDOR

Author: cbieneman Date: Tue Mar 15 13:25:36 2016 New Revision: 263570 URL: http://llvm.org/viewvc/llvm-project?rev=263570&view=rev Log: [CMake] Defaulting CLANG_VENDOR to PACKAGE_VENDOR LLVM r263566 adds a generic PACKAGE_VENDOR configuration which can be used to specify the vendor for LLVM tool

r263571 - [CMake] Updating Apple build configurations

Author: cbieneman Date: Tue Mar 15 13:27:28 2016 New Revision: 263571 URL: http://llvm.org/viewvc/llvm-project?rev=263571&view=rev Log: [CMake] Updating Apple build configurations This updates Apple build configurations to adapt to r263566 & r263570, which added a PACKAGE_VENDOR variable. Modif

Re: [PATCH] D14737: Convert some ObjC msgSends to runtime calls

rjmccall added a comment. Can you find where that bitcast is being added? I know that different parts of IRGen are differently sensitive to types — it's possible that the return code is one of those more-permissive places. http://reviews.llvm.org/D14737

Re: [PATCH] D18175: Avoid using LookupResult's implicit copy ctor and assignment operator to avoid warnings

On Tue, Mar 15, 2016 at 11:26 AM, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > rjmccall added a comment. > > Ignore Dave and fix the problem, please. :) > +1, sorry for the race on review. > > > Repository: > rL LLVM > > http://reviews.llvm.org/D18175 > > > > ___

Re: [PATCH] D14737: Convert some ObjC msgSends to runtime calls

pete added a comment. In http://reviews.llvm.org/D14737#375735, @rjmccall wrote: > Can you find where that bitcast is being added? I know that different parts > of IRGen are differently sensitive to types — it's possible that the return > code is one of those more-permissive places. Sure, wi

Re: [PATCH] D17988: Fix destructor definition of invalid classes

rjmccall added a comment. Seems okay to me. http://reviews.llvm.org/D17988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14737: Convert some ObjC msgSends to runtime calls

rjmccall added a comment. Ah, okay, if you changed it to cast explicitly, that's all I was concerned about. http://reviews.llvm.org/D14737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D15599: [CodeGen] Fix a crash that occurs when attribute "naked" is attached to a c++ member function

ahatanak updated this revision to Diff 50759. ahatanak added a comment. Address review comments. - Rewrite cleanupNakedFunction. - Fix test case attr-naked.cpp. Check that the thunk function doesn't get removed when the virtual function is marked "naked". http://reviews.llvm.org/D15599 Files:

Re: [PATCH] D15599: [CodeGen] Fix a crash that occurs when attribute "naked" is attached to a c++ member function

ahatanak marked 2 inline comments as done. Comment at: test/CodeGen/attr-naked.c:20 @@ -19,3 +19,3 @@ __attribute((naked)) void t3(int x) { -// CHECK: define void @t3(i32) +// CHECK: define void @t3(i32 %x) // CHECK-NOT: alloca This is a side effect of not exiti

Re: [PATCH] D18174: Fix libcxx build on musl

bcraig added a comment. If I understand it correctly, __GLIBC__ is defined in features.h, so this won't work. I suspect that the build isn't broken. You likely just need to define LIBCXX_HAS_MUSL_LIBC on your cmake line. That will cause __config_site.in to #define _LIBCPP_HAS_MUSL_LIBC for y

Re: [PATCH] D18182: [test] Don't use UNSUPPORTED in FileCheck prefixes

rjmccall added a comment. LGTM. http://reviews.llvm.org/D18182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18174: Fix libcxx build on musl

raj.khem added a comment. @bcraig, right, check for __GLIBC__ can be moved after including features.h. https://chromium.googlesource.com/native_client/pnacl-libcxx/+/master%5E!/ seems to add needed tweaks which can be enabled by passing -D__musl__ in CFLAGS may be it can be backported to 3.8 bran

r263574 - Test commit - Remove some trailing whitespace

Author: pabbar01 Date: Tue Mar 15 14:03:09 2016 New Revision: 263574 URL: http://llvm.org/viewvc/llvm-project?rev=263574&view=rev Log: Test commit - Remove some trailing whitespace Modified: cfe/trunk/test/Preprocessor/arm-target-features.c Modified: cfe/trunk/test/Preprocessor/arm-target-fe

Re: [PATCH] D18193: [ARM] Add more ARM Cortex-R8 regression tests to Clang.

t.p.northover added a subscriber: t.p.northover. t.p.northover accepted this revision. t.p.northover added a reviewer: t.p.northover. t.p.northover added a comment. This revision is now accepted and ready to land. This looks fine to me. Tim. http://reviews.llvm.org/D18193 ___

Re: [PATCH] D18174: Fix libcxx build on musl

raj.khem added a comment. 3.8 has it in there. So may be this is just not required. I will add -DLIBCXX_HAS_MUSL_LIBC=ON to Cmake and see what comes out http://reviews.llvm.org/D18174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

Re: [PATCH] D18174: Fix libcxx build on musl

bcraig added a comment. The trouble is that features.h doesn't exist in musl (as far as I know). That's the biggest reason why _LIBCPP_HAS_MUSL_LIBC is needed. http://reviews.llvm.org/D18174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18174: Fix libcxx build on musl

raj.khem added a comment. I think my problem was that while compiling libcxxabi, it wants to peek into libcxx headers but then libcxxabi cmake infra doesnt have the musl support like libcxx. So Now I solved it by adding -D_LIBCPP_HAS_MUSL_LIBC to CXXFLAGS. http://reviews.llvm.org/D18174 ___

Re: [PATCH] D18174: Fix libcxx build on musl

EricWF added a subscriber: EricWF. EricWF added a comment. @raj.khem Can you file a bug against libc++abi please? http://reviews.llvm.org/D18174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D18174: Fix libcxx build on musl

raj.khem added a comment. libcxx still has problem compiling on musl/aarch64 though. I fixed it with this patch https://github.com/kraj/meta-clang/blob/master/recipes-devtools/clang/libcxx/0001-use-constexpr-when-using-glibc.patch does this make sense ? http://reviews.llvm.org/D18174 _

Re: [PATCH] D18174: Fix libcxx build on musl

EricWF added a comment. That patch looks hugely dangerous because you've now changed when your static mutex's get initialized. Please file a bug against libc++. http://reviews.llvm.org/D18174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17360: [cfi] Fix handling of sanitize trap/recover flags in the cross-DSO CFI mode.

eugenis added a comment. No, this is not committed. I've run dcommit in the wrong checkout and landed http://reviews.llvm.org/D17900 instead. Repository: rL LLVM http://reviews.llvm.org/D17360 ___ cfe-commits mailing list cfe-commits@lists.llvm.

r263578 - [cfi] Don't emit checks for disabled CFI kinds.

Author: eugenis Date: Tue Mar 15 15:19:29 2016 New Revision: 263578 URL: http://llvm.org/viewvc/llvm-project?rev=263578&view=rev Log: [cfi] Don't emit checks for disabled CFI kinds. In the cross-DSO CFI mode clang emits __cfi_check_fail that handles errors triggered from other modules with target

Re: [PATCH] D17360: [cfi] Fix handling of sanitize trap/recover flags in the cross-DSO CFI mode.

eugenis added a comment. r263578, finally Repository: rL LLVM http://reviews.llvm.org/D17360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18175: Avoid using LookupResult's implicit copy ctor and assignment operator to avoid warnings

myatsina added a comment. How can I create a test case where isSingleResult() returns false? I don't see existent tests in the commit that added this method's functionality. Repository: rL LLVM http://reviews.llvm.org/D18175 ___ cfe-commits maili

Re: [PATCH] D18175: Avoid using LookupResult's implicit copy ctor and assignment operator to avoid warnings

rjmccall added a comment. Hmm. Checking whether LookupName returns false will catch a lot of simple cases. I think the test case you need might have to be a lookup that finds multiple overloads of a function in C++. Repository: rL LLVM http://reviews.llvm.org/D18175 ___

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe added inline comments. Comment at: clang-tidy/readability/AvoidStdBindCheck.cpp:42 @@ +41,3 @@ + + for (size_t I = 1, ArgCount = C->getNumArgs(); I < ArgCount; ++I) { +const Expr *E = C->getArg(I); alexfh wrote: > Please use a range-based for loop over

Re: [PATCH] D18174: Fix libcxx build on musl

bcraig added a comment. In http://reviews.llvm.org/D18174#375813, @raj.khem wrote: > I think my problem was that while compiling libcxxabi, it wants to peek into > libcxx headers but then libcxxabi cmake infra doesnt have the musl support > like libcxx. So Now I solved it by adding -D_LIBCPP_HA

r263584 - Move the fixit for -Wformat-security to a note.

Author: bwilson Date: Tue Mar 15 15:56:38 2016 New Revision: 263584 URL: http://llvm.org/viewvc/llvm-project?rev=263584&view=rev Log: Move the fixit for -Wformat-security to a note. r263299 added a fixit for the -Wformat-security warning, but that runs into complications with our guideline that e

Re: r263299 - Add fix-it for format-security warnings.

I think r263584 does what you suggest. Let me know if not. > On Mar 11, 2016, at 4:53 PM, Bob Wilson via cfe-commits > wrote: > > OK. I will do that. > >> On Mar 11, 2016, at 4:15 PM, David Blaikie > > wrote: >> >> >> >> On Fri, Mar 11, 2016 at 4:14 PM, Bob Wilson

r263587 - [OpenMP] Base support for target directive codegen on NVPTX device.

Author: arpith Date: Tue Mar 15 16:04:57 2016 New Revision: 263587 URL: http://llvm.org/viewvc/llvm-project?rev=263587&view=rev Log: [OpenMP] Base support for target directive codegen on NVPTX device. Summary: This patch adds base support for codegen of the target directive on the NVPTX device.

Re: [PATCH] D18174: Fix libcxx build on musl

EricWF added a comment. The method @bcraig is describing is documented here: http://libcxx.llvm.org/docs/BuildingLibcxx.html#id4 http://reviews.llvm.org/D18174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

r263589 - Revert commit http://reviews.llvm.org/D17877 to fix tests on x86.

Author: arpith Date: Tue Mar 15 16:26:34 2016 New Revision: 263589 URL: http://llvm.org/viewvc/llvm-project?rev=263589&view=rev Log: Revert commit http://reviews.llvm.org/D17877 to fix tests on x86. Removed: cfe/trunk/test/OpenMP/nvptx_target_codegen.cpp Modified: cfe/trunk/lib/CodeGen/C

[PATCH] D18196: [CodeGen] Emit lifetime.end intrinsic after destructor call in landing pad

ahatanak created this revision. ahatanak added reviewers: rnk, rjmccall. ahatanak added a subscriber: cfe-commits. This patch fixes a bug in CodeGen where lifetime.end intrinsics were not being inserted after destructor calls in landing pad blocks, which prevented StackColoring from merging stac

Re: [PATCH] D14737: Convert some ObjC msgSends to runtime calls

pete added a comment. In http://reviews.llvm.org/D14737#375739, @rjmccall wrote: > Ah, okay, if you changed it to cast explicitly, that's all I was concerned > about. Cool. Thanks. Any other concerns or does this look good to you? http://reviews.llvm.org/D14737 _

Re: [PATCH] D18138: Add -fnative-half-arguments-and-returns

srhines added a reviewer: kristof.beyls. srhines added a comment. Kristof, can you or someone at ARM (where this is clearly relevant) take a look here? The CL obviously looks fine to me, but I might not have all of the original context as to why this was so constrained to OpenCL. Thanks. http:

[PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

pcc created this revision. pcc added reviewers: rjmccall, rsmith, rafael, joker.eph, majnemer, rnk. pcc added a subscriber: cfe-commits. Also add documentation for the new feature. The new IR scheme for virtual calls (http://lists.llvm.org/pipermail/llvm-dev/2016-February/096146.html) will be imp

Re: [PATCH] D14737: Convert some ObjC msgSends to runtime calls

rjmccall added a comment. Yes, LGTM. http://reviews.llvm.org/D14737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

kkwli0 updated this revision to Diff 50774. kkwli0 marked 5 inline comments as done. kkwli0 added a comment. Addressed the comments from the last review: added assert calls and outline the common code in ActOnOpenMPToClause, ActOnOpenMPFromClause and ActOnOpenMPMapClause to a static function.

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

sfantao added a comment. Thanks Kelvin, I'm fine with the patch. Let's wait for Alexey to see if he has any concern. Thanks again! Samuel http://reviews.llvm.org/D15944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

r263596 - Myriad: define __myriad2 macro automatically

Author: dougk Date: Tue Mar 15 17:34:02 2016 New Revision: 263596 URL: http://llvm.org/viewvc/llvm-project?rev=263596&view=rev Log: Myriad: define __myriad2 macro automatically Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/test/Driver/myriad-toolchain.c cfe/trunk/test/Preprocess

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

EricWF added a comment. By including `fallback_malloc.ipp` in a new C++ file we now have 2 different OOM emergancy buffers. I think it would be preferable to use only one. This would require a fairly large restructuring of `fallback_malloc.ipp` though. http://reviews.llvm.org/D17815 ___

Re: [PATCH] D18175: Avoid using LookupResult's implicit copy ctor and assignment operator to avoid warnings

myatsina updated this revision to Diff 50780. myatsina added a comment. Adding requested test case + changing the code accordingly Repository: rL LLVM http://reviews.llvm.org/D18175 Files: lib/Sema/SemaStmtAsm.cpp test/CodeGen/ms-inline-asm-errors.cpp Index: lib/Sema/SemaStmtAsm.cpp ===

Re: [PATCH] D18088: Add a new warning to notify users of mismatched SDK and deployment target

bob.wilson added a comment. This is a good idea overall. See comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:198 @@ -197,2 +197,3 @@ InGroup>; +def warn_incompatible_sdk : Warning<"using SDK for '%0' but deploying to '%1'">; def warn_debug_compression_una

Re: [PATCH] D18175: Avoid using LookupResult's implicit copy ctor and assignment operator to avoid warnings

rjmccall added a comment. Thank you, LGTM. Repository: rL LLVM http://reviews.llvm.org/D18175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18196: [CodeGen] Emit lifetime.end intrinsic after destructor call in landing pad

rjmccall added a comment. You should talk to Reid or someone else involved in MSVC-style EH support to ensure that they generate a reasonable code pattern for this. You should also check that any back-end peepholes we have in place (null type infos to signify a call-terminate landingpad?) aren'

r263607 - Convert some ObjC msgSends to runtime calls.

Author: pete Date: Tue Mar 15 19:33:21 2016 New Revision: 263607 URL: http://llvm.org/viewvc/llvm-project?rev=263607&view=rev Log: Convert some ObjC msgSends to runtime calls. It is faster to directly call the ObjC runtime for methods such as retain/release instead of sending a message to those

Re: [PATCH] D14737: Convert some ObjC msgSends to runtime calls

This revision was automatically updated to reflect the committed changes. Closed by commit rL263607: Convert some ObjC msgSends to runtime calls. (authored by pete). Changed prior to commit: http://reviews.llvm.org/D14737?vs=50651&id=50785#toc Repository: rL LLVM http://reviews.llvm.org/D14

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

jamesr marked 5 inline comments as done. jamesr added a comment. Thank you for the comments, new patch coming.. (is there a way to post comments and upload a new patch at the same time?) http://reviews.llvm.org/D14731 ___ cfe-commits mailing list c

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

jamesr updated this revision to Diff 50788. http://reviews.llvm.org/D14731 Files: include/__config include/__mutex_base test/libcxx/test/format.py test/libcxx/thread/thread.mutex/thread_safety_annotations_not_enabled.pass.cpp test/libcxx/thread/thread.mutex/thread_safety_lock_guard.pass

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

EricWF added a comment. So I fixed up LIT so that it also adds "-Werror=thread-safety" for both ".pass.cpp" and ".fail.cpp" tests. Could you apply it to your patch? https://gist.github.com/EricWF/8a0bfb6ff02f8c9f9940 Comment at: include/__mutex_base:37 @@ -30,1 +36,3 @@ + +clas

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

jamesr added a comment. In http://reviews.llvm.org/D14731#376128, @EricWF wrote: > So I fixed up LIT so that it also adds "-Werror=thread-safety" for both > ".pass.cpp" and ".fail.cpp" tests. Could you apply it to your patch? > https://gist.github.com/EricWF/8a0bfb6ff02f8c9f9940 Cool! Applied

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

jamesr updated this revision to Diff 50790. http://reviews.llvm.org/D14731 Files: include/__config include/__mutex_base test/libcxx/test/config.py test/libcxx/thread/thread.mutex/thread_safety_annotations_not_enabled.pass.cpp test/libcxx/thread/thread.mutex/thread_safety_lock_guard.pass

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

EricWF added a comment. So this LGTM except for one last change (I'm sorry). LIT now knows when "-Werror=thread-safety" is being passed. Could you change the tests guarded by "#if !defined(__clang__) || !__has_attribute(aquire_capability)` to say "// REQUIRES: thread-safety" instead? I prefer u

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

EricWF added inline comments. Comment at: include/__mutex_base:37 @@ -30,1 +36,3 @@ + +class _LIBCPP_TYPE_VIS _LIBCPP_THREAD_SAFETY_ANNOTATION(capability("mutex")) mutex { I appreciate the super thorough answer! http://reviews.llvm.org/D14731 __

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

jamesr added a comment. In http://reviews.llvm.org/D14731#376138, @EricWF wrote: > So this LGTM except for one last change (I'm sorry). LIT now knows when > "-Werror=thread-safety" is being passed. Could you change the tests guarded > by "#if !defined(__clang__) || !__has_attribute(aquire_capab

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

EricWF added a comment. Yes exactly. `// REQUIRES: ` tells LIT to skip the test (and report it as UNSUPPORTED) whenever the feature is not present. http://reviews.llvm.org/D14731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [modules] PR24954

Please restrict this to the case where the function template is a friend (check D->getFriendObjectKind()). Otherwise, this looks good to me. Thanks! On Mon, Mar 7, 2016 at 2:23 AM, Vassil Vassilev wrote: > ping... > > On 22/02/16 21:51, Vassil Vassilev wrote: >> >> On 02/02/16 02:52, Richard Smit

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

jamesr updated this revision to Diff 50791. jamesr added a comment. Use // REQUIRES: thread-safety instead of macros to feature guard tests http://reviews.llvm.org/D14731 Files: include/__config include/__mutex_base test/libcxx/test/config.py test/libcxx/thread/thread.mutex/thread_safet

  1   2   >