Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

2016-03-12 Thread Alexander Droste via cfe-commits
Alexander_Droste updated this revision to Diff 50526. Alexander_Droste added a comment. - use MPI mock header in integration test file http://reviews.llvm.org/D12761 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/MPI-C

Re: [PATCH] D14905: [constexpr-lambda] Support parsing of constexpr specifier (and its inference) on lambda expressions

2016-03-12 Thread Faisal Vali via cfe-commits
faisalv added a comment. *ping* http://reviews.llvm.org/D14905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18095: Add __attribute__((linkonce_odr_linkage))

2016-03-12 Thread John McCall via cfe-commits
rjmccall added a comment. Okay, first off, linkonce_odr is not an acceptable term to be introducing as an attribute name. If we need this, we can find some way to describe it that isn't a random internal compiler term. More importantly, I don't understand how your problem is solved by linkonce

r263344 - clang-cl: Add a test for the interaction of /Yc and /showIncludes.

2016-03-12 Thread Nico Weber via cfe-commits
Author: nico Date: Sat Mar 12 13:55:59 2016 New Revision: 263344 URL: http://llvm.org/viewvc/llvm-project?rev=263344&view=rev Log: clang-cl: Add a test for the interaction of /Yc and /showIncludes. We almost get this right, but not completely (see FIXME). It looks like /FI headers generally aren

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

2016-03-12 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Some comments inline. I still have to do an overall pass over this checker, but it looks much better than the first version! Comment at: lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:47 @@ +46,3 @@ +BReporter->reportDoubleNonblocking(PreC

[PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

2016-03-12 Thread don hinton via cfe-commits
hintonda created this revision. hintonda added a reviewer: rjmccall. hintonda added a subscriber: cfe-commits. Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed. http://reviews.llvm.org/D18123 Files: include/clang/AST/UnresolvedSet.h include/clang/Sema/Loo

Re: [libcxx] r249738 - Split out of .

2016-03-12 Thread Adrian Prantl via cfe-commits
> On Mar 11, 2016, at 4:11 PM, Duncan P. N. Exon Smith > wrote: > > Did anyone file a PR for this? > I filed PR 26928 - Prune the include path for modules https://llvm.org/bugs/show_bug.cgi?id=26928 as a starting point. -- adrian ___ cfe-commits m

[PATCH] D18127: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

2016-03-12 Thread Mehdi AMINI via cfe-commits
joker.eph created this revision. joker.eph added reviewers: echristo, chandlerc. joker.eph added a subscriber: cfe-commits. This flag is enabled by default in the driver when NDEBUG is set. It is forwarded on the LLVMContext to discard all value names (but GlobalValue) for performance purpose. Th

Re: [PATCH] D17910: clang-format: [JS] Handle certain cases of ASI.

2016-03-12 Thread Martin Probst via cfe-commits
mprobst updated this revision to Diff 50537. mprobst added a comment. - Handle unary !. - Address review comments. - Support declarations and statements in ASI. http://reviews.llvm.org/D17910 Files: lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/Forma

r263352 - clang-cl: Add /Yc argument to /showIncludes output.

2016-03-12 Thread Nico Weber via cfe-commits
Author: nico Date: Sat Mar 12 20:44:13 2016 New Revision: 263352 URL: http://llvm.org/viewvc/llvm-project?rev=263352&view=rev Log: clang-cl: Add /Yc argument to /showIncludes output. To make this work, delay printing of ExtraDeps in HeaderIncludesCallback a bit, so that it happens after CompilerI

r263353 - Make test a bit stricter to check not just the file basename is printed.

2016-03-12 Thread Nico Weber via cfe-commits
Author: nico Date: Sat Mar 12 20:48:51 2016 New Revision: 263353 URL: http://llvm.org/viewvc/llvm-project?rev=263353&view=rev Log: Make test a bit stricter to check not just the file basename is printed. Modified: cfe/trunk/test/Driver/cl-pch-showincludes.cpp Modified: cfe/trunk/test/Driver/

r263355 - Also test that the pch file is not printed in /showIncludes

2016-03-12 Thread Nico Weber via cfe-commits
Author: nico Date: Sat Mar 12 21:04:46 2016 New Revision: 263355 URL: http://llvm.org/viewvc/llvm-project?rev=263355&view=rev Log: Also test that the pch file is not printed in /showIncludes Modified: cfe/trunk/test/Driver/cl-pch-showincludes.cpp Modified: cfe/trunk/test/Driver/cl-pch-showin

Re: r188037 - clang-cl: Support /showIncludes

2016-03-12 Thread Nico Weber via cfe-commits
On Thu, Aug 8, 2013 at 8:32 PM, Hans Wennborg wrote: > Author: hans > Date: Thu Aug 8 19:32:23 2013 > New Revision: 188037 > > URL: http://llvm.org/viewvc/llvm-project?rev=188037&view=rev > Log: > clang-cl: Support /showIncludes > > This option prints information about #included files to stderr.

Re: [PATCH] D18127: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

2016-03-12 Thread Chandler Carruth via cfe-commits
chandlerc added a comment. Change these tests to use %clang_cc1 rather than add all the messy regex to handle arguments losing names? Comment at: lib/Driver/Tools.cpp:3715 @@ -3714,1 +3714,3 @@ CmdArgs.push_back("-disable-llvm-verifier"); + // Disable LLVM value names in -a

r263371 - Update for new argument to scalbn

2016-03-12 Thread Matt Arsenault via cfe-commits
Author: arsenm Date: Sat Mar 12 23:12:47 2016 New Revision: 263371 URL: http://llvm.org/viewvc/llvm-project?rev=263371&view=rev Log: Update for new argument to scalbn Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modified: cfe/trunk/lib/AST/ExprConstant.cpp URL: http://llvm.org/viewvc/llvm-p

Re: [PATCH] D18127: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

2016-03-12 Thread Mehdi AMINI via cfe-commits
joker.eph updated this revision to Diff 50541. joker.eph added a comment. Use cc1 in the few tests that were relying on value names. Also add test/CodeGenCXX/discard-name-values.cpp to test the new cc1 flag. http://reviews.llvm.org/D18127 Files: include/clang/Driver/CC1Options.td include/c

Re: [PATCH] D18127: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

2016-03-12 Thread Mehdi AMINI via cfe-commits
joker.eph updated this revision to Diff 50546. joker.eph added a comment. s/clang -cc1/%clang_cc1/ http://reviews.llvm.org/D18127 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGBuilder.h lib/CodeGen/CGCall.cpp lib/CodeGen/CGExpr.cpp