Author: pcc
Date: Thu Feb 25 21:07:33 2016
New Revision: 261960
URL: http://llvm.org/viewvc/llvm-project?rev=261960&view=rev
Log:
Make vtables_blacklist dependency conditional on existence of clang target.
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified: cfe/trunk/runtime/CMakeLists.txt
(I don't understand why this flag needs to exist, but) I've implemented a
fix in r261960.
Peter
On Thu, Feb 25, 2016 at 06:50:52PM -0800, Steven Wu wrote:
> Hi Peter
>
> I notice after this commit, I can no longer use cmake option
> -DCLANG_TOOL_DRIVER_BUILD=OFF to choose not to build and link
Author: pxl
Date: Thu Feb 25 21:13:03 2016
New Revision: 261961
URL: http://llvm.org/viewvc/llvm-project?rev=261961&view=rev
Log:
[OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr
Summary:
OpenCL access qualifiers are now not only used for image types, refine it to
avoid misleading,
Add
Author: chapuni
Date: Thu Feb 25 21:15:09 2016
New Revision: 261962
URL: http://llvm.org/viewvc/llvm-project?rev=261962&view=rev
Log:
OpenMPClause.h: Fix typo in \param. [-Wdocumentation]
Modified:
cfe/trunk/include/clang/AST/OpenMPClause.h
Modified: cfe/trunk/include/clang/AST/OpenMPClause.
Author: chapuni
Date: Thu Feb 25 21:15:13 2016
New Revision: 261963
URL: http://llvm.org/viewvc/llvm-project?rev=261963&view=rev
Log:
Checkers/CheckObjCDealloc.cpp: Prune "\param". [-Wdocumentation]
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp
Modified: cfe/trunk/lib/
ABataev added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7767-7768
@@ -7766,4 +7766,4 @@
"bit fields cannot be used to specify storage in a map clause">;
-def err_omp_array_section_in_rightmost_expression : Error<
- "array section can only be assoc
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4002
@@ +4001,3 @@
+static llvm::Value *
+emitNumTeamsClauseForTargetDirective(CodeGenFunction &CGF,
+ const OMPExecutableDirective &D,
I still don't lik
Thanks a lot!
Steven
> On Feb 25, 2016, at 7:12 PM, Peter Collingbourne wrote:
>
> (I don't understand why this flag needs to exist, but) I've implemented a
> fix in r261960.
>
> Peter
>
> On Thu, Feb 25, 2016 at 06:50:52PM -0800, Steven Wu wrote:
>> Hi Peter
>>
>> I notice after this comm
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D17170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: dcoughlin
Date: Thu Feb 25 21:41:31 2016
New Revision: 261970
URL: http://llvm.org/viewvc/llvm-project?rev=261970&view=rev
Log:
[analyzer] Prune some incorrect \param doc comment annotations.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp
cfe/trunk/lib/Static
ABataev accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2781-2783
@@ +2780,5 @@
+ const Expr *IfCond = nullptr;
+ if (auto *C = S.getSingleClause()) {
+IfCond = C->getCondition();
+ }
+
Remov
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D17629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2758-2760
@@ +2757,5 @@
+ const Expr *IfCond = nullptr;
+ if (auto *C = S.getSingleClause()) {
+IfCond = C->getCondition();
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2736-2738
@@ +2735,5 @@
+ const Expr *IfCond = nullptr;
+ if (auto *C = S.getSingleClause()) {
+IfCond = C->getCondition();
Author: majnemer
Date: Thu Feb 25 22:23:19 2016
New Revision: 261975
URL: http://llvm.org/viewvc/llvm-project?rev=261975&view=rev
Log:
[MSVC Compat] Don't evaluate member base expressions w/o side effects
A member expression's base doesn't always have an impact on what the
member decl would evalu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261975: [MSVC Compat] Don't evaluate member base expressions
w/o side effects (authored by majnemer).
Changed prior to commit:
http://reviews.llvm.org/D17619?vs=49109&id=49150#toc
Repository:
rL LLVM
rtrieu accepted this revision.
rtrieu added a comment.
This revision is now accepted and ready to land.
LGTM
The other issues brought up in this review can go in follow up patches.
http://reviews.llvm.org/D15636
___
cfe-commits mailing list
cfe-comm
Author: ahatanak
Date: Thu Feb 25 23:07:00 2016
New Revision: 261976
URL: http://llvm.org/viewvc/llvm-project?rev=261976&view=rev
Log:
[Driver] Disable frame pointer elimination by default if target is
x86_64-pc-win32-macho.
rdar://problem/24470634
Modified:
cfe/trunk/lib/Driver/Tools.cpp
pxli168 added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:6194-6203
@@ +6193,12 @@
+
+ incompatTy = S.Context.getPointerType(
+ S.Context.getAddrSpaceQualType(S.Context.VoidTy, ResultAddrSpace));
+ LHS = S.ImpCastExprToType(LHS.get(), incompatTy,
+
rtrieu added a comment.
This seems rather strange. Usually, a OpaqueValueExpr will hold an expression
that is held elsewhere in the AST. However, in this case, it appears that all
the references to --i are all behind OpaqueValueExpr's, so they aren't
processed.
`-CStyleCastExpr 0x5675d30
silvas added a comment.
Thanks for splitting this out.
I think the `-fprofile-instrument=llvm` is straightforward and uncontroversial.
Let's focus this review on that and split the others into a separate review.
But a quick preview of my thoughs about `-fprofile-instrument={llvm,clang}-use`:
I
djasper added a comment.
Thanks for looking at this.
Please also add a test in unittests/Format/FormatTest.cpp.
Comment at: lib/Format/TokenAnnotator.cpp:507
@@ -506,3 +506,3 @@
!Line.First->isOneOf(tok::kw_enum, tok::kw_case)) {
-if (Tok->Previous->is
Could someone provide a feedback?
Thanks,
--Serge
2016-01-26 20:55 GMT+06:00 Serge Pavlov :
> sepavloff created this revision.
> sepavloff added a subscriber: cfe-commits.
>
> Declaration of friend function may depend on template parameters,
> however it does not become a template function:
>
>
101 - 123 of 123 matches
Mail list logo
