pxli168 added inline comments.
Comment at: lib/Sema/SemaCast.cpp:2324-2326
@@ +2323,5 @@
+} else {
+Self.Diag(OpRange.getBegin(),
+ diag::error_opencl_cast_non_zero_to_event_t)
+ << intValue.toString(10) << SrcExpr.get()->getSource
pxli168 added a comment.
https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15603
Bug reported.
http://reviews.llvm.org/D17438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
It looks good to me. Devin could you take a look at this as well?
http://reviews.llvm.org/D16044
___
cfe-commits mailing list
cfe-commits@l
Alexander_Droste marked 36 inline comments as done.
Comment at:
tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPICheckerPathSensitive.cpp:79
@@ +78,3 @@
+ if (!ReqRegions.empty()) {
+Ctx.addTransition(State);
+ }
Alexander_Droste wrote:
> zaks.anna wr
Alexander_Droste updated this revision to Diff 49023.
Alexander_Droste marked 2 inline comments as done.
Alexander_Droste added a comment.
- fixed checkUnmatchedWaits (added ErrorNode)
- non fatal error node for double nonblocking
- renamed BugReporter variable to BReporter
- description why custo
Alexander_Droste added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MPI-Checker/MPIBugReporter.cpp:38
@@ +37,3 @@
+ Report->addRange(MPICallEvent.getSourceRange());
+ SourceRange Range = RequestRegion->sourceRange();
+ // util::sourceRange(RequestRegion);
--
hokein updated this revision to Diff 49027.
hokein marked an inline comment as done.
hokein added a comment.
Make apply-fix work on relative path in `command` field of compilation database.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/Cl
Alexander_Droste updated this revision to Diff 49028.
Alexander_Droste added a comment.
- removed commented out line
- removed dashes '–––' from comment in `MPIChecker.cpp` testfile
- (diff is created with `clang` as pwd)
http://reviews.llvm.org/D12761
Files:
lib/StaticAnalyzer/Checkers/CMake
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D16040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
alexfh added inline comments.
Comment at: clang-tidy/readability/AvoidStdBindCheck.cpp:37
@@ +36,3 @@
+
+std::vector
+buildBindArguments(const MatchFinder::MatchResult &Result, const CallExpr *C) {
`SmallVector<>` would be better here, since the number of argument
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.h:76
@@ +75,3 @@
+ // Note: In unittest, it is empty.
+ StringRef BuildDirectory;
+
As discussed offline, I'd like `Clang
omtcyf0 created this revision.
omtcyf0 added reviewers: cfe-commits, alexfh.
Because of the recent Google Code shutdown links to the Google Code Style up
there are no longer relevant.
http://reviews.llvm.org/D17602
Files:
clang-tidy/google/AvoidCStyleCastsCheck.h
clang-tidy/google/ExplicitC
hokein updated this revision to Diff 49042.
hokein added a comment.
Save the build directory in each error, making ClangTidyError not rely on
ClangTidyContext.
The benchmark result shows that using StringRef doesn't improve performance
greatly.
http://reviews.llvm.org/D17335
Files:
clang-ti
hokein updated this revision to Diff 49044.
hokein added a comment.
Don't modify unrelevant code.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/clang-tidy/Inputs/compilation-databas
hokein added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,1 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_
+Definitions
This should be in one line?
http://reviews.llvm.org
omtcyf0 added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,1 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_
+Definitions
hokein wrote:
> This should be in one line?
It is in
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM, thanks!
http://reviews.llvm.org/D16040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,1 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_
+Definitions
omtcyf0 wrote:
> hokein wrote:
> > This should be in
omtcyf0 updated this revision to Diff 49048.
omtcyf0 added a comment.
Removed the breakline.
http://reviews.llvm.org/D17602
Files:
clang-tidy/google/AvoidCStyleCastsCheck.h
clang-tidy/google/ExplicitConstructorCheck.h
clang-tidy/google/OverloadedUnaryAndCheck.h
clang-tidy/google/Unnamed
omtcyf0 added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,2 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
All parameters should be named, with identical names in the declaratio
alexfh added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,2 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
All parameters should be named, with identical names in the declaration
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D17586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
http://reviews.llvm.org/D17602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
alexfh added a comment.
Hajian, if you have no concerns, could you commit the patch? Thanks!
http://reviews.llvm.org/D17602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyf0 added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,2 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
All parameters should be named, with identical names in the declaratio
hokein accepted this revision.
hokein added a comment.
LGTM. I will commit the patch for you @omtcyf0.
http://reviews.llvm.org/D17602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyf0 added a comment.
Thank you very much, @hokein!
http://reviews.llvm.org/D17602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,2 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
All parameters should be named, with identical names in the declaration
omtcyf0 added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,2 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
All parameters should be named, with identical names in the declaratio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261868: [clang-tidy] update links to Google Code Style in
docs (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D17602?vs=49048&id=49052#toc
Repository:
rL LLVM
http://reviews.
Author: hokein
Date: Thu Feb 25 08:31:10 2016
New Revision: 261868
URL: http://llvm.org/viewvc/llvm-project?rev=261868&view=rev
Log:
[clang-tidy] update links to Google Code Style in docs
Summary: Because of the recent Google Code shutdown links to the Google Code
Style up there are no longer re
AndyG added a comment.
Second bump :o)
http://reviews.llvm.org/D17149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 49054.
hokein added a comment.
Simplify test code.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/clang-tidy/Inputs/compilation-database/template
logan added inline comments.
Comment at: lib/Headers/unwind.h:61
@@ +60,3 @@
+#define _UNWIND_ARM_EHABI 0
+#endif
+
compnerd wrote:
> logan wrote:
> > logan wrote:
> > > compnerd wrote:
> > > > logan wrote:
> > > > > compnerd wrote:
> > > > > > logan wrote:
> > >
Author: aaronballman
Date: Thu Feb 25 09:14:09 2016
New Revision: 261872
URL: http://llvm.org/viewvc/llvm-project?rev=261872&view=rev
Log:
Replace a compiler-specific approach to determining the presence of a getDecl()
member function with one that does not require compiler-specific workarounds;
alexfh added inline comments.
Comment at: test/clang-tidy/clang-tidy-run-with-database.cpp:2
@@ +1,3 @@
+// REQUIRES: shell
+// RUN: mkdir -p %T/compilation-database-test
+// RUN: mkdir -p %T/compilation-database-test/include
You don't need to create the root dire
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks! I've commit in r261872.
http://reviews.llvm.org/D17575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AndyG updated this revision to Diff 49058.
AndyG marked 5 inline comments as done.
AndyG added a comment.
Updated patch according to the comments made. Also spotted a corner-case where
a double-diagnostic was produced, for example in the following where one string
has too few arguments and the
alexfh added inline comments.
Comment at: clang-tidy/readability/RedundantStringInitCheck.cpp:26
@@ +25,3 @@
+void RedundantStringInitCheck::registerMatchers(
+ast_matchers::MatchFinder *Finder) {
+ if (!getLangOpts().CPlusPlus)
nit: `ast_matchers::` can be o
Author: marshall
Date: Thu Feb 25 09:25:29 2016
New Revision: 261874
URL: http://llvm.org/viewvc/llvm-project?rev=261874&view=rev
Log:
Add test to ensure that the converting constructor in N4089 is present and
working
Added:
libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.dltr/
AndyG added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:3923-3924
@@ +3922,4 @@
+ PartialDiagnostic PDiag = S.PDiag(diag::warn_printf_data_arg_not_used);
+ for (unsigned i = 1; i < DiagnosticExprs.size(); ++i)
+PDiag << DiagnosticExprs[i]->getSourceRange();
+
Yes, I know. Trying to come up with a good solution.
On Thu, Feb 25, 2016 at 4:59 AM, Sean Silva wrote:
> This or r261737 seem to be causing a bot failure:
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/636
>
> -- Sean Silva
>
> On Wed, Feb 24, 2016 a
Author: marshall
Date: Thu Feb 25 09:27:13 2016
New Revision: 261875
URL: http://llvm.org/viewvc/llvm-project?rev=261875&view=rev
Log:
No, really - test the constructor
Modified:
libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.dltr/unique.ptr.dltr.dflt1/convert_ctor.pass.cpp
Mo
hokein updated this revision to Diff 49060.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/clang-tidy/Inputs/compilation-database/tem
hokein marked 3 inline comments as done.
Comment at: test/clang-tidy/clang-tidy-run-with-database.cpp:16
@@ +15,3 @@
+// RUN: FileCheck -input-file=%T/compilation-database-test/a/b.cpp %s
-check-prefix=CHECK-FIX2
+// RUN: FileCheck -input-file=%T/compilation-database-test/b/b.cpp
Anastasia added a comment.
I was just wondering with SPIRV coming these days, how long should we be
supporting and maintaining previous SPIR versions. Might be worth clarifying
that...
Comment at: lib/CodeGen/TargetInfo.cpp:7022
@@ -7021,1 +7021,3 @@
+class SPIRTargetCodeGen
Alexander_Droste added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:46
@@ +45,3 @@
+ExplodedNode *ErrorNode = Ctx.generateNonFatalErrorNode(State, &Tag);
+BReporter->reportDoubleNonblocking(PreCallEvent, *Req, MR, ExplNode);
+Ctx.
ddkilzer added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:804
@@ +803,3 @@
+/// Returns true if there is a call to -dealloc anywhere on the stack and false
+/// otherwise. If true, it also sets \param SelfValOut to the value of
+/// 'self' in the
ddkilzer added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:804
@@ +803,3 @@
+/// Returns true if there is a call to -dealloc anywhere on the stack and false
+/// otherwise. If true, it also sets \param SelfValOut to the value of
+/// 'self' in the
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
Pls revise by Anastasia's comments. Otherwise LGTM.
We have two options about SPIR-V support:
1. drop SPIR support and move on to SPIR-V
2. keep supporting both SPIR and SPIR-V
Option 1 is cl
Seems like this test got flagged as 'slow' by Google's internal
infrastructure - and that makes me wonder about whether it's appropriate to
have in the lit test suite - we really want to keep these tests as fast as
possible.
I think we're generally OK committing iterator invalidation fixes without
Author: benlangmuir
Date: Thu Feb 25 10:36:26 2016
New Revision: 261887
URL: http://llvm.org/viewvc/llvm-project?rev=261887&view=rev
Log:
Add FieldNames to __NSConstantString_tag
Since consumers of the AST may expect fields to be named.
Patch by Brad King!
Modified:
cfe/trunk/lib/AST/ASTCon
Author: alexfh
Date: Thu Feb 25 10:46:54 2016
New Revision: 261893
URL: http://llvm.org/viewvc/llvm-project?rev=261893&view=rev
Log:
[clang-tidy] Adding headers needed in modernize-deprecated-headers tests
Added:
clang-tools-extra/trunk/test/clang-tidy/Inputs/modernize-deprecated-headers/
Let's see if r261893 fixes this.
On Thu, Feb 25, 2016 at 4:31 PM, Alexander Kornienko
wrote:
> Yes, I know. Trying to come up with a good solution.
>
> On Thu, Feb 25, 2016 at 4:59 AM, Sean Silva wrote:
>
>> This or r261737 seem to be causing a bot failure:
>> http://lab.llvm.org:8011/builders/
I've committed r261893 that adds stub headers and points the tool to the
right search directory. If the solution works, this commit can be reverted.
On Thu, Feb 25, 2016 at 2:12 AM, NAKAMURA Takumi via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chapuni
> Date: Wed Feb 24 19:12:57
Author: marshall
Date: Thu Feb 25 10:50:51 2016
New Revision: 261894
URL: http://llvm.org/viewvc/llvm-project?rev=261894&view=rev
Log:
Another chunk of N4089
Modified:
libcxx/trunk/include/memory
Modified: libcxx/trunk/include/memory
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/inc
Author: marshall
Date: Thu Feb 25 10:55:58 2016
New Revision: 261896
URL: http://llvm.org/viewvc/llvm-project?rev=261896&view=rev
Log:
Update the status of a N4089 and a couple issues
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.
Author: chapuni
Date: Thu Feb 25 10:59:59 2016
New Revision: 261897
URL: http://llvm.org/viewvc/llvm-project?rev=261897&view=rev
Log:
Revert r261814, "check-clang-tools: Introduce the feature target-headers",
corresponding to r261893.
Modified:
clang-tools-extra/trunk/test/clang-tidy/modern
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks.
http://reviews.llvm.org/D16876
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Thanks! r261897.
On Fri, Feb 26, 2016 at 1:55 AM Alexander Kornienko
wrote:
> I've committed r261893 that adds stub headers and points the tool to the
> right search directory. If the solution works, this commit can be reverted.
>
> On Thu, Feb 25, 2016 at 2:12 AM, NAKAMURA Takumi via cfe-commit
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you for fixing this!
http://reviews.llvm.org/D17335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:804
@@ +803,3 @@
+/// Returns true if there is a call to -dealloc anywhere on the stack and false
+/// otherwise. If true, it also sets \param SelfValOut to the value of
+/// 'self' in th
Author: cbieneman
Date: Thu Feb 25 12:39:19 2016
New Revision: 261911
URL: http://llvm.org/viewvc/llvm-project?rev=261911&view=rev
Log:
[CMake] Fixing install-clang-headers dependencies to depend on generating the
headers.
Modified:
cfe/trunk/lib/Headers/CMakeLists.txt
Modified: cfe/trunk/l
Author: dcoughlin
Date: Thu Feb 25 12:55:24 2016
New Revision: 261917
URL: http://llvm.org/viewvc/llvm-project?rev=261917&view=rev
Log:
[analyzer] Make ObjCDeallocChecker path sensitive.
Convert the ObjCDeallocChecker to be path sensitive. The primary
motivation for this change is to prevent fals
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261917: [analyzer] Make ObjCDeallocChecker path sensitive.
(authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D17511?vs=48995&id=49097#toc
Repository:
rL LLVM
http://reviews.l
Author: dcoughlin
Date: Thu Feb 25 13:13:43 2016
New Revision: 261921
URL: http://llvm.org/viewvc/llvm-project?rev=261921&view=rev
Log:
Revert "[analyzer] Make ObjCDeallocChecker path sensitive."
This reverts commit r261917. It broke the bots.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/
majnemer created this revision.
majnemer added reviewers: rsmith, andreybokhanko.
majnemer added a subscriber: cfe-commits.
A member expression's base doesn't always have an impact on what the
member decl would evaluate to. In such a case, the base is used as a
poor man's scope qualifier.
This f
majnemer updated this revision to Diff 49103.
majnemer added a comment.
- Add support for static data members too.
http://reviews.llvm.org/D17619
Files:
lib/AST/ExprConstant.cpp
test/SemaCXX/ms-const-member-expr.cpp
Index: test/SemaCXX/ms-const-member-expr.cpp
=
erik65536 created this revision.
erik65536 added reviewers: djasper, klimek.
erik65536 added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D17621
Files:
lib/Format/TokenAnnotator.cpp
Index: lib/Format/TokenAnnotator.cpp
==
Author: marshall
Date: Thu Feb 25 14:15:47 2016
New Revision: 261925
URL: http://llvm.org/viewvc/llvm-project?rev=261925&view=rev
Log:
Added tests to make sure that the categorization traits work on incomplete types
Modified:
libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.cat/arr
Author: marshall
Date: Thu Feb 25 14:17:03 2016
New Revision: 261926
URL: http://llvm.org/viewvc/llvm-project?rev=261926&view=rev
Log:
more status updates
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-proje
shuaiwang marked 3 inline comments as done.
shuaiwang added a comment.
http://reviews.llvm.org/D17586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shuaiwang updated this revision to Diff 49108.
shuaiwang added a comment.
more test cases
http://reviews.llvm.org/D17586
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTid
majnemer updated this revision to Diff 49109.
majnemer added a comment.
- Refactor this change.
http://reviews.llvm.org/D17619
Files:
lib/AST/ExprConstant.cpp
test/SemaCXX/ms-const-member-expr.cpp
Index: test/SemaCXX/ms-const-member-expr.cpp
Author: dcoughlin
Date: Thu Feb 25 15:15:16 2016
New Revision: 261929
URL: http://llvm.org/viewvc/llvm-project?rev=261929&view=rev
Log:
[analyzer] Reapply r261917 with a fix.
This reapplies "[analyzer] Make ObjCDeallocChecker path sensitive." (r261917)
with a fix for an error on some bots about s
xur created this revision.
xur added reviewers: davidxl, silvas, justinruggles.
xur added subscribers: cfe-commits, xur, mcrosier, davidxl, slingn.
This patch expands cc1 option -fprofile-instrument= with three new values:
(1) -fprofile-instrument=llvm
This enables IR PGO instrumentation.
(2) -fpr
Create a new review here:
http://reviews.llvm.org/D17622
Thanks,
-Rong
On Wed, Feb 24, 2016 at 9:22 PM, Sean Silva wrote:
> silvas added a comment.
>
> In http://reviews.llvm.org/D15829#360006, @xur wrote:
>
>> Here is the new patch that removes the auto detection of profile kind.
>>
>> In this
xur added a comment.
Create a new review here:
http://reviews.llvm.org/D17622
Thanks,
-Rong
http://reviews.llvm.org/D15829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: test/clang-tidy/readability-redundant-string-init.cpp:69
@@ +68,3 @@
+#define M(x) x
+#define N { std::string s = ""; }
+
Please add a CHECK-FIXES to ensure the macro definition hasn't changed and that
the macro invocatio
shuaiwang updated this revision to Diff 49114.
shuaiwang added a comment.
CHECK-FIXES for macro tests
http://reviews.llvm.org/D17586
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/Re
shuaiwang marked an inline comment as done.
shuaiwang added a comment.
http://reviews.llvm.org/D17586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis updated the summary for this revision.
eugenis updated this revision to Diff 49115.
eugenis added a comment.
OK, done. Please take another look.
This is inferior to the original patch in terms of functionality, but the
implementation is a lot simpler.
Repository:
rL LLVM
http://revie
alexfh accepted this revision.
alexfh added a comment.
Looks good!
I'll commit the patch for you.
http://reviews.llvm.org/D17586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dcoughlin
Date: Thu Feb 25 17:36:52 2016
New Revision: 261935
URL: http://llvm.org/viewvc/llvm-project?rev=261935&view=rev
Log:
[analyzer] Warn on use of 'self' after call to to [super dealloc].
Referring to 'self' after a call to [super dealloc] is a use-after-free in
Objective-C because
This revision was automatically updated to reflect the committed changes.
dcoughlin marked an inline comment as done.
Closed by commit rL261935: [analyzer] Warn on use of 'self' after call to to
[super dealloc]. (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D17528?vs
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp:165
@@ +164,3 @@
+ if (Desc.empty())
+Desc = "use of 'self' after it is freed with call to [super dealloc]";
+
zaks.anna wrote:
> Does "has been freed" sound
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261939: Add a new check, readability-redundant-string-init,
that checks unnecessary… (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D17586?vs=49114&id=49118#toc
Repository:
rL
Author: alexfh
Date: Thu Feb 25 17:57:30 2016
New Revision: 261940
URL: http://llvm.org/viewvc/llvm-project?rev=261940&view=rev
Log:
Remove a blank line at EOF. NFC
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/readability-redundant-string-init.rst
Modified:
clang-tools-extra/tr
Author: alexfh
Date: Thu Feb 25 17:57:23 2016
New Revision: 261939
URL: http://llvm.org/viewvc/llvm-project?rev=261939&view=rev
Log:
Add a new check, readability-redundant-string-init, that checks unnecessary
string initializations.
Reviewers: hokein, alexfh
Subscribers: cfe-commits
Patch by S
jpienaar added reviewers: eliben, jyknight, chandlerc.
jpienaar updated this revision to Diff 49119.
jpienaar added a comment.
Updated preprocessor test init.c to use -match-full-lines.
http://reviews.llvm.org/D17002
Files:
lib/Basic/Targets.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/Drive
Author: dcoughlin
Date: Thu Feb 25 18:23:41 2016
New Revision: 261944
URL: http://llvm.org/viewvc/llvm-project?rev=261944&view=rev
Log:
[analyzer] Fix a memory error in r261935 caught by the Windows bots.
It was using a temporary StringRef after its underlying storage was freed.
Modified:
cf
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks terrible, please commit :)
http://reviews.llvm.org/D17619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: dcoughlin
Date: Thu Feb 25 18:47:42 2016
New Revision: 261945
URL: http://llvm.org/viewvc/llvm-project?rev=261945&view=rev
Log:
[analyzer] Shorten ObjcSuperDeallocChecker diagnostics.
Change "use of 'self' after it has been freed with call to [super dealloc]" to
"use of 'self' after it ha
steven_wu created this revision.
steven_wu added reviewers: rtrieu, thakis.
steven_wu added a subscriber: cfe-commits.
-Wfor-loop-analysis was incorrectly warning about certain cases because
the DeclMatcher is not looking pass OpaqueValueExpr.
http://reviews.llvm.org/D17627
Files:
lib/Sema/Sem
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: caomhin, fraggamuffin, cfe-commits.
The map modifier 'delete' is parser in c++ mode as a delete keyword, which
requires special handling in the map clause par
ryee88 added a comment.
any comments?
http://reviews.llvm.org/D16949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 updated this revision to Diff 49136.
http://reviews.llvm.org/D17596
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenOpenCL/spir_version.cl
Index: test/CodeGenOpenCL/spir_version.cl
===
--- /dev/null
+++ test/CodeGenOpenCL/
On Tue, Feb 16, 2016 at 10:45 PM, David Blaikie wrote:
>
>
> On Tue, Feb 16, 2016 at 10:01 PM, Ryan Yee via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> ryee88 updated this revision to Diff 48149.
>> ryee88 added a comment.
>>
>> Keeping the number of test files to a minimum makes sens
pxli168 marked an inline comment as done.
pxli168 added a comment.
I think this is just a small change to help identify the which standard llvm-ir
is using.
And there is a SPIRV branch from Khronos
https://github.com/KhronosGroup/SPIRV-LLVM
We can start there and try to merge the spir-v support
Hi Peter
I notice after this commit, I can no longer use cmake option
-DCLANG_TOOL_DRIVER_BUILD=OFF to choose not to build and link the clang driver.
When using -DCLANG_TOOL_DRIVER_BUILD=OFF, clang target will not exist so cmake
will error on the line:
> +add_dependencies(clang vtables_blacklis
1 - 100 of 123 matches
Mail list logo
