[clang-tools-extra] r261811 - [clang-tidy] Another attempt to fix MSVC build

2016-02-24 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Wed Feb 24 18:39:11 2016 New Revision: 261811 URL: http://llvm.org/viewvc/llvm-project?rev=261811&view=rev Log: [clang-tidy] Another attempt to fix MSVC build Modified: clang-tools-extra/trunk/clang-tidy/modernize/DeprecatedHeadersCheck.cpp Modified: clang-tools-extra/t

Re: [clang-tools-extra] r261738 - [clang-tidy] introduce modernize-deprecated-headers check

2016-02-24 Thread Alexander Kornienko via cfe-commits
The build should be fixed, but the tests for this check fail. I'll fix the tests tomorrow. On Thu, Feb 25, 2016 at 12:46 AM, Alexander Kornienko wrote: > I have a couple ideas, will try on the buildbot, since I don't have MSVC > to try fixes locally. > > On Wed, Feb 24, 2016 at 10:27 PM, Alexand

[clang-tools-extra] r261814 - check-clang-tools: Introduce the feature "target-headers".

2016-02-24 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Wed Feb 24 19:12:57 2016 New Revision: 261814 URL: http://llvm.org/viewvc/llvm-project?rev=261814&view=rev Log: check-clang-tools: Introduce the feature "target-headers". For now, it just detects that host is non-Windows and target is msvc. FIXME: It should be probable for

Re: [PATCH] D17511: [analyzer] Make ObjCDeallocChecker path sensitive.

2016-02-24 Thread Devin Coughlin via cfe-commits
dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:184 @@ -144,21 +183,3 @@ - // Determine if the class subclasses NSObject. - IdentifierInfo* NSObjectII = &Ctx.Idents.get("NSObject"); - IdentifierInfo* SenTestCaseII = &Ctx.Idents.ge

Re: [PATCH] D17511: [analyzer] Make ObjCDeallocChecker path sensitive.

2016-02-24 Thread Devin Coughlin via cfe-commits
dcoughlin updated this revision to Diff 48995. dcoughlin marked 8 inline comments as done. dcoughlin added a comment. This update addresses Anna's review comments. The big change is that the program state now maps instance symbols to sets of initial ivar symbols that must be released. (Rather th

[PATCH] D17589: Fix Clang tests that used CHECK-NEXT-NOT and CHECK-DAG-NOT

2016-02-24 Thread Paul Robinson via cfe-commits
probinson created this revision. probinson added reviewers: jyknight, dexonsmith. probinson added a subscriber: cfe-commits. Herald added a reviewer: tstellarAMD. FileCheck actually doesn't support combo suffixes. In D17587 I made it complain, and these are the Clang tests that it caught. http:

Re: [clang-tools-extra] r261738 - [clang-tidy] introduce modernize-deprecated-headers check

2016-02-24 Thread Richard Smith via cfe-commits
On Wed, Feb 24, 2016 at 5:36 AM, Alexander Kornienko via cfe-commits wrote: > Author: alexfh > Date: Wed Feb 24 07:36:34 2016 > New Revision: 261738 > > URL: http://llvm.org/viewvc/llvm-project?rev=261738&view=rev > Log: > [clang-tidy] introduce modernize-deprecated-headers check > > Summary: > Th

Re: [PATCH] D17550: Adding doxygen comments to the LLVM intrinsics (part 6, popcntintrin.h)

2016-02-24 Thread Eric Christopher via cfe-commits
Those are all compelling reasons for me. Let's go with whatever you and Dmitri think would be best for now. :) -eric On Wed, Feb 24, 2016 at 12:41 PM Romanova, Katya < katya_roman...@playstation.sony.com> wrote: > Hello, > > > > I don’t think it will too hard to convert C++ style doxygen comment

Re: [PATCH] D17515: AMDGPU: Add builtins for recently added intrinsics

2016-02-24 Thread Tom Stellard via cfe-commits
tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D17515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D17520: AMDGPU: Fix inconsistent register name for flat_scratch

2016-02-24 Thread Tom Stellard via cfe-commits
tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D17520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D17519: AMDGPU: Fix broken/confusing predefined macro

2016-02-24 Thread Tom Stellard via cfe-commits
tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D17519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D17589: Fix Clang tests that used CHECK-NEXT-NOT and CHECK-DAG-NOT

2016-02-24 Thread Tom Stellard via cfe-commits
tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D17589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

r261818 - [OpenCL] Add Sema checks for types

2016-02-24 Thread Xiuli Pan via cfe-commits
Author: pxl Date: Wed Feb 24 21:34:20 2016 New Revision: 261818 URL: http://llvm.org/viewvc/llvm-project?rev=261818&view=rev Log: [OpenCL] Add Sema checks for types Summary: Add Sema checks for opencl type: image, pipe This patch is partitioned from http://reviews.llvm.org/D16047 Reviewers:

Re: [clang-tools-extra] r261737 - [clang-tidy] Added a check for forward declaration in the potentially wrong namespace

2016-02-24 Thread Sean Silva via cfe-commits
This or r261737 seem to be causing a bot failure: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/636 -- Sean Silva On Wed, Feb 24, 2016 at 5:35 AM, Alexander Kornienko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: alexfh > Date: Wed Feb

r261820 - [OPENMP 4.5] Support fielddecls in 'shared' clause.

2016-02-24 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Feb 24 21:59:29 2016 New Revision: 261820 URL: http://llvm.org/viewvc/llvm-project?rev=261820&view=rev Log: [OPENMP 4.5] Support fielddecls in 'shared' clause. OpenMP 4.5 allows to use non-static data members of current class in non-static member functions in different k

r261823 - Twek fix for PR24473 (r261506) - Preserve the template arguments as written

2016-02-24 Thread Faisal Vali via cfe-commits
Author: faisalv Date: Wed Feb 24 23:09:30 2016 New Revision: 261823 URL: http://llvm.org/viewvc/llvm-project?rev=261823&view=rev Log: Twek fix for PR24473 (r261506) - Preserve the template arguments as written (within the DeclRefExpr Node) when creating AST nodes that reference specializations of

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

2016-02-24 Thread Xiuli PAN via cfe-commits
pxli168 marked 2 inline comments as done. pxli168 added a comment. Remove test case for access quilifier in test/SemaOpenCL/invalid-kernel-attrs.cl. Due to the patch http://reviews.llvm.org/D17437. read_only can only be used in parameters with pipe and image type. Comment at: t

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

2016-02-24 Thread Sean Silva via cfe-commits
silvas added a comment. In http://reviews.llvm.org/D15829#360006, @xur wrote: > Here is the new patch that removes the auto detection of profile kind. > > In this patch, I replace the CC1 option of -fprofile-instr-use=<> with > -fprofile-instrument={llvm-use|clang-use}. For the use compilation,

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

2016-02-24 Thread Xiuli PAN via cfe-commits
pxli168 updated this revision to Diff 49007. http://reviews.llvm.org/D16040 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CodeGenFunction.cpp lib/Parse/ParseDecl.cpp lib/Sema/SemaChecking.cpp lib/Sema/SemaDe

r261824 - [OPENMP 4.5] Codegen for member decls in 'lastprivate' clause.

2016-02-24 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Feb 24 23:25:57 2016 New Revision: 261824 URL: http://llvm.org/viewvc/llvm-project?rev=261824&view=rev Log: [OPENMP 4.5] Codegen for member decls in 'lastprivate' clause. OpenMP 4.5 allows to privatize non-static member decls in non-static member functions. Patch capture

Re: [PATCH] D16876: [OpenCL] Refine pipe builtin support

2016-02-24 Thread Xiuli PAN via cfe-commits
pxli168 updated this revision to Diff 49008. pxli168 added a comment. 1. Make new indent and leave space for the incoming OpenCL C++. 2. Check for the index to see if they are integers. http://reviews.llvm.org/D16876 Files: include/clang/Basic/Builtins.h include/clang/Basic/DiagnosticSemaKi

Re: [PATCH] D17355: [Sema] Remove assert in TreeTransform::TransformObjCObjectType

2016-02-24 Thread Akira Hatanaka via cfe-commits
ahatanak added a comment. Is this OK to commit? I've committed the patch to fix the TypeLocBuilder bug in r261260. http://reviews.llvm.org/D17355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D17355: [Sema] Remove assert in TreeTransform::TransformObjCObjectType

2016-02-24 Thread Doug Gregor via cfe-commits
doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. LGTM, sorry for the delay. http://reviews.llvm.org/D17355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [PATCH] D17528: [analyzer] Warn on use of 'self' after call to to [super dealloc].

2016-02-24 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp:165 @@ +164,3 @@ + if (Desc.empty()) +Desc = "use of 'self' after it is freed with call to [super dealloc]"; + Does "has been freed" sound better? ==

Re: [PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

2016-02-24 Thread Xiuli PAN via cfe-commits
pxli168 added a comment. foo((event_t)0); Is above use have been hint by some test cases? Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7679 @@ -7678,2 +7678,3 @@ def err_wrong_sampler_addressspace: Error< - "sampler type cannot be used with the __local and __globa

Re: [PATCH] D17355: [Sema] Remove assert in TreeTransform::TransformObjCObjectType

2016-02-24 Thread Akira Hatanaka via cfe-commits
ahatanak added a comment. Thanks, I'll commit this shortly. http://reviews.llvm.org/D17355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r261829 - [Sema] Remove assert in TreeTransform::TransformObjCObjectType.

2016-02-24 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Thu Feb 25 01:08:33 2016 New Revision: 261829 URL: http://llvm.org/viewvc/llvm-project?rev=261829&view=rev Log: [Sema] Remove assert in TreeTransform::TransformObjCObjectType. The assert isn't correct since TypeLoc::ObjCObjectTypeLoc doesn't indicate whether the type is a d

Re: [PATCH] D17355: [Sema] Remove assert in TreeTransform::TransformObjCObjectType

2016-02-24 Thread Akira Hatanaka via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261829: [Sema] Remove assert in TreeTransform::TransformObjCObjectType. (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D17355?vs=48247&id=49012#toc Repository: rL LLVM http

<    1   2