probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
LGTM.
One question I have, which shouldn't block this (as we've done several like
this already):
Is is okay to be using C++ style comments in these headers?
(Is there a C-style comment t
xur marked 4 inline comments as done.
Comment at: lib/CodeGen/CodeGenModule.cpp:151
@@ -151,1 +150,3 @@
+ if (CodeGenOpts.hasProfileClangUse() &&
+ !CodeGenOpts.InstrProfileInput.empty()) {
auto ReaderOrErr =
davidxl wrote:
> Is the second condition sti
xur updated this revision to Diff 48859.
xur marked 2 inline comments as done.
xur added a comment.
Integrated with David's comments.
Thanks,
-Rong
http://reviews.llvm.org/D15829
Files:
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOpti
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
OK, let's go with this as a starting point. We don't need to get
maximally-precise type information in the first iteration.
http://reviews.llvm.org/D16821
_
Author: awatry
Date: Tue Feb 23 18:52:15 2016
New Revision: 261714
URL: http://llvm.org/viewvc/llvm-project?rev=261714&view=rev
Log:
math: Fix ilogb(double) return type
Signed-off-by: Aaron Watry
Reviewed-by: Jan Vesely
Modified:
libclc/trunk/generic/lib/math/ilogb.cl
Modified: libclc/tru
Calling getMostRecentDecl seems like a slightly fragile way to avoid
iterator invalidation here. Instead...
@@ -214,6 +212,19 @@ namespace clang {
unsigned I = Record.size();
Record.push_back(0);
+ auto &Specializations = Common->Specializations;
+ auto &&PartialSpecializa
rtrieu added a comment.
While this change does add the intended error messages, it won't produce a
correct a typo-corrected AST. For instance:
void run(int sss) {
sss = ? : ;
}
Will produce an empty function body:
`-FunctionDecl 0x7082ef0 line:1:6 run 'void (int)'
On Tue, Feb 23, 2016 at 8:28 AM, H.J. Lu wrote:
> On Tue, Feb 23, 2016 at 8:15 AM, Michael Matz wrote:
>> Hi,
>>
>> On Tue, 23 Feb 2016, H.J. Lu wrote:
>>
>>> I thought
>>>
>>> ---
>>> An empty type is a type where it and all of its subobjects (recursively)
>>> are of class, structure, union, or
arsenm created this revision.
arsenm added a subscriber: cfe-commits.
http://reviews.llvm.org/D17558
Files:
docs/LanguageExtensions.rst
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins.c
Index: test/CodeGen/builtins.c
==
rsmith added a subscriber: rsmith.
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
Sure, it makes sense to expose this.
Comment at: docs/LanguageExtensions.rst:1743
@@ +1742,3 @@
+
+This pro
pxli168 updated this revision to Diff 48872.
pxli168 marked an inline comment as done.
http://reviews.llvm.org/D17437
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaType.cpp
test/CodeGenOpenCL/opencl_types.cl
test/SemaOpenCL/invalid-image.cl
test/
pxli168 added a comment.
It now gives a warning for both C99 and OpenCL.
But for target SPIR it gives an err only because it treat unprototyped function
as varidic function:
/// \brief Checks whether the given calling convention supports variadic
/// calls. Unprototyped calls also use the va
Author: jyknight
Date: Tue Feb 23 20:59:33 2016
New Revision: 261717
URL: http://llvm.org/viewvc/llvm-project?rev=261717&view=rev
Log:
Default vaarg lowering should support indirect struct types.
Fixes PR11517 for SPARC.
On most targets, clang lowers va_arg itself, eschewing the use of the
llvm
arsenm updated this revision to Diff 48879.
arsenm added a comment.
Add long double version. Add the short summary before linking to the intrinsic
doc
http://reviews.llvm.org/D17558
Files:
docs/LanguageExtensions.rst
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeG
Author: pxl
Date: Tue Feb 23 22:29:36 2016
New Revision: 261719
URL: http://llvm.org/viewvc/llvm-project?rev=261719&view=rev
Log:
[OpenCL] Add Sema checks for OpenCL 2.0 block
Summary:
Add Sema checks for opencl 2.0 new features: Block.
This patch is partitioned from http://reviews.llvm.org/D1604
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261719: [OpenCL] Add Sema checks for OpenCL 2.0 block
(authored by pxl).
Changed prior to commit:
http://reviews.llvm.org/D17436?vs=48774&id=48880#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17
Hi,
Does anyone knows why the svn seems to be stuck after I commit this patch.
Thanks
Xiuli
-Original Message-
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
Xiuli Pan via cfe-commits
Sent: Wednesday, February 24, 2016 12:41 PM
To: cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261717: Default vaarg lowering should support indirect
struct types. (authored by jyknight).
Changed prior to commit:
http://reviews.llvm.org/D16154?vs=44785&id=48881#toc
Repository:
rL LLVM
http://
gbedwell added a subscriber: gbedwell.
gbedwell added a comment.
In http://reviews.llvm.org/D17550#360177, @probinson wrote:
> One question I have, which shouldn't block this (as we've done several like
> this already):
> Is is okay to be using C++ style comments in these headers?
> (Is there
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, echristo.
This lets you write, e.g.
uint3 a = threadIdx;
uint3 b = blockIdx;
dim3 c = gridDim;
dim3 d = blockDim;
which is legal in nvcc, but was not legal in clang.
The fact that e.g. the
echristo added a subscriber: echristo.
echristo added a comment.
Yeah, we should be doing this. Nice catch Paul and Greg.
Repository:
rL LLVM
http://reviews.llvm.org/D17550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Yeah, we should be doing this. Nice catch Paul and Greg.
On Tue, Feb 23, 2016, 10:34 PM Greg Bedwell
wrote:
> gbedwell added a subscriber: gbedwell.
> gbedwell added a comment.
>
> In http://reviews.llvm.org/D17550#360177, @probinson wrote:
>
> > One question I have, which shouldn't block this (
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, echristo.
curand.h includes curand_mtgp32_kernel.h. In host mode, this header
redefines threadIdx and blockDim, giving them their "proper" types of
uint3 and dim3, respectively.
clang has its own p
101 - 123 of 123 matches
Mail list logo
