r261618 - [ms-inline-asm] Fixing bug in single asm statement support

2016-02-23 Thread Marina Yatsina via cfe-commits
Author: myatsina Date: Tue Feb 23 02:53:45 2016 New Revision: 261618 URL: http://llvm.org/viewvc/llvm-project?rev=261618&view=rev Log: [ms-inline-asm] Fixing bug in single asm statement support Fixing a crash caused by trying to merge a single-line asm statement with an asm block that follows it

[clang-tools-extra] r261622 - [clang-tidy] Updated docs on testing clang-tidy checks.

2016-02-23 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Tue Feb 23 03:30:20 2016 New Revision: 261622 URL: http://llvm.org/viewvc/llvm-project?rev=261622&view=rev Log: [clang-tidy] Updated docs on testing clang-tidy checks. Modified: clang-tools-extra/trunk/docs/clang-tidy/index.rst Modified: clang-tools-extra/trunk/docs/clan

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

2016-02-23 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 48797. omtcyf0 marked 4 inline comments as done. omtcyf0 added a comment. Resolved issues @alexfh pointed to. http://reviews.llvm.org/D17484 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/DeprecatedHeadersCheck.cpp clang-tidy/moderniz

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

2016-02-23 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 48799. omtcyf0 added a comment. changed the warning comment to be more precise; fixed line with > 80 symbols http://reviews.llvm.org/D17484 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/DeprecatedHeadersCheck.cpp clang-tidy/modernize

r261625 - Print options, if requested.

2016-02-23 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Tue Feb 23 04:29:02 2016 New Revision: 261625 URL: http://llvm.org/viewvc/llvm-project?rev=261625&view=rev Log: Print options, if requested. Modified: cfe/trunk/lib/Tooling/CommonOptionsParser.cpp Modified: cfe/trunk/lib/Tooling/CommonOptionsParser.cpp URL: http://llvm.

r261626 - Fix a -Wunused-variable diagnostic.

2016-02-23 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Tue Feb 23 04:29:04 2016 New Revision: 261626 URL: http://llvm.org/viewvc/llvm-project?rev=261626&view=rev Log: Fix a -Wunused-variable diagnostic. Modified: cfe/trunk/lib/ASTMatchers/ASTMatchersInternal.cpp Modified: cfe/trunk/lib/ASTMatchers/ASTMatchersInternal.cpp URL

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

2016-02-23 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. A few small comments! Comment at: include/clang/Basic/AttrDocs.td:1572 @@ +1571,3 @@ +The __read_only, __write_only, __read_write, read_only, write_only and +read_write names are reserved for use as access qualifiers and shall not be +used otherwise. -

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

2016-02-23 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl:24 @@ -23,3 +23,3 @@ work_group_commit_read_pipe(p, tmp);// expected-error{{invalid argument type to function work_group_commit_read_pipe (expecting 'reserve_id_t')}} - sub_group_co

r261632 - [analyzer] Improve pointer arithmetic checker.

2016-02-23 Thread Gabor Horvath via cfe-commits
Author: xazax Date: Tue Feb 23 06:34:39 2016 New Revision: 261632 URL: http://llvm.org/viewvc/llvm-project?rev=261632&view=rev Log: [analyzer] Improve pointer arithmetic checker. This patch is intended to improve pointer arithmetic checker. From now on it only warns when the pointer arithmetic is

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

2016-02-23 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261632: [analyzer] Improve pointer arithmetic checker. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D14203?vs=41022&id=48806#toc Repository: rL LLVM http://reviews.llvm.org/

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-02-23 Thread Robert Lougher via cfe-commits
rob.lougher added a comment. Ping. Just test changes - OK to commit? http://reviews.llvm.org/D16298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-format-vs] Add Format on Save function. Add Format Document function.

2016-02-23 Thread Péter Budai via cfe-commits
Hi, This patch adds Format on Save and Format Document functions to clang-format-vs Visual Studio extension. The automatic format option can be turned on and off completely or for specific file extensions via the Options dialog. Patch is attached, tested on Visual Studio 2013 and 2015. Peter

r261634 - Supporting all entities declared in lexical scope in LLVM debug info.

2016-02-23 Thread Amjad Aboud via cfe-commits
Author: aaboud Date: Tue Feb 23 07:37:18 2016 New Revision: 261634 URL: http://llvm.org/viewvc/llvm-project?rev=261634&view=rev Log: Supporting all entities declared in lexical scope in LLVM debug info. Differential Revision: http://reviews.llvm.org/D15977 Added: cfe/trunk/test/CodeGenCXX/de

Re: [PATCH] D15977: [Clang] Supporting all entities declared in lexical scope in LLVM debug info

2016-02-23 Thread Amjad Aboud via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261634: Supporting all entities declared in lexical scope in LLVM debug info. (authored by aaboud). Changed prior to commit: http://reviews.llvm.org/D15977?vs=47988&id=48808#toc Repository: rL LLVM

r261635 - [CLANG] [AVX512] [BUILTIN] Adding pro{lv|r}{d|q}{128|256|512} builtin to clang

2016-02-23 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Tue Feb 23 07:41:13 2016 New Revision: 261635 URL: http://llvm.org/viewvc/llvm-project?rev=261635&view=rev Log: [CLANG] [AVX512] [BUILTIN] Adding pro{lv|r}{d|q}{128|256|512} builtin to clang Differential Revision: http://reviews.llvm.org/D17506 Modified: cfe/trunk/inc

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

2016-02-23 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one nit. Let me know if you need me to commit the patch for you. Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:99 @@ +98,3 @@ +std::string R

Re: [PATCH] D17244: [clang-tidy] readability-ternary-operator new check

2016-02-23 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/readability/BracesAroundStatementsCheck.cpp:16 @@ -15,2 +15,3 @@ using namespace clang::ast_matchers; +using namespace clang::tidy::lexer_utils; This file only needs one function from this namespace, so it's

r261638 - [CLANG] [AVX512] [BUILTIN] Adding pro{lv|r}{d|q}{128|256|512} builtin to clang

2016-02-23 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Tue Feb 23 08:23:53 2016 New Revision: 261638 URL: http://llvm.org/viewvc/llvm-project?rev=261638&view=rev Log: [CLANG] [AVX512] [BUILTIN] Adding pro{lv|r}{d|q}{128|256|512} builtin to clang Adding closer to the end of macro }->}) Differential Revision: http://reviews.llv

Re: [PATCH] D17407: [Sema] PR25755 Fix crash when initializing out-of-order struct references

2016-02-23 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 48815. hintonda added a comment. Moved new test into existing test file. http://reviews.llvm.org/D17407 Files: lib/Sema/SemaInit.cpp test/CXX/dcl.decl/dcl.init/dcl.init.list/p3-0x.cpp test/SemaCXX/cxx0x-initializer-aggregates.cpp test/SemaCXX/cxx0x

Re: [PATCH] D16044: getVariableName() for MemRegion

2016-02-23 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. What is the status if this? Do you need some help with any of the modifications? I'd love to see this patch in the repository soon. http://reviews.llvm.org/D16044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[libclc] r261639 - math: Add ilogb ported from amd-builtins

2016-02-23 Thread Aaron Watry via cfe-commits
Author: awatry Date: Tue Feb 23 08:43:09 2016 New Revision: 261639 URL: http://llvm.org/viewvc/llvm-project?rev=261639&view=rev Log: math: Add ilogb ported from amd-builtins The scalar float/double function bodies are a direct copy/paste with usage of the CLC wrappers to vectorize them. This com

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

2016-02-23 Thread H.J. Lu via cfe-commits
On Mon, Feb 22, 2016 at 4:50 AM, Michael Matz wrote: > Hi, > > On Sat, 20 Feb 2016, Richard Smith wrote: > >> > An empty type is a type where it and all of its subobjects >> > (recursively) are of class, structure, union, or array type. >> > >> > doesn't cover "trivially-copyable". >> >> That's co

Re: [PATCH] D17436: [OpenCL] Add Sema checks for OpenCL 2.0 block

2016-02-23 Thread Anastasia Stulova via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D17436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D17437: [OpenCL] Add Sema checks for types

2016-02-23 Thread Yaxun Liu via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Comment at: lib/Sema/SemaType.cpp:2180 @@ -2179,1 +2179,3 @@ + // OpenCL v2.0 s6.16.13.1 - Arrays of pipe type are not supported. + // OpenCL v2.0 s6.9.b - Ar

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

2016-02-23 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. Mostly minor comments, but I like this approach! Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7713 @@ +7712,3 @@ +def err_opencl_invalid_read_write : Error< + "access qualifier read_write can not be used for %0 %select{|earlier than Ope

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

2016-02-23 Thread Michael Matz via cfe-commits
Hi, On Tue, 23 Feb 2016, H.J. Lu wrote: > > --- > > An empty type is a type where it and all of its subobjects (recursively) > > are of class, structure, union, or array type. No memory slot nor > > register should be used to pass or return an object of empty type that's > > trivially copyable.

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

2016-02-23 Thread H.J. Lu via cfe-commits
On Tue, Feb 23, 2016 at 7:30 AM, Michael Matz wrote: > Hi, > > On Tue, 23 Feb 2016, H.J. Lu wrote: > >> > --- >> > An empty type is a type where it and all of its subobjects (recursively) >> > are of class, structure, union, or array type. No memory slot nor >> > register should be used to pass o

r261641 - [CLANG] [AVX512] [BUILTIN] Adding prorv{d|q}{128|256|512} builtin to clang

2016-02-23 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Tue Feb 23 09:59:47 2016 New Revision: 261641 URL: http://llvm.org/viewvc/llvm-project?rev=261641&view=rev Log: [CLANG] [AVX512] [BUILTIN] Adding prorv{d|q}{128|256|512} builtin to clang Differential Revision: http://reviews.llvm.org/D17512 Modified: cfe/trunk/includ

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

2016-02-23 Thread Michael Matz via cfe-commits
Hi, On Tue, 23 Feb 2016, H.J. Lu wrote: > I thought > > --- > An empty type is a type where it and all of its subobjects (recursively) > are of class, structure, union, or array type. > --- > > excluded > > struct empty > { > empty () = default; > }; Why would that be excluded? There are no

r261642 - Allow running dump_format_style.py from any directory.

2016-02-23 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Tue Feb 23 10:11:43 2016 New Revision: 261642 URL: http://llvm.org/viewvc/llvm-project?rev=261642&view=rev Log: Allow running dump_format_style.py from any directory. Modified: cfe/trunk/docs/tools/dump_format_style.py Modified: cfe/trunk/docs/tools/dump_format_style.py

r261643 - Update clang-format options docs.

2016-02-23 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Tue Feb 23 10:11:51 2016 New Revision: 261643 URL: http://llvm.org/viewvc/llvm-project?rev=261643&view=rev Log: Update clang-format options docs. Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst URL: http://llvm.o

r261644 - Support language selection for \code blocks.

2016-02-23 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Tue Feb 23 10:11:55 2016 New Revision: 261644 URL: http://llvm.org/viewvc/llvm-project?rev=261644&view=rev Log: Support language selection for \code blocks. Modified: cfe/trunk/docs/tools/dump_format_style.py Modified: cfe/trunk/docs/tools/dump_format_style.py URL: http

r261645 - Clean up clang-format options documentation. NFC

2016-02-23 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Tue Feb 23 10:12:00 2016 New Revision: 261645 URL: http://llvm.org/viewvc/llvm-project?rev=261645&view=rev Log: Clean up clang-format options documentation. NFC Use uniform style for inline code blocks, specify language for YAML code blocks, various formatting fixes etc. Mod

r261646 - Fix a typo. NFC

2016-02-23 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Tue Feb 23 10:12:08 2016 New Revision: 261646 URL: http://llvm.org/viewvc/llvm-project?rev=261646&view=rev Log: Fix a typo. NFC Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst cfe/trunk/include/clang/Format/Format.h Modified: cfe/trunk/docs/ClangFormatStyleOptio

[libcxx] r261647 - More updates; patch for 2583 ready

2016-02-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 23 10:20:24 2016 New Revision: 261647 URL: http://llvm.org/viewvc/llvm-project?rev=261647&view=rev Log: More updates; patch for 2583 ready Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/vi

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

2016-02-23 Thread H.J. Lu via cfe-commits
On Tue, Feb 23, 2016 at 8:15 AM, Michael Matz wrote: > Hi, > > On Tue, 23 Feb 2016, H.J. Lu wrote: > >> I thought >> >> --- >> An empty type is a type where it and all of its subobjects (recursively) >> are of class, structure, union, or array type. >> --- >> >> excluded >> >> struct empty >> { >>

[libcxx] r261648 - Add additional tests to ensure that we DTRT with short lists. This is LWG#2590, but there are no code changes, just additional tests

2016-02-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 23 10:25:20 2016 New Revision: 261648 URL: http://llvm.org/viewvc/llvm-project?rev=261648&view=rev Log: Add additional tests to ensure that we DTRT with short lists. This is LWG#2590, but there are no code changes, just additional tests Modified: libcxx/trunk/

Re: [PATCH] D17438: [OpenCL] Add Sema checks for atomics and implicit declaration

2016-02-23 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. I agree there seems to be nothing specifically on this topic in OpenCL spec. However, I wouldn't modify Clang and rely on its default behavior: 1. In C99 gives a warning 2. For some targets set up in a special way (i.e. SPIR) gives an error Comment a

Re: [PATCH] D16876: [OpenCL] Refine pipe builtin support

2016-02-23 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. Could you please address number 1 from my previous comment? Otherwise, I think we should try to proceed quickly here, it will be too hard to merge back in after long delay and also it would be nice to have as many corrections as possible ASAP. Could we move Richard t

Re: [PATCH] D17437: [OpenCL] Add Sema checks for types

2016-02-23 Thread Anastasia Stulova via cfe-commits
Anastasia accepted this revision. Comment at: test/SemaOpenCL/sampler_t.cl:13 @@ -12,2 +12,3 @@ foo(5); // expected-error {{sampler_t variable required - got 'int'}} + sampler_t sa[] = {argsmp,const_smp}; // expected-error {{array of 'sampler_t' type is invalid in OpenCL}} }

Re: r261626 - Fix a -Wunused-variable diagnostic.

2016-02-23 Thread David Blaikie via cfe-commits
On Tue, Feb 23, 2016 at 2:29 AM, Alexander Kornienko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: alexfh > Date: Tue Feb 23 04:29:04 2016 > New Revision: 261626 > > URL: http://llvm.org/viewvc/llvm-project?rev=261626&view=rev > Log: > Fix a -Wunused-variable diagnostic. > > Modif

Re: [PATCH] D16876: [OpenCL] Refine pipe builtin support

2016-02-23 Thread Pekka Jääskeläinen via cfe-commits
pekka.jaaskelainen accepted this revision. pekka.jaaskelainen added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D16876#359781, @Anastasia wrote: > @Pekka, do you have any more comments? Nope. Looking forward to finally implementing proper pipe support

Re: [PATCH] D16876: [OpenCL] Refine pipe builtin support

2016-02-23 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. In http://reviews.llvm.org/D16876#359786, @pekka.jaaskelainen wrote: > In http://reviews.llvm.org/D16876#359781, @Anastasia wrote: > > > @Pekka, do you have any more comments? > > > Nope. Looking forward to finally implementing proper pipe support to pocl. > > With the

[libcxx] r261653 - Add tests for LWG#2560. No code changes, just tests

2016-02-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 23 11:01:52 2016 New Revision: 261653 URL: http://llvm.org/viewvc/llvm-project?rev=261653&view=rev Log: Add tests for LWG#2560. No code changes, just tests Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp Modi

r261654 - Revert "[VFS] Add support for handling path traversals"

2016-02-23 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Tue Feb 23 11:06:50 2016 New Revision: 261654 URL: http://llvm.org/viewvc/llvm-project?rev=261654&view=rev Log: Revert "[VFS] Add support for handling path traversals" This reverts commit r261551 due to failing tests in windows bots: http://lab.llvm.org:8011/builders/clang-x6

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

2016-02-23 Thread Bruno Cardoso Lopes via cfe-commits
Looks like r261551's fault. Reverted in r261654. On Mon, Feb 22, 2016 at 11:12 PM, Bruno Cardoso Lopes wrote: > Reverted r261552 & r261556 in r261613. Waiting for next win bot > results to see if it's necessary to revert r261551 as well. > > On Mon, Feb 22, 2016 at 7:16 PM, Bruno Cardoso Lopes >

[libcxx] r261655 - More updates

2016-02-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 23 11:07:15 2016 New Revision: 261655 URL: http://llvm.org/viewvc/llvm-project?rev=261655&view=rev Log: More updates Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-project/libc

Re: r261626 - Fix a -Wunused-variable diagnostic.

2016-02-23 Thread Alexander Kornienko via cfe-commits
On Tue, Feb 23, 2016 at 5:51 PM, David Blaikie wrote: > > > On Tue, Feb 23, 2016 at 2:29 AM, Alexander Kornienko via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: alexfh >> Date: Tue Feb 23 04:29:04 2016 >> New Revision: 261626 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=

r261657 - Remove an unnecessary workaround introduced in r259975. (NFC)

2016-02-23 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue Feb 23 11:13:47 2016 New Revision: 261657 URL: http://llvm.org/viewvc/llvm-project?rev=261657&view=rev Log: Remove an unnecessary workaround introduced in r259975. (NFC) Now that LLVM r259973 allows replacing a temporary type with another temporary we can rely on the orig

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

2016-02-23 Thread Adrian Prantl via cfe-commits
--> r261657. Author: adrian Date: Tue Feb 23 17:13:47 2016 + Remove an unnecessary workaround introduced in r259975. (NFC) Now that LLVM r259973 allows replacing a temporary type with another temporary we can rely on the original implementation. It is possible for

Re: [PATCH] D17092: [X86] Add -mseparate-stack-seg

2016-02-23 Thread Michael LeMay via cfe-commits
mlemay-intel added a comment. Thank you for your feedback! Comment at: lib/CodeGen/TargetInfo.cpp:1569 @@ +1568,3 @@ +CGF.getTarget().getTargetOpts().Features; + if (std::find(TargetFeatures.begin(), TargetFeatures.end(), +"+separate-stack-seg") != TargetFea

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

2016-02-23 Thread Anastasia Stulova via cfe-commits
Anastasia removed a reviewer: pekka.jaaskelainen. Anastasia added a subscriber: pekka.jaaskelainen. Anastasia updated this revision to Diff 48826. Anastasia added a comment. I am adding a small clean up here for duplicate code! @Sam, could you please re-check again. Thanks! http://reviews.llvm.

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

2016-02-23 Thread Yaxun Liu via cfe-commits
yaxunl added inline comments. Comment at: test/SemaOpenCL/storageclass-cl20.cl:11 @@ -10,3 +10,3 @@ static global int S2 = 5; - static private int S3 = 5;// expected-error{{program scope variable must reside in global or constant address space}} + static private int S3 = 5;

[PATCH] D17547: [OpenMP] Add support for multidimensional array sections in map clause SEMA.

2016-02-23 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0. sfantao added subscribers: caomhin, fraggamuffin, cfe-commits. In some cases it can be proved statically that multidimensional array section refer to contiguous storage and can therefor

[libcxx] r261661 - These new tests fail on the green-dragon bots, which use an old Apple compiler.

2016-02-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 23 12:09:38 2016 New Revision: 261661 URL: http://llvm.org/viewvc/llvm-project?rev=261661&view=rev Log: These new tests fail on the green-dragon bots, which use an old Apple compiler. Since they're scheduled to be updated soon, we'll just comment out this test for th

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

2016-02-23 Thread Samuel Antao via cfe-commits
sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932 @@ +3900,34 @@ +// Reference types are ignored for mapping purposes. +if (auto *RefTy = ExprTy->getAs()) + ExprTy = RefTy->getPointeeType().getCanonicalType(); + +// Given that an

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

2016-02-23 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: test/SemaOpenCL/storageclass-cl20.cl:19 @@ -15,1 +18,2 @@ + extern int G6; // expected-error{{program scope variable must reside in global or constant address space}} } Khronos bug: https://cvs.khronos.org/bugzilla/s

Re: [PATCH] D17367: [OpenMP] Code generation for target data directive

2016-02-23 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 48831. sfantao updated the summary for this revision. sfantao added a comment. Rebase. http://reviews.llvm.org/D17367 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp test/OpenMP/target_data_codegen.c

Re: [PATCH] D17436: [OpenCL] Add Sema checks for OpenCL 2.0 block

2016-02-23 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: test/SemaOpenCL/invalid-block.cl:17 @@ +16,3 @@ +void f2(BlkInt *BlockPtr) { + BlkInt B = ^int(int I) {return 1;}; + BlkInt *P = &B; // expected-error {{invalid argument type 'BlkInt' (aka 'int (^)(int)') to unary expression}} --

Re: [PATCH] D17368: [OpenMP] Code generation for target enter data directive

2016-02-23 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 48834. sfantao added a comment. Rebase. http://reviews.llvm.org/D17368 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp test/OpenMP/target_enter_data_codegen.cpp Index: test/OpenMP/target_enter_data_

Re: [PATCH] SemaCXX: Support templates in availability attributes

2016-02-23 Thread Manman Ren via cfe-commits
This patch looks good to me. But I am not sure if Aaron has any comment. > On Feb 22, 2016, at 6:19 PM, Duncan P. N. Exon Smith > wrote: > >> >> On 2016-Feb-22, at 17:24, Manman Ren wrote: >> >> >> >>> On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon Smith >>> wrote: >>> >>> This patch add

Re: [PATCH] D17507: The controlling expression for _Generic is unevaluated

2016-02-23 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM for trunk and 3.8. http://reviews.llvm.org/D17507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

r261669 - Amends r252104 to evaluate the controlling expression in an unevaluated context. This eliminates false-positive diagnostics about null pointer dereferences (etc) in the controlling expressio

2016-02-23 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Feb 23 12:55:15 2016 New Revision: 261669 URL: http://llvm.org/viewvc/llvm-project?rev=261669&view=rev Log: Amends r252104 to evaluate the controlling expression in an unevaluated context. This eliminates false-positive diagnostics about null pointer dereferences (

Re: [PATCH] D17369: [OpenMP] Code generation for target exit data directive

2016-02-23 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 48835. sfantao added a comment. Rebase. http://reviews.llvm.org/D17369 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp test/OpenMP/target_exit_data_codegen.cpp Index: test/OpenMP/target_exit_data_co

Re: [PATCH] D17507: The controlling expression for _Generic is unevaluated

2016-02-23 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r261669. http://reviews.llvm.org/D17507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r261669 - Amends r252104 to evaluate the controlling expression in an unevaluated context. This eliminates false-positive diagnostics about null pointer dereferences (etc) in the controlling expre

2016-02-23 Thread Aaron Ballman via cfe-commits
Hans, this should be safe to merge into 3.8 (as Richard had mentioned in the review thread). Can you do the merge magic on my behalf? Thanks! ~Aaron On Tue, Feb 23, 2016 at 1:55 PM, Aaron Ballman via cfe-commits wrote: > Author: aaronballman > Date: Tue Feb 23 12:55:15 2016 > New Revision: 2616

Re: r261669 - Amends r252104 to evaluate the controlling expression in an unevaluated context. This eliminates false-positive diagnostics about null pointer dereferences (etc) in the controlling expre

2016-02-23 Thread Hans Wennborg via cfe-commits
Hi Aaron, I'll let it sit in the tree for a bit, and will then merge it later today. Many thanks, Hans On Tue, Feb 23, 2016 at 11:01 AM, Aaron Ballman wrote: > Hans, this should be safe to merge into 3.8 (as Richard had mentioned > in the review thread). Can you do the merge magic on my behalf?

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

2016-02-23 Thread Eric Christopher via cfe-commits
Thanks Adrian! On Tue, Feb 23, 2016 at 9:19 AM Adrian Prantl wrote: > --> r261657. > > Author: adrian > Date: Tue Feb 23 17:13:47 2016 + > > Remove an unnecessary workaround introduced in r259975. (NFC) > > Now that LLVM r259973 allows replacing a temporary type with another >

Re: r261669 - Amends r252104 to evaluate the controlling expression in an unevaluated context. This eliminates false-positive diagnostics about null pointer dereferences (etc) in the controlling expre

2016-02-23 Thread Aaron Ballman via cfe-commits
On Tue, Feb 23, 2016 at 2:03 PM, Hans Wennborg wrote: > Hi Aaron, > > I'll let it sit in the tree for a bit, and will then merge it later today. Sounds great, thank you! ~Aaron > > Many thanks, > Hans > > On Tue, Feb 23, 2016 at 11:01 AM, Aaron Ballman > wrote: >> Hans, this should be safe to

Re: [PATCH] D17019: [OpenMP] Code generation for teams - kernel launching

2016-02-23 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 48839. sfantao added a comment. Rebase. http://reviews.llvm.org/D17019 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGStmtOpenMP.cpp lib/CodeGen/CodeGenFunction.h test/OpenMP/teams_codegen.cpp Index: test/OpenMP/teams_codegen.cpp

r261670 - Revert r261634 "Supporting all entities declared in lexical scope in LLVM debug info." and r261657

2016-02-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Feb 23 13:10:16 2016 New Revision: 261670 URL: http://llvm.org/viewvc/llvm-project?rev=261670&view=rev Log: Revert r261634 "Supporting all entities declared in lexical scope in LLVM debug info." and r261657 r261634 and r261633 seems to have caused PR26715. r261657 depends

Re: r261657 - Remove an unnecessary workaround introduced in r259975. (NFC)

2016-02-23 Thread Hans Wennborg via cfe-commits
I'm sorry, but I had to revert this in order to revert r261634. r261657 On Tue, Feb 23, 2016 at 9:13 AM, Adrian Prantl via cfe-commits wrote: > Author: adrian > Date: Tue Feb 23 11:13:47 2016 > New Revision: 261657 > > URL: http://llvm.org/viewvc/llvm-project?rev=261657&view=rev > Log: > Remove a

Re: [PATCH] SemaCXX: Support templates in availability attributes

2016-02-23 Thread Aaron Ballman via cfe-commits
On Tue, Feb 23, 2016 at 1:52 PM, Manman Ren wrote: > This patch looks good to me. But I am not sure if Aaron has any comment. > > On Feb 22, 2016, at 6:19 PM, Duncan P. N. Exon Smith > wrote: > > > On 2016-Feb-22, at 17:24, Manman Ren wrote: > > > > On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon

Re: r261657 - Remove an unnecessary workaround introduced in r259975. (NFC)

2016-02-23 Thread Hans Wennborg via cfe-commits
On Tue, Feb 23, 2016 at 11:15 AM, Hans Wennborg wrote: > I'm sorry, but I had to revert this in order to revert r261634. r261657 Meant to say the revert is in r261670. > > On Tue, Feb 23, 2016 at 9:13 AM, Adrian Prantl via cfe-commits > wrote: >> Author: adrian >> Date: Tue Feb 23 11:13:47 2016

Re: r261657 - Remove an unnecessary workaround introduced in r259975. (NFC)

2016-02-23 Thread Adrian Prantl via cfe-commits
I will carefully revert the revert of this commit on top of the current trunk. Thanks for the notice. -- adrian > On Feb 23, 2016, at 11:15 AM, Hans Wennborg wrote: > > I'm sorry, but I had to revert this in order to revert r261634. r261657 > > On Tue, Feb 23, 2016 at 9:13 AM, Adrian Prantl v

r261673 - Reapply r261657.

2016-02-23 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Tue Feb 23 13:30:08 2016 New Revision: 261673 URL: http://llvm.org/viewvc/llvm-project?rev=261673&view=rev Log: Reapply r261657. Remove an unnecessary workaround introduced in r259975. (NFC) Now that LLVM r259973 allows replacing a temporary type with another temporary we can

r261674 - Rename Action::begin() to Action::input_begin().

2016-02-23 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Feb 23 13:30:43 2016 New Revision: 261674 URL: http://llvm.org/viewvc/llvm-project?rev=261674&view=rev Log: Rename Action::begin() to Action::input_begin(). Also introduce inputs() that reutnrs an llvm::iterator_range. Iterating over A->inputs() is much less mysterious than

Re: r261657 - Remove an unnecessary workaround introduced in r259975. (NFC)

2016-02-23 Thread Adrian Prantl via cfe-commits
Done in r261673. -- adrian > On Feb 23, 2016, at 11:23 AM, Adrian Prantl via cfe-commits > wrote: > > I will carefully revert the revert of this commit on top of the current > trunk. Thanks for the notice. > > -- adrian > >> On Feb 23, 2016, at 11:15 AM, Hans Wennborg wrote: >> >> I'm sor

Re: r261297 - Implement the likely resolution of core issue 253.

2016-02-23 Thread Richard Smith via cfe-commits
On Sat, Feb 20, 2016 at 6:53 AM, Nico Weber wrote: > On Fri, Feb 19, 2016 at 10:32 PM, Nico Weber wrote: >> >> On Fri, Feb 19, 2016 at 10:02 PM, Nico Weber wrote: >>> >>> On Fri, Feb 19, 2016 at 8:01 PM, Richard Smith >>> wrote: On Fri, Feb 19, 2016 at 4:41 PM, Nico Weber wrote:

Re: r261674 - Rename Action::begin() to Action::input_begin().

2016-02-23 Thread David Blaikie via cfe-commits
On Tue, Feb 23, 2016 at 11:30 AM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: nico > Date: Tue Feb 23 13:30:43 2016 > New Revision: 261674 > > URL: http://llvm.org/viewvc/llvm-project?rev=261674&view=rev > Log: > Rename Action::begin() to Action::input_begin(). > > Al

[libcxx] r261677 - Fix a missing closing tag

2016-02-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 23 13:48:44 2016 New Revision: 261677 URL: http://llvm.org/viewvc/llvm-project?rev=261677&view=rev Log: Fix a missing closing tag Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm

[libcxx] r261676 - More updates

2016-02-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 23 13:48:09 2016 New Revision: 261676 URL: http://llvm.org/viewvc/llvm-project?rev=261676&view=rev Log: More updates Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-project/libc

r261680 - [CMake] Add install-clang-format target by migrating to add_clang_tool

2016-02-23 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Tue Feb 23 14:33:15 2016 New Revision: 261680 URL: http://llvm.org/viewvc/llvm-project?rev=261680&view=rev Log: [CMake] Add install-clang-format target by migrating to add_clang_tool This change migrates clang-format to add_clang_tool which makes a component-based install

Re: r261674 - Rename Action::begin() to Action::input_begin().

2016-02-23 Thread Nico Weber via cfe-commits
On Tue, Feb 23, 2016 at 2:44 PM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Tue, Feb 23, 2016 at 11:30 AM, Nico Weber via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: nico >> Date: Tue Feb 23 13:30:43 2016 >> New Revision: 261674 >> >> URL: http:

[PATCH] D17550: Adding doxygen comments to the LLVM intrinsics (part 6, popcntintrin.h)

2016-02-23 Thread Katya Romanova via cfe-commits
kromanova created this revision. kromanova added a subscriber: cfe-commits. kromanova set the repository for this revision to rL LLVM. Here is the patch with the doxygen comments for the intrinsincs in the header file popcntintrin.h. The doxygen comments are automatically generated based on SCE i

Re: r261674 - Rename Action::begin() to Action::input_begin().

2016-02-23 Thread David Blaikie via cfe-commits
On Tue, Feb 23, 2016 at 12:46 PM, Nico Weber wrote: > On Tue, Feb 23, 2016 at 2:44 PM, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> >> On Tue, Feb 23, 2016 at 11:30 AM, Nico Weber via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: nico >>> Date:

Re: r261674 - Rename Action::begin() to Action::input_begin().

2016-02-23 Thread Nico Weber via cfe-commits
On Tue, Feb 23, 2016 at 3:55 PM, David Blaikie wrote: > > > On Tue, Feb 23, 2016 at 12:46 PM, Nico Weber wrote: > >> On Tue, Feb 23, 2016 at 2:44 PM, David Blaikie via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> >>> >>> On Tue, Feb 23, 2016 at 11:30 AM, Nico Weber via cfe-commits

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

2016-02-23 Thread Rong Xu via cfe-commits
xur updated this revision to Diff 48846. xur marked an inline comment as done. xur added a comment. Here is the new patch that removes the auto detection of profile kind. In this patch, I replace the CC1 option of -fprofile-instr-use=<> with -fprofile-instrument={llvm-use|clang-use}. For the use

Re: r261674 - Rename Action::begin() to Action::input_begin().

2016-02-23 Thread David Blaikie via cfe-commits
On Tue, Feb 23, 2016 at 1:02 PM, Nico Weber wrote: > On Tue, Feb 23, 2016 at 3:55 PM, David Blaikie wrote: > >> >> >> On Tue, Feb 23, 2016 at 12:46 PM, Nico Weber wrote: >> >>> On Tue, Feb 23, 2016 at 2:44 PM, David Blaikie via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>>

Re: r261669 - Amends r252104 to evaluate the controlling expression in an unevaluated context. This eliminates false-positive diagnostics about null pointer dereferences (etc) in the controlling expre

2016-02-23 Thread Hans Wennborg via cfe-commits
On Tue, Feb 23, 2016 at 11:12 AM, Aaron Ballman wrote: > On Tue, Feb 23, 2016 at 2:03 PM, Hans Wennborg wrote: >> Hi Aaron, >> >> I'll let it sit in the tree for a bit, and will then merge it later today. > > Sounds great, thank you! r261684. >> Many thanks, >> Hans >> >> On Tue, Feb 23, 2016

[libcxxabi] r261691 - Creating release candidate rc3 from release_380 branch

2016-02-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Feb 23 15:40:04 2016 New Revision: 261691 URL: http://llvm.org/viewvc/llvm-project?rev=261691&view=rev Log: Creating release candidate rc3 from release_380 branch Added: libcxxabi/tags/RELEASE_380/rc3/ (props changed) - copied from r261690, libcxxabi/branches/re

[libcxx] r261690 - Creating release candidate rc3 from release_380 branch

2016-02-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Feb 23 15:40:01 2016 New Revision: 261690 URL: http://llvm.org/viewvc/llvm-project?rev=261690&view=rev Log: Creating release candidate rc3 from release_380 branch Added: libcxx/tags/RELEASE_380/rc3/ (props changed) - copied from r261689, libcxx/branches/release_

[libunwind] r261697 - Creating release candidate rc3 from release_380 branch

2016-02-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Feb 23 15:40:24 2016 New Revision: 261697 URL: http://llvm.org/viewvc/llvm-project?rev=261697&view=rev Log: Creating release candidate rc3 from release_380 branch Added: libunwind/tags/RELEASE_380/rc3/ - copied from r261696, libunwind/branches/release_38/ ___

r261703 - [analyzer] Find ObjC 'self' decl even when block captures local named 'self'.

2016-02-23 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Tue Feb 23 16:26:04 2016 New Revision: 261703 URL: http://llvm.org/viewvc/llvm-project?rev=261703&view=rev Log: [analyzer] Find ObjC 'self' decl even when block captures local named 'self'. When looking up the 'self' decl in block captures, make sure to find the actual sel

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

2016-02-23 Thread David Li via cfe-commits
davidxl added inline comments. Comment at: include/clang/Frontend/CodeGenOptions.h:83 @@ -82,2 +82,3 @@ enum ProfileInstrKind { ProfileNoInstr,// No instrumentation. +ProfileClangInstr, // Clang instrumentation to generate execution counts Maybe Pr

r261705 - PR24667: fix quadratic runtime if textually-included modular headers define large numbers of macros.

2016-02-23 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Feb 23 17:20:51 2016 New Revision: 261705 URL: http://llvm.org/viewvc/llvm-project?rev=261705&view=rev Log: PR24667: fix quadratic runtime if textually-included modular headers define large numbers of macros. Modified: cfe/trunk/include/clang/Lex/Preprocessor.h c

Re: [PATCH] SemaCXX: Support templates in availability attributes

2016-02-23 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2016-Feb-23, at 11:18, Aaron Ballman wrote: > > On Tue, Feb 23, 2016 at 1:52 PM, Manman Ren wrote: >> This patch looks good to me. But I am not sure if Aaron has any comment. >> >> On Feb 22, 2016, at 6:19 PM, Duncan P. N. Exon Smith >> wrote: >> >> >> On 2016-Feb-22, at 17:24, Manman

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

2016-02-23 Thread Richard Trieu via cfe-commits
rtrieu added a comment. A few more comments. In http://reviews.llvm.org/D15636#358588, @AndyG wrote: > Patch additionally re-based off r261522. It's usually a bad idea to rebase in the middle of a string of patches. Phabricator isn't aware of revisions, so while a base to latest patch will s

Re: [PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

2016-02-23 Thread James Y Knight via cfe-commits
jyknight added a comment. Ping. I'm pretty sure you said you were going to look at this. :) http://reviews.llvm.org/D17183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17348: Add -Wcast-calling-convention to warn when casting away calling conventions

2016-02-23 Thread Richard Trieu via cfe-commits
rtrieu added inline comments. Comment at: lib/Sema/SemaCast.cpp:1729 @@ +1728,3 @@ +/// defined in the current TU. +static void diagnoseCallingConvCast(Sema &Self, const ExprResult &SrcExpr, +QualType DstType, SourceRange OpRange) {

  1   2   >