Author: dexonsmith
Date: Mon Feb 22 16:24:22 2016
New Revision: 261585
URL: http://llvm.org/viewvc/llvm-project?rev=261585&view=rev
Log:
Lex: Check for 0 buckets on header map construction
Switch to using `isPowerOf2_32()` to check whether the buckets are a
power of two, and as a side benefit rej
> On 2016-Feb-22, at 10:39, Adrian Prantl wrote:
>
>>
>> On Feb 20, 2016, at 1:00 PM, Duncan P. N. Exon Smith via cfe-commits
>> wrote:
>>
>> Author: dexonsmith
>> Date: Sat Feb 20 15:00:58 2016
>> New Revision: 261448
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=261448&view=rev
>> Lo
On Mon, Feb 22, 2016 at 4:44 PM, Aaron Ballman
wrote:
> On Mon, Feb 22, 2016 at 4:43 PM, Samuel Benzaquen
> wrote:
> >
> > On Mon, Feb 22, 2016 at 4:19 PM, Aaron Ballman
> > wrote:
> >>
> >> On Mon, Feb 22, 2016 at 4:13 PM, Samuel Benzaquen via cfe-commits
> >> wrote:
> >> > Author: sbenza
> >
On Mon, Feb 22, 2016 at 5:27 PM, Hans Wennborg wrote:
> On Mon, Feb 22, 2016 at 1:13 PM, Samuel Benzaquen via cfe-commits
> wrote:
> > Author: sbenza
> > Date: Mon Feb 22 15:13:02 2016
> > New Revision: 261574
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=261574&view=rev
> > Log:
> > [AST
arsenm added inline comments.
Comment at: lib/Basic/Targets.cpp:2059-2063
@@ +2058,7 @@
+
+ if (Has16BitInsts)
+Features["16-bit-insts"] = true;
+
+ if (hasSMemRealTime)
+Features["s-memrealtime"] = true;
+
echristo wrote:
> This is typically more of the
alexfh added inline comments.
Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:78
@@ +77,3 @@
+ if (LangOpts.CPlusPlus11) {
+std::vector> Cxx11DeprecatedHeaders = {
+{"fenv.h", "cfenv"},
This can be done without STL algorithms and lambdas:
Hello everyone,
Below are some buildbot numbers for the week of 2/07/2016 - 2/13/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
Hello everyone,
Below are some buildbot numbers for the last week of 2/14/2016 - 2/20/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
hintonda updated this revision to Diff 48742.
hintonda added a comment.
Added comment
Added comment to test file.
http://reviews.llvm.org/D17248
Files:
lib/CodeGen/CGValue.h
test/Sema/attr-aligned.c
Index: test/Sema/attr-aligned.c
===
On Mon, Feb 22, 2016 at 01:38:27PM -0800, Pete Cooper wrote:
>
> > On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote:
> >
> > One thing that I'd like to do (and this would help CFI as well) is to
> > specifically recognize cases like this:
> >
> > ```
> > struct B {
> > virtual void vf()
dcoughlin created this revision.
dcoughlin added a reviewer: zaks.anna.
dcoughlin added a subscriber: cfe-commits.
Referring to 'self' after a call to [super dealloc] is a use-after-free in
Objective-C because NSObject's -dealloc frees the memory pointed to by self.
This patch extends the ObjCS
> On Feb 22, 2016, at 3:47 PM, Peter Collingbourne wrote:
>
> On Mon, Feb 22, 2016 at 01:38:27PM -0800, Pete Cooper wrote:
>>
>>> On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote:
>>>
>>> One thing that I'd like to do (and this would help CFI as well) is to
>>> specifically recognize c
dcoughlin added a subscriber: cfe-commits.
dcoughlin updated this revision to Diff 48750.
dcoughlin added a comment.
Provide diff with context. Apologies for leaving that out.
http://reviews.llvm.org/D17511
Files:
lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp
test/Analysis/DeallocMissing
On Mon, Feb 22, 2016 at 03:59:01PM -0800, Mehdi Amini wrote:
>
> > On Feb 22, 2016, at 3:47 PM, Peter Collingbourne wrote:
> >
> > On Mon, Feb 22, 2016 at 01:38:27PM -0800, Pete Cooper wrote:
> >>
> >>> On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote:
> >>>
> >>> One thing that I'd lik
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
hintonda added a comment.
Thanks David. Btw, could you commit it for me? I don't have commit access.
http://reviews.llvm.org/D17248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dexonsmith
Date: Mon Feb 22 18:48:16 2016
New Revision: 261596
URL: http://llvm.org/viewvc/llvm-project?rev=261596&view=rev
Log:
Lex: Return "" when HeaderMap::lookupFilename fails
Change getString() to return Optional, and change
lookupFilename() to return an empty string if either one o
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:89
@@ -109,7 +88,3 @@
-static bool synthesizedPropertyRequiresRelease(const ObjCPropertyDecl *PD) {
- // A synthesized property must be released if and only if the kind of setter
- //
> On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon Smith
> wrote:
>
> This patch adds support for templates in availability attributes.
> - If the context for an availability diagnostic is a
>`FunctionTemplateDecl`, look through it to the `FunctionDecl`.
> AvailabilityResult Decl::getAvail
Hi Adrian,
On Sat, Feb 20, 2016 at 1:18 PM Adrian Prantl wrote:
> This had me puzzled for a second, but then I figured out what happened :-)
> The “crash” I quoted in the commit message really was an assertion
> failure, to be precise, the very assertion I relaxed in LLVM r259973 in
> order to b
This or r261551 seem to be causing a build failure:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/527
-- Sean SIlva
On Mon, Feb 22, 2016 at 10:41 AM, Bruno Cardoso Lopes via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bruno
> Date: Mon F
pxli168 accepted this revision.
pxli168 added a comment.
This revision is now accepted and ready to land.
Then there will be no problem.
I will change my patches as well.
LGTM!
Thanks.
http://reviews.llvm.org/D16928
___
cfe-commits mailing list
cfe-
> On 2016-Feb-22, at 17:24, Manman Ren wrote:
>
>
>
>> On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon Smith
>> wrote:
>>
>> This patch adds support for templates in availability attributes.
>> - If the context for an availability diagnostic is a
>> `FunctionTemplateDecl`, look through it t
pxli168 added a comment.
It seems this patch is useless.
The spec does not tell about implicit declaration of function, but now clang
with -triple spir will output err if there is implicit declaration of function.
I have read about spir and opencl spec but could not find anything talk about
that
Hi Sean,
This is hopefully fixed in r261556.
On Mon, Feb 22, 2016 at 5:45 PM, Sean Silva wrote:
> This or r261551 seem to be causing a build failure:
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/527
>
> -- Sean SIlva
>
> On Mon, Feb 22, 2016 at 10:4
The bot is still red:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast
On Mon, Feb 22, 2016 at 6:48 PM, Bruno Cardoso Lopes <
bruno.card...@gmail.com> wrote:
> Hi Sean,
>
> This is hopefully fixed in r261556.
>
> On Mon, Feb 22, 2016 at 5:45 PM, Sean Silva wrote
Yes, but because of a related but different issue. The same as here:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10026
I've been trying to figure it out but it's been hard without a Unix
system available. I'll keep investigating and revert later tonight in
case I can't guess it.
Hello everyone,
LLVM buildmaster will be updated and restarted in few minutes.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 updated this revision to Diff 48773.
pxli168 added a comment.
Add array check for types.
http://reviews.llvm.org/D17437
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaType.cpp
test/CodeGenOpenCL/opencl_types.cl
test/SemaOpenCL/invalid-imag
pxli168 updated this revision to Diff 48774.
http://reviews.llvm.org/D17436
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaType.cpp
test/SemaOpenCL/invalid-block.cl
Index: test/SemaOpenCL/invalid-block.cl
=
pxli168 added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:6714
@@ +6713,3 @@
+ if (LangOpts.OpenCLVersion >= 200 && T->isBlockPointerType()) {
+const BlockPointerType *BlkTy = T->getAs();
+const FunctionProtoType *FTy =
Anastasia wrote:
> Yes, but
Author: bruno
Date: Tue Feb 23 01:06:12 2016
New Revision: 261613
URL: http://llvm.org/viewvc/llvm-project?rev=261613&view=rev
Log:
Revert "[VFS] Add 'overlay-relative' field to YAML files" and "[VFS] Fix call
to getVFSFromYAML in unittests"
This reverts commit r261552 and r261556 because of fai
delena added a subscriber: delena.
Comment at: lib/CodeGen/TargetInfo.cpp:1569
@@ +1568,3 @@
+CGF.getTarget().getTargetOpts().Features;
+ if (std::find(TargetFeatures.begin(), TargetFeatures.end(),
+"+separate-stack-seg") != TargetFeatures.end()) {
---
Reverted r261552 & r261556 in r261613. Waiting for next win bot
results to see if it's necessary to revert r261551 as well.
On Mon, Feb 22, 2016 at 7:16 PM, Bruno Cardoso Lopes
wrote:
> Yes, but because of a related but different issue. The same as here:
> http://lab.llvm.org:8011/builders/clang-
101 - 134 of 134 matches
Mail list logo
