Author: ericwf
Date: Sat Feb 20 01:59:16 2016
New Revision: 261421
URL: http://llvm.org/viewvc/llvm-project?rev=261421&view=rev
Log:
Rename <__hash_table> traits so they don't conflict with similar traits.
In particular <__tree> defines many of the same types of traits classes.
Modified:
lib
Author: rdivacky
Date: Sat Feb 20 02:31:24 2016
New Revision: 261422
URL: http://llvm.org/viewvc/llvm-project?rev=261422&view=rev
Log:
Fix handling of vaargs on PPC32 when going from regsave to overflow.
It can happen that when we only have 1 more register left in the regsave
area we need to stor
rtrieu added a comment.
In http://reviews.llvm.org/D15636#352532, @AndyG wrote:
> Richard, are you happy with this latest version? Can I proceed to commit it?
>
> Thanks.
No, this is not ready yet. This code is old and needs a bit of clean up, and
because your patch touches it, you will be o
Author: majnemer
Date: Sat Feb 20 03:23:44 2016
New Revision: 261424
URL: http://llvm.org/viewvc/llvm-project?rev=261424&view=rev
Log:
[MSVC Compat] Add support for /GX, /GX-
These are legacy flags which map to /EHsc and /EHs-c- respectively.
Modified:
cfe/trunk/include/clang/Driver/CLCompat
Author: majnemer
Date: Sat Feb 20 03:23:47 2016
New Revision: 261425
URL: http://llvm.org/viewvc/llvm-project?rev=261425&view=rev
Log:
[MSVC Compat] Implement -EHc semantics
The -EHc flag implicitly adds a nothrow attribute to any extern "C"
function when exceptions are enabled.
Modified:
cf
Author: majnemer
Date: Sat Feb 20 03:23:41 2016
New Revision: 261423
URL: http://llvm.org/viewvc/llvm-project?rev=261423&view=rev
Log:
Remove -fnew-ms-eh
This flag no longer controls any behavior inside of clang.
Modified:
cfe/trunk/include/clang/Driver/CC1Options.td
cfe/trunk/test/CodeG
Author: alexfh
Date: Sat Feb 20 05:42:13 2016
New Revision: 261431
URL: http://llvm.org/viewvc/llvm-project?rev=261431&view=rev
Log:
[clang-tidy] Describe modules, link to LLVM development docs, other minor
updates
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-
andreybokhanko updated this revision to Diff 48591.
andreybokhanko added a comment.
Patch updated in response to Reid's proposal (to introduce KEYMSCOMPAT).
(To clarify, I agree with Aaron that we should wait for MS' response first.
Though I frankly don't expect them to accept recognition of "st
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261432: [CMake] Add partial support for MSVC in compiler-rt
builtins, by Roman Shirokiy. (authored by aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D17452?vs=48489&id=48593#toc
Repository
On 20 Feb 2016, at 09:31, Roman Divacky via cfe-commits
wrote:
>
> Author: rdivacky
> Date: Sat Feb 20 02:31:24 2016
> New Revision: 261422
>
> URL: http://llvm.org/viewvc/llvm-project?rev=261422&view=rev
> Log:
> Fix handling of vaargs on PPC32 when going from regsave to overflow.
>
> It can
- Original Message -
> From: "Dimitry Andric via cfe-commits"
> To: "Hans Wennborg"
> Cc: "Roman Divacky" , "cfe-commits"
>
> Sent: Saturday, February 20, 2016 8:24:36 AM
> Subject: Re: r261422 - Fix handling of vaargs on PPC32 when going from
> regsave to overflow.
>
> On 20 Feb 20
On Fri, Feb 19, 2016 at 10:32 PM, Nico Weber wrote:
> On Fri, Feb 19, 2016 at 10:02 PM, Nico Weber wrote:
>
>> On Fri, Feb 19, 2016 at 8:01 PM, Richard Smith
>> wrote:
>>
>>> On Fri, Feb 19, 2016 at 4:41 PM, Nico Weber wrote:
>>> > On Fri, Feb 19, 2016 at 4:29 PM, Richard Smith via cfe-commits
esakella added a comment.
In http://reviews.llvm.org/D17029#356428, @akyrtzi wrote:
> If I apply just the test changes without the rest of the changes, I don't see
> any failures, so I'm not sure these are effective tests.
This happens because also one of the changes is the new line 4304 which
esakella added a comment.
In http://reviews.llvm.org/D17026#356418, @akyrtzi wrote:
> Doesn't this mean that _all_ of the Importer.FromDiag() calls will be ignored
> by VerifyDiagnosticConsumer ? Why specifically change only this two and what
> are we going to do with the others ?
> This seems
LegalizeAdulthood created this revision.
LegalizeAdulthood added a reviewer: alexfh.
LegalizeAdulthood added a subscriber: cfe-commits.
This changeset improves check_clang_tidy.py to allow chnages made by a check to
a header to be verified.
A new argument `--header-filter` allows the test file t
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806
@@ -3780,4 +3798,10 @@
OffloadEntriesInfoManager.registerTargetRegionEntryInfo(
DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID);
}
+/// \brief Emit the num_teams clause
On Fri, Feb 19, 2016 at 1:07 PM, Richard Smith wrote:
> On Fri, Feb 19, 2016 at 5:35 AM, Michael Matz wrote:
>> Hi,
>>
>> On Thu, 18 Feb 2016, Richard Smith wrote:
>>
>>> >> An empty type is a type where it and all of its subobjects
>>> >> (recursively) are of class, structure, union, or array ty
On 20 February 2016 at 18:55, H.J. Lu wrote:
> struct dummy0
> {
> };
>
> struct dummy
> {
> dummy0 d[20];
>
> dummy0 * foo (int i);
> };
>
> dummy0 *
> dummy::foo (int i)
> {
> return &d[i];
> }
>
> dummy0 *
> bar (dummy d, int i)
> {
> return d.foo (i);
> }
1. This has undefined behavio
Author: dexonsmith
Date: Sat Feb 20 12:53:45 2016
New Revision: 261442
URL: http://llvm.org/viewvc/llvm-project?rev=261442&view=rev
Log:
Lex: Remove explicitly deleted copy constructor, NFC
`std::unique_ptr` already deletes these, so there's no
reason for the boiler-plate in HeaderMap.
Modified:
Author: dexonsmith
Date: Sat Feb 20 12:55:08 2016
New Revision: 261443
URL: http://llvm.org/viewvc/llvm-project?rev=261443&view=rev
Log:
Lex: clang-format HeaderMap.h, NFC
Modified:
cfe/trunk/include/clang/Lex/HeaderMap.h
Modified: cfe/trunk/include/clang/Lex/HeaderMap.h
URL:
http://llvm.or
akyrtzi added a comment.
I'm not sure removing all the Importer.FromDiag() calls is the right thing. You
are changing
Importer.FromDiag(D->getLocation(), diag::err_unsupported_ast_node)
to
Importer.ToDiag(SourceLocation(), diag::err_unsupported_ast_node)
and you lose the source location infor
akyrtzi added a comment.
Could you check if you can decouple VerifyDiagnosticConsumer from depending on
a particular DiagnosticsEngine ?
http://reviews.llvm.org/D17026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
omtcyf0 created this revision.
omtcyf0 added reviewers: alexfh, LegalizeAdulthood, Eugene.Zelenko.
omtcyf0 added a subscriber: cfe-commits.
This patch introduces the modernize-deprecated-headers check, which is supposed
to replace deprecated C library headers with the C++ STL-ones.
For informati
omtcyf0 updated this revision to Diff 48598.
omtcyf0 added a comment.
fixed clang-tidy/modernize/DeprecatedHeaders.h head typo caused by the check
rename
http://reviews.llvm.org/D17484
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
clang-tidy/m
On Sat, Feb 20, 2016 at 10:50 AM, Matthijs van Duin
wrote:
> On 20 February 2016 at 18:55, H.J. Lu wrote:
>> struct dummy0
>> {
>> };
>>
>> struct dummy
>> {
>> dummy0 d[20];
>>
>> dummy0 * foo (int i);
>> };
>>
>> dummy0 *
>> dummy::foo (int i)
>> {
>> return &d[i];
>> }
>>
>> dummy0 *
>>
On 20 February 2016 at 20:34, H.J. Lu wrote:
> Is there a class, which meets the above definition, with a member function
> which can't be passed without a memory slot or a register?
The EmptyInt class in my first post in this thread. It has no
non-static data members, has standard layout, and h
Author: akirtzidis
Date: Sat Feb 20 14:34:55 2016
New Revision: 261445
URL: http://llvm.org/viewvc/llvm-project?rev=261445&view=rev
Log:
[c-index-test] CMake: When installing c-index-test to a different prefix
directory, add an rpath so that
it can find libclang.
Modified:
cfe/trunk/tools/c-
Author: dexonsmith
Date: Sat Feb 20 14:39:51 2016
New Revision: 261446
URL: http://llvm.org/viewvc/llvm-project?rev=261446&view=rev
Log:
Lex: Add some unit tests for corrupt header maps
Split the implementation of `HeaderMap` into `HeaderMapImpl` so that we
can write unit tests that don't depend
Author: dexonsmith
Date: Sat Feb 20 15:00:58 2016
New Revision: 261448
URL: http://llvm.org/viewvc/llvm-project?rev=261448&view=rev
Log:
Lex: Check buckets on header map construction
If the number of buckets is not a power of two, immediately recognize
the header map as corrupt, rather than waiti
This had me puzzled for a second, but then I figured out what happened :-)
The “crash” I quoted in the commit message really was an assertion failure, to
be precise, the very assertion I relaxed in LLVM r259973 in order to be able to
defer the building of the DeclContext implemented by this commi
Author: dexonsmith
Date: Sat Feb 20 15:24:31 2016
New Revision: 261449
URL: http://llvm.org/viewvc/llvm-project?rev=261449&view=rev
Log:
Lex: Check whether the header map buffer has space for the buckets
Check up front whether the header map buffer has space for all of its
declared buckets.
Ther
Eugene.Zelenko added a comment.
Thank you for implementing this check!
However, I think will be good idea to always wrap header name in <> for warning
and FixIt.
http://reviews.llvm.org/D17484
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
hintonda added a comment.
This change breaks a couple tests in test/SemaCXX/linkage.cpp where we no
longer allow mixing internal and external linkage, i.e., extern "C" functions
have external linkage no matter where they are declared, but return types and
parameters declared in anonymous namesp
On Sat, Feb 20, 2016 at 11:40 AM, Matthijs van Duin
wrote:
> On 20 February 2016 at 20:34, H.J. Lu wrote:
>> Is there a class, which meets the above definition, with a member function
>> which can't be passed without a memory slot or a register?
>
> The EmptyInt class in my first post in this th
omtcyf0 updated this revision to Diff 48600.
omtcyf0 added a comment.
Thanks for a review, Eugene!
The FixItHint and warning now comes with the "angled" version of header
wrapping.
http://reviews.llvm.org/D17484
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/DeprecatedHea
hintonda updated this revision to Diff 48601.
hintonda added a comment.
Fixed additional tests.
http://reviews.llvm.org/D17362
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/CXX/drs/dr3xx.cpp
test/Sema/pr23090-crash-on-invalid.cpp
test/SemaCXX/warn-unused
Author: dexonsmith
Date: Sat Feb 20 16:53:22 2016
New Revision: 261455
URL: http://llvm.org/viewvc/llvm-project?rev=261455&view=rev
Log:
Lex: Add a test for HeaderMap::lookupFileName()
Add a simple test for `HeaderMap::lookupFileName()`. I'm planning to
add better error checking in a moment, and
Author: dexonsmith
Date: Sat Feb 20 17:09:14 2016
New Revision: 261456
URL: http://llvm.org/viewvc/llvm-project?rev=261456&view=rev
Log:
Lex: Use dbgs() instead of fprintf() in HeaderMap::dump()
This way it's easy to change HeaderMapImpl::getString() to return a
StringRef.
There's a slight chang
Author: dexonsmith
Date: Sat Feb 20 17:12:51 2016
New Revision: 261459
URL: http://llvm.org/viewvc/llvm-project?rev=261459&view=rev
Log:
Lex: Change HeaderMapImpl::getString() to return StringRef, NFC
Modified:
cfe/trunk/include/clang/Lex/HeaderMap.h
cfe/trunk/lib/Lex/HeaderMap.cpp
Modif
Author: dexonsmith
Date: Sat Feb 20 18:14:36 2016
New Revision: 261461
URL: http://llvm.org/viewvc/llvm-project?rev=261461&view=rev
Log:
Lex: Never overflow the file in HeaderMap::lookupFilename()
If a header map file is corrupt, the strings in the string table may not
be null-terminated. The lo
On Mon, Feb 15, 2016 at 8:05 AM, Aaron Ballman
wrote:
> On Sun, Feb 14, 2016 at 11:00 PM, Felix Berger via cfe-commits
> wrote:
> > Author: flx
> > Date: Sun Feb 14 22:00:39 2016
> > New Revision: 260872
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=260872&view=rev
> > Log:
> > Add isAnyP
On 20 February 2016 at 23:35, H.J. Lu wrote:
> Can a compiler tell if a copy constructor or destructor is trivial
> from the class declaration without function body?
Yes, the mere presence of the declaration suffices to render it
non-trivial (unless explicitly declared "= default" like I did with
On Sat, 20 Feb 2016, H.J. Lu wrote:
On Fri, Feb 19, 2016 at 1:07 PM, Richard Smith wrote:
On Fri, Feb 19, 2016 at 5:35 AM, Michael Matz wrote:
Hi,
On Thu, 18 Feb 2016, Richard Smith wrote:
An empty type is a type where it and all of its subobjects
(recursively) are of class, structure, un
On Sat, Feb 20, 2016 at 7:48 PM, Felix Berger wrote:
>
>
> On Mon, Feb 15, 2016 at 8:05 AM, Aaron Ballman
> wrote:
>>
>> On Sun, Feb 14, 2016 at 11:00 PM, Felix Berger via cfe-commits
>> wrote:
>> > Author: flx
>> > Date: Sun Feb 14 22:00:39 2016
>> > New Revision: 260872
>> >
>> > URL: http://l
LegalizeAdulthood added a comment.
Other than a few nits, LGTM.
Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:54
@@ +53,3 @@
+: Check(Check), LangOpts(LangOpts) {
+ CStyledHeaderToCxx["assert.h"] = "cassert";
+ CStyledHeaderToCxx["float.h"] = "cfloat";
--
rizsotto.mailinglist accepted this revision.
rizsotto.mailinglist added a comment.
This revision is now accepted and ready to land.
thanks Anton, LGTM!
http://reviews.llvm.org/D17091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
rizsotto.mailinglist added a comment.
the semicolon at the end of line 39 is an issue for PEP8. please remove it.
http://reviews.llvm.org/D17091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Eugene.Zelenko added a comment.
Another idea: to replace limits.h with limits and also replace its defines with
their C++ counterparts. For example, INT_MIN with numeric_limits::min().
Will be definitely useful for LLDB code modernization.
http://reviews.llvm.org/D17484
pxli168 added a comment.
LGTM!
Thanks.
http://reviews.llvm.org/D16928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 accepted this revision.
pxli168 added a comment.
This revision is now accepted and ready to land.
LGTM!
Thanks
http://reviews.llvm.org/D16928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
On Sat, Feb 20, 2016 at 4:57 PM, Matthijs van Duin
wrote:
> On 20 February 2016 at 23:35, H.J. Lu wrote:
>> Can a compiler tell if a copy constructor or destructor is trivial
>> from the class declaration without function body?
>
> Yes, the mere presence of the declaration suffices to render it
>
flx created this revision.
flx added a reviewer: alexfh.
flx added a subscriber: cfe-commits.
flx set the repository for this revision to rL LLVM.
Move code shared between UnnecessaryCopyInitialization and ForRangeCopyCheck
into utilities files.
Add more test cases for UnnecessaryCopyInitializati
Author: mren
Date: Sat Feb 20 23:31:05 2016
New Revision: 261466
URL: http://llvm.org/viewvc/llvm-project?rev=261466&view=rev
Log:
Class Property: Fix a crash with old ABI when generating metadata in classes.
rdar://23891898
Modified:
cfe/trunk/lib/CodeGen/CGObjCMac.cpp
cfe/trunk/test/Co
On 20 Feb 2016 6:54 p.m., "H.J. Lu" wrote:
>
> On Sat, Feb 20, 2016 at 4:57 PM, Matthijs van Duin
> wrote:
> > On 20 February 2016 at 23:35, H.J. Lu wrote:
> >> Can a compiler tell if a copy constructor or destructor is trivial
> >> from the class declaration without function body?
> >
> > Yes,
On Sat, Feb 20, 2016 at 9:47 PM, Richard Smith wrote:
> On 20 Feb 2016 6:54 p.m., "H.J. Lu" wrote:
>>
>> On Sat, Feb 20, 2016 at 4:57 PM, Matthijs van Duin
>> wrote:
>> > On 20 February 2016 at 23:35, H.J. Lu wrote:
>> >> Can a compiler tell if a copy constructor or destructor is trivial
>> >>
On 20 Feb 2016 10:01 p.m., "H.J. Lu" wrote:
>
> On Sat, Feb 20, 2016 at 9:47 PM, Richard Smith
wrote:
> > On 20 Feb 2016 6:54 p.m., "H.J. Lu" wrote:
> >>
> >> On Sat, Feb 20, 2016 at 4:57 PM, Matthijs van Duin
> >> wrote:
> >> > On 20 February 2016 at 23:35, H.J. Lu wrote:
> >> >> Can a compil
Author: delena
Date: Sun Feb 21 01:41:23 2016
New Revision: 261467
URL: http://llvm.org/viewvc/llvm-project?rev=261467&view=rev
Log:
Added SKL and CNL processors and features to Clang
Differential Revision: http://reviews.llvm.org/D16756
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/tru
57 matches
Mail list logo
