bcraig created this revision.
bcraig added reviewers: rubenvb, yaron.keren, jroelofs, howard.hinnant,
mclow.lists.
bcraig added a subscriber: cfe-commits.
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where this is going.
For the locale refactor
On Thu, Feb 18, 2016 at 6:35 AM, Michael Matz wrote:
> Hi,
>
> On Tue, 16 Feb 2016, H.J. Lu wrote:
>
>> Here is the new definition:
>>
>> An empty type is a type where it and all of its subobjects (recursively)
>> are of class, structure, union, or array type. No memory slot nor
>> register shoul
rjmccall added a comment.
LGTM.
http://reviews.llvm.org/D17023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: akirtzidis
Date: Thu Feb 18 17:08:36 2016
New Revision: 261274
URL: http://llvm.org/viewvc/llvm-project?rev=261274&view=rev
Log:
[ASTImporter] Implement missing VisitAccessSpecDecl function in ASTImporter
class.
Patch by Elisavet Sakellari!
Modified:
cfe/trunk/lib/AST/ASTImporter.cp
akyrtzi added a subscriber: akyrtzi.
akyrtzi accepted this revision.
akyrtzi added a reviewer: akyrtzi.
akyrtzi added a comment.
This revision is now accepted and ready to land.
LGTM, committed in r261274.
http://reviews.llvm.org/D16923
___
cfe-comm
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:2716
@@ +2715,3 @@
+ if (Ops.LHS->getType() != RHS->getType()) {
+bool isSigned =
dyn_cast(Ops.E)->getRHS()->getType().getTypePtr()->isSignedIntegerType();
+RHS = Builder.CreateIntCast(RHS, Ops.LHS-
akyrtzi added a subscriber: akyrtzi.
akyrtzi added a comment.
Doesn't this mean that _all_ of the Importer.FromDiag() calls will be ignored
by VerifyDiagnosticConsumer ? Why specifically change only this two and what
are we going to do with the others ?
This seems more like needing a fix higher
rsmith added inline comments.
Comment at: lib/AST/DeclCXX.cpp:396-425
@@ -394,1 +395,32 @@
+bool CXXRecordDecl::allowConstDefaultInitSlow() const {
+ assert(getDefinition() && "only call this on completed records");
+ if (hasUserProvidedDefaultConstructor()) {
+data().setA
akyrtzi added a subscriber: akyrtzi.
akyrtzi added a comment.
If I apply just the test changes without the rest of the changes, I don't see
any failures, so I'm not sure these are effective tests.
http://reviews.llvm.org/D17029
___
cfe-commits mail
thakis updated this revision to Diff 48418.
thakis added a comment.
Thanks! All done.
http://reviews.llvm.org/D16552
Files:
include/clang/AST/DeclCXX.h
lib/AST/ASTImporter.cpp
lib/AST/DeclCXX.cpp
lib/Sema/SemaInit.cpp
lib/Serialization/ASTReaderDecl.cpp
lib/Serialization/ASTWriter.c
Author: rtrieu
Date: Thu Feb 18 17:58:40 2016
New Revision: 261278
URL: http://llvm.org/viewvc/llvm-project?rev=261278&view=rev
Log:
Add -Wcomma warning to Clang.
-Wcomma will detect and warn on most uses of the builtin comma operator. It
currently whitelists the first and third statements of th
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM!
If it's convenient, it'd be nice to check in a new cxx_dr_status.html without
your change first, as a separate commit, so it's more obvious which parts of
the file are changed b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261278: Add -Wcomma warning to Clang. (authored by rtrieu).
Changed prior to commit:
http://reviews.llvm.org/D3976?vs=21170&id=48419#toc
Repository:
rL LLVM
http://reviews.llvm.org/D3976
Files:
cf
Author: rtrieu
Date: Thu Feb 18 18:15:50 2016
New Revision: 261285
URL: http://llvm.org/viewvc/llvm-project?rev=261285&view=rev
Log:
Fix my typo from r261278
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trun
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
It seems this CL broke LLDB CMake build bot -
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/11554
Could you take a look?
Repository:
rL LLVM
http://reviews.llvm.org/D3976
__
This was already fixed in r261285.
On Thu, Feb 18, 2016 at 4:31 PM, Oleksiy Vyalov via cfe-commits
wrote:
> ovyalov added a subscriber: ovyalov.
> ovyalov added a comment.
>
> It seems this CL broke LLDB CMake build bot -
> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261290: Add call to find_package to load LLVM dependencies
(authored by rnk).
Changed prior to commit:
http://reviews.llvm.org/D13622?vs=37031&id=48431#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: rnk
Date: Thu Feb 18 18:56:56 2016
New Revision: 261290
URL: http://llvm.org/viewvc/llvm-project?rev=261290&view=rev
Log:
Add call to find_package to load LLVM dependencies
ClangConfig requires LLVMConfig, so add find_package call in
ClangConfig so find_package(clang REQUIRED CONFIG) will
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good, thanks. I like the new approach of avoiding the creation of a
LateParsedMethodDeclaration if we couldn't get a NamedDecl back. I'll land it
soon.
http://reviews.llvm.org/D17072
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM with a request for a tiny other improvement in the documentation.
Thanks!
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SubEngine.h:111
@@ -103,3 +110
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261292: [Sema] PR25181 Fix crash when method declaration
with throw spec fails to… (authored by rnk).
Changed prior to commit:
http://reviews.llvm.org/D17072?vs=47923&id=48435#toc
Repository:
rL LLVM
Author: rnk
Date: Thu Feb 18 19:15:08 2016
New Revision: 261292
URL: http://llvm.org/viewvc/llvm-project?rev=261292&view=rev
Log:
[Sema] PR25181 Fix crash when method declaration with throw spec fails to parse
correctly
Fixes crash referenced in PR25181 where dyn_cast is called on a null
instanc
dcoughlin marked an inline comment as done.
dcoughlin added a comment.
http://reviews.llvm.org/D17418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dcoughlin
Date: Thu Feb 18 19:35:10 2016
New Revision: 261293
URL: http://llvm.org/viewvc/llvm-project?rev=261293&view=rev
Log:
[analyzer] Add checker callback for beginning of function.
Add a checker callback that is called when the analyzer starts analyzing a
function either at the top
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261293: [analyzer] Add checker callback for beginning of
function. (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D17418?vs=48406&id=48438#toc
Repository:
rL LLVM
http://r
silvas added a comment.
Apologies for the delay. At this point, I think that this patch has evolved
enough that it is best to start a new patch. I think the steps forward are:
- Have cc1 accept -fprofile-instrument=llvm (requires no driver changes, but is
enough for developers to test by being
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D17313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Thu Feb 18 19:49:39 2016
New Revision: 261295
URL: http://llvm.org/viewvc/llvm-project?rev=261295&view=rev
Log:
Update cxx_dr_status.html with today's cwg_index.html.
Created by:
cd www
curl -O http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_index.html
./make_cxx_dr_status
Mod
thakis closed this revision.
thakis added a comment.
Thanks! Landed the cxx_dr_status.html update in r261295 and this change in
r261297.
http://reviews.llvm.org/D16552
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: nico
Date: Thu Feb 18 19:52:46 2016
New Revision: 261297
URL: http://llvm.org/viewvc/llvm-project?rev=261297&view=rev
Log:
Implement the likely resolution of core issue 253.
C++11 requires const objects to have a user-provided constructor, even for
classes without any fields. DR 253 relax
jfb added a comment.
Is this ready to land? I'm hoping to get it into the 3.8 branch since it
affects musl libc's latest release.
http://reviews.llvm.org/D17349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
dcoughlin updated this revision to Diff 48447.
dcoughlin added a comment.
Addressed additional comments from Anna offline:
- "[super dealloc] called again" is OK as a path note but not good as an error
message. I've changed it to "[super dealloc] should not be called multiple
times".
- Added a
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, xazax.hun, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
While working with LLDB code I noticed that readability-container-size-empty
does
Author: nico
Date: Thu Feb 18 20:51:07 2016
New Revision: 261301
URL: http://llvm.org/viewvc/llvm-project?rev=261301&view=rev
Log:
Fix SemaTemplate/instantiate-field.cpp after r261297.
For templates, fields can have incomplete types:
template
struct A2 {
struct B;
B b;
};
Don't t
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision is now accepted and ready to land.
Yeah, constraint validation is not one of the highlights of the current
implementation. This seems reasonable enough to merge I think.
http://reviews
pxli168 updated this revision to Diff 48452.
pxli168 added a comment.
Refine the pipe parse to solve the problem the attribute for pipe will be
handled twice within Declarator
http://reviews.llvm.org/D16040
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/
Author: jfb
Date: Fri Feb 19 00:54:45 2016
New Revision: 261309
URL: http://llvm.org/viewvc/llvm-project?rev=261309&view=rev
Log:
ARM: fix VFP asm constraints
Summary:
Rich Felker was sad that clang used 'w' and 'P' for VFP constraints when GCC
documents them as 't' and 'w':
https://gcc.gnu.or
Author: jfb
Date: Fri Feb 19 00:54:47 2016
New Revision: 261310
URL: http://llvm.org/viewvc/llvm-project?rev=261310&view=rev
Log:
Add test.
Added:
cfe/trunk/test/CodeGen/arm-vfp-asm-constraint.c
Added: cfe/trunk/test/CodeGen/arm-vfp-asm-constraint.c
URL:
http://llvm.org/viewvc/llvm-project/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261309: ARM: fix VFP asm constraints (authored by jfb).
Changed prior to commit:
http://reviews.llvm.org/D17349?vs=48363&id=48453#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17349
Files:
cfe/
should probably have test coverage
On Thu, Feb 18, 2016 at 6:46 PM, Eugene Zelenko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Eugene.Zelenko created this revision.
> Eugene.Zelenko added reviewers: alexfh, xazax.hun, aaron.ballman.
> Eugene.Zelenko added a subscriber: cfe-commits.
> E
Author: majnemer
Date: Fri Feb 19 01:15:33 2016
New Revision: 261312
URL: http://llvm.org/viewvc/llvm-project?rev=261312&view=rev
Log:
Correct typos after acting on invalid subscript expressions
Modified:
cfe/trunk/lib/Parse/ParseExpr.cpp
cfe/trunk/test/SemaCXX/typo-correction.cpp
Modifi
pxli168 created this revision.
pxli168 added reviewers: Anastasia, pekka.jaaskelainen.
pxli168 added a subscriber: cfe-commits.
Add Sema checks for opencl 2.0 new features: Block.
http://reviews.llvm.org/D17436
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sem
101 - 142 of 142 matches
Mail list logo
