Author: chapuni
Date: Tue Feb 16 02:13:36 2016
New Revision: 260944
URL: http://llvm.org/viewvc/llvm-project?rev=260944&view=rev
Log:
clang-tools-extra/test/Unit/lit.site.cfg.in: Prune on_clone. I guess it has
been unused since r188006.
Modified:
clang-tools-extra/trunk/test/Unit/lit.site.cf
Hahnfeld created this revision.
Hahnfeld added reviewers: rsmith, t.p.northover.
Hahnfeld added a subscriber: cfe-commits.
Herald added a subscriber: emaste.
Also introduce `-stdlib=default` to override the configured value and use it to
make the tests always pass.
http://reviews.llvm.org/D17286
pekka.jaaskelainen accepted this revision.
pekka.jaaskelainen added a comment.
LGTM.
http://reviews.llvm.org/D16686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pekka.jaaskelainen added inline comments.
Comment at: test/SemaOpenCL/invalid-func.cl:6
@@ +5,2 @@
+void foo(int, ...); // expected-error{{OpenCL does not allow variadic
arguments}}
+int printf(const char *, ...);
I wonder should we check for the fingerprint too
alexfh added a comment.
Unfortunately, the review of the changes in the script might take some time. I
think, we can submit the fix itself already and work on the rest of the patch
after that.
http://reviews.llvm.org/D16953
___
cfe-commits mailing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260948: [clang-tidy] Enhance modernize-redundant-void-arg
check to apply fixes to… (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D16953?vs=47319&id=48054#toc
Repository:
rL L
Author: alexfh
Date: Tue Feb 16 03:49:05 2016
New Revision: 260948
URL: http://llvm.org/viewvc/llvm-project?rev=260948&view=rev
Log:
[clang-tidy] Enhance modernize-redundant-void-arg check to apply fixes to
header files
Fixes http://llvm.org/PR25894
Patch by Richard Thomson!
Differential revis
alexfh added a comment.
I've committed the changes to the check code. Can you submit the change to the
script as a separate patch?
Repository:
rL LLVM
http://reviews.llvm.org/D16953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
alexfh added a comment.
And thank you for the fix, btw!
Repository:
rL LLVM
http://reviews.llvm.org/D16953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you!
http://reviews.llvm.org/D17134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
hokein updated this revision to Diff 48057.
hokein marked an inline comment as done.
hokein added a comment.
Add a note in testcase.
http://reviews.llvm.org/D17134
Files:
clang-tidy/readability/BracesAroundStatementsCheck.cpp
test/clang-tidy/readability-braces-around-statements-assert-failu
Author: hokein
Date: Tue Feb 16 04:31:33 2016
New Revision: 260952
URL: http://llvm.org/viewvc/llvm-project?rev=260952&view=rev
Log:
[clang-tidy] Fix an assert failure of ForStmt in
`readability-braces-around-statements` check.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260952: [clang-tidy] Fix an assert failure of ForStmt in
`readability-braces-around… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D17134?vs=48057&id=48058#toc
Repository:
rL
Author: hokein
Date: Tue Feb 16 04:36:51 2016
New Revision: 260953
URL: http://llvm.org/viewvc/llvm-project?rev=260953&view=rev
Log:
[clang-tidy] Fix an assert failure in `modernize-loop-convert`.
Summary:
The test code will trigger following an assert failure:
assert.h assertion failed at LoopC
Author: abataev
Date: Tue Feb 16 05:18:12 2016
New Revision: 260954
URL: http://llvm.org/viewvc/llvm-project?rev=260954&view=rev
Log:
[OPENMP] Improved handling of pseudo-captured expressions in OpenMP.
Expressions inside 'schedule'|'dist_schedule' clause must be captured in
combined directives to
bsmith added a comment.
Ping, it would be nice to get this committed to complete ARMv8-M support.
Repository:
rL LLVM
http://reviews.llvm.org/D15283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: abataev
Date: Tue Feb 16 06:13:49 2016
New Revision: 260957
URL: http://llvm.org/viewvc/llvm-project?rev=260957&view=rev
Log:
[OPENMP] Allow to use compound assignment operators.
Loop-based directives allow to use iterators as loop counters. Iterators are
allowed to define their own opera
MatsPetersson added a subscriber: MatsPetersson.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7700
@@ -7698,2 +7699,3 @@
+ "OpenCL does not allow variadic arguments">;
// OpenCL v2.0 s6.13.6 -- Builtin Pipe Functions
Looks good
Comm
Author: vkalintiris
Date: Tue Feb 16 08:15:27 2016
New Revision: 260961
URL: http://llvm.org/viewvc/llvm-project?rev=260961&view=rev
Log:
Issue a warning instead of fatal errors when checks for libatomic fail.
This should fix PR26631, PR26622 and has the nice property that the addition
of the Che
MatsPetersson added inline comments.
Comment at: test/SemaOpenCL/invalid-func.cl:6
@@ +5,2 @@
+void foo(int, ...); // expected-error{{OpenCL does not allow variadic
arguments}}
+int printf(const char *, ...);
pekka.jaaskelainen wrote:
> I wonder should we check f
carlo.bertolli added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:759
@@ +758,3 @@
+ ///
+ void emitForStaticInitWithKMPSchedule(CodeGenFunction &CGF,
+SourceLocation Loc,
I added this because OpenMPScheduleC
Author: marshall
Date: Tue Feb 16 08:35:56 2016
New Revision: 260964
URL: http://llvm.org/viewvc/llvm-project?rev=260964&view=rev
Log:
Added a (private) status page for the Jacksonville meeting
Added:
libcxx/trunk/www/upcoming_meeting.html
Removed:
libcxx/trunk/www/kona.html
Removed: lib
I changed the type of message from fatal_error to warning in r260961. While the
test for atomics works fine in most cases, it fails because we include
and , and the user's host compiler might not provide them
during a bootstrap (see PR26631 and PR26622).
Does anyone have any idea how to tackle
Author: marshall
Date: Tue Feb 16 08:42:23 2016
New Revision: 260966
URL: http://llvm.org/viewvc/llvm-project?rev=260966&view=rev
Log:
Add some comments
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-project
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5046
@@ +5045,3 @@
+ if (D->hasAttr()) {
+S.Diag(D->getLocation(), diag::err_opencl_multiple_access_qualifiers)
+<< D->getSourceRange();
That's why I think it should be pointin
pawosm01 added a comment.
You're right, this patch smuggles elimination of two dead functions. I've
prepared alternative version of this patch which does not do that.
Repository:
rL LLVM
http://reviews.llvm.org/D16929
___
cfe-commits mailing lis
Author: marshall
Date: Tue Feb 16 10:05:15 2016
New Revision: 260975
URL: http://llvm.org/viewvc/llvm-project?rev=260975&view=rev
Log:
Add some status
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-project/l
aaron.ballman updated this revision to Diff 48075.
aaron.ballman added a comment.
Using the AST_MATCHER_FUNCTION macro instead.
Using Expr::isNullPointerConstant() turns out to have strange behavior with
implicit casts and nullptr, and also requires further restrictions (for
instance, it claims
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM, thanks
http://reviews.llvm.org/D17272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: hans
Date: Tue Feb 16 11:16:15 2016
New Revision: 260982
URL: http://llvm.org/viewvc/llvm-project?rev=260982&view=rev
Log:
Merging r258107:
r258107 | marshall | 2016-01-18 16:50:37 -0800 (Mon, 18 Jan 2016) | 1 line
F
Marshall told me this one's approved. Merged in r260982. Thanks, Hans
On Fri, Feb 12, 2016 at 10:22 AM, Hans Wennborg wrote:
> Marshall: ping?
>
> On Mon, Feb 1, 2016 at 1:48 PM, Hans Wennborg wrote:
>> Marshall: ping?
>>
>> On Tue, Jan 26, 2016 at 11:08 AM, Hans Wennborg wrote:
>>> On Tue, Jan
sbenza added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:4838
@@ +4837,3 @@
+ gnuNullExpr(), cxxNullPtrLiteralExpr(),
+ expr(integerLiteral(equals(0),
hasParent(expr(hasType(pointerType()));
+}
is this expr() necessary?
ht
Author: hans
Date: Tue Feb 16 11:17:42 2016
New Revision: 260983
URL: http://llvm.org/viewvc/llvm-project?rev=260983&view=rev
Log:
Merging r259682:
r259682 | dexonsmith | 2016-02-03 11:30:20 -0800 (Wed, 03 Feb 2016) | 7 lines
Marshall told me it's approved. Merged in r260983. Thanks, Hans
On Fri, Feb 12, 2016 at 10:34 AM, Hans Wennborg wrote:
> Marshall: ping?
>
> On Wed, Feb 3, 2016 at 5:08 PM, Hans Wennborg wrote:
>> I'm OK if Marshall is.
>>
>> Thanks,
>> Hans
>>
>> On Wed, Feb 3, 2016 at 4:59 PM, Duncan P. N. Exo
jmolloy accepted this revision.
jmolloy added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D16929
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
eliben added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:6498
@@ +6497,3 @@
+
+ Class classify(QualType Ty) const;
+
jpienaar wrote:
> We only had one DefaultNumRegisterParameters that we supported
> (DefaultNumRegisterParameters=4) so I just propaga
On Sun, Feb 14, 2016 at 8:14 AM, Dimitry Andric wrote:
> On 14 Feb 2016, at 17:08, Dimitry Andric via cfe-commits
> wrote:
>>
>> Author: dim
>> Date: Sun Feb 14 10:08:20 2016
>> New Revision: 260851
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=260851&view=rev
>> Log:
>> As reported in http
On Fri, Feb 12, 2016 at 11:39 AM, H.J. Lu wrote:
> On Fri, Feb 12, 2016 at 6:58 AM, Matthijs van Duin
> wrote:
>> On 11 February 2016 at 16:31, H.J. Lu wrote:
>>> struct A {
>>> static void foo (void) ();
>>> static int xxx;
>>> };
>>
>> What about it? It's an empty struct. (And it declares a f
carlo.bertolli added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:759
@@ +758,3 @@
+ ///
+ void emitForStaticInitWithKMPSchedule(CodeGenFunction &CGF,
+SourceLocation Loc,
carlo.bertolli wrote:
> I added this
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGExpr.cpp:2937-2943
@@ -2936,2 +2936,9 @@
QualType BaseTy = Base.getType();
+ // If the base is a pointer, we actually need to compute the offset in the
+ // pointee.
+ if (BaseTy->isAnyPo
vsk created this revision.
vsk added reviewers: rsmith, benlangmuir.
vsk added a subscriber: cfe-commits.
If we try to read a corrupt pch, we can easily assert-fail or trigger invalid
memory accesses when manipulating ASTReader::RecordData objects. This problem
is easy enough to diagnose when asse
Author: nico
Date: Tue Feb 16 13:05:50 2016
New Revision: 260990
URL: http://llvm.org/viewvc/llvm-project?rev=260990&view=rev
Log:
clang-cl: Expose -isystem.
Like cl.exe, clang-cl allows adding system include directories via the
INCLUDE env var. Having a driver flag for this functionality is use
ping...
On 07/02/16 22:33, Vassil Vassilev wrote:
Improve a comment.
--Vassil
On 07/02/16 20:48, Vassil Vassilev wrote:
Would this patch be any better?
--Vassil
On 05/02/16 21:49, Richard Smith wrote:
This belongs in ASTDeclReader::attachPreviousDecl[Impl]. That's
where we propagate data that's
Author: rnk
Date: Tue Feb 16 13:16:20 2016
New Revision: 260993
URL: http://llvm.org/viewvc/llvm-project?rev=260993&view=rev
Log:
[typo-correction] Apply name specifier corrections when forming a NNS
Previously we would leave behind the old name specifier prefix, which
creates an invalid AST. Ot
Author: rnk
Date: Tue Feb 16 13:16:28 2016
New Revision: 260994
URL: http://llvm.org/viewvc/llvm-project?rev=260994&view=rev
Log:
Exclude PCH/missing-file.cpp on Windows, it does not pass reliably
Tag the test with "REQUIRES: can-remove-opened-file", which is what we
use for the similar test Modu
saugustine requested a review of this revision.
saugustine added a comment.
Would you mind reviewing this, and checking it in if you find it acceptable?
http://reviews.llvm.org/D17214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
Since this is just a wording change, presumably the diagnostic is already
tested in an existing file - perhaps you could exetendi that test to cover
this functionality (we try not to add new test files too much - better to
test functionality once/in one place as much as possible (both for ease of
r
aaron.ballman marked an inline comment as done.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:4838
@@ +4837,3 @@
+ gnuNullExpr(), cxxNullPtrLiteralExpr(),
+ expr(integerLiteral(equals(0),
hasParent(expr(hasType(pointerType()));
+}
sbenza wrote
sbenza added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:4838
@@ +4837,3 @@
+ gnuNullExpr(), cxxNullPtrLiteralExpr(),
+ expr(integerLiteral(equals(0),
hasParent(expr(hasType(pointerType()));
+}
aaron.ballman wrote:
> sbenza
Do I understand correctly that there are still issues here's that are not fixed?
(I'm trying to understand if there is something here to merge for 3.8,
but I'm having trouble following these commits.)
On Tue, Feb 16, 2016 at 6:44 AM, Vasileios Kalintiris
wrote:
> I changed the type of message fr
On Wed, Feb 10, 2016 at 2:50 AM, Alexey Bataev via cfe-commits
wrote:
> Author: abataev
> Date: Wed Feb 10 04:50:12 2016
> New Revision: 260370
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260370&view=rev
> Log:
> Fix PR26543: add a check for definition in CXXRecordDecl.
>
> Modified:
> cf
Or is this comment on PR26059 all that needs to be done for 3.8?
"Bug 26369, which has been fixed with r260961, requires the following
commits to get merged on the release branch:
- [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out
whether we need to link with libatomic."
- [li
aaron.ballman updated this revision to Diff 48092.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Removed an unnecessary expr() matcher.
http://reviews.llvm.org/D17034
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTM
aaron.ballman marked 2 inline comments as done.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:4838
@@ +4837,3 @@
+ gnuNullExpr(), cxxNullPtrLiteralExpr(),
+ integerLiteral(equals(0), hasParent(expr(hasType(pointerType());
+}
Ah, good catch! No,
On 16 Feb 2016, at 18:51, Hans Wennborg wrote:
>
> On Sun, Feb 14, 2016 at 8:14 AM, Dimitry Andric wrote:
>> On 14 Feb 2016, at 17:08, Dimitry Andric via cfe-commits
>> wrote:
>>>
>>> Author: dim
>>> Date: Sun Feb 14 10:08:20 2016
>>> New Revision: 260851
>>>
>>> URL: http://llvm.org/viewvc/
Hi Hans,
> Or is this comment on PR26059 all that needs to be done for 3.8?
That's correct. I wrote that comment in order to clarify which bits we should
merge in 3.8.
The latest commit:
- [libcxx] r260961 - Issue a warning instead of fatal errors when checks for
libatomic fail."
makes sure
--- a/lib/Sema/SemaLookup.cpp
+++ b/lib/Sema/SemaLookup.cpp
@@ -419,6 +419,25 @@ static bool isPreferredLookupResult(Sema &S,
Sema::LookupNameKind Kind,
}
}
+ // VarDecl can have incomplete array types, prefer the one with more complete
+ // array type.
+ if (VarDecl *DVD = dyn_cast(DUn
On Tue, Feb 16, 2016 at 10:24 AM, H.J. Lu wrote:
>
> On Fri, Feb 12, 2016 at 11:39 AM, H.J. Lu wrote:
> > On Fri, Feb 12, 2016 at 6:58 AM, Matthijs van Duin
> > wrote:
> >> On 11 February 2016 at 16:31, H.J. Lu wrote:
> >>> struct A {
> >>> static void foo (void) ();
> >>> static int xxx;
> >>>
On Tue, Feb 16, 2016 at 12:22 PM, Richard Smith wrote:
> On Tue, Feb 16, 2016 at 10:24 AM, H.J. Lu wrote:
>>
>> On Fri, Feb 12, 2016 at 11:39 AM, H.J. Lu wrote:
>> > On Fri, Feb 12, 2016 at 6:58 AM, Matthijs van Duin
>> > wrote:
>> >> On 11 February 2016 at 16:31, H.J. Lu wrote:
>> >>> struct
Author: rnk
Date: Tue Feb 16 14:34:27 2016
New Revision: 261005
URL: http://llvm.org/viewvc/llvm-project?rev=261005&view=rev
Log:
Stop using "template" when printing qualtype names
Summary:
The keyword "template" isn't necessary when
printing a fully-qualified qualtype name, and, in fact,
results
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261005: Stop using "template" when printing qualtype names
(authored by rnk).
Changed prior to commit:
http://reviews.llvm.org/D17214?vs=47854&id=48095#toc
Repository:
rL LLVM
http://reviews.llvm.or
carlo.bertolli added a comment.
I have addressed some of the comments and restructured the code as requested.
Let me know about further comments.
Thanks for making this a better patch!
Repository:
rL LLVM
http://reviews.llvm.org/D17170
___
cfe-co
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
I have addressed some of the comments and restructured the code as requested.
Let me know about further comments.
Thanks for making this a better patch!
Comment at: lib/CodeGen/CGOpenMPRuntime.h:669
On Tue, Feb 16, 2016 at 12:25 PM, H.J. Lu wrote:
> On Tue, Feb 16, 2016 at 12:22 PM, Richard Smith wrote:
>> On Tue, Feb 16, 2016 at 10:24 AM, H.J. Lu wrote:
>>>
>>> On Fri, Feb 12, 2016 at 11:39 AM, H.J. Lu wrote:
>>> > On Fri, Feb 12, 2016 at 6:58 AM, Matthijs van Duin
>>> > wrote:
>>> >> On
Author: aaronballman
Date: Tue Feb 16 15:02:23 2016
New Revision: 261008
URL: http://llvm.org/viewvc/llvm-project?rev=261008&view=rev
Log:
Add a nullPointerConstant() AST matcher to handle variations of null pointer
constants in one matcher.
Modified:
cfe/trunk/docs/LibASTMatchersReference.h
aaron.ballman closed this revision.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Thanks for the review and suggestions! I've commit in r261008.
http://reviews.llvm.org/D17034
___
cfe-commits mailing list
cfe-commits
FYI, this change and the LLVM version have each broken my libcxx
builds. I cross compile from Linux x64 to Hexagon, and my host machine
doesn't have . The LLVM change was particularly offensive
because I wasn't planning on building LLVM itself.
I have since worked around the issue by making
On Tue, Feb 16, 2016 at 1:02 PM, Richard Smith wrote:
> On Tue, Feb 16, 2016 at 12:25 PM, H.J. Lu wrote:
>> On Tue, Feb 16, 2016 at 12:22 PM, Richard Smith
>> wrote:
>>> On Tue, Feb 16, 2016 at 10:24 AM, H.J. Lu wrote:
On Fri, Feb 12, 2016 at 11:39 AM, H.J. Lu wrote:
> On Fri,
Author: aaronballman
Date: Tue Feb 16 15:06:10 2016
New Revision: 261009
URL: http://llvm.org/viewvc/llvm-project?rev=261009&view=rev
Log:
Missing semicolons are kind of important. Who knew?
Modified:
cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.cpp
Modified: cfe/trunk/unittests/ASTMatche
dblaikie added a comment.
Thanks - please commit when ready
http://reviews.llvm.org/D15977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Is this anything more than the -Wdeprecated warning? (could we split out
the -Wdeprecated warning that deals with the deprecated implicit special
member generation, then just use that warning for this clang-tidy check?)
On Thu, Feb 11, 2016 at 3:16 PM, Jonathan B Coe via cfe-commits <
cfe-commits@
On Tue, Feb 16, 2016 at 1:10 PM, H.J. Lu wrote:
> On Tue, Feb 16, 2016 at 1:02 PM, Richard Smith wrote:
>> On Tue, Feb 16, 2016 at 12:25 PM, H.J. Lu wrote:
>>> On Tue, Feb 16, 2016 at 12:22 PM, Richard Smith
>>> wrote:
On Tue, Feb 16, 2016 at 10:24 AM, H.J. Lu wrote:
>
> On Fri,
carlo.bertolli updated this revision to Diff 48100.
carlo.bertolli added a comment.
Address comments and rebase over new version of http://reviews.llvm.org/D17148.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
Files:
include/clang/AST/StmtOpenMP.h
lib/CodeGen/CGOpenMPRuntime.cpp
l
On Tue, Feb 16, 2016 at 1:15 PM, Richard Smith wrote:
> On Tue, Feb 16, 2016 at 1:10 PM, H.J. Lu wrote:
>> On Tue, Feb 16, 2016 at 1:02 PM, Richard Smith wrote:
>>> On Tue, Feb 16, 2016 at 12:25 PM, H.J. Lu wrote:
On Tue, Feb 16, 2016 at 12:22 PM, Richard Smith
wrote:
> On Tue,
On Tue, Feb 16, 2016 at 1:21 PM, H.J. Lu wrote:
> On Tue, Feb 16, 2016 at 1:15 PM, Richard Smith wrote:
>> On Tue, Feb 16, 2016 at 1:10 PM, H.J. Lu wrote:
>>> On Tue, Feb 16, 2016 at 1:02 PM, Richard Smith
>>> wrote:
On Tue, Feb 16, 2016 at 12:25 PM, H.J. Lu wrote:
> On Tue, Feb 16,
On Tue, Feb 16, 2016 at 1:45 PM, Richard Smith wrote:
> On Tue, Feb 16, 2016 at 1:21 PM, H.J. Lu wrote:
>> On Tue, Feb 16, 2016 at 1:15 PM, Richard Smith wrote:
>>> On Tue, Feb 16, 2016 at 1:10 PM, H.J. Lu wrote:
On Tue, Feb 16, 2016 at 1:02 PM, Richard Smith
wrote:
> On Tue, Fe
dsanders added a comment.
Sorry for the early ping but I need to fix this for rc3 (which Hans is hoping
to tag mid-week) and I'm stuck as long as the requirement that the C++ tests in
r260527 fail without my patch is in place.
I'm happy to make this '#ifdef __mips__' if that helps.
http://rev
thakis updated this revision to Diff 48107.
thakis added a comment.
Checkpointing; not production quality. I tried implementing the general DR 253
rule, and this patch mostly does that. It currently walks all fields and all
bases for every const record decl; there should probably be a cache for
Hi Ben,
Does 'this change' refer to r260235 or r260961?
From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of Craig, Ben
via cfe-commits [cfe-commits@lists.llvm.org]
Sent: 16 February 2016 21:09
To: cfe-commits@lists.llvm.org
Subject: Re: [li
Hi Ben,
> FYI, this change and the LLVM version have each broken my libcxx
> builds. I cross compile from Linux x64 to Hexagon, and my host machine
> doesn't have . The LLVM change was particularly offensive
> because I wasn't planning on building LLVM itself.
There's no change on the LLVM side
Author: tra
Date: Tue Feb 16 16:03:20 2016
New Revision: 261018
URL: http://llvm.org/viewvc/llvm-project?rev=261018&view=rev
Log:
[CUDA] pass debug options to ptxas.
ptxas optimizations are disabled if we need to generate debug info
as ptxas does not accept '-g' otherwise.
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261018: [CUDA] pass debug options to ptxas. (authored by
tra).
Changed prior to commit:
http://reviews.llvm.org/D17111?vs=47680&id=48108#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17111
Files
jbcoe added a comment.
It's more than the warning because it offers fixits. Other than that it should
be the same. Using the same code as used to warn on deprecated special members
would be a great idea. I'm not too sure where to start looking and how much of
Sema is exposed to clang-tidy thoug
mclow.lists added a comment.
> Any objections to using the original sizes, but constructing the objects at
> global scope?
I think that should work.
http://reviews.llvm.org/D15539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
george.burgess.iv updated this revision to Diff 48111.
george.burgess.iv added a comment.
- Reworded docs update
- Added support for `reinterpret_cast`s of overloaded functions in both C and
C++
- Added general facility in `Sema` to query if an overloaded expression can
resolve to being not-over
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Let's wrap it in a MIPS ifdef for the moment, and then, post-release we can see
if that can be relaxed.
Given that, LGTM.
http://reviews.llvm.org/D17132
logan added a comment.
In general, it looks good to me if the comments are addressed.
Sorry for not replying responsively. Not sure why I missed the follow-up
e-mails after @rengolin's reply.
Comment at: lib/Headers/unwind.h:61
@@ +60,3 @@
+#define _UNWIND_ARM_EHABI 0
+#endif
bcraig updated this revision to Diff 48112.
bcraig added a comment.
Addressed EricWF's feedback.
http://reviews.llvm.org/D16545
Files:
CMakeLists.txt
test/CMakeLists.txt
test/libcxxabi/test/config.py
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
=
Thanks. I'll commit using a MIPS ifdef in the morning and merge once it's
through the buildbots.
From: Marshall Clow [mclow.li...@gmail.com]
Sent: 16 February 2016 22:37
To: Daniel Sanders; h...@chromium.org; mclow.li...@gmail.com
Cc: cfe-commits@lists.llvm
bcraig updated this revision to Diff 48113.
bcraig added a comment.
Addressed EricWF's feedback (hopefully).
http://reviews.llvm.org/D16544
Files:
test/CMakeLists.txt
test/libcxx/test/config.py
test/libcxx/test/target_info.py
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
===
bcraig marked 6 inline comments as done.
bcraig added a comment.
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig marked an inline comment as done.
bcraig added a comment.
http://reviews.llvm.org/D16545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
So does this latest revision get the check-mark of approval?
http://reviews.llvm.org/D15539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis updated this revision to Diff 48115.
thakis added a comment.
Ok, that was just a bug. Now all libstdc++5.3 cases I tried build. Still not
production-quality, but the overall direction won't change. If you want to
comment on that, please do, else I'll ping this again after I've cleaned it
rsmith added a comment.
The direction here looks fine to me.
Comment at: lib/Sema/SemaInit.cpp:369
@@ +368,3 @@
+ ND = dyn_cast(ND->getParent())) {
+if (S.getStdNamespace()->InEnclosingNamespaceSetOf(ND))
+ return true;
I wonder if this recursion
On Tue, Feb 16, 2016 at 1:48 PM, H.J. Lu wrote:
> On Tue, Feb 16, 2016 at 1:45 PM, Richard Smith wrote:
>> On Tue, Feb 16, 2016 at 1:21 PM, H.J. Lu wrote:
>>> On Tue, Feb 16, 2016 at 1:15 PM, Richard Smith
>>> wrote:
On Tue, Feb 16, 2016 at 1:10 PM, H.J. Lu wrote:
> On Tue, Feb 16, 2
On Tue, Feb 16, 2016 at 3:36 PM, Richard Smith wrote:
> On Tue, Feb 16, 2016 at 1:48 PM, H.J. Lu wrote:
>> On Tue, Feb 16, 2016 at 1:45 PM, Richard Smith wrote:
>>> On Tue, Feb 16, 2016 at 1:21 PM, H.J. Lu wrote:
On Tue, Feb 16, 2016 at 1:15 PM, Richard Smith
wrote:
> On Tue, Fe
jpienaar updated the summary for this revision.
jpienaar updated this revision to Diff 48119.
jpienaar marked an inline comment as done.
jpienaar added a comment.
Herald added a subscriber: joker.eph.
Move mregparm check to Tools.cpp and correct triple used in test.
http://reviews.llvm.org/D1700
jpienaar added inline comments.
Comment at: test/CodeGen/lanai-arguments.c:1
@@ +1,2 @@
+// RUN: %clang_cc1 -triple wasm32-unknown-unknown %s -emit-llvm -o - \
+// RUN: | FileCheck %s -check-prefix=LANAI
eliben wrote:
> why wasm triple?
Fixed, thanks.
http://r
Author: rsmith
Date: Tue Feb 16 18:04:04 2016
New Revision: 261034
URL: http://llvm.org/viewvc/llvm-project?rev=261034&view=rev
Log:
Improve diagnostics for ill-formed literal operator declarations.
Patch by Erik Pilkington!
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
1 - 100 of 122 matches
Mail list logo
