ah, right, sorry about that - gmail didn't render cfe-commits on the to
line in the first email... weird.
Anyway, no need to include llvm-commits on clang-only changes.
On Mon, Feb 8, 2016 at 11:30 AM, Xinliang David Li
wrote:
> Both cfe-commits and llvm-commits are cc'ed.
>
> David
>
> On Mon,
rsmith added a comment.
Can we implement all of DR253 instead? (That is, don't restrict this change to
libstdc++'s types.) We don't have precise wording for DR253 yet, but do have
the guidance that "if the implicit default constructor initializes all
subobjects, no initializer should be require
* H. J. Lu:
> On Mon, Feb 8, 2016 at 11:32 AM, Florian Weimer wrote:
>> * H. J. Lu:
>>
>>> I created a mailing list to discuss Linux specific,.processor independent
>>> modification and extension of generic System V Application Binary Interface:
>>>
>>> https://groups.google.com/d/forum/linux-abi
thakis added a comment.
Will do, thanks! In "If the implicit default constructor initializes all
subobjects, no initializer should be required", is "initializes all subobjects
meant recursively? I.e. is this ok according to that language?
`
struct Inner {
Inner() = default;
int i;
On Mon, Feb 8, 2016 at 11:44 AM, Florian Weimer wrote:
> * H. J. Lu:
>
>> On Mon, Feb 8, 2016 at 11:32 AM, Florian Weimer wrote:
>>> * H. J. Lu:
>>>
I created a mailing list to discuss Linux specific,.processor independent
modification and extension of generic System V Application Binar
On Mon, Feb 8, 2016 at 11:33 AM, Jonathan Wakely wrote:
> On 8 February 2016 at 19:23, Richard Smith wrote:
>> "POD for the purpose of layout" is defined in the Itanium C++ ABI here:
>>
>> http://mentorembedded.github.io/cxx-abi/abi.html#definitions
>
> Thanks. So there's no problem using "POD f
On Mon, Feb 8, 2016 at 11:39 AM, David Blaikie wrote:
>
>
> On Mon, Feb 8, 2016 at 9:25 AM, David Li via llvm-commits
> wrote:
>>
>> davidxl updated this revision to Diff 47217.
>> davidxl added a comment.
>>
>> Simplified test case suggested by Vedant.
>>
>>
>> http://reviews.llvm.org/D16947
>>
davidxl updated this revision to Diff 47239.
davidxl added a comment.
Further simplify tests according to David B's comment.
http://reviews.llvm.org/D16947
Files:
lib/CodeGen/CGClass.cpp
test/Profile/def-assignop.cpp
Index: test/Profile/def-assignop.cpp
rsmith added a comment.
In http://reviews.llvm.org/D16552#346678, @thakis wrote:
> Will do, thanks! In "If the implicit default constructor initializes all
> subobjects, no initializer should be required", is "initializes all
> subobjects meant recursively?
I think so, or more specifically, t
erik.pilkington updated this revision to Diff 47240.
erik.pilkington added a comment.
Thanks! This update fixes everything you brought up.
http://reviews.llvm.org/D16930
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclCXX.cpp
test/CXX/over/over.oper/over.literal/p5.cpp
On Mon, Feb 8, 2016 at 12:05 PM, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 11:33 AM, Jonathan Wakely
> wrote:
> > On 8 February 2016 at 19:23, Richard Smith wrote:
> >> "POD for the purpose of layout" is defined in the Itanium C++ ABI here:
> >>
> >> http://mentorembedded.github.io/cxx-abi/abi.h
jbcoe planned changes to this revision.
jbcoe added a comment.
Placeholder handling needs correcting.
Repository:
rL LLVM
http://reviews.llvm.org/D16962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
rsmith added a comment.
Thanks, this looks good. I think we can make the control flow a little more
obvious by moving the `return true;`s right after we emit each diagnostic, and
that also lets us remove the `goto`.
Comment at: lib/Sema/SemaDeclCXX.cpp:11769
@@ +11768,3 @@
+st
beanz created this revision.
beanz added a reviewer: bogner.
beanz added a subscriber: cfe-commits.
This commit re-lands r259862. The underlying cause of the build breakage was an
incorrectly written capabilities test. In tools/Driver/CMakeLists.txt I was
attempting to check if a linker flag wor
Hi Eric,
On 6 February 2016 at 16:36, Eric Fiselier via cfe-commits
wrote:
> Cleanup node-type handling in the unordered containers
This seems to have broken __gnu_cxx::hash_map (used by hash.cpp and
hash2.cpp in the test-suite). A smaller reproducer is:
#include
typedef __gnu_cxx::hash_map >
ariccio added a comment.
One of two comments addressed, one question asked.
Comment at: llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:792
@@ +791,3 @@
+
+const MemRegion* MemRegionManager::getMemSpaceForLocalVariable(const VarDecl
*D, llvm::PointerUnion &V) {
+ const
On Mon, Feb 8, 2016 at 12:38 PM, Richard Smith wrote:
> On Mon, Feb 8, 2016 at 12:05 PM, H.J. Lu wrote:
>>
>> On Mon, Feb 8, 2016 at 11:33 AM, Jonathan Wakely
>> wrote:
>> > On 8 February 2016 at 19:23, Richard Smith wrote:
>> >> "POD for the purpose of layout" is defined in the Itanium C++ ABI
erik.pilkington updated this revision to Diff 47246.
erik.pilkington added a comment.
Remove the FinishedParams label, clean up the control flow.
http://reviews.llvm.org/D16930
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclCXX.cpp
test/CXX/over/over.oper/over.literal/
Author: nwilson
Date: Mon Feb 8 16:02:50 2016
New Revision: 260155
URL: http://llvm.org/viewvc/llvm-project?rev=260155&view=rev
Log:
[Concepts] Remove the IsConcept bit and associated member functions from VarDecl
because the information is now stored in TemplateDecl.
Modified:
cfe/trunk/inc
Author: nico
Date: Mon Feb 8 16:23:09 2016
New Revision: 260159
URL: http://llvm.org/viewvc/llvm-project?rev=260159&view=rev
Log:
Make ParentMap work with explicit specializations of function templates.
For an explicit specialization, we first build a FunctionDecl, and then
we call SubstDecl() o
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 47247.
jbcoe added a comment.
Require C++14 for improved fixits.
Do not attempt to generate fixits for more complicated uses of bind.
http://reviews.llvm.org/D16962
Files:
clang-tidy/misc/AvoidStdB
On Mon, Feb 8, 2016 at 1:40 PM, H.J. Lu wrote:
>
> On Mon, Feb 8, 2016 at 12:38 PM, Richard Smith wrote:
> > On Mon, Feb 8, 2016 at 12:05 PM, H.J. Lu wrote:
> >>
> >> On Mon, Feb 8, 2016 at 11:33 AM, Jonathan Wakely
> >> wrote:
> >> > On 8 February 2016 at 19:23, Richard Smith wrote:
> >> >> "P
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260160: This patch adds doxygen comments for all the
intrinsincs in the header file… (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D16913?vs=46988&id=47250#toc
Repository:
Author: kromanova
Date: Mon Feb 8 16:35:09 2016
New Revision: 260160
URL: http://llvm.org/viewvc/llvm-project?rev=260160&view=rev
Log:
This patch adds doxygen comments for all the intrinsincs in the header file
pmmintrin.h. The doxygen comments are automatically generated based on Sony's
intrin
Do we really need an 'empty type' special case?
The x86_64 psABI already seems clear that empty types with size <= 16
are not passed at all. Following the algorithm in section 3.2.3, each
eightbyte is classified as NO_CLASS, and thus is not passed. So the
proposed change would only affect the beha
xur updated this revision to Diff 47251.
xur marked an inline comment as done.
xur added a comment.
fixed the typo in comments
http://reviews.llvm.org/D15829
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CodeGen
Author: davidxl
Date: Mon Feb 8 16:41:37 2016
New Revision: 260161
URL: http://llvm.org/viewvc/llvm-project?rev=260161&view=rev
Log:
[PGO] Cover more cases of implicitly generated C++ methods
Modified:
cfe/trunk/test/Profile/cxx-implicit.cpp
Modified: cfe/trunk/test/Profile/cxx-implicit.cpp
On Mon, Feb 8, 2016 at 2:35 PM, Richard Smith wrote:
> On Mon, Feb 8, 2016 at 1:40 PM, H.J. Lu wrote:
>>
>> On Mon, Feb 8, 2016 at 12:38 PM, Richard Smith wrote:
>> > On Mon, Feb 8, 2016 at 12:05 PM, H.J. Lu wrote:
>> >>
>> >> On Mon, Feb 8, 2016 at 11:33 AM, Jonathan Wakely
>> >> wrote:
>> >>
On Mon, Feb 8, 2016 at 2:42 PM, Richard Smith wrote:
> Do we really need an 'empty type' special case?
>
> The x86_64 psABI already seems clear that empty types with size <= 16
> are not passed at all. Following the algorithm in section 3.2.3, each
> eightbyte is classified as NO_CLASS, and thus i
On Mon, Feb 8, 2016 at 2:46 PM, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 2:35 PM, Richard Smith wrote:
>> On Mon, Feb 8, 2016 at 1:40 PM, H.J. Lu wrote:
>>>
>>> On Mon, Feb 8, 2016 at 12:38 PM, Richard Smith
>>> wrote:
>>> > On Mon, Feb 8, 2016 at 12:05 PM, H.J. Lu wrote:
>>> >>
>>> >> On Mon,
On Mon, Feb 8, 2016 at 2:51 PM, Richard Smith wrote:
> On Mon, Feb 8, 2016 at 2:46 PM, H.J. Lu wrote:
>> On Mon, Feb 8, 2016 at 2:35 PM, Richard Smith wrote:
>>> On Mon, Feb 8, 2016 at 1:40 PM, H.J. Lu wrote:
On Mon, Feb 8, 2016 at 12:38 PM, Richard Smith
wrote:
> On Mon,
On Mon, Feb 8, 2016 at 2:49 PM, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 2:42 PM, Richard Smith wrote:
>> Do we really need an 'empty type' special case?
>>
>> The x86_64 psABI already seems clear that empty types with size <= 16
>> are not passed at all. Following the algorithm in section 3.2.3,
On Mon, Feb 8, 2016 at 2:54 PM, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 2:51 PM, Richard Smith wrote:
>> On Mon, Feb 8, 2016 at 2:46 PM, H.J. Lu wrote:
>>> On Mon, Feb 8, 2016 at 2:35 PM, Richard Smith wrote:
On Mon, Feb 8, 2016 at 1:40 PM, H.J. Lu wrote:
>
> On Mon, Feb 8, 2016 a
jbcoe updated this revision to Diff 47259.
jbcoe added a comment.
Moved check to readability module.
Aside: would it be worthwhile creating a python script to move checks from one
module to another?
http://reviews.llvm.org/D16962
Files:
clang-tidy/readability/AvoidStdBindCheck.cpp
clang-t
On Mon, Feb 8, 2016 at 2:58 PM, Richard Smith wrote:
> On Mon, Feb 8, 2016 at 2:54 PM, H.J. Lu wrote:
>> On Mon, Feb 8, 2016 at 2:51 PM, Richard Smith wrote:
>>> On Mon, Feb 8, 2016 at 2:46 PM, H.J. Lu wrote:
On Mon, Feb 8, 2016 at 2:35 PM, Richard Smith
wrote:
> On Mon, Feb 8,
On Mon, Feb 8, 2016 at 2:55 PM, Richard Smith wrote:
> On Mon, Feb 8, 2016 at 2:49 PM, H.J. Lu wrote:
>> On Mon, Feb 8, 2016 at 2:42 PM, Richard Smith wrote:
>>> Do we really need an 'empty type' special case?
>>>
>>> The x86_64 psABI already seems clear that empty types with size <= 16
>>> are
Thanks for fixing this!
On Sun, Feb 7, 2016 at 1:32 PM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nico
> Date: Sun Feb 7 15:32:17 2016
> New Revision: 260058
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260058&view=rev
> Log:
> Make nozlibcompress.c pass and r
On Mon, Feb 8, 2016 at 12:07 PM, Xinliang David Li
wrote:
> On Mon, Feb 8, 2016 at 11:39 AM, David Blaikie wrote:
> >
> >
> > On Mon, Feb 8, 2016 at 9:25 AM, David Li via llvm-commits
> > wrote:
> >>
> >> davidxl updated this revision to Diff 47217.
> >> davidxl added a comment.
> >>
> >> Simpl
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D16761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, 8 Feb 2016, H.J. Lu wrote:
> >> I was referring to program properties:
> >>
> >> https://groups.google.com/forum/#!topic/generic-abi/fyIXttIsYc8
> >
> > This looks more like an ELF topic to me, not really ABI.
> >
> > Please discuss this on a GNU project list because it affects the
> > ent
On Mon, Feb 8, 2016 at 3:17 PM, David Blaikie wrote:
>
>
> On Mon, Feb 8, 2016 at 12:07 PM, Xinliang David Li
> wrote:
>>
>> On Mon, Feb 8, 2016 at 11:39 AM, David Blaikie wrote:
>> >
>> >
>> > On Mon, Feb 8, 2016 at 9:25 AM, David Li via llvm-commits
>> > wrote:
>> >>
>> >> davidxl updated thi
On Mon, Feb 8, 2016 at 3:01 PM, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 2:58 PM, Richard Smith wrote:
>> On Mon, Feb 8, 2016 at 2:54 PM, H.J. Lu wrote:
>>> On Mon, Feb 8, 2016 at 2:51 PM, Richard Smith wrote:
On Mon, Feb 8, 2016 at 2:46 PM, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 2:35
On Mon, Feb 8, 2016 at 3:21 PM, Xinliang David Li
wrote:
> On Mon, Feb 8, 2016 at 3:17 PM, David Blaikie wrote:
> >
> >
> > On Mon, Feb 8, 2016 at 12:07 PM, Xinliang David Li
> > wrote:
> >>
> >> On Mon, Feb 8, 2016 at 11:39 AM, David Blaikie
> wrote:
> >> >
> >> >
> >> > On Mon, Feb 8, 2016 a
saugustine updated this revision to Diff 47267.
saugustine added a comment.
- Privatize all functions but getFullyQualifiedName.
http://reviews.llvm.org/D15861
Files:
include/clang/Tooling/Core/QualTypeNames.h
lib/Tooling/Core/CMakeLists.txt
lib/Tooling/Core/QualTypeNames.cpp
unittests/
On Mon, Feb 8, 2016 at 3:35 PM, David Blaikie wrote:
>
>
> On Mon, Feb 8, 2016 at 3:21 PM, Xinliang David Li
> wrote:
>>
>> On Mon, Feb 8, 2016 at 3:17 PM, David Blaikie wrote:
>> >
>> >
>> > On Mon, Feb 8, 2016 at 12:07 PM, Xinliang David Li
>> > wrote:
>> >>
>> >> On Mon, Feb 8, 2016 at 11:39
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
OK, let's go ahead with this approach for now; we can investigate replacing the
implementation with a `PrintingPolicy` flag later.
Comment at: lib/Tooling/Core/QualTypeNames.
Author: ericwf
Date: Mon Feb 8 17:47:13 2016
New Revision: 260172
URL: http://llvm.org/viewvc/llvm-project?rev=260172&view=rev
Log:
Revert r260012 due to __gnu_cxx::hash_map breakage
Removed:
libcxx/trunk/test/libcxx/containers/unord/key_value_traits.pass.cpp
libcxx/trunk/test/std/contai
Hey Tim,
Sorry about the breakage. I've reverted the commit in r260172. I'll make
sure that gnu_cxx::hash_map continues to work before recommitting.
/Eric
On Mon, Feb 8, 2016 at 2:23 PM, Tim Northover
wrote:
> Hi Eric,
>
> On 6 February 2016 at 16:36, Eric Fiselier via cfe-commits
> wrote:
>
On Mon, Feb 8, 2016 at 3:46 PM, Xinliang David Li
wrote:
> On Mon, Feb 8, 2016 at 3:35 PM, David Blaikie wrote:
> >
> >
> > On Mon, Feb 8, 2016 at 3:21 PM, Xinliang David Li
> > wrote:
> >>
> >> On Mon, Feb 8, 2016 at 3:17 PM, David Blaikie
> wrote:
> >> >
> >> >
> >> > On Mon, Feb 8, 2016 at
To be clear, you are suggesting breaking the test into two (one for
copy, and one for move) ? I am totally fine with that. I thought you
suggested removing the testing of move/op case because they might
share the same code path (clang's implementation) as the copy/op.
thanks,
David
On Mon, Feb
On Mon, Feb 8, 2016 at 3:58 PM, Xinliang David Li
wrote:
> To be clear, you are suggesting breaking the test into two (one for
> copy, and one for move) ? I am totally fine with that.
Nah, no need to split the test case - we try to keep the number of test
files down (& group related tests into
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks great, thanks, do you need someone to commit this for you?
http://reviews.llvm.org/D16930
___
cfe-commits mailing list
cfe-commits@lists.ll
Thanks!
On Sun, Feb 7, 2016 at 1:00 PM, Nico Weber via cfe-commits
wrote:
> Author: nico
> Date: Sun Feb 7 15:00:17 2016
> New Revision: 260056
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260056&view=rev
> Log:
> Disable failing nozlibcompress.c
>
> This test hasn't been running after it wa
alexfh added a comment.
In http://reviews.llvm.org/D16962#346822, @jbcoe wrote:
> Moved check to readability module.
>
> Aside: would it be worthwhile creating a python script to move checks from
> one module to another?
It's reasonable to teach the `rename_check.py` script move across modules
On Mon, Feb 8, 2016 at 4:05 PM, David Blaikie wrote:
>
>
> On Mon, Feb 8, 2016 at 3:58 PM, Xinliang David Li
> wrote:
>>
>> To be clear, you are suggesting breaking the test into two (one for
>> copy, and one for move) ? I am totally fine with that.
>
>
> Nah, no need to split the test case - we
eugenis added a comment.
In http://reviews.llvm.org/D16738#345696, @EricWF wrote:
> I prefer using the `(void*)` casts when possible. In particular when doing
> the pointer comparisons. Could you change those back to `void*` casts then
> use the `__as_base` function for the rest?
done
Repos
eugenis updated this revision to Diff 47271.
Repository:
rL LLVM
http://reviews.llvm.org/D16738
Files:
include/__config
include/functional
Index: include/functional
===
--- include/functional
+++ include/functional
@@ -1564,6
erik.pilkington added a comment.
Yes I do, if you don't mind. Thanks for your help!
http://reviews.llvm.org/D16930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, Feb 8, 2016 at 4:31 PM, Xinliang David Li
wrote:
> On Mon, Feb 8, 2016 at 4:05 PM, David Blaikie wrote:
> >
> >
> > On Mon, Feb 8, 2016 at 3:58 PM, Xinliang David Li
> > wrote:
> >>
> >> To be clear, you are suggesting breaking the test into two (one for
> >> copy, and one for move) ? I
ha! somehow I kept thinking you are referring to implicit declared ctors.
From your test case, it is seems that the implicit copy/move op is
also broken and is fixed by this patch too. That means a missing test
case to me. Will update the case when verified.
thanks,
David
On Mon, Feb 8, 2016
Author: rsmith
Date: Mon Feb 8 19:05:04 2016
New Revision: 260181
URL: http://llvm.org/viewvc/llvm-project?rev=260181&view=rev
Log:
Fix undefined behavior when compiling in C++14 due to sized operator delete
being called with the wrong size: convert CGFunctionInfo to use TrailingObjects
and ask T
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, Feb 8, 2016 at 5:05 PM, Xinliang David Li
wrote:
> ha! somehow I kept thinking you are referring to implicit declared ctors.
>
Ah, glad we figured out the disconnect - thanks for bearing with me!
>
> From your test case, it is seems that the implicit copy/move op is
> also broken and i
FWIW, I tried to do something like this, perhaps with some other
improvements, a few years ago. Not sure if things have changed for the
better since then, but maybe those old patches may provide some
insight/other improvements/options:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-201409
flx added inline comments.
Comment at: clang-tidy/misc/UninitializedFieldCheck.cpp:178
@@ +177,3 @@
+
+ SmallPtrSet FieldsToInit;
+ fieldsRequiringInit(MemberFields, FieldsToInit);
alexfh wrote:
> What about this? (relates to line 184 now)
My comment on this was
flx updated this revision to Diff 47280.
flx added a comment.
Renamed the check to: cppcoreguidelines-pro-type-member-init, note the extra
dash between member and init to be consistent with the camelcase notation of
the class name ProTypeMemberInitCheck.
http://reviews.llvm.org/D16517
Files:
Author: rsmith
Date: Mon Feb 8 19:57:24 2016
New Revision: 260189
URL: http://llvm.org/viewvc/llvm-project?rev=260189&view=rev
Log:
Remove 'llvm::TrailingObjects::operator delete', clang side.
Modified:
cfe/trunk/include/clang/CodeGen/CGFunctionInfo.h
Modified: cfe/trunk/include/clang/CodeG
Interesting, it seems that libTooling is decoupled from the particular API
changes in r260048.
> On Feb 8, 2016, at 5:39 PM, David Blaikie wrote:
>
> FWIW, I tried to do something like this, perhaps with some other
> improvements, a few years ago. Not sure if things have changed for the better
Author: rnk
Date: Mon Feb 8 20:51:17 2016
New Revision: 260194
URL: http://llvm.org/viewvc/llvm-project?rev=260194&view=rev
Log:
Avoid forcing emission of delayed dllexported classes on template instantiation
Fixes PR26490
Modified:
cfe/trunk/lib/Sema/SemaTemplateInstantiate.cpp
cfe/tru
On Mon, Feb 8, 2016 at 3:08 PM, Joseph Myers wrote:
> On Mon, 8 Feb 2016, H.J. Lu wrote:
>
>> >> I was referring to program properties:
>> >>
>> >> https://groups.google.com/forum/#!topic/generic-abi/fyIXttIsYc8
>> >
>> > This looks more like an ELF topic to me, not really ABI.
>> >
>> > Please di
ariccio updated this revision to Diff 47289.
http://reviews.llvm.org/D16873
Files:
llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp
Index: llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRe
ariccio marked 2 inline comments as done.
ariccio added a comment.
I've reformatted, and changed the `PointerUnion` to a `const
StackFrameContext*`.
Built successfully, etc...
(I hope I don't sound too pushy!)
Comment at: llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp
I took a look at the problem. The implicitly defaulted operators
should not be instrumented as specified -- I actually I just added the
new test case for that (checking profile counter not generated) right
after my previous reply and it still passes with this patch. The
reason is that those operato
- Original Message -
> From: "Ulrich Weigand"
> To: "Hal Finkel"
> Cc: cfe-commits@lists.llvm.org
> Sent: Monday, February 8, 2016 7:53:29 AM
> Subject: Re: r259931 - [SystemZ] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP
> macros
>
> Hal Finkel wrote on 05.02.2016 23:14:54:
>
> > Just a g
ABataev added a comment.
Ping
http://reviews.llvm.org/D11182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
Ping
http://reviews.llvm.org/D10599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Mon Feb 8 22:05:37 2016
New Revision: 260195
URL: http://llvm.org/viewvc/llvm-project?rev=260195&view=rev
Log:
Use the reserved spellings for attributes
Change the no_sanitize attribute to use the reserved spelling.
Modified:
libcxx/trunk/include/__config
Modified: l
This patch adds support for templates in availability attributes.
- If the context for an availability diagnostic is a
`FunctionTemplateDecl`, look through it to the `FunctionDecl`.
- Add `__has_feature(attribute_availability_in_templates)`.
Is there anything else I should be testing to be
On Mon, Feb 8, 2016 at 7:39 PM, Xinliang David Li
wrote:
> I took a look at the problem. The implicitly defaulted operators
> should not be instrumented as specified -- I actually I just added the
> new test case for that (checking profile counter not generated) right
> after my previous reply an
On Mon, Feb 8, 2016 at 8:46 PM, David Blaikie wrote:
>
> On Mon, Feb 8, 2016 at 7:39 PM, Xinliang David Li
> wrote:
>>
>> I took a look at the problem. The implicitly defaulted operators
>> should not be instrumented as specified -- I actually I just added the
>> new test case for that (checking
On Mon, Feb 8, 2016 at 9:00 PM, Xinliang David Li
wrote:
> On Mon, Feb 8, 2016 at 8:46 PM, David Blaikie wrote:
> >
> > On Mon, Feb 8, 2016 at 7:39 PM, Xinliang David Li
> > wrote:
> >>
> >> I took a look at the problem. The implicitly defaulted operators
> >> should not be instrumented as spec
Wrong in the sense the the coverage result for the default operators
(the line where they are declared) is marked as if they are not called
which can be confusing to the user.
David
On Mon, Feb 8, 2016 at 9:09 PM, David Blaikie wrote:
>
>
> On Mon, Feb 8, 2016 at 9:00 PM, Xinliang David Li
> wr
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: fraggamuffin, caomhin, cfe-commits.
This patch implements the launching of a target region in the presence of a
nested teams region, i.e calls tgt_target_team
Author: cbieneman
Date: Tue Feb 9 00:01:47 2016
New Revision: 260201
URL: http://llvm.org/viewvc/llvm-project?rev=260201&view=rev
Log:
[CMake] Providing a CMake cache for 3-stage builds
This cache file can be used to generate a 3-stage clang build. You can
configure using the following CMake co
Neat! Besides the awesomeness of the bootstrap, I didn't know about the -C
option! (well, except that you told me about it at the social last week,
but this is the first time I saw the actual usage).
btw, the README.txt in cmake/caches says "The first two cache files in the
directory" -- but it's
Will do. That comment obviously is out of date as I keep adding files :-).
This latest one is a special ball of evil clever cmake goop, I can’t wait till
bogner spots it :-).
-Chris
> On Feb 8, 2016, at 10:38 PM, Sean Silva wrote:
>
> Neat! Besides the awesomeness of the bootstrap, I didn't k
Author: marshall
Date: Tue Feb 9 00:38:56 2016
New Revision: 260202
URL: http://llvm.org/viewvc/llvm-project?rev=260202&view=rev
Log:
Minor updates to failing tests. NFC
Modified:
libcxx/trunk/test/std/input.output/iostream.format/quoted.manip/quoted_char.fail.cpp
libcxx/trunk/test/std
Author: cbieneman
Date: Tue Feb 9 00:49:08 2016
New Revision: 260203
URL: http://llvm.org/viewvc/llvm-project?rev=260203&view=rev
Log:
[CMake] Updating caches README with explanations of useful cache files.
This is in response to silvas' post-commit suggestion.
Modified:
cfe/trunk/cmake/cac
101 - 188 of 188 matches
Mail list logo
