Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

bcraig added a comment. @mclow.lists ping http://reviews.llvm.org/D15539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13893: Roll-back r250822.

angelgarcia added a subscriber: angelgarcia. angelgarcia added a comment. The compiler complained about creating constant instances of classes without a user provided constructor (which is the case for the ASTMatchers). I gave up this change because it broke the build for a huge amount of people

Re: [PATCH] D13893: Roll-back r250822.

The compiler complained about creating constant instances of classes without a user provided constructor (which is the case for the ASTMatchers). I gave up this change because it broke the build for a huge amount of people and I didn't want that to happen again. ___

Re: [PATCH] D16259: Add clang-tidy readability-redundant-control-flow check

On Wed, Feb 3, 2016 at 3:57 PM, Kim Gräsman wrote: > On Mon, Feb 1, 2016 at 4:32 PM, Aaron Ballman wrote: >> >> >> Comment at: clang-tidy/readability/RedundantControlFlowCheck.cpp:60 >> @@ +59,3 @@ >> + if (const auto *Return = dyn_cast(*last)) >> +issueDiagnostic(Result, Bl

Re: [PATCH] D16376: clang-tidy check: rule-of-five

On Wed, Feb 3, 2016 at 4:13 PM, David Blaikie wrote: > > > On Wed, Feb 3, 2016 at 1:03 PM, Jonathan Coe wrote: >> >> >> >> On 3 February 2016 at 18:44, David Blaikie wrote: >>> >>> >>> >>> On Wed, Feb 3, 2016 at 10:23 AM, Jonathan Coe wrote: All the C++ compilers I have tried using (G

Re: r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions

On Wed, Feb 3, 2016 at 1:00 PM, Richard Smith wrote: > On Wed, Feb 3, 2016 at 11:08 AM, Anastasia Stulova > wrote: >> >> I think the main reason is that we have committed pipe type before the >> release branch was taken. It appears to have no use without the pipe builtin >> functions. >> >> Are t

Re: [PATCH] D16376: clang-tidy check: rule-of-five

On Wed, Feb 3, 2016 at 1:40 PM, Aaron Ballman wrote: > On Wed, Feb 3, 2016 at 4:13 PM, David Blaikie wrote: > > > > > > On Wed, Feb 3, 2016 at 1:03 PM, Jonathan Coe wrote: > >> > >> > >> > >> On 3 February 2016 at 18:44, David Blaikie wrote: > >>> > >>> > >>> > >>> On Wed, Feb 3, 2016 at 10:23

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

On Wed, Feb 3, 2016 at 12:40 PM, Bob Wilson wrote: > > On Feb 3, 2016, at 12:23 PM, Xinliang David Li wrote: > > On Tue, Feb 2, 2016 at 1:31 PM, Bob Wilson wrote: > > > On Jan 22, 2016, at 1:43 PM, Sean Silva via cfe-commits > wrote: > > silvas added a comment. > > In http://reviews.llvm.org/D1

r259715 - Revert r259624 - Make CF constant string decl visible to name lookup to fix module errors.

Author: qcolombet Date: Wed Feb 3 16:14:53 2016 New Revision: 259715 URL: http://llvm.org/viewvc/llvm-project?rev=259715&view=rev Log: Revert r259624 - Make CF constant string decl visible to name lookup to fix module errors. This breaks some internal bots in stage2: clang seg fault. Looking wi

Re: [PATCH] D16376: clang-tidy check: rule-of-five

jbcoe planned changes to this revision. jbcoe added a comment. If the destructor is user-declared then I need to `=delete` the compiler-generated copy constructor and copy assignment operator (if they are not defined, if either is defined then they are already handled by this check). The move

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

yaxunl updated this revision to Diff 46838. yaxunl marked 3 inline comments as done. yaxunl added a comment. Revised as Anastasia suggested. http://reviews.llvm.org/D16686 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticParseKinds.td incl

r259716 - [cfi] Safe handling of unaddressable vtable pointers (clang).

Author: eugenis Date: Wed Feb 3 16:18:55 2016 New Revision: 259716 URL: http://llvm.org/viewvc/llvm-project?rev=259716&view=rev Log: [cfi] Safe handling of unaddressable vtable pointers (clang). Avoid crashing when printing diagnostics for vtable-related CFI errors. In diagnostic mode, the front

Re: [PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

eugenis closed this revision. eugenis added a comment. http://llvm.org/viewvc/llvm-project?rev=259716&view=rev Repository: rL LLVM http://reviews.llvm.org/D16823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

AndyG added a comment. Thoughts? Am I good to go? Cheers, Andy http://reviews.llvm.org/D15636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r259721 - Reapply r259624, it is likely not the commit causing the bot failures.

Author: qcolombet Date: Wed Feb 3 16:41:00 2016 New Revision: 259721 URL: http://llvm.org/viewvc/llvm-project?rev=259721&view=rev Log: Reapply r259624, it is likely not the commit causing the bot failures. Original message: Make CF constant string decl visible to name lookup to fix module errors

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

zaks.anna added inline comments. Comment at: tools/clang/lib/StaticAnalyzer/Checkers/Checkers.td:75 @@ -74,1 +74,3 @@ +def MPI : Package<"mpi">; + Alexander_Droste wrote: > zaks.anna wrote: > > This should probably go under the 'option' package. What do you thin

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

rsmith added inline comments. Comment at: include/clang/Driver/Options.td:1463 @@ +1462,3 @@ +Group; +def mnofloat128 : Flag<["-"], "mno-float128">, +Group; Per the mangling rules at the top of this file, this should be named `mno_float128`.

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

rtrieu added a comment. Oops, forget to hit send on my last comment. My concern is something like: printf(condition ? "first message: %d" : "second message: %d", 5, 10); There's nothing in the code implying that either message is the one that should be using two arguments, so which one will

r259728 - Bump DiagnosticSemaKinds count; we're close to hitting it.

Author: mren Date: Wed Feb 3 17:35:29 2016 New Revision: 259728 URL: http://llvm.org/viewvc/llvm-project?rev=259728&view=rev Log: Bump DiagnosticSemaKinds count; we're close to hitting it. $ grep '= DIAG_START_SEMA' include/clang/Basic/DiagnosticIDs.h DIAG_START_ANALYSIS = DIAG_STAR

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added inline comments. Comment at: lib/Sema/SemaExpr.cpp:1156-1159 @@ +1155,6 @@ + + QualType LHSElemType = dyn_cast(LHSType) ? +cast(LHSType)->getElementType() : LHSType; + QualType RHSElemType = dyn_cast(RHSType) ? +cast(RHSType)->getElementType(

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

On Wed, Feb 3, 2016 at 3:52 PM, Hubert Tong < hubert.reinterpretc...@gmail.com> wrote: > hubert.reinterpretcast added inline comments. > > > Comment at: lib/Sema/SemaExpr.cpp:1156-1159 > @@ +1155,6 @@ > + > + QualType LHSElemType = dyn_cast(LHSType) ? > +cast(LHSType)->getEle

Re: [PATCH] D16748: Cleanup MemRegion.cpp/MemRegion.h

ariccio marked an inline comment as done. ariccio added a comment. Grr! missed a single note. http://reviews.llvm.org/D16748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

LegalizeAdulthood added a comment. I am already working on fixing this bug (isn't PR25894 already assigned to me?), but what's missing from this patch is an automated test that proves it works. In order to write such an automated test, I believe som

Re: [PATCH] D13893: Roll-back r250822.

ariccio added a comment. In http://reviews.llvm.org/D13893#343436, @angelgarcia wrote: > The compiler complained about creating constant instances of classes > without a user provided constructor (which is the case for the ASTMatchers). > > I gave up this change because it broke the build for a

Re: [PATCH] D16700: [Clang-tidy] Make null pointer literals for fixes configurable for two checks

LegalizeAdulthood added inline comments. Comment at: clang-tidy/readability/ImplicitBoolCastCheck.h:32 @@ -30,1 +31,3 @@ +Options.get("NullPointerLiteral", +Context->getLangOpts().CPlusPlus11 ? "nullptr" : "0")) {} void registerMatchers(ast_matchers::Mat

[PATCH] D16870: [CUDA] Tweak attribute-based overload resolution to match nvcc behavior.

tra created this revision. tra added reviewers: jlebar, jingyue, jpienaar, eliben. tra added a subscriber: cfe-commits. This is an artefact of split-mode CUDA compilation that we need to mimic. HD functions are sometimes allowed to call H or D functions. Due to split compilation mode device-side c

Re: [PATCH] D16700: [Clang-tidy] Make null pointer literals for fixes configurable for two checks

Eugene.Zelenko added inline comments. Comment at: clang-tidy/readability/ImplicitBoolCastCheck.h:32 @@ -30,1 +31,3 @@ +Options.get("NullPointerLiteral", +Context->getLangOpts().CPlusPlus11 ? "nullptr" : "0")) {} void registerMatchers(ast_matchers::MatchF

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

LegalizeAdulthood added a comment. Again, isn't this already assigned to me in the bug tracker? In general, my assumption in bug trackers is that if someone has assigned the bug to themselves, then they are working on it. Repository: rL LLVM http://reviews.llvm.org/D16794 ___

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

LegalizeAdulthood added a comment. In http://reviews.llvm.org/D16794#341552, @aaron.ballman wrote: > Missing a test case for this functionality. The isExpansionInMainFile() was > used to silence the diagnostic in macros, but it was pointed out during > review that this should be fixed and it se

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D16794#343652, @LegalizeAdulthood wrote: > Again, isn't this already assigned to me in the bug tracker? > > In general, my assumption in bug trackers is that if someone has assigned the > bug to themselves, then they are working on it.

Re: [PATCH] D16259: Add clang-tidy readability-redundant-control-flow check

In article , Aaron Ballman writes: > On Wed, Feb 3, 2016 at 3:57 PM, Kim Gräsman wrote: > > On Mon, Feb 1, 2016 at 4:32 PM, Aaron Ballman > wrote: > >> > >> > >> Comment at: clang-tidy/readability/RedundantControlFlowCheck.cpp:60 > >> @@ +59,3 @@ > >> + if (const auto *R

Re: [libcxx] r259682 - re.results.form: Format out-of-range subexpression references as null

Hans, do you mind merging this to the 3.8 branch? Marshall, do you agree this is okay to take? > On 2016-Feb-03, at 11:30, Duncan P. N. Exon Smith via cfe-commits > wrote: > > Author: dexonsmith > Date: Wed Feb 3 13:30:20 2016 > New Revision: 259682 > > URL: http://llvm.org/viewvc/llvm-proje

r259734 - Fix predefine for __NSConstantString struct type

Author: benlangmuir Date: Wed Feb 3 18:55:24 2016 New Revision: 259734 URL: http://llvm.org/viewvc/llvm-project?rev=259734&view=rev Log: Fix predefine for __NSConstantString struct type Per review feedback the name was wrong and it can be used outside Objective-C. Unfortunately, making the inte

Re: r259624 - Make CF constant string decl visible to name lookup to fix module errors

Hey Doug, I fixed this in r259734; could you take a glance at that patch too? As I mentioned in person it required more changes than just moving this definition outside the if/fixing the name. Thanks, Ben > On Feb 3, 2016, at 11:50 AM, Ben Langmuir via cfe-commits > wrote: > > >> On Feb 3

Re: [libcxx] r259682 - re.results.form: Format out-of-range subexpression references as null

I'm OK if Marshall is. Thanks, Hans On Wed, Feb 3, 2016 at 4:59 PM, Duncan P. N. Exon Smith via cfe-commits wrote: > Hans, do you mind merging this to the 3.8 branch? > > Marshall, do you agree this is okay to take? > >> On 2016-Feb-03, at 11:30, Duncan P. N. Exon Smith via cfe-commits >> wrot

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson updated this revision to Diff 46854. nwilson added a comment. - This update removes the parameter in `TemplateDecl::setConcept` since there isn't a need to mark a concept false. http://reviews.llvm.org/D13357 Files: include/clang/AST/DeclTemplate.h include/clang/Basic/DiagnosticSem

Re: [PATCH] D16738: Fix invalid casts in .

eugenis updated this revision to Diff 46857. eugenis added a comment. How about this? Repository: rL LLVM http://reviews.llvm.org/D16738 Files: include/__config include/functional Index: include/functional === --- include/f

Re: [PATCH] D16870: [CUDA] Tweak attribute-based overload resolution to match nvcc behavior.

jingyue added inline comments. Comment at: include/clang/Sema/Sema.h:8801 @@ -8798,3 +8800,3 @@ // LangOpts.CUDADisableTargetCallChecks is true. -CFP_Fallback, // Low priority caller/callee combination -CFP_Best, // Preferred caller/callee comb

[PATCH] D16873: Refactor MemRegionManager::getVarRegion to call two new functions, improving readability

ariccio created this revision. ariccio added reviewers: aaron.ballman, dcoughlin. ariccio added a subscriber: cfe-commits. Instead of one long function, `MemRegionManager::getVarRegion` now calls `getMemRegionGloballyStored` for global, non-static variables, and `getMemRegionStaticLocal` for sta

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

hubert.reinterpretcast added a comment. Minor comments; otherwise, LGTM. Comment at: lib/Sema/SemaDecl.cpp:6007 @@ +6006,3 @@ + // applied only to the definition of a [...] variable template, declared + // in namespace scope. [...] A concept definition refers to [...]

Re: [PATCH] D16870: [CUDA] Tweak attribute-based overload resolution to match nvcc behavior.

tra added a comment. When overload set contains h and HD functions that are otherwise equal for overload resolution, you want to be able to tell which one is better. http://reviews.llvm.org/D16870 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

pxli168 added inline comments. Comment at: lib/CodeGen/CGLoopInfo.cpp:131 @@ +130,3 @@ +// equivalent LoopHintAttr enums. +// See OpenCL v2.0 s6.11.5 for details. +// 0 corresponds to opencl_unroll_hint attribute without Can you also change this commen

Re: [PATCH] D16692: [OpenCL] Eliminate warning when declaring OpenCL builtin functions

pxli168 added a comment. I see you have committed this patch, you can try to follow the guide here: http://llvm.org/docs/Phabricator.html#committing-a-change To add something in your commit and then the system will automatic close the diff and have link to the commmit. This will help others to fi

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson updated this revision to Diff 46863. nwilson added a comment. - Address Hubert's comments about the quoted section of the TS. http://reviews.llvm.org/D13357 Files: include/clang/AST/DeclTemplate.h include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/SemaTemp

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev added a comment. Richard? http://reviews.llvm.org/D11182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev added a comment. Richard? http://reviews.llvm.org/D10599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r259734 - Fix predefine for __NSConstantString struct type

> On Feb 3, 2016, at 4:55 PM, Ben Langmuir via cfe-commits > wrote: > > Author: benlangmuir > Date: Wed Feb 3 18:55:24 2016 > New Revision: 259734 > > URL: http://llvm.org/viewvc/llvm-project?rev=259734&view=rev > Log: > Fix predefine for __NSConstantString struct type > > Per review feedbac

r259750 - PR23057: fix use-after-free due to local token buffer in ParseCXXAmbiguousParenExpression, by Dmitry Polukhin

Author: abataev Date: Wed Feb 3 22:22:09 2016 New Revision: 259750 URL: http://llvm.org/viewvc/llvm-project?rev=259750&view=rev Log: PR23057: fix use-after-free due to local token buffer in ParseCXXAmbiguousParenExpression, by Dmitry Polukhin Differential Revision: http://reviews.llvm.org/D16572

Re: [PATCH] D16572: PR23057: fix use-after-free due to local token buffer in ParseCXXAmbiguousParenExpression

ABataev added a subscriber: ABataev. ABataev closed this revision. ABataev added a comment. Committed in http://reviews.llvm.org/rL259750 http://reviews.llvm.org/D16572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 updated this revision to Diff 46865. pxli168 added a comment. Remove repeat test case. http://reviews.llvm.org/D16040 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CodeGenFunction.cpp lib/Sema/SemaChecking.cpp lib/Sema/SemaDeclAttr.c

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5067 @@ +5066,3 @@ + if (DeclTy->isPipeType() || + (S.getLangOpts().OpenCLVersion < 200 && DeclTy->isImageType())) { +S.Diag(D->getLocation(), diag::err_opencl_invalid_read_write) --

r259751 - Basic: mark TLS as supported on Windows on ARM

Author: compnerd Date: Wed Feb 3 23:05:23 2016 New Revision: 259751 URL: http://llvm.org/viewvc/llvm-project?rev=259751&view=rev Log: Basic: mark TLS as supported on Windows on ARM LLVM can now lower TLS access as per the MS ABI on ARM. This enables the generation of TLS access for Windows on A

Re: [PATCH] D16870: [CUDA] Tweak attribute-based overload resolution to match nvcc behavior.

jingyue added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:132-141 @@ -131,12 +131,12 @@ // (d) HostDevice behavior depends on compilation mode. if (CallerTarget == CFT_HostDevice) { // Calling a function that matches compilation mode is OK. // Calling a func

Re: [PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

ichesnokov updated this revision to Diff 46876. ichesnokov marked 2 inline comments as done. ichesnokov added a comment. Test case enriched to check typedef redefinition without warnings. Minor fix of comment. http://reviews.llvm.org/D16351 Files: lib/Sema/SemaDecl.cpp test/SemaOpenCL/impli

Re: [PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

ichesnokov marked 3 inline comments as done. Comment at: lib/Sema/SemaDecl.cpp:2039 @@ -2038,1 +2038,3 @@ + // Added isImplicit() check, because implicit TypeDecl::getLocation() + // returns 0. The're many implicit typedefs in OpenCL, e.g. atomic_flag. Fixed

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:340-341 @@ +339,4 @@ + case llvm::Triple::nvptx64: +assert(CGM.getLangOpts().OpenMPIsDevice && + "OpenMP NVPTX is only prepared to deal with device code."); +return createCGOpenMPRuntimeN

Re: [PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

ichesnokov marked 3 inline comments as done. ichesnokov added a comment. Notice that redefinition of typedef defined at system header will show the same message. http://reviews.llvm.org/D16351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

sfantao added a comment. Hi Alexey, Thanks for the feedback! Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:340-341 @@ +339,4 @@ + case llvm::Triple::nvptx64: +assert(CGM.getLangOpts().OpenMPIsDevice && + "OpenMP NVPTX is only prepared to deal with device code."); +

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:552-555 @@ -551,2 +551,6 @@ + /// \brief Create specialized OpenMP runtime code generation class for NVPTX + /// targets. + static CGOpenMPRuntime *createCGOpenMPRuntimeNVPTX(CodeGenModule &CGM); + publ

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:552-555 @@ -551,2 +551,6 @@ + /// \brief Create specialized OpenMP runtime code generation class for NVPTX + /// targets. + static CGOpenMPRuntime *createCGOpenMPRuntimeNVPTX(CodeGenModule &CGM); + publ

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:552-555 @@ -551,2 +551,6 @@ + /// \brief Create specialized OpenMP runtime code generation class for NVPTX + /// targets. + static CGOpenMPRuntime *createCGOpenMPRuntimeNVPTX(CodeGenModule &CGM); + publ

Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

ichesnokov removed rL LLVM as the repository for this revision. ichesnokov updated this revision to Diff 46877. ichesnokov added a comment. Patch improvements http://reviews.llvm.org/D16574 Files: test/SemaOpenCL/char-must-be-signed.cl Index: test/SemaOpenCL/char-must-be-signed.cl ==

Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

ichesnokov added a comment. Please review and accept. http://reviews.llvm.org/D16574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

AndyG added a comment. In your case, the first string would be highlighted only. Yes, I see what you mean. Is it possible to have multiple ranges for the diagnostic? By which I mean, to produce the following: test.cpp:x:y: warning: data argument not used by format string [-Wformat-extra-a

<    1   2