RE: [cfe-commits] r170428 [1/3] - in /cfe/trunk: include/clang/AST/ include/clang/Basic/ include/clang/Sema/ include/clang/Serialization/ lib/AST/ lib/CodeGen/ lib/Parse/ lib/Sema/ lib/Serialization/

Hi Richard, Since these are OpenCL specific types, I think you are right, these types shouldn't be part of the C++ ABI library. Thanks Guy -Original Message- From: meta...@gmail.com [mailto:meta...@gmail.com] On Behalf Of Richard Smith Sent: Wednesday, February 03, 2016 02:46 To: B

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

rengolin added subscribers: labrinea, bsmith. rengolin added a comment. Hi, I think it's clear now to me that this strategy isn't going to work. What you need is to add support for AArch64 in the TargetParser and simplify the name matching in the same way we did for ARM. There really is no othe

Re: [PATCH] D16613: Introduce a cmake module to figure out whether we need to link with libatomic.

dsanders added a comment. FWIW, the changes in the last revision look minor to me. I doubt it affects the LGTM > Do we have any test cases for arbitrary sized trivally copyable structures? > That might also be needed. The failures in 3.8.0rc1 (and presumably still occur in the 3.8.0rc2 that w

Re: [PATCH] D16626: [x86] Correct setting of WIntType for MCU target

andreybokhanko added a comment. Ping! http://reviews.llvm.org/D16626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r259637 - Reduce initial Sema memory consumption by 400KB. By Elisavet Sakellari.

Author: axel Date: Wed Feb 3 04:45:22 2016 New Revision: 259637 URL: http://llvm.org/viewvc/llvm-project?rev=259637&view=rev Log: Reduce initial Sema memory consumption by 400KB. By Elisavet Sakellari. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp U

Re: [PATCH] D16801: [OpenMP] Change in initial size of DSAStackTy::StackTy

karies added a subscriber: karies. karies closed this revision. karies added a comment. Committed as r259637 http://reviews.llvm.org/D16801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r259639 - -inline-asm][X86] Add ability to use AVX512 in MS inline asm

Author: myatsina Date: Wed Feb 3 05:32:08 2016 New Revision: 259639 URL: http://llvm.org/viewvc/llvm-project?rev=259639&view=rev Log: -inline-asm][X86] Add ability to use AVX512 in MS inline asm Defined the new AVX512 registers in clang inline asm. Fixed a bug in the MC subtarget info creation d

[clang-tools-extra] r259640 - clang-tidy: [misc-unused-parameters] Ignore template instantiations.

Author: djasper Date: Wed Feb 3 05:33:18 2016 New Revision: 259640 URL: http://llvm.org/viewvc/llvm-project?rev=259640&view=rev Log: clang-tidy: [misc-unused-parameters] Ignore template instantiations. No functional changes intended as we should already do the corresponding fixes when visiting t

Re: [cfe-commits] r170428 [1/3] - in /cfe/trunk: include/clang/AST/ include/clang/Basic/ include/clang/Sema/ include/clang/Serialization/ lib/AST/ lib/CodeGen/ lib/Parse/ lib/Sema/ lib/Serialization/

FYI: OpenCL is planning to add C++ flavor of kernel language: https://www.khronos.org/registry/cl/specs/opencl-2.1-openclc++.pdf On Wed, Feb 3, 2016 at 12:04 PM, Benyei, Guy via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Richard, > Since these are OpenCL specific types, I think you are

[clang-tools-extra] r259643 - [clang-tidy] bug fix: Don't warn on partial template specialization in `misc-definitions-in-headers` check.

Author: hokein Date: Wed Feb 3 06:10:27 2016 New Revision: 259643 URL: http://llvm.org/viewvc/llvm-project?rev=259643&view=rev Log: [clang-tidy] bug fix: Don't warn on partial template specialization in `misc-definitions-in-headers` check. Reviewers: alexfh Subscribers: cfe-commits Differenti

Re: [PATCH] D16578: [clang-tidy] bug fix: Don't warn on partial template specialization in `misc-definitions-in-headers` check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL259643: [clang-tidy] bug fix: Don't warn on partial template specialization in `misc… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D16578?vs=45984&id=46767#toc Repository: r

Re: [PATCH] D16578: [clang-tidy] bug fix: Don't warn on partial template specialization in `misc-definitions-in-headers` check.

hokein added a comment. @alexfh, I get commit access, and have committed the patch by myself (Seems it is a successful commit :D ). Repository: rL LLVM http://reviews.llvm.org/D16578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

Re: [PATCH] D16539: [FIX] 26194 - LLVM crash in CXXNameMangler::mangleType

ichesnokov updated the summary for this revision. ichesnokov updated this revision to Diff 46772. ichesnokov added a comment. This diff adds mangling check test cases for Itanium and Microsoft manglers http://reviews.llvm.org/D16539 Files: lib/AST/ItaniumMangle.cpp lib/AST/MicrosoftMangle.c

Re: [PATCH] D16539: [FIX] 26194 - LLVM crash in CXXNameMangler::mangleType

ichesnokov added a comment. I noticed that MicrosoftMangler already has many extension functions. I.e. this MicrosoftMangler.cpp change is Ok. Please review and accept/commit. http://reviews.llvm.org/D16539 ___ cfe-commits mailing list cfe-commits@

Re: [PATCH] D16376: clang-tidy check: rule-of-five

jbcoe retitled this revision from "clang-tidy check: Assignment and Construction" to "clang-tidy check: rule-of-five". jbcoe removed rL LLVM as the repository for this revision. jbcoe updated this revision to Diff 46775. jbcoe added a comment. I've responded to review comments (thanks for those)

Re: [PATCH] D16376: clang-tidy check: rule-of-five

jbcoe marked an inline comment as done. jbcoe added a comment. I think I'll move this check to `cppcoreguidelines` and call it `rule-of-five`. https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c21-if-you-define-or-delete-any-default-operation-define-or-delete-them-all

r259646 - [analyzer] AnalysisConsumer: print fully-qualified function name while displaying progress

Author: ygribov Date: Wed Feb 3 07:35:33 2016 New Revision: 259646 URL: http://llvm.org/viewvc/llvm-project?rev=259646&view=rev Log: [analyzer] AnalysisConsumer: print fully-qualified function name while displaying progress -analyzer-display progress option prints only function names which may

Re: [PATCH] D16804: [analyzer] AnalysisConsumer: print fully-qualified function name while displaying progress

This revision was automatically updated to reflect the committed changes. Closed by commit rL259646: [analyzer] AnalysisConsumer: print fully-qualified function name while… (authored by ygribov). Changed prior to commit: http://reviews.llvm.org/D16804?vs=46640&id=46777#toc Repository: rL LLV

r259647 - Forgot to remove file in previous commit.

Author: ygribov Date: Wed Feb 3 07:36:31 2016 New Revision: 259647 URL: http://llvm.org/viewvc/llvm-project?rev=259647&view=rev Log: Forgot to remove file in previous commit. Removed: cfe/trunk/test/Analysis/analyze_display_progress.c Removed: cfe/trunk/test/Analysis/analyze_display_progres

[PATCH] D16851: Update of "GCC extensions not implemented yet" in Clang User's Manual

andreybokhanko created this revision. andreybokhanko added a reviewer: rsmith. andreybokhanko added a subscriber: cfe-commits. #pragma weak, global register variables and static initialization of flexible array members are supported, so I removed them from "GCC extensions not implemented yet" li

Re: [PATCH] D16376: clang-tidy check: rule-of-five

alexfh added a comment. In http://reviews.llvm.org/D16376#342901, @jbcoe wrote: > I think I'll move this check to `cppcoreguidelines` and call it > `rule-of-five`. Yes, please move it to cppcoreguidelines. > https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c21-if-y

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki added a comment. In http://reviews.llvm.org/D13126#335929, @danielmarjamaki wrote: > For information, I am testing this patch right now.. it will take a while 1-2 > days. I have run my latest patch.. In 2215 projects it found 875 warnings. For comparison the -Wconversion gene

r259648 - Provide match function to look over an entire TU again.

Author: djasper Date: Wed Feb 3 08:29:55 2016 New Revision: 259648 URL: http://llvm.org/viewvc/llvm-project?rev=259648&view=rev Log: Provide match function to look over an entire TU again. Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchFinder.h cfe/trunk/unittests/ASTMatchers/ASTM

Re: [PATCH] D16770: [MS] PR26234: Allow typedef redefinition of equally qualified, sized and aligned types in C

d.zobnin.bugzilla updated this revision to Diff 46781. d.zobnin.bugzilla added a comment. Thanks for the review! Updated the patch according to the comments: allowed only integer, enum and pointer types which have the same qualifiers, signedness, width and alignment. Changed the diagnostic text

Re: [PATCH] D16482: Add builtins for bitreverse intrinsic

hfinkel added a subscriber: hfinkel. hfinkel accepted this revision. hfinkel added a reviewer: hfinkel. hfinkel added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D16482 ___ cfe-commits mailing list cfe-c

Re: [PATCH] D16376: clang-tidy check: rule-of-five

alexfh added inline comments. Comment at: clang-tidy/misc/RuleOfFiveCheck.cpp:30 @@ +29,3 @@ +.bind("copy-ctor")), + unless(hasDescendant(cxxMethodDecl(isCopyAssignmentOperator(), + this); Why is `hasDe

Re: [PATCH] D16770: [MS] PR26234: Allow typedef redefinition of equally qualified, sized and aligned types in C

d.zobnin.bugzilla marked 5 inline comments as done. Comment at: include/clang/AST/ASTContext.h:1772-1783 @@ -1771,1 +1771,14 @@ + /// Return true is the given typedef types are compatible in C from MSVC's + /// point of view. + // + // Conditions: + // 1. Both typedef typ

r259651 - [OpenCL] Adding reserved operator logical xor for OpenCL

Author: stulova Date: Wed Feb 3 09:17:14 2016 New Revision: 259651 URL: http://llvm.org/viewvc/llvm-project?rev=259651&view=rev Log: [OpenCL] Adding reserved operator logical xor for OpenCL This patch adds the reserved operator ^^ when compiling for OpenCL (spec v1.1 s6.3.g), which results in a

Re: [PATCH] D16748: Cleanup MemRegion.cpp/MemRegion.h

aaron.ballman closed this revision. aaron.ballman added a comment. LGTM, but the patch does not apply cleanly because it was created using absolute paths. In the future, please generate the patch with relative paths. ;-) Commit in r259652 http://reviews.llvm.org/D16748

r259652 - Minor cleanup to remove casts and improve some const correctness. NFC.

Author: aaronballman Date: Wed Feb 3 09:20:51 2016 New Revision: 259652 URL: http://llvm.org/viewvc/llvm-project?rev=259652&view=rev Log: Minor cleanup to remove casts and improve some const correctness. NFC. Patch by Alexander Riccio. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/P

Re: [PATCH] D16759: [OpenMP] Parsing + sema for target parallel for directive.

arpith-jacob marked an inline comment as done. arpith-jacob added a comment. Alexey, I've made the change in the comments. Thanks very much for your time! http://reviews.llvm.org/D16759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

Re: [PATCH] D12834: add gcc abi_tag support

DmitryPolukhin added a comment. I think Sema part should be exacted to separate patch and committed first after fixing Aaron's comments. Mangling part requires more work and much more tests. I'm still looking what actually GCC does and how it can be re-implemented in Clang without calling mangl

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

yaxunl updated this revision to Diff 46783. yaxunl marked an inline comment as done. yaxunl added a comment. Revised as Xiuli suggested. With the change, there will be quotation marks around the attribute name, so other diagnostics are also changed to be consistent. http://reviews.llvm.org/D16

Re: [PATCH] D16854: [clang-tidy] Fix a crash issue on misc-virtual-near-miss check.

congliu accepted this revision. congliu added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rL LLVM http://reviews.llvm.org/D16854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D16819: Remove llvm::(cast|isa) from lib/CodeGen/Address.h to fix build with gcc-4.8.1

sugak added a comment. @rsmith: yes, I need someone to commit this. http://reviews.llvm.org/D16819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

alexfh added a comment. Sorry for the delay. A few more comments. Comment at: clang-tidy/google/GlobalNamesInHeadersCheck.cpp:30 @@ +29,3 @@ + RawStringHeaderFileExtensions, HeaderFileExtensions)) { +llvm::errs() << "Invalid header file extension: " +

Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

sbenza updated this revision to Diff 46796. sbenza added a comment. Added comment about StringLikeClasses http://reviews.llvm.org/D16152 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/FasterStringFindCheck.cpp clang-tidy/performance/FasterStringFindCheck.h clang-tid

Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

sbenza updated this revision to Diff 46798. sbenza added a comment. Make the delimiter a constant and fix mismatch between parse/serialize of the option. http://reviews.llvm.org/D16152 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/FasterStringFindCheck.cpp clang-tid

Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

ichesnokov added a comment. Please review and approve. Repository: rL LLVM http://reviews.llvm.org/D16574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r259667 - Add back the ABITest makefiles

Author: cbieneman Date: Wed Feb 3 11:16:01 2016 New Revision: 259667 URL: http://llvm.org/viewvc/llvm-project?rev=259667&view=rev Log: Add back the ABITest makefiles These files are standalone and not integrated with CMake, so we probably want them. Added: cfe/trunk/utils/ABITest/Makefile.

[clang-tools-extra] r259668 - [clang-tidy] Fix a crash issue on misc-virtual-near-miss check.

Author: hokein Date: Wed Feb 3 11:21:44 2016 New Revision: 259668 URL: http://llvm.org/viewvc/llvm-project?rev=259668&view=rev Log: [clang-tidy] Fix a crash issue on misc-virtual-near-miss check. Summary: The crash is caused by triggering a Assertion failed in DeclCXX.h when the check detects no

Re: [PATCH] D16854: [clang-tidy] Fix a crash issue on misc-virtual-near-miss check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL259668: [clang-tidy] Fix a crash issue on misc-virtual-near-miss check. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D16854?vs=46787&id=46800#toc Repository: rL LLVM http:/

Re: r259622 - Fix miscompile and rejects-valids when disambiguating after an ambiguous

On 3 February 2016 at 02:58, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Tue Feb 2 20:58:20 2016 > New Revision: 259622 > > URL: http://llvm.org/viewvc/llvm-project?rev=259622&view=rev > Log: > Fix miscompile and rejects-valids when disambiguating after an ambiguous > C-style-ca

r259670 - clang-format: Fix formatting of ternary expressions with comments.

Author: djasper Date: Wed Feb 3 11:27:10 2016 New Revision: 259670 URL: http://llvm.org/viewvc/llvm-project?rev=259670&view=rev Log: clang-format: Fix formatting of ternary expressions with comments. Before: int i = aa ? /*=*/bb

Re: [PATCH] D16376: clang-tidy check: rule-of-five

Is this really that useful of a rule? The language does the right thing for the most part already (you don't need to explicitly delete them - they're implicitly deleted if you define any others - except for backcompat with C++98, but those cases are deprecated & we should probably split out the war

Re: [PATCH] D16770: [MS] PR26234: Allow typedef redefinition of equally qualified, sized and aligned types in C

rnk added inline comments. Comment at: include/clang/AST/ASTContext.h:1772-1783 @@ -1771,1 +1771,14 @@ + /// Return true is the given typedef types are compatible in C from MSVC's + /// point of view. + // + // Conditions: + // 1. Both typedef types are either integer, en

r259671 - Add builtins for bitreverse intrinsic

Author: arsenm Date: Wed Feb 3 11:49:38 2016 New Revision: 259671 URL: http://llvm.org/viewvc/llvm-project?rev=259671&view=rev Log: Add builtins for bitreverse intrinsic Follow the naming convention that bswap uses since it's a similar sort of operation. Modified: cfe/trunk/include/clang/Ba

Re: [PATCH] D16482: Add builtins for bitreverse intrinsic

arsenm closed this revision. arsenm added a comment. r259671. Should I put some documentation for these somewhere? docs/LanguageExtensions.rst seems to be the place, but it only has a random subset of the current builtins. http://reviews.llvm.org/D16482

Re: [PATCH] D16770: [MS] PR26234: Allow typedef redefinition of equally qualified, sized and aligned types in C

thakis added a subscriber: thakis. thakis added a comment. Out of interest, what is this needed for? System headers? http://reviews.llvm.org/D16770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [PATCH] D16808: [MCU] PR26438: Fix assertion failure on function returning an empty struct or union

DavidKreitzer added a comment. Denis, can you please explain your rationale for choosing to return 0-sized aggregates in memory for MCU? It doesn't match gcc behavior. For example, int g; union U {} u; union U f(int a, int b, int c) { g = a + b + c; return u; } void f1() { f(1, 2, 3); }

Re: [PATCH] D16846: PR26449: Fixes for bugs in __builtin_classify_type implementation

rjmccall added inline comments. Comment at: lib/AST/ExprConstant.cpp:6213 @@ -6211,3 +6212,3 @@ else if (ArgTy->isEnumeralType()) -return enumeral_type_class; +return LangOpts.CPlusPlus ? enumeral_type_class : integer_type_class; else if (ArgTy->isBooleanType())

Re: [PATCH] D16770: [MS] PR26234: Allow typedef redefinition of equally qualified, sized and aligned types in C

d.zobnin.bugzilla marked 2 inline comments as done. d.zobnin.bugzilla added a comment. @thakis, it is needed to be able to compile SPEC2000: 255.vortex. http://reviews.llvm.org/D16770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

Re: [PATCH] D16638: [CUDA] Added device-side system call decls and related wrappers.

tra retitled this revision from "[CUDA] Added device-side std::{malloc/free}" to "[CUDA] Added device-side system call decls and related wrappers.". tra updated the summary for this revision. tra updated this revision to Diff 46803. tra marked 3 inline comments as done. tra added a comment. Addre

Re: [PATCH] D16376: clang-tidy check: rule-of-five

All the C++ compilers I have tried using (GCC,Clang,MSVC) will generate assignment operators even if the user defines a copy-constructor. This is the behaviour I set out to write a check for. The cpp core guide lines recommend defining all or none of the special functions https://github.com/isocpp

Re: [PATCH] D16626: [x86] Correct setting of WIntType for MCU target

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D16626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:2039 @@ +2038,3 @@ + if (Old->isImplicit() || New->isImplicit()) { +// Since we don't emit system header warnings for compatibility with GCC, +// don't do this for implicit type redifinition warnings the s

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

Anastasia added inline comments. Comment at: lib/Sema/SemaStmtAttr.cpp:230 @@ +229,3 @@ + << A.getName() << AANT_ArgumentIntegerConstant << E->getSourceRange(); + return 0; +} 0 -> nullptr http://reviews.llvm.org/D16686

Re: [PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

samsonov accepted this revision. samsonov added a reviewer: samsonov. samsonov added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/CodeGen/CGClass.cpp:2608 @@ -2607,3 +2607,3 @@ auto TypeId = CGM.CreateCfiIdForTypeMetadata(MD); if (CGM.ge

Re: [PATCH] D16376: clang-tidy check: rule-of-five

On Wed, Feb 3, 2016 at 10:23 AM, Jonathan Coe wrote: > All the C++ compilers I have tried using (GCC,Clang,MSVC) will generate > assignment operators even if the user defines a copy-constructor. This is > the behaviour I set out to write a check for. > > The cpp core guide lines recommend definin

r259677 - Fix regression from r259622: the operand of an increment that is the operand of

Author: rsmith Date: Wed Feb 3 12:48:43 2016 New Revision: 259677 URL: http://llvm.org/viewvc/llvm-project?rev=259677&view=rev Log: Fix regression from r259622: the operand of an increment that is the operand of a cast expression is not the operand of a cast expression itself, so if it's parenthe

Re: r259622 - Fix miscompile and rejects-valids when disambiguating after an ambiguous

On Wed, Feb 3, 2016 at 9:30 AM, Renato Golin wrote: > On 3 February 2016 at 02:58, Richard Smith via cfe-commits > wrote: >> Author: rsmith >> Date: Tue Feb 2 20:58:20 2016 >> New Revision: 259622 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=259622&view=rev >> Log: >> Fix miscompile and re

r259678 - Added Anastasia Stulova as a code owner for OpenCL

Author: stulova Date: Wed Feb 3 12:51:19 2016 New Revision: 259678 URL: http://llvm.org/viewvc/llvm-project?rev=259678&view=rev Log: Added Anastasia Stulova as a code owner for OpenCL Reviewers: Chris Lattner Subscribers: cfe-dev Modified: cfe/trunk/CODE_OWNERS.TXT Modified: cfe/trunk/CO

Re: [PATCH] D16638: [CUDA] Added device-side system call decls and related wrappers.

jlebar added a comment. lg with one question about printf. Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:237 @@ +236,3 @@ +// device-side declaration for it. +__device__ int printf(const char *, ...); +} // extern "C" I think we want an attribute on thi

Re: r259622 - Fix miscompile and rejects-valids when disambiguating after an ambiguous

On 02/03/16 11:30, Renato Golin via cfe-commits wrote: On 3 February 2016 at 02:58, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue Feb 2 20:58:20 2016 New Revision: 259622 URL: http://llvm.org/viewvc/llvm-project?rev=259622&view=rev Log: Fix miscompile and rejects-valids when d

RE: r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions

I think the main reason is that we have committed pipe type before the release branch was taken. It appears to have no use without the pipe builtin functions. Are there any risks of adding this now? Btw, @Richard, I have just updated CODE_OWNERS.TXT putting myself as a code owner of OpenCL (app

Re: [PATCH] D16638: [CUDA] Added device-side system call decls and related wrappers.

tra added inline comments. Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:232 @@ +231,3 @@ +// Clang will convert printf into vprintf, but we still need +// device-side declaration for it. +__device__ int printf(const char *, ...); jlebar wrote: > I'd pref

r259681 - [Sema debugger support] Require non-void types to be complete in unknown-anytype casts.

Author: dgregor Date: Wed Feb 3 13:13:08 2016 New Revision: 259681 URL: http://llvm.org/viewvc/llvm-project?rev=259681&view=rev Log: [Sema debugger support] Require non-void types to be complete in unknown-anytype casts. When performing a cast from an __unknown_anytype function call to a non-vo

Re: [PATCH] D16467: [libcxx] re.results.form: Format out-of-range subexpression references as null

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D16467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[libcxx] r259682 - re.results.form: Format out-of-range subexpression references as null

Author: dexonsmith Date: Wed Feb 3 13:30:20 2016 New Revision: 259682 URL: http://llvm.org/viewvc/llvm-project?rev=259682&view=rev Log: re.results.form: Format out-of-range subexpression references as null Rather than crashing in match_results::format() when a reference to a marked subexpression

Re: [PATCH] D16467: [libcxx] re.results.form: Format out-of-range subexpression references as null

Committed in r259682. > On 2016-Feb-03, at 11:16, Marshall Clow wrote: > > mclow.lists accepted this revision. > mclow.lists added a comment. > This revision is now accepted and ready to land. > > LGTM > > > http://reviews.llvm.org/D16467 > > >

Re: [PATCH] D16467: [libcxx] re.results.form: Format out-of-range subexpression references as null

dexonsmith added a comment. Committed in r259682. http://reviews.llvm.org/D16467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

eugenis added inline comments. Comment at: lib/CodeGen/CGClass.cpp:2608 @@ -2607,3 +2607,3 @@ auto TypeId = CGM.CreateCfiIdForTypeMetadata(MD); if (CGM.getCodeGenOpts().SanitizeCfiCrossDso && TypeId) { EmitCfiSlowPathCheck(M, BitSetTest, TypeId, CastedVTable, StaticData

Re: [PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

eugenis updated this revision to Diff 46807. Repository: rL LLVM http://reviews.llvm.org/D16823 Files: lib/CodeGen/CGClass.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h test/CodeGen/cfi-check-fail.c test/CodeGenCXX/cfi-cast.cpp test/CodeGenC

Re: r259624 - Make CF constant string decl visible to name lookup to fix module errors

> On Feb 2, 2016, at 7:26 PM, Ben Langmuir via cfe-commits > wrote: > > Author: benlangmuir > Date: Tue Feb 2 21:26:19 2016 > New Revision: 259624 > > URL: http://llvm.org/viewvc/llvm-project?rev=259624&view=rev > Log: > Make CF constant string decl visible to name lookup to fix module errors

Re: r259624 - Make CF constant string decl visible to name lookup to fix module errors

> On Feb 3, 2016, at 11:45 AM, Douglas Gregor wrote: > >> >> On Feb 2, 2016, at 7:26 PM, Ben Langmuir via cfe-commits >> wrote: >> >> Author: benlangmuir >> Date: Tue Feb 2 21:26:19 2016 >> New Revision: 259624 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=259624&view=rev >> Log: >> M

Re: [PATCH] D16748: Cleanup MemRegion.cpp/MemRegion.h

ariccio added a comment. In http://reviews.llvm.org/D16748#343011, @aaron.ballman wrote: > LGTM, but the patch does not apply cleanly because it was created using > absolute paths. In the future, please generate the patch with relative paths. > ;-) > > Commit in r259652 Oops. http://reviews

Re: [PATCH] D16482: Add builtins for bitreverse intrinsic

hfinkel added a comment. In http://reviews.llvm.org/D16482#343177, @arsenm wrote: > r259671. > > Should I put some documentation for these somewhere? > docs/LanguageExtensions.rst seems to be the place, but it only has a random > subset of the current builtins. My impression is that we priori

r259687 - Refactor conversion of deduced template arguments to reduce repetition.

Author: rsmith Date: Wed Feb 3 14:15:01 2016 New Revision: 259687 URL: http://llvm.org/viewvc/llvm-project?rev=259687&view=rev Log: Refactor conversion of deduced template arguments to reduce repetition. Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp Modified: cfe/trunk/lib/Sema/Sem

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

On Tue, Feb 2, 2016 at 1:31 PM, Bob Wilson wrote: > >> On Jan 22, 2016, at 1:43 PM, Sean Silva via cfe-commits >> wrote: >> >> silvas added a comment. >> >> In http://reviews.llvm.org/D15829#333902, @davidxl wrote: >> >>> For the longer term, one possible solution is to make FE based >>> instrum

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste added a comment. Hi Anna, thanks for having a look once more! Comment at: tools/clang/lib/StaticAnalyzer/Checkers/Checkers.td:75 @@ -74,1 +74,3 @@ +def MPI : Package<"mpi">; + zaks.anna wrote: > This should probably go under the 'option' pack

Re: [PATCH] D16692: [OpenCL] Eliminate warning when declaring OpenCL builtin functions

yaxunl closed this revision. yaxunl added a comment. committed http://reviews.llvm.org/D16692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16044: getVariableName() for MemRegion

Alexander_Droste added a comment. Comment at: tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:662 @@ +661,3 @@ +else if (auto SV = +ER->getIndex().getAs()) { +llvm::SmallString<8> buf; Alexander_Droste wrote: > xazax.hun wrote: > > These a

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

> On Feb 3, 2016, at 12:23 PM, Xinliang David Li wrote: > > On Tue, Feb 2, 2016 at 1:31 PM, Bob Wilson > wrote: >> >>> On Jan 22, 2016, at 1:43 PM, Sean Silva via cfe-commits >>> wrote: >>> >>> silvas added a comment. >>> >>> In http://reviews.llvm.org/D15829#3

Re: [PATCH] D16808: [MCU] PR26438: Fix assertion failure on function returning an empty struct or union

hjl.tools added a comment. I am planning to update i386, x86-64 and IA MCU psABIs to address how to pass and return C++ empty class after resolving: https://llvm.org/bugs/show_bug.cgi?id=26337 by updating C++ ABI to explicitly pass and return C++ empty class like C empty structure. http://revi

r259688 - Ensure that we substitute into the declaration of a template parameter pack

Author: rsmith Date: Wed Feb 3 14:40:30 2016 New Revision: 259688 URL: http://llvm.org/viewvc/llvm-project?rev=259688&view=rev Log: Ensure that we substitute into the declaration of a template parameter pack (that is not a pack expansion) during template argument deduction, even if we deduced tha

Re: [PATCH] D16638: [CUDA] Added device-side system call decls and related wrappers.

tra updated this revision to Diff 46818. tra added a comment. Updated comment. http://reviews.llvm.org/D16638 Files: lib/Headers/__clang_cuda_runtime_wrapper.h Index: lib/Headers/__clang_cuda_runtime_wrapper.h === --- lib/Header

Re: [PATCH] D16638: [CUDA] Added device-side system call decls and related wrappers.

jlebar added a comment. lgtm. Thank you. http://reviews.llvm.org/D16638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r259690 - [CUDA] added declarations for device-side system calls

Author: tra Date: Wed Feb 3 14:53:58 2016 New Revision: 259690 URL: http://llvm.org/viewvc/llvm-project?rev=259690&view=rev Log: [CUDA] added declarations for device-side system calls ...and std:: wrappers for free/malloc. Modified: cfe/trunk/lib/Headers/__clang_cuda_runtime_wrapper.h Modi

Re: [PATCH] D16638: [CUDA] Added device-side system call decls and related wrappers.

tra closed this revision. tra added a comment. Committed in r259690 http://reviews.llvm.org/D16638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions

On Wed, Feb 3, 2016 at 11:08 AM, Anastasia Stulova < anastasia.stul...@arm.com> wrote: > I think the main reason is that we have committed pipe type before the > release branch was taken. It appears to have no use without the pipe > builtin functions. > > Are there any risks of adding this now? >

Re: [PATCH] D16376: clang-tidy check: rule-of-five

On 3 February 2016 at 18:44, David Blaikie wrote: > > > On Wed, Feb 3, 2016 at 10:23 AM, Jonathan Coe wrote: > >> All the C++ compilers I have tried using (GCC,Clang,MSVC) will generate >> assignment operators even if the user defines a copy-constructor. This is >> the behaviour I set out to wri

Re: [PATCH] D16259: Add clang-tidy readability-redundant-control-flow check

On Mon, Feb 1, 2016 at 4:32 PM, Aaron Ballman wrote: > > > Comment at: clang-tidy/readability/RedundantControlFlowCheck.cpp:60 > @@ +59,3 @@ > + if (const auto *Return = dyn_cast(*last)) > +issueDiagnostic(Result, Block, Return->getSourceRange(), > +Redund

Re: [PATCH] D13893: Roll-back r250822.

ariccio added a subscriber: ariccio. ariccio added a comment. Whatever happened to this? What in `ASTMatchers` did it break? It seems like a good change, and nobody followed up to fix it? Repository: rL LLVM http://reviews.llvm.org/D13893 ___ cf

Re: [PATCH] D13893: Roll-back r250822.

ariccio added a comment. See original diff here: http://reviews.llvm.org/D13890 Repository: rL LLVM http://reviews.llvm.org/D13893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16376: clang-tidy check: rule-of-five

On Wed, Feb 3, 2016 at 1:03 PM, Jonathan Coe wrote: > > > On 3 February 2016 at 18:44, David Blaikie wrote: > >> >> >> On Wed, Feb 3, 2016 at 10:23 AM, Jonathan Coe wrote: >> >>> All the C++ compilers I have tried using (GCC,Clang,MSVC) will generate >>> assignment operators even if the user de

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

sfantao updated this revision to Diff 46825. sfantao marked 4 inline comments as done. sfantao added a comment. Clean up changes that are not required now. Use CGOpenMPRuntime to contain everything that requires sharing. Create diagnostic to notify user about unsupported OpenMP targets. http:/

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

sfantao added a comment. Hi Alexey, Thanks again for the review! Comment at: lib/CodeGen/CGOpenMPRuntimeCommon.h:1 @@ +1,2 @@ +//=== CGOpenMPRuntimeCommon.h - Helpers for OpenMP Runtimes Codegen ==// +// ABataev wrote: > I don't think we need this new

Re: [PATCH] D16544: [libcxx] Framework to allow testing of static libc++abi

bcraig added a comment. ping http://reviews.llvm.org/D16544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16545: [libcxxabi] Enable testing for static libc++abi

bcraig added a comment. ping http://reviews.llvm.org/D16545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16044: getVariableName() for MemRegion

xazax.hun added inline comments. Comment at: tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:662 @@ +661,3 @@ +else if (auto SV = +ER->getIndex().getAs()) { +llvm::SmallString<8> buf; Alexander_Droste wrote: > Alexander_Droste wrote: > > xaza

  1   2   >