Re: [PATCH] D14471: [AArch64] Fix a crash in driver

2016-02-02 Thread Akira Hatanaka via cfe-commits
ahatanak updated this revision to Diff 46725. ahatanak added a comment. Sorry for taking so long to get back to this patch. I've updated the patch based on your review comments. I defined a new helper function getAArch64FeaturesFromCPU which gets the target features from the cpu name and checks

Fwd: [cfe-commits] r170428 [1/3] - in /cfe/trunk: include/clang/AST/ include/clang/Basic/ include/clang/Sema/ include/clang/Serialization/ lib/AST/ lib/CodeGen/ lib/Parse/ lib/Sema/ lib/Serialization/

2016-02-02 Thread Richard Smith via cfe-commits
Hi Guy, > Modified: cfe/trunk/lib/CodeGen/CGRTTI.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGRTTI.cpp?rev=170428&r1=170427&r2=170428&view=diff > == > --- cfe/trunk/lib/CodeGen/CGRTTI.cpp (orig

Re: [PATCH] D16748: Cleanup MemRegion.cpp/MemRegion.h

2016-02-02 Thread Alexander Riccio via cfe-commits
ariccio marked 3 inline comments as done. ariccio added a comment. I will remove that `const` later tonight. Comment at: C:/LLVM/llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:1396 @@ -1395,3 +1395,3 @@ const auto &ReferencedBlockVars = AC->getReferencedBlockVars(BC->

Re: [PATCH] D15305: [CUDA] Do not allow dynamic initialization of global device side variables.

2016-02-02 Thread Artem Belevich via cfe-commits
tra added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:429-430 @@ +428,4 @@ + CXXConstructorDecl *CD) { + if (!CD->isDefined() && CD->isTemplateInstantiation()) +InstantiateFunctionDefinition(VarLoc, CD->getFirstDecl()); + --

Re: [PATCH] D16638: [CUDA] Added device-side std::{malloc/free}

2016-02-02 Thread Artem Belevich via cfe-commits
tra updated this revision to Diff 46729. tra added a comment. Added few more device-side system calls and related wrapper functions. Added nothrow attributes on malloc/free. http://reviews.llvm.org/D16638 Files: lib/Headers/__clang_cuda_runtime_wrapper.h Index: lib/Headers/__clang_cuda_runti

r259616 - Fix Itanium RTTI emission so that we emit fundamental type information into the

2016-02-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Feb 2 19:32:42 2016 New Revision: 259616 URL: http://llvm.org/viewvc/llvm-project?rev=259616&view=rev Log: Fix Itanium RTTI emission so that we emit fundamental type information into the C++ ABI library for the same set of types for which we expect the C++ ABI library to

Re: [cfe-commits] r170428 [1/3] - in /cfe/trunk: include/clang/AST/ include/clang/Basic/ include/clang/Sema/ include/clang/Serialization/ lib/AST/ lib/CodeGen/ lib/Parse/ lib/Sema/ lib/Serialization/

2016-02-02 Thread Richard Smith via cfe-commits
Fixed as part of r259616. On Tue, Feb 2, 2016 at 4:45 PM, Richard Smith wrote: > Hi Guy, > >> Modified: cfe/trunk/lib/CodeGen/CGRTTI.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGRTTI.cpp?rev=170428&r1=170427&r2=170428&view=diff >> ===

Re: [PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

2016-02-02 Thread Alexey Samsonov via cfe-commits
samsonov added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2642 @@ +2641,3 @@ + llvm::MDString::get(CGM.getLLVMContext(), "all-vtables")); + llvm::Value *ValidVtable = Builder.CreateZExt( + Builder.CreateCall(CGM.getIntrinsic(llvm::Intrinsic::bitset_test), -

r259618 - Fix typo in OpenCL type mangling. This is still bogus (we should either use the

2016-02-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Feb 2 19:43:59 2016 New Revision: 259618 URL: http://llvm.org/viewvc/llvm-project?rev=259618&view=rev Log: Fix typo in OpenCL type mangling. This is still bogus (we should either use the actual source name of the typedef or a vendor mangling) but at least it stands a chan

Re: [PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

2016-02-02 Thread Evgeniy Stepanov via cfe-commits
eugenis added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2642 @@ +2641,3 @@ + llvm::MDString::get(CGM.getLLVMContext(), "all-vtables")); + llvm::Value *ValidVtable = Builder.CreateZExt( + Builder.CreateCall(CGM.getIntrinsic(llvm::Intrinsic::bitset_test), --

Re: [PATCH] D16638: [CUDA] Added device-side std::{malloc/free}

2016-02-02 Thread Justin Lebar via cfe-commits
jlebar added inline comments. Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:215 @@ +214,3 @@ +// Device-side CUDA system calls. +// http://docs.nvidia.com/cuda/ptx-writers-guide-to-interoperability/index.html#system-calls + It seems that only vprintf, fr

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

2016-02-02 Thread Xiuli PAN via cfe-commits
pxli168 added inline comments. Comment at: lib/Sema/SemaStmtAttr.cpp:216 @@ +215,3 @@ +S.Diag(A.getLoc(), diag::err_attribute_too_many_arguments) +<< "opencl_unroll_hint" << 1; +return nullptr; I think you should not use hard code here, just use A.

r259622 - Fix miscompile and rejects-valids when disambiguating after an ambiguous

2016-02-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Feb 2 20:58:20 2016 New Revision: 259622 URL: http://llvm.org/viewvc/llvm-project?rev=259622&view=rev Log: Fix miscompile and rejects-valids when disambiguating after an ambiguous C-style-cast to function/array type or parenthesized function-style cast/array indexing. Mo

r259624 - Make CF constant string decl visible to name lookup to fix module errors

2016-02-02 Thread Ben Langmuir via cfe-commits
Author: benlangmuir Date: Tue Feb 2 21:26:19 2016 New Revision: 259624 URL: http://llvm.org/viewvc/llvm-project?rev=259624&view=rev Log: Make CF constant string decl visible to name lookup to fix module errors The return type of the __builtin___*StringMakeConstantString functions is a pointer to

Re: [PATCH] D16801: [OpenMP] Change in initial size of DSAStackTy::StackTy

2016-02-02 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG. Will you commit it yourself or you want me to do this? http://reviews.llvm.org/D16801 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

Re: [PATCH] D16748: Cleanup MemRegion.cpp/MemRegion.h

2016-02-02 Thread Alexander Riccio via cfe-commits
ariccio added a comment. All set. http://reviews.llvm.org/D16748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16748: Cleanup MemRegion.cpp/MemRegion.h

2016-02-02 Thread Alexander Riccio via cfe-commits
ariccio updated this revision to Diff 46737. ariccio marked 2 inline comments as done. ariccio added a comment. Removed single `const`. http://reviews.llvm.org/D16748 Files: C:/LLVM/llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h C:/LLVM/llvm/tools/clang/lib/St

r259628 - clang-format: [JS/TypeScript] Support "enum" as an optional property name, too.

2016-02-02 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Tue Feb 2 23:33:44 2016 New Revision: 259628 URL: http://llvm.org/viewvc/llvm-project?rev=259628&view=rev Log: clang-format: [JS/TypeScript] Support "enum" as an optional property name, too. Before: enum?: string []; After: enum?: string[]; Modified: cfe/trunk/l

[PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

2016-02-02 Thread Akira Hatanaka via cfe-commits
ahatanak created this revision. ahatanak added reviewers: doug.gregor, rjmccall, vsk. ahatanak added a subscriber: cfe-commits. This patch fixes a bug in the code between line 117-126 of TypeLocBuilder.cpp which was causing the assert in line 132. The bug manifests itself when an element of size

Re: r259507 - Make the remaining headers self-contained.

2016-02-02 Thread Sean Silva via cfe-commits
On Tue, Feb 2, 2016 at 11:15 AM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Tue, Feb 2, 2016 at 11:11 AM, Rafael EspĂ­ndola < > cfe-commits@lists.llvm.org> wrote: > >> Out of curiosity, what technique were you using to find out if the >> headers were self-contained?

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

2016-02-02 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeCommon.h:1 @@ +1,2 @@ +//=== CGOpenMPRuntimeCommon.h - Helpers for OpenMP Runtimes Codegen ==// +// I don't think we need this new file and new namespace. If some (currently) internal

Re: r259507 - Make the remaining headers self-contained.

2016-02-02 Thread NAKAMURA Takumi via cfe-commits
I am not enabling modules builder(s) since my local branch has a few commits. I will create more builders after release_38 released. On Wed, Feb 3, 2016 at 3:56 PM Sean Silva wrote: > On Tue, Feb 2, 2016 at 11:15 AM, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> >>

<    1   2