Re: [PATCH] D16514: Add -stop-on-failure driver option, and enable it by default for CUDA compiles.

2016-01-27 Thread Justin Lebar via cfe-commits
jlebar added a comment. Friendly ping. http://reviews.llvm.org/D16514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16664: [CUDA] Generate CUDA's printf alloca in its function's entry block.

2016-01-27 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: rnk. jlebar added subscribers: tra, echristo, jhen, cfe-commits. This is necessary to prevent llvm from generating stacksave intrinsics around this alloca. NVVM doesn't have a stack, and we don't handle said intrinsics. I'm not sure if appen

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

2016-01-27 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast added a comment. In http://reviews.llvm.org/D15120#337654, @rjmccall wrote: > In http://reviews.llvm.org/D15120#337552, @hubert.reinterpretcast wrote: > > > It remains that the present standardization effort (as `_Float128`) does > > not imbue the "interchange" type with i

Re: [PATCH] D16664: [CUDA] Generate CUDA's printf alloca in its function's entry block.

2016-01-27 Thread Eric Christopher via cfe-commits
echristo added inline comments. Comment at: lib/CodeGen/CGCUDABuiltin.cpp:109 @@ -106,1 +108,3 @@ +// stacksave/stackrestore intrinsics, which cause ptxas to choke. +auto *Alloca = new llvm::AllocaInst( llvm::Type::getInt8Ty(Ctx), llvm::ConstantInt::get(Int32Ty, B

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

2016-01-27 Thread Marshall Clow via cfe-commits
mclow.lists updated this revision to Diff 46210. mclow.lists added a comment. Add the tests that Eric suggested. Had to toss in a `decay`. http://reviews.llvm.org/D16605 Files: test/std/experimental/iterator/nothing_to_do.pass.cpp test/std/experimental/iterator/ostream.joiner/ostream.joine

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

2016-01-27 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D16605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[libcxx] r259015 - Left a file out of r259014

2016-01-27 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Jan 27 22:15:35 2016 New Revision: 259015 URL: http://llvm.org/viewvc/llvm-project?rev=259015&view=rev Log: Left a file out of r259014 Added: libcxx/trunk/include/experimental/iterator Added: libcxx/trunk/include/experimental/iterator URL: http://llvm.org/viewvc/l

[libcxx] r259014 - implement ostream_joiner. Reviewed as http://reviews.llvm.org/D16605

2016-01-27 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Jan 27 22:14:56 2016 New Revision: 259014 URL: http://llvm.org/viewvc/llvm-project?rev=259014&view=rev Log: implement ostream_joiner. Reviewed as http://reviews.llvm.org/D16605 Added: libcxx/trunk/test/std/experimental/iterator/ libcxx/trunk/test/std/experimenta

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

2016-01-27 Thread Marshall Clow via cfe-commits
mclow.lists closed this revision. mclow.lists added a comment. Landed as r259014 and r259015. http://reviews.llvm.org/D16605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16634: [libcxx] Whitelist inclusion of sysctl.h instead of blacklisting

2016-01-27 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks fine to me. http://reviews.llvm.org/D16634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

r259016 - Revert r258951 (and r258950), "Refactor backend diagnostics for unsupported features"

2016-01-27 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Wed Jan 27 22:41:32 2016 New Revision: 259016 URL: http://llvm.org/viewvc/llvm-project?rev=259016&view=rev Log: Revert r258951 (and r258950), "Refactor backend diagnostics for unsupported features" It broke layering violation in LLVMIR. clang r258950 "Add backend dignostic

r259022 - [Lex] Share some common code between decimal and octal parsing in NumericLiteralParser.

2016-01-27 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Jan 27 23:22:54 2016 New Revision: 259022 URL: http://llvm.org/viewvc/llvm-project?rev=259022&view=rev Log: [Lex] Share some common code between decimal and octal parsing in NumericLiteralParser. There were a couple slight variations between the two copies that I don't

RE: r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions

2016-01-27 Thread xiuli pan via cfe-commits
Hi hans, Request to merge it to release 38 It adds Pipe BIFs to be used along with Pipe type committed earlier (in r257254). Thanks Xiuli -Original Message- From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Xiuli Pan via cfe-commits Sent: Tuesday, January 26,

[PATCH] D16673: Don't split NumericConstant tokens if a digit separator proceeds a period.

2016-01-27 Thread Craig Topper via cfe-commits
craig.topper created this revision. craig.topper added a reviewer: rsmith. craig.topper added a subscriber: cfe-commits. Currently we split a token if a digit separator proceeds a period. This causes the digit separator to be interpreted instead as the start of a character constant token. gcc se

[libcxx] r259023 - [libcxx] Remove pragmas that were needed to suppress warnings produced

2016-01-27 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Thu Jan 28 00:13:36 2016 New Revision: 259023 URL: http://llvm.org/viewvc/llvm-project?rev=259023&view=rev Log: [libcxx] Remove pragmas that were needed to suppress warnings produced by -Wpadded. We don't need these pragmas anymore because -Wpadded was removed from buildit

Re: [PATCH] D16632: clang-cl: Take dllexport from original function decl into account

2016-01-27 Thread Stephan Bergmann via cfe-commits
sberg added a comment. Yeah, my first naive finding when encountering the error was that it went away when unconditionally using FD->getCanonicalDecl() instead of FD in that if-else-if block. But that caused other parts of clang-test to fail. The current version passes all tests (happens to), b

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

2016-01-27 Thread Stephan Bergmann via cfe-commits
sberg updated this revision to Diff 46227. sberg added a comment. updated as discussed in the comments http://reviews.llvm.org/D15267 Files: include/clang/AST/ASTConsumer.h include/clang/Frontend/MultiplexConsumer.h include/clang/Sema/Sema.h lib/CodeGen/CodeGenAction.cpp lib/CodeGen/M

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

2016-01-27 Thread Stephan Bergmann via cfe-commits
sberg updated this revision to Diff 46228. sberg added a comment. updated as discussed in the comments http://reviews.llvm.org/D16628 Files: lib/Parse/ParseDeclCXX.cpp test/Parser/ms-anachronism.c Index: test/Parser/ms-anachronism.c =

<    1   2