echristo added a comment.
Probably qualifies as obvious. Also can you add some text to the assert
while you're there?
http://reviews.llvm.org/D16495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Probably qualifies as obvious. Also can you add some text to the assert
while you're there?
On Fri, Jan 22, 2016, 5:07 PM Justin Lebar wrote:
> jlebar created this revision.
> jlebar added a reviewer: tra.
> jlebar added subscribers: cfe-commits, jhen, echristo.
>
> No functional changes.
>
> ht
xazax.hun marked an inline comment as done.
xazax.hun added a comment.
Thank you for the fix and sorry for not noticing this. I was unlucky and the
tests did pass on my machine.
Repository:
rL LLVM
http://reviews.llvm.org/D15921
___
cfe-commits
Author: dexonsmith
Date: Sat Jan 23 09:12:47 2016
New Revision: 258625
URL: http://llvm.org/viewvc/llvm-project?rev=258625&view=rev
Log:
Revert "unordered_map: Reuse insert logic in emplace when possible, NFC"
This reverts commit r258575. EricWF sent me an email (no link since it
was off-list) r
+cfe-commits
(This looks like a broken feature of Phab. I suggest not using it,
since it hasn't put the patch context in this email, it didn't CC
the list, and it spawned a new thread instead of replying to the
commit:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160118/147763.html
Note that this was reverted due to post-commit review, but Phab
forked it into a different thread. Here it is:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160118/147795.html
> On 2016-Jan-22, at 14:48, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>
> Author: dexonsmith
> Date
> On 2016-Jan-22, at 18:01, Eric Fiselier wrote:
>
>
>
> On Fri, Jan 22, 2016 at 10:44 AM, Duncan P. N. Exon Smith
> wrote:
>
> > On 2016-Jan-21, at 22:22, Eric Fiselier wrote:
> >
> >
> >
> > On Thu, Jan 21, 2016 at 10:35 PM, Duncan P. N. Exon Smith
> > wrote:
> >
> > > On 2016-Jan-21,
Author: aaronballman
Date: Sat Jan 23 11:49:18 2016
New Revision: 258628
URL: http://llvm.org/viewvc/llvm-project?rev=258628&view=rev
Log:
Improving documentation for the isMoveAssignmentOperator AST matcher.
Patch by Jonathan Coe.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cf
aaron.ballman abandoned this revision.
aaron.ballman added a comment.
You are correct, this was fixed with http://reviews.llvm.org/D16179. Thanks!
http://reviews.llvm.org/D16377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:6985
@@ -6984,6 +6984,3 @@
SmallString<16> PrettyTargetValue;
- if (T->isSpecificBuiltinType(BuiltinType::Bool))
-PrettyTargetValue = Value.isZero() ? "false" : "true";
- else
-IntegerValue.toS
ehsan created this revision.
ehsan added a reviewer: rnk.
ehsan added a subscriber: cfe-commits.
MSVC's driver accepts all unknown arguments but warns about them. clang
by default rejects all unknown arguments. This causes issues
specifically with build systems such as autoconf which liberally p
OK.
-eric
On Fri, Jan 22, 2016 at 5:56 PM Justin Lebar wrote:
> jlebar created this revision.
> jlebar added a reviewer: tra.
> jlebar added subscribers: echristo, jhen, cfe-commits.
>
> CUDA (well, strictly speaking, NVPTX) doesn't support aliases.
>
> http://reviews.llvm.org/D16502
>
> Files:
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
OK. One question inline, but feel free to commit after answering one way or the
other :)
-eric
Comment at: test/SemaCUDA/alias.cu:1-
jlebar added inline comments.
Comment at: test/SemaCUDA/alias.cu:1-2
@@ +1,3 @@
+// REQUIRES: x86-registered-target
+// REQUIRES: nvptx-registered-target
+// RUN: %clang_cc1 -triple nvptx-unknown-cuda -fsyntax-only -fcuda-is-device
-verify -DEXPECT_ERR %s
echrist
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: echristo, cfe-commits, jhen.
When compiling CUDA, we run the frontend N times, once for each device
arch. This means that if you have a compile error in your file, you'll
see that error N times.
Relatedly, if p
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks! Do you have SVN commit access?
http://reviews.llvm.org/D16438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
jlebar added inline comments.
Comment at: test/SemaCUDA/alias.cu:1-2
@@ +1,3 @@
+// REQUIRES: x86-registered-target
+// REQUIRES: nvptx-registered-target
+// RUN: %clang_cc1 -triple nvptx-unknown-cuda -fsyntax-only -fcuda-is-device
-verify -DEXPECT_ERR %s
jlebar
Author: jlebar
Date: Sat Jan 23 15:28:08 2016
New Revision: 258640
URL: http://llvm.org/viewvc/llvm-project?rev=258640&view=rev
Log:
[CUDA] Use Triple::isNVPTX() instead of enumerating nvptx && nvptx64.
Summary: No functional changes.
Subscribers: tra, echristo, jhen, cfe-commits
Differential R
jlebar added a comment.
In http://reviews.llvm.org/D16495#334383, @echristo wrote:
> Probably qualifies as obvious. Also can you add some text to the assert
> while you're there?
Done in my local tree, will submit with that change.
http://reviews.llvm.org/D16495
__
Author: jlebar
Date: Sat Jan 23 15:28:10 2016
New Revision: 258641
URL: http://llvm.org/viewvc/llvm-project?rev=258641&view=rev
Log:
[CUDA] Reject the alias attribute in CUDA device code.
Summary: CUDA (well, strictly speaking, NVPTX) doesn't support aliases.
Reviewers: echristo
Subscribers: cf
Author: jlebar
Date: Sat Jan 23 15:28:17 2016
New Revision: 258643
URL: http://llvm.org/viewvc/llvm-project?rev=258643&view=rev
Log:
[CUDA] Disallow variadic functions other than printf in device code.
Reviewers: tra
Subscribers: cfe-commits, echristo, jhen
Differential Revision: http://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258641: [CUDA] Reject the alias attribute in CUDA device
code. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16502?vs=45783&id=45809#toc
Repository:
rL LLVM
http://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258640: [CUDA] Use Triple::isNVPTX() instead of enumerating
nvptx && nvptx64. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16495?vs=45775&id=45808#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258643: [CUDA] Disallow variadic functions other than printf
in device code. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16484?vs=45736&id=45811#toc
Repository:
rL LLVM
h
Author: jlebar
Date: Sat Jan 23 15:28:14 2016
New Revision: 258642
URL: http://llvm.org/viewvc/llvm-project?rev=258642&view=rev
Log:
[CUDA] Make printf work.
Summary:
The code in CGCUDACall is largely based on a patch written by Eli
Bendersky:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258642: [CUDA] Make printf work. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16372?vs=45456&id=45810#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16372
Files:
cfe/t
nick.sumner added a comment.
Thanks for your help!
I don't have SVN commit access.
http://reviews.llvm.org/D16438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LegalizeAdulthood updated this revision to Diff 45812.
LegalizeAdulthood marked 2 inline comments as done.
LegalizeAdulthood added a comment.
Update from review comments.
http://reviews.llvm.org/D16308
Files:
clang-tidy/readability/SimplifyBooleanExprCheck.cpp
clang-tidy/readability/Simplif
Author: betulb
Date: Sat Jan 23 16:50:44 2016
New Revision: 258650
URL: http://llvm.org/viewvc/llvm-project?rev=258650&view=rev
Log:
Clang changes for value profiling
Differential Revision: http://reviews.llvm.org/D8940
Added:
cfe/trunk/test/Profile/c-indirect-call.c
Modified:
cfe/trunk
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258650: Clang changes for value profiling (authored by
betulb).
Changed prior to commit:
http://reviews.llvm.org/D8940?vs=45550&id=45813#toc
Repository:
rL LLVM
http://reviews.llvm.org/D8940
Files:
betulb added a comment.
Committed in revision 258650.
Repository:
rL LLVM
http://reviews.llvm.org/D8940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Sat, Jan 16, 2016 at 03:51:11PM +0100, Joerg Sonnenberger via cfe-commits
wrote:
> Hello Richard,
> can this be merged into 3.8? It creates some trivial noise under
> valgrind.
Ping?
Joerg
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
Author: betulb
Date: Sat Jan 23 18:56:19 2016
New Revision: 258652
URL: http://llvm.org/viewvc/llvm-project?rev=258652&view=rev
Log:
[PGO] Windows buildbot failure fix. [NFC]
Modified:
cfe/trunk/lib/CodeGen/CodeGenPGO.h
Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.h
URL:
http://llvm.org/view
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
It seems this CL is causing Window build to fail -
http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/3885
Could you take a look?
Repository:
rL LLVM
http://reviews.llvm.org/D8940
___
LegalizeAdulthood marked 8 inline comments as done.
Comment at: clang-tidy/readability/RedundantReturnCheck.cpp:24
@@ +23,3 @@
+ functionDecl(isDefinition(), returns(asString("void")),
+ has(compoundStmt(hasAnySubstatement(returnStmt()
+ .bind("
LegalizeAdulthood retitled this revision from "Add clang-tidy
readability-redundant-return check" to "Add clang-tidy
readability-redundant-control-flow check".
LegalizeAdulthood updated this revision to Diff 45814.
LegalizeAdulthood marked an inline comment as done.
LegalizeAdulthood added a comm
http://reviews.llvm.org/rL258652 should fix the issue. Please let me know if
you continue to see failures.
-Betul
-Original Message-
From: Oleksiy Vyalov [mailto:ovya...@google.com]
Sent: Saturday, January 23, 2016 5:10 PM
To: bet...@codeaurora.org; m...@justinbogner.com; dnovi...@googl
37 matches
Mail list logo
