alexfh added a subscriber: alexfh.
alexfh added a comment.
Should be fixed in http://reviews.llvm.org/D16179.
http://reviews.llvm.org/D16377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: aaronballman
Date: Fri Jan 22 16:37:09 2016
New Revision: 258573
URL: http://llvm.org/viewvc/llvm-project?rev=258573&view=rev
Log:
Add am AST matcher for isMoveAssignmentOperator.
Patch by Jonathan Coe.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/clang
xur added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:440
@@ +439,3 @@
+ if (CodeGenOpts.ProfileIRInstr) {
+// Should not have ProfileInstrGenerate set -- it is for clang
+// instrumentation only.
silvas wrote:
> Then change the existing refe
Author: dexonsmith
Date: Fri Jan 22 16:48:02 2016
New Revision: 258575
URL: http://llvm.org/viewvc/llvm-project?rev=258575&view=rev
Log:
unordered_map: Reuse insert logic in emplace when possible, NFC
An upcoming commit will add an optimization to insert() that avoids
unnecessary mallocs when we
alexfh added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:30
@@ +29,3 @@
+Class = Class.trim();
+if (!Class.empty())
+ Result.push_back(Class);
aaron.ballman wrote:
> > Also changed the separator to be ';' instead of '
I'll upload a new patch in a moment. Replies inline below.
> On 2016-Jan-21, at 23:12, Eric Fiselier wrote:
>
> EricWF added a comment.
>
> Overall the patch looks good but I have a few concerns.
>
>> - If argument.first can be trivially converted to key_type, don't alloc.
>
>
> I'm concern
dexonsmith updated this revision to Diff 45758.
dexonsmith added a comment.
Committed r258511 and r258575 as preps. Updated patch addresses review
comments (and skips the trivially constructible parts).
http://reviews.llvm.org/D16360
Files:
include/__hash_table
include/unordered_map
tes
dcoughlin updated this revision to Diff 45756.
dcoughlin marked 6 inline comments as done.
dcoughlin added a comment.
I've updated ddkilzer's patch to address Jordan's last round of comments.
Specifically, I have:
- Changed the patch to use isObjCRetainableType() to additional warn about
proper
Author: adrian
Date: Fri Jan 22 17:30:56 2016
New Revision: 258582
URL: http://llvm.org/viewvc/llvm-project?rev=258582&view=rev
Log:
Module Debugging: Canonicalize the file names used as PCH module names
by stripping the path. Follow-up to r258555.
This is safe because only one PCH per CU is curr
krasin added a subscriber: krasin.
krasin added a comment.
FYI: this revision has likely broken the build:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/9561
FAIL: Clang :: Analysis/simple-stream-checks.c (367 of 8927)
- TEST 'Clang :: Analysis/simple-stream-checks.c' FAI
aprantl added a comment.
The linetable produced by GCC appears to be the most accurate one (stopping at
the && for the short-circuit evaluation and then returning there for the actual
& and the branch). I would not have a problem with clang implementing it.
The downside of it is that it breaks t
Author: zaks
Date: Fri Jan 22 18:45:37 2016
New Revision: 258591
URL: http://llvm.org/viewvc/llvm-project?rev=258591&view=rev
Log:
[analyzer] Fixup r258572 Utility to match function calls.
Initialize the IdentifierInfo pointer. Hope this fixes the buildbot breakage.
Modified:
cfe/trunk/inclu
zaks.anna added a comment.
Looks like the 'II' pointer wasn't initialized. Should be fixed by r258591.
Repository:
rL LLVM
http://reviews.llvm.org/D15921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: marshall
Date: Fri Jan 22 19:02:29 2016
New Revision: 258593
URL: http://llvm.org/viewvc/llvm-project?rev=258593&view=rev
Log:
Fix test to pass in C++03
Modified:
libcxx/trunk/test/libcxx/utilities/meta/is_referenceable.pass.cpp
Modified: libcxx/trunk/test/libcxx/utilities/meta/is_re
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, jhen, echristo.
No functional changes.
http://reviews.llvm.org/D16495
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
eugenis created this revision.
eugenis added reviewers: pcc, kcc.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
In the Itanium ABI, vtable may be emitted speculatively as an
available_externally global. Such vtable may not be present at the
link
Author: dcoughlin
Date: Fri Jan 22 19:09:07 2016
New Revision: 258594
URL: http://llvm.org/viewvc/llvm-project?rev=258594&view=rev
Log:
[analyzer] SATestBuild.py: Remove html and log when producing reference results.
The html reports are huge -- every issue in a given file results in a separate
c
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D16496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: cfe-commits.
http://reviews.llvm.org/D16498
Files:
include/clang/Basic/BuiltinsAMDGPU.def
test/CodeGenOpenCL/builtins-amdgcn.cl
Index: test/CodeGenOpenCL/builtins-amdgcn.cl
Author: eugenis
Date: Fri Jan 22 19:20:18 2016
New Revision: 258596
URL: http://llvm.org/viewvc/llvm-project?rev=258596&view=rev
Log:
[cfi] Do not emit bit set entry for available_externally vtables.
In the Itanium ABI, vtable may be emitted speculatively as an
available_externally global. Such v
eugenis closed this revision.
eugenis added a comment.
r258596
Repository:
rL LLVM
http://reviews.llvm.org/D16496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: echristo, jhen, cfe-commits.
NVPTX doesn't support aliases, so don't generate them.
http://reviews.llvm.org/D16499
Files:
lib/Driver/Tools.cpp
test/Driver/cuda-constructor-alias.cu
Index: test/Driver/cuda-
Author: chapuni
Date: Fri Jan 22 19:38:20 2016
New Revision: 258598
URL: http://llvm.org/viewvc/llvm-project?rev=258598&view=rev
Log:
SemaOpenMP.cpp: Fix a warning in r258543. [-Wunused-variable]
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp
URL:
ht
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: echristo, jhen, cfe-commits.
These aliases are done to support inline asm, but there's nothing we can
do: NVPTX doesn't support aliases.
http://reviews.llvm.org/D16501
Files:
lib/CodeGen/CodeGenModule.cpp
t
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: echristo, jhen, cfe-commits.
CUDA (well, strictly speaking, NVPTX) doesn't support aliases.
http://reviews.llvm.org/D16502
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/
On Fri, Jan 22, 2016 at 10:44 AM, Duncan P. N. Exon Smith <
dexonsm...@apple.com> wrote:
>
> > On 2016-Jan-21, at 22:22, Eric Fiselier wrote:
> >
> >
> >
> > On Thu, Jan 21, 2016 at 10:35 PM, Duncan P. N. Exon Smith <
> dexonsm...@apple.com> wrote:
> >
> > > On 2016-Jan-21, at 17:59, Eric Fiselie
ygao updated this revision to Diff 45784.
http://reviews.llvm.org/D15705
Files:
test/Preprocessor/bigoutput.c
test/lit.cfg
Index: test/lit.cfg
===
--- test/lit.cfg
+++ test/lit.cfg
@@ -491,4 +491,9 @@
if use_gmalloc:
conf
EricWF added a subscriber: EricWF.
EricWF added a comment.
How are you getting this warning? I can't generate it with Clang 3.8 on 64bit
linux with -m32. In that configuration int and long have the same size.
http://reviews.llvm.org/D16480
___
cfe-
ehsan created this revision.
ehsan added a reviewer: thakis.
ehsan added a subscriber: cfe-commits.
MSVC suppresses a trailing comma if no arguments are passed in place of
a variadic argument[1]. This patch adds a -Wmicrosoft warning when
accepting such code.
[1] https://msdn.microsoft.com/en-us
On Fri, Jan 22, 2016 at 3:22 PM, Nico Weber wrote:
> Every time we accept something in MS mode that isn't standards compliant,
> we should accept it with a warning (for stuff that's harmless, an Extension
> warning, for stuff that can lead to bugs a Warning warning), unless it's
> really hard to
101 - 130 of 130 matches
Mail list logo
