Author: abataev
Date: Fri Jan 22 02:56:50 2016
New Revision: 258495
URL: http://llvm.org/viewvc/llvm-project?rev=258495&view=rev
Log:
[OPENMP] Generalize codegen for 'sections'-based directive.
If 'sections' directive has only one sub-section, the code for 'single'-based
directive was emitted. Re
nick.sumner retitled this revision from "Fix printing of nested variable
declarations with suppressed tags" to "Fix printing of types in initializers
with suppressed tags.".
nick.sumner updated the summary for this revision.
nick.sumner updated this revision to Diff 45658.
nick.sumner added a com
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG.
I'd probably add a test to unittests/Tooling/RecursiveASTVisitorTest.cpp.
http://reviews.llvm.org/D16413
___
cfe-commits mailing list
cfe-com
danielmarjamaki added a comment.
In http://reviews.llvm.org/D16310#331538, @LegalizeAdulthood wrote:
> If you state what the check does, then
>
> In http://reviews.llvm.org/D16310#331054, @danielmarjamaki wrote:
>
> > In http://reviews.llvm.org/D16310#330367, @LegalizeAdulthood wrote:
> >
> > > W
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D16401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
pxli168 updated this revision to Diff 45681.
pxli168 marked 4 inline comments as done.
pxli168 added a comment.
Rewrite some comments and add missing invalid test case.
http://reviews.llvm.org/D16040
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen
Author: nico
Date: Fri Jan 22 08:12:44 2016
New Revision: 258500
URL: http://llvm.org/viewvc/llvm-project?rev=258500&view=rev
Log:
Replace some tabs with spaces.
Modified:
cfe/trunk/unittests/Tooling/RecursiveASTVisitorTest.cpp
Modified: cfe/trunk/unittests/Tooling/RecursiveASTVisitorTest.cp
jbcoe added inline comments.
Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.h:25
@@ +24,3 @@
+/// assignment operator to be `= delete`.
+///
+/// For the user-facing documentation see:
jbcoe wrote:
> The standard says that compiler generation of
Author: arpith
Date: Fri Jan 22 08:58:21 2016
New Revision: 258502
URL: http://llvm.org/viewvc/llvm-project?rev=258502&view=rev
Log:
[OpenMP] Sema for depend clause on target exit data directive.
Summary:
Accept depend clause on target exit data directive in sema and add test cases.
Reviewers: A
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258502: [OpenMP] Sema for depend clause on target exit data
directive. (authored by arpith).
Changed prior to commit:
http://reviews.llvm.org/D16401?vs=45532&id=45684#toc
Repository:
rL LLVM
http://
ehsan created this revision.
ehsan added a reviewer: rnk.
ehsan added a subscriber: cfe-commits.
In the Microsoft ABI, some expressions containing references to variables
cannot be evaluated as a constant. These are expressions containing a
conditional, logical and/or, or comma operator with an o
thakis closed this revision.
thakis added a comment.
r258503, thanks! (with the extra test)
http://reviews.llvm.org/D16413
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mdaniels updated this revision to Diff 45685.
http://reviews.llvm.org/D16344
Files:
include/type_traits
test/std/utilities/meta/meta.rel/is_convertible.pass.cpp
Index: test/std/utilities/meta/meta.rel/is_convertible.pass.cpp
===
ehsan added inline comments.
Comment at: lib/AST/ExprConstant.cpp:4113
@@ +4112,3 @@
+ if (!CheckPotentialExpressionContainingDeclRefExpr(E->getTrueExpr(),
+ E->getFalseExpr()))
+return false;
O
Author: nico
Date: Fri Jan 22 09:11:54 2016
New Revision: 258503
URL: http://llvm.org/viewvc/llvm-project?rev=258503&view=rev
Log:
Let RecursiveASTVisitor visit array index VarDecls
An implicit copy ctor creates loop VarDecls that hang off CXXCtorInitializer.
RecursiveASTVisitor used to not visit
Author: asbokhan
Date: Fri Jan 22 09:24:34 2016
New Revision: 258504
URL: http://llvm.org/viewvc/llvm-project?rev=258504&view=rev
Log:
Change of UserLabelPrefix default value from "_" to ""
Differential Revision: http://reviews.llvm.org/D16295
Modified:
cfe/trunk/lib/Basic/TargetInfo.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258504: Change of UserLabelPrefix default value from "_" to
"" (authored by asbokhan).
Changed prior to commit:
http://reviews.llvm.org/D16295?vs=45177&id=45687#toc
Repository:
rL LLVM
http://review
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D16444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
andreybokhanko added a comment.
Rafael, thanks for the review!
In http://reviews.llvm.org/D16295#329929, @rafael wrote:
> I am pretty sure the cases in init.c are wrong as the assembly itself
> doesn't use a '_'.
>
> Having said that, it is probably a good thing to do this in two steps.
> So t
Author: nico
Date: Fri Jan 22 09:49:53 2016
New Revision: 258505
URL: http://llvm.org/viewvc/llvm-project?rev=258505&view=rev
Log:
Try to pacify MSVC.
I'm not sure why it needs these braces, but they help locally.
Modified:
cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
Modified: cfe/tru
Fun fact: cl.exe refuses to compile this program:
#include
void f(std::vector v) {
for (int i : v)
do {} while(false);
}
¯\_(ツ)_/¯
On Fri, Jan 22, 2016 at 10:49 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nico
> Date: Fri Jan 22 09:49:53 2016
> New Revis
Author: majnemer
Date: Fri Jan 22 10:36:44 2016
New Revision: 258506
URL: http://llvm.org/viewvc/llvm-project?rev=258506&view=rev
Log:
[MSVC Compat] Don't provide /volatile:ms semantics to types > pointer
Volatile loads of type wider than a pointer get split by MSVC because
the base x86 ISA doesn
majnemer added a subscriber: majnemer.
majnemer added a comment.
Adding @rsmith as a reviewer.
http://reviews.llvm.org/D16465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dexonsmith created this revision.
dexonsmith added reviewers: EricWF, mclow.lists.
dexonsmith added a subscriber: cfe-commits.
Rather than crashing in match_results::format() when a reference to a
marked subexpression is out of range, format the subexpression as
empty (i.e., replace it with an emp
davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.
LGTM.
I think we also need a user level option to turn value profiling on/off (in
followups).
http://reviews.llvm.org/D8940
___
cfe-commits m
LegalizeAdulthood added a comment.
I find this an interesting discussion. I do not mean to imply that my remarks
constitute any sort of demand that this check produce my suggestion for a fixit.
In http://reviews.llvm.org/D16310#333416, @danielmarjamaki wrote:
> I expect that this warning will
> On 2016-Jan-21, at 22:22, Eric Fiselier wrote:
>
>
>
> On Thu, Jan 21, 2016 at 10:35 PM, Duncan P. N. Exon Smith
> wrote:
>
> > On 2016-Jan-21, at 17:59, Eric Fiselier wrote:
> >
> > EricWF added a comment.
> >
> > In http://reviews.llvm.org/D12354#331776, @dexonsmith wrote:
> >
> >> Thi
Author: adrian
Date: Fri Jan 22 11:43:43 2016
New Revision: 258507
URL: http://llvm.org/viewvc/llvm-project?rev=258507&view=rev
Log:
Module Debugging: Use a nonzero DWO id for precompiled headers.
PCH files don't have a module signature and LLVM uses a nonzero DWO id as
an indicator for skeleton /
On Fri, Jan 22, 2016 at 9:43 AM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Fri Jan 22 11:43:43 2016
> New Revision: 258507
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258507&view=rev
> Log:
> Module Debugging: Use a nonzero DWO id for precompi
hokein marked an inline comment as done.
Comment at: clang-tidy/utils/HeaderFileExtensionsUtils.cpp:49
@@ +48,3 @@
+ AllHeaderFileExtensions.split(Suffixes, ',');
+ HeaderFileExtensions.clear();
+ for (llvm::StringRef Suffix : Suffixes) {
I'm +1 on keeping the
hokein added a subscriber: hokein.
Comment at: clang-tidy/performance/FasterStringFindCheck.h:25
@@ +24,3 @@
+/// The character literal overload is more efficient.
+///
+/// For the user-facing documentation see:
I think you need to add document about `StringLikeC
> On Jan 22, 2016, at 9:50 AM, David Blaikie wrote:
>
>
>
> On Fri, Jan 22, 2016 at 9:43 AM, Adrian Prantl via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: adrian
> Date: Fri Jan 22 11:43:43 2016
> New Revision: 258507
>
> URL: http://llvm.org/viewvc/llvm-project?rev=25
On Thu, Jan 21, 2016 at 7:32 PM, Sean Silva wrote:
> silvas added a comment.
>
> @slingn and I had a discussion offline about the potential names and came up
> with some ideas, but none is a clear winner.
>
> Overall, my feeling is that from a user's perspective, the frontend stuff is
> probably
Author: dexonsmith
Date: Fri Jan 22 12:27:26 2016
New Revision: 258511
URL: http://llvm.org/viewvc/llvm-project?rev=258511&view=rev
Log:
unordered: Rename __construct_node_hash() to allow forwarding, NFC
Rename the version of __construct_node() that takes a hash as an
argument to __construct_node
> On 2016-Jan-21, at 23:14, Eric Fiselier wrote:
>
> EricWF added a comment.
>
>> - Did I successfully match the coding style? (I'm kind of lost without
>> clang-format TBH.)
>
>
> The style looks pretty good. I'll comment on any nits I have.
>
>> - Should I separate the change to __constru
hjl.tools created this revision.
hjl.tools added a reviewer: rsmith.
hjl.tools added a subscriber: cfe-commits.
From
https://gcc.gnu.org/ml/gcc-patches/2010-09/msg01807.html
-fsplit-stack should pass --wrap=pthread_create to linker for -fsplit-stack
It is needed to initialize the stack guard. T
rnk added a comment.
Your code won't catch this test case:
static int x;
extern inline const bool *f() {
static const bool p = !&x;
return &p;
}
Getting this exactly right is going to be a challenge. =/
Comment at: include/clang/Basic/DiagnosticASTKinds.td:151
@@
davidxl added a comment.
This option is not needed for -fprofile-instr-use compilation as the compiler
can detect the flavor of the profile (patch pending review), and decide what to
do.
The question here is what the option should look like to tell the compiler
which phase to do the instrumen
xur updated this revision to Diff 45708.
xur added a comment.
This new patches integrates Sean review comments:
(1) make -fprofile-ir-instr a cc1 option instead of driver option.
(2) add one cc1 option test, and test the pass is indeed invoked.
(3) remove the driver test (runtime library).
(4) fix
Author: dcoughlin
Date: Fri Jan 22 12:45:22 2016
New Revision: 258517
URL: http://llvm.org/viewvc/llvm-project?rev=258517&view=rev
Log:
[analyzer] SATestBuild.py: Handle spaces in path passed to --use-analyzer.
I missed this one in r258493.
Modified:
cfe/trunk/utils/analyzer/SATestBuild.py
Author: adrian
Date: Fri Jan 22 12:46:45 2016
New Revision: 258519
URL: http://llvm.org/viewvc/llvm-project?rev=258519&view=rev
Log:
Fix a typo in r258507 and change the PCH dwoid constant to ~1UL.
rdar://problem/24290667
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
cfe/trunk/lib/Code
Author: adrian
Date: Fri Jan 22 12:46:40 2016
New Revision: 258518
URL: http://llvm.org/viewvc/llvm-project?rev=258518&view=rev
Log:
Fix 80-column violations.
Modified:
cfe/trunk/test/Modules/ExtDebugInfo.cpp
Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp
URL:
http://llvm.org/viewvc/llvm
beanz created this revision.
beanz added reviewers: echristo, chandlerc, grosbach, bob.wilson.
beanz added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This patch is provided in preparation for removing autoconf on 1/26. The
proposal to remove autoconf on 1/26 was discussed on th
thakis created this revision.
thakis added reviewers: rsmith, rnk.
thakis added a subscriber: cfe-commits.
Herald added subscribers: aemerson, klimek.
RecursiveASTVisitor::TraverseFunctionHelper() traverses a function's
ParmVarDecls by going to the function's getTypeSourceInfo if it exists, and `
Author: yrnkrn
Date: Fri Jan 22 13:03:27 2016
New Revision: 258524
URL: http://llvm.org/viewvc/llvm-project?rev=258524&view=rev
Log:
Merge templated static member variables, fixes http://llvm.org/pr26179.
Patch by Vassil Vassilev!
Reviewed by Richard Smith.
Added:
cfe/trunk/test/Modules/Inp
Committed revision 258524.
2016-01-21 19:33 GMT+02:00 Vassil Vassilev via cfe-commits <
cfe-commits@lists.llvm.org>:
> ping... (perhaps someone else with commit rights can check it it...)
> --Vassil
>
> On 18/01/16 22:07, Vassil Vassilev wrote:
>
> Thanks! Could you check it in?
> -- Vassil
> On
mcrosier added a subscriber: mcrosier.
mcrosier added a comment.
Would it make sense to include an additional test (in test/Driver) that shows
the -fprofile-ir-instr option being passed from the driver to the frontend?
Such a test case would land in clang_f_opt.c, which has many examples.
rnk added a comment.
Let's go ahead and land this. It doesn't seem high risk. Richard will be back
on Monday, he's been skiing.
http://reviews.llvm.org/D15670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
ehsan added a comment.
In http://reviews.llvm.org/D16465#333688, @rnk wrote:
> Your code won't catch this test case:
>
> static int x;
> extern inline const bool *f() {
> static const bool p = !&x;
> return &p;
> }
>
> Getting this exactly right is going to be a challenge. =/
Oh y
Author: adrian
Date: Fri Jan 22 13:14:24 2016
New Revision: 258526
URL: http://llvm.org/viewvc/llvm-project?rev=258526&view=rev
Log:
Rephrase this test to help debug a buildbot issue
Modified:
cfe/trunk/test/Modules/ExtDebugInfo.cpp
Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp
URL:
htt
Thanks!
--Vassil
On 22/01/16 20:07, Yaron Keren wrote:
Committed revision 258524.
2016-01-21 19:33 GMT+02:00 Vassil Vassilev via cfe-commits
mailto:cfe-commits@lists.llvm.org>>:
ping... (perhaps someone else with commit rights can check it it...)
--Vassil
On 18/01/16 22:07, Vass
Sure. I'd be happy to address any comments post-landing.
Thanks!
On Fri, Jan 22, 2016 at 2:13 PM, Reid Kleckner wrote:
> rnk added a comment.
>
> Let's go ahead and land this. It doesn't seem high risk. Richard will be
> back on Monday, he's been skiing.
>
>
> http://reviews.llvm.org/D15670
>
ehsan added a comment.
Sure. I'd be happy to address any comments post-landing.
Thanks!
http://reviews.llvm.org/D15670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ehsan
Date: Fri Jan 22 13:26:44 2016
New Revision: 258530
URL: http://llvm.org/viewvc/llvm-project?rev=258530&view=rev
Log:
[MSVC Compat] Accept elided commas in macro function arguments
Summary:
This fixes PR25875. When the trailing comma in a macro argument list is
elided, we need to t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258530: [MSVC Compat] Accept elided commas in macro function
arguments (authored by ehsan).
Changed prior to commit:
http://reviews.llvm.org/D15670?vs=43310&id=45718#toc
Repository:
rL LLVM
http://r
Author: adrian
Date: Fri Jan 22 13:29:41 2016
New Revision: 258531
URL: http://llvm.org/viewvc/llvm-project?rev=258531&view=rev
Log:
Fix the build by using the correct suffix for 64 bit literals
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOp
jbcoe planned changes to this revision.
jbcoe added a comment.
i need the matcher from http://reviews.llvm.org/D16470 to add a corresponding
pair of checks and fixes for move-constructors and move-assignment.
http://reviews.llvm.org/D16376
___
cfe-
rafael added a subscriber: rafael.
rafael added a comment.
Needs a testcase.
http://reviews.llvm.org/D16469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna updated this revision to Diff 45720.
zaks.anna added a comment.
Thanks for spotting the bug! The bug is fixed and the tests are added in this
revision.
http://reviews.llvm.org/D15624
Files:
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/darwin-sanitizer-ld.c
te
Is it possible to emit some -Wmicrosoft warning in cases where this is
necessary?
On Fri, Jan 22, 2016 at 2:26 PM, Ehsan Akhgari via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ehsan
> Date: Fri Jan 22 13:26:44 2016
> New Revision: 258530
>
> URL: http://llvm.org/viewvc/llvm-projec
Do you mean only a warning for the case this patch is handling, or also for
cases such as the second test case in
https://llvm.org/bugs/show_bug.cgi?id=25875#c1 too?
(I think it would probably be a good idea to warn in both cases.)
On Fri, Jan 22, 2016 at 2:39 PM, Nico Weber wrote:
> Is it poss
xur added inline comments.
Comment at: lib/Driver/Tools.cpp:3279
@@ -3278,1 +3278,3 @@
+
+ Args.AddAllArgs(CmdArgs, options::OPT_fprofile_ir_instr);
}
mcrosier wrote:
> I don't think AddAllArgs is what you really want. What if the user specifies
> the option t
bcraig created this revision.
bcraig added a reviewer: mclow.lists.
bcraig added a subscriber: cfe-commits.
The old code produced a couple of these warnings...
src/string.cpp:95:11: warning: comparison of constant -2147483648 with
expression of type 'long' (range [-2147483648, 2147483647]) is al
arsenm created this revision.
arsenm added a reviewer: jmolloy.
arsenm added a subscriber: cfe-commits.
Follow the naming convention that bswap uses since it's a
similar sort of operation.
http://reviews.llvm.org/D16482
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test
Every time we accept something in MS mode that isn't standards compliant,
we should accept it with a warning (for stuff that's harmless, an Extension
warning, for stuff that can lead to bugs a Warning warning), unless it's
really hard to implement.
(See also
https://docs.google.com/presentation/d/
Author: sfantao
Date: Fri Jan 22 14:21:36 2016
New Revision: 258543
URL: http://llvm.org/viewvc/llvm-project?rev=258543&view=rev
Log:
[OpenMP] Update map clause SEMA to support OpenMP 4.5 possible list items.
Summary:
Extend support in the map clause SEMA for the expressions supported in the
Ope
I implemented Reid's suggestion in 258545. I tested that the test runs and
passes when the DIA SDK is around (this is usually the case), and doesn't
run when it isn't.
On Thu, Jan 21, 2016 at 2:09 PM, Alexey Samsonov wrote:
> On Thu, Jan 21, 2016 at 10:58 AM, Reid Kleckner wrote:
>
>> On Thu, J
Hans,
This change looks pretty trivial, and is required to not crash for the test
cases in PR26134. Can we merge it to release_38, please?
-Dimitry
> On 19 Jan 2016, at 19:28, Dimitry Andric via cfe-commits
> wrote:
>
> Hi Richard,
>
> I am unsure if you are specifically the code owner of
It seems Richard is out of office, but perhaps he can verify this later.
Dimitry: go ahead and merge it (or let me know if you'd like me to).
On Fri, Jan 22, 2016 at 12:38 PM, Dimitry Andric wrote:
> Hans,
>
> This change looks pretty trivial, and is required to not crash for the test
> cases i
jbcoe updated this revision to Diff 45729.
jbcoe added a comment.
Added handling for move-constructor/move-assignment pairs.
http://reviews.llvm.org/D16376
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp
Thanks, I merged it in r258549.
-Dimitry
> On 22 Jan 2016, at 21:43, Hans Wennborg wrote:
>
> It seems Richard is out of office, but perhaps he can verify this later.
>
> Dimitry: go ahead and merge it (or let me know if you'd like me to).
>
> On Fri, Jan 22, 2016 at 12:38 PM, Dimitry Andric
For the longer term, one possible solution is to make FE based
instrumentation only used for coverage testing which can be turned on
with -fcoverage-mapping option (currently, -fcoverage-mapping can not
be used alone and must be used together with
-fprofile-instr-generate). To summarize:
A. Curren
jbcoe added inline comments.
Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp:52
@@ +51,3 @@
+ hasDescendant(
+ cxxMethodDecl(isMoveAssignmentOperator(), unless(isImplicit()))
+ .bind("move-assignment")),
davidxl added a comment.
For the longer term, one possible solution is to make FE based
instrumentation only used for coverage testing which can be turned on
with -fcoverage-mapping option (currently, -fcoverage-mapping can not
be used alone and must be used together with
-fprofile-instr-generate)
probinson added a comment.
Ping.
http://reviews.llvm.org/D16094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added a comment.
Ping.
http://reviews.llvm.org/D15881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Fri Jan 22 14:52:54 2016
New Revision: 258550
URL: http://llvm.org/viewvc/llvm-project?rev=258550&view=rev
Log:
[OpenMP] Remove '#if 1' hanging in target_map_messages.cpp.
Modified:
cfe/trunk/test/OpenMP/target_map_messages.cpp
Modified: cfe/trunk/test/OpenMP/target_
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: jhen, echristo, cfe-commits.
http://reviews.llvm.org/D16484
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/SemaCUDA/va-arg.cu
test/SemaCUDA/vararg.cu
Index: test/SemaCUDA/v
LegalizeAdulthood added a comment.
As a general comment, I am continually fascinated by the **huge** variety of
opinion as to matters of readability within the C++ community. I don't know
why we have so many differing opinions compared to the communities built around
other programming language
silvas added inline comments.
Comment at: lib/Driver/Tools.cpp:3279
@@ -3278,1 +3278,3 @@
+
+ Args.AddAllArgs(CmdArgs, options::OPT_fprofile_ir_instr);
}
xur wrote:
> mcrosier wrote:
> > I don't think AddAllArgs is what you really want. What if the user
> > sp
ahatanak added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:1962
@@ +1961,3 @@
+for (auto *U : I->users())
+ InstrsToRemove.push_back(cast(U));
+
manmanren wrote:
> Do we need to check if the user has been erased? I am not sure if the same
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Small nit. LGTM otherwise.
Comment at: lib/Sema/SemaDecl.cpp:8291-8293
@@ +8290,5 @@
+// in device-side CUDA code.
+if (NewFD->isVariadic() && (NewFD->hasAttr() ||
+
samsonov accepted this revision.
samsonov added a reviewer: samsonov.
samsonov added a comment.
LGTM
Comment at: lib/Driver/ToolChains.cpp:339
@@ +338,3 @@
+ }
+}
+
You might need `llvm_unreachable` at the very end to suppress GCC warnings
(http://llvm.org/doc
Thank you for fixing this!
On Fri, Jan 22, 2016 at 12:30 PM, Nico Weber wrote:
> I implemented Reid's suggestion in 258545. I tested that the test runs and
> passes when the DIA SDK is around (this is usually the case), and doesn't
> run when it isn't.
>
> On Thu, Jan 21, 2016 at 2:09 PM, Alexey
Author: adrian
Date: Fri Jan 22 15:14:41 2016
New Revision: 258555
URL: http://llvm.org/viewvc/llvm-project?rev=258555&view=rev
Log:
Module debugging: Create a parent DIModule with the PCH name for types
emitted into a precompiled header to mirror the debug info emitted for
object files importing
hjl.tools updated this revision to Diff 45735.
hjl.tools added a comment.
Add a testcase.
http://reviews.llvm.org/D16469
Files:
lib/Driver/Tools.cpp
test/Driver/split-stack-ld.c
Index: test/Driver/split-stack-ld.c
===
--- /dev
arsenm closed this revision.
arsenm added a comment.
r258560
http://reviews.llvm.org/D16444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mcrosier added inline comments.
Comment at: lib/Driver/Tools.cpp:3279
@@ -3278,1 +3278,3 @@
+
+ Args.AddAllArgs(CmdArgs, options::OPT_fprofile_ir_instr);
}
silvas wrote:
> xur wrote:
> > mcrosier wrote:
> > > I don't think AddAllArgs is what you really want. Wh
Author: arsenm
Date: Fri Jan 22 15:30:53 2016
New Revision: 258560
URL: http://llvm.org/viewvc/llvm-project?rev=258560&view=rev
Log:
AMDGPU: Rename builtins to use amdgcn prefix
Keep the ones still used by libclc around for now.
Emit the new amdgcn intrinsic name if not targeting r600,
in which
jlebar added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:8291-8293
@@ +8290,5 @@
+// in device-side CUDA code.
+if (NewFD->isVariadic() && (NewFD->hasAttr() ||
+NewFD->hasAttr()) &&
+!(II && II->isStr("printf") && !D.isFunctio
jlebar updated this revision to Diff 45736.
jlebar marked an inline comment as done.
jlebar added a comment.
Add check for extern "C" printf -- we don't want to take just any printf!
http://reviews.llvm.org/D16484
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
tes
silvas added a comment.
In http://reviews.llvm.org/D15829#333902, @davidxl wrote:
> For the longer term, one possible solution is to make FE based
> instrumentation only used for coverage testing which can be turned on
> with -fcoverage-mapping option (currently, -fcoverage-mapping can not
> b
Author: xazax
Date: Fri Jan 22 15:45:51 2016
New Revision: 258562
URL: http://llvm.org/viewvc/llvm-project?rev=258562&view=rev
Log:
[clang-tidy] Handle decayed types and other improvements in VirtualNearMiss
check.
Handle decayed types, ignore qualifiers and accessibility when considering a
meth
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258562: [clang-tidy] Handle decayed types and other
improvements in VirtualNearMiss… (authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D16179?vs=45482&id=45739#toc
Repository:
rL
Author: arsenm
Date: Fri Jan 22 15:56:30 2016
New Revision: 258564
URL: http://llvm.org/viewvc/llvm-project?rev=258564&view=rev
Log:
AMDGPU: Add barrier builtin
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def
cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn.cl
Modified: cfe/trunk/
silvas added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:440
@@ +439,3 @@
+ if (CodeGenOpts.ProfileIRInstr) {
+// Should not have ProfileInstrGenerate set -- it is for clang
+// instrumentation only.
Then change the existing references in cla
eugenis added a comment.
ping
Repository:
rL LLVM
http://reviews.llvm.org/D15699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258572: [analyzer] Utility to match function calls.
(authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D15921?vs=44721&id=45748#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15
Author: xazax
Date: Fri Jan 22 16:32:46 2016
New Revision: 258572
URL: http://llvm.org/viewvc/llvm-project?rev=258572&view=rev
Log:
[analyzer] Utility to match function calls.
This patch adds a small utility to match function calls. This utility abstracts
away the mutable keywords and the lazy i
Should be fixed in http://reviews.llvm.org/D16179.
On Jan 20, 2016 23:55, "Aaron Ballman" wrote:
> aaron.ballman updated this revision to Diff 45451.
> aaron.ballman added a comment.
>
> Now checking that both the base *and* the derived functions have names.
>
>
> http://reviews.llvm.org/D16377
>
1 - 100 of 130 matches
Mail list logo
