Author: ericwf
Date: Thu Jan 21 19:09:23 2016
New Revision: 258464
URL: http://llvm.org/viewvc/llvm-project?rev=258464&view=rev
Log:
Merging r258196:
r258196 | ericwf | 2016-01-19 14:52:04 -0700 (Tue, 19 Jan 2016) | 1 line
A
Author: arpith
Date: Thu Jan 21 19:09:37 2016
New Revision: 258466
URL: http://llvm.org/viewvc/llvm-project?rev=258466&view=rev
Log:
[OpenMP] Sema for depend clause on target enter data directive.
Summary:
Accept depend clause on target enter data directive in sema and add test cases.
Reviewers:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258466: [OpenMP] Sema for depend clause on target enter data
directive. (authored by arpith).
Changed prior to commit:
http://reviews.llvm.org/D16400?vs=45525&id=45621#toc
Repository:
rL LLVM
http:/
Author: ericwf
Date: Thu Jan 21 19:10:25 2016
New Revision: 258467
URL: http://llvm.org/viewvc/llvm-project?rev=258467&view=rev
Log:
Merging r258198:
r258198 | ericwf | 2016-01-19 14:58:49 -0700 (Tue, 19 Jan 2016) | 1 line
A
Author: ericwf
Date: Thu Jan 21 19:11:34 2016
New Revision: 258468
URL: http://llvm.org/viewvc/llvm-project?rev=258468&view=rev
Log:
Merging r258201:
r258201 | ericwf | 2016-01-19 15:07:10 -0700 (Tue, 19 Jan 2016) | 1 line
A
Author: ericwf
Date: Thu Jan 21 19:12:23 2016
New Revision: 258469
URL: http://llvm.org/viewvc/llvm-project?rev=258469&view=rev
Log:
Merging r258249:
r258249 | ericwf | 2016-01-19 16:42:10 -0700 (Tue, 19 Jan 2016) | 7 lines
Author: ericwf
Date: Thu Jan 21 19:13:27 2016
New Revision: 258470
URL: http://llvm.org/viewvc/llvm-project?rev=258470&view=rev
Log:
Merging r258277:
r258277 | ericwf | 2016-01-19 20:04:50 -0700 (Tue, 19 Jan 2016) | 1 line
F
Hi Hans,
CC Marshall
FYI All my pending libc++ and libc++abi commits have been pushed to the
release_38 branch.
/Eric
On Thu, Jan 21, 2016 at 1:51 PM, Eric Fiselier wrote:
> I'll merge all my commits tonight. Thanks Hans.
>
> /Eric
>
> On Wed, Jan 20, 2016 at 10:38 AM, Hans Wennborg wrote:
>
george.burgess.iv updated this revision to Diff 45622.
george.burgess.iv added a comment.
- Rebased
- Removed bits that were already upstreamed as part of
http://reviews.llvm.org/D14877
- Added support for LLVM's `allocsize` attribute (under review at
http://reviews.llvm.org/D14933 )
http://re
Author: samsonov
Date: Thu Jan 21 19:35:45 2016
New Revision: 258476
URL: http://llvm.org/viewvc/llvm-project?rev=258476&view=rev
Log:
[Docs] Slightly update LSan documentation.
Modified:
cfe/trunk/docs/AddressSanitizer.rst
cfe/trunk/docs/LeakSanitizer.rst
Modified: cfe/trunk/docs/Addres
nick.sumner created this revision.
nick.sumner added reviewers: bkramer, rsmith.
nick.sumner added a subscriber: cfe-commits.
Allow C style casts of enums to be printed correctly when the incoming
PrintingPolicy suppresses tags. This can happen, when casts to enums occur
during the initializatio
kromanova updated this revision to Diff 45632.
kromanova marked an inline comment as done.
kromanova added a comment.
Updated patch to address Craig's comments.
Repository:
rL LLVM
http://reviews.llvm.org/D16177
Files:
lib/Headers/f16cintrin.h
test/CodeGen/f16c-builtins.c
Index: test/Co
EricWF added a comment.
In http://reviews.llvm.org/D12354#331776, @dexonsmith wrote:
> This patch looks correct to me. Is there any reason it wasn't committed?
I was concerned about using a function-local static in the library headers, I
don't think libc++ does that anywhere else and I wanted
kromanova marked an inline comment as done.
Comment at: lib/Headers/f16cintrin.h:47
@@ -34,1 +46,3 @@
+
+
#define _mm_cvtps_ph(a, imm) __extension__ ({ \
craig.topper wrote:
> Can we do something like this to remove the last temporary?
>
> #define _cvtss_sh(a, i
nick.sumner created this revision.
nick.sumner added reviewers: bkramer, rsmith.
nick.sumner added a subscriber: cfe-commits.
Allow nested variable declarations using suppressed tags.
This is the logical conclusion of a handful of patches needed to correctly
print types in nested declarations and
kromanova updated this revision to Diff 45635.
kromanova marked an inline comment as done.
kromanova added a comment.
I further simplified the macros by removing the statement for the define that I
added (_cvtss_sh) and for the one that was there before (_mm_cvtps_ph).
I also formatted __DEFAULT
silvas added a comment.
This needs tests showing that the IR gen/use passes get run. Maybe use
-debug-pass=Structure like test/CodeGen/thinlto_backend.c?
My biggest concern is the naming and user visible parts. I can't come up with
anything better than `-fprofile-ir-instr` TBH. Overall, from a
silvas added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.def:108
@@ -107,2 +107,3 @@
///< execution counts to use with PGO.
+CODEGENOPT(ProfileIRInstr, 1, 0) ///< IR level code PGO instrumentation and
use.
CODEGENOP
kromanova added a comment.
Craig, do you think it's necessary to make the tests more fancy by checking how
the vector is initialized before the builtin invocation and/or that one element
is extracted from the vector after the builtin returned a value? It will add
additional 10-15 check lines to
Ok, will do
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
22.01.2016 0:10, Hans Wennborg пишет:
> Jack suggested (https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that
> this should be merged to 3.8.
>
> Alexey, you're the code owner here. OK for merging? If yes,
Later today I will post another fix, that will fix all 'sections'
related troubles, including this one. So I don't think it is necessary
to merge it
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
22.01.2016 0:10, Hans Wennborg пишет:
> Jack suggested (https://ll
silvas added a comment.
@slingn and I had a discussion offline about the potential names and came up
with some ideas, but none is a clear winner.
Overall, my feeling is that from a user's perspective, the frontend stuff is
probably best referred to as "coverage-based". It's not as clear for the
silvas added a comment.
@bogner btw, did you say that at Apple you guys have a requirement of
supporting existing profdata? I.e. users can pass older profdata to a newer
compiler?
Realistically, it would be nice if our PGO offering defaulted to the IR stuff
(since it seems like it is going to
dcoughlin abandoned this revision.
dcoughlin added a comment.
Abandoning because the test-case removal was incorporated into
http://reviews.llvm.org/D5023.
http://reviews.llvm.org/D5031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
silvas added a comment.
For the preview of all the changes, can you please put that in a separate patch
from this one?
Repository:
rL LLVM
http://reviews.llvm.org/D15999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
kromanova added a comment.
In http://reviews.llvm.org/D15999#333173, @silvas wrote:
> For the preview of all the changes, can you please put that in a separate
> patch from this one?
Done.
See http://reviews.llvm.org/D16442
Repository:
rL LLVM
http://reviews.llvm.org/D15999
_
arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: cfe-commits.
Keep the one still used by libclc that works
around for now.
Emit the new amdgcn intrinsic name if not targeting r600,
in which case the old AMDGPU name is still used.
http://reviews.llvm.
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D16385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after addressing the `IncompleteClass` comment.
Thanks for the patch!
Comment at: test/std/utilities/meta/meta.rel/is_convertible.pass.cpp:217
@@ -209,1 +216,3 @@
+/
> On 2016-Jan-21, at 17:59, Eric Fiselier wrote:
>
> EricWF added a comment.
>
> In http://reviews.llvm.org/D12354#331776, @dexonsmith wrote:
>
>> This patch looks correct to me. Is there any reason it wasn't committed?
>
>
> I was concerned about using a function-local static in the librar
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
I agree that the vector initialization code will be prone to changing. I think
what you have is fine.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D16177
__
On Thu, Jan 21, 2016 at 10:35 PM, Duncan P. N. Exon Smith <
dexonsm...@apple.com> wrote:
>
> > On 2016-Jan-21, at 17:59, Eric Fiselier wrote:
> >
> > EricWF added a comment.
> >
> > In http://reviews.llvm.org/D12354#331776, @dexonsmith wrote:
> >
> >> This patch looks correct to me. Is there any
Author: ericwf
Date: Fri Jan 22 00:25:47 2016
New Revision: 258491
URL: http://llvm.org/viewvc/llvm-project?rev=258491&view=rev
Log:
Add __uncvref type for use in later patches
Modified:
libcxx/trunk/include/type_traits
Modified: libcxx/trunk/include/type_traits
URL:
http://llvm.org/viewvc/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258492: 2 missing intrinsics _cvtss_sh and _mm_cvtps_ph were
added to the intrinsics… (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D16177?vs=45635&id=45650#toc
Repository:
Author: kromanova
Date: Fri Jan 22 00:50:50 2016
New Revision: 258492
URL: http://llvm.org/viewvc/llvm-project?rev=258492&view=rev
Log:
2 missing intrinsics _cvtss_sh and _mm_cvtps_ph were added to the intrinsics
header f16intrin.h
Differential Revision: http://reviews.llvm.org/D16177
Modified:
Author: dcoughlin
Date: Fri Jan 22 01:08:06 2016
New Revision: 258493
URL: http://llvm.org/viewvc/llvm-project?rev=258493&view=rev
Log:
[analyzer] Update SATestBuild.py to handle spaces in paths.
The Jenkins workspace on the new Green Dragon builder for the static analyzer
has spaces
in its path
EricWF added a comment.
Overall the patch looks good but I have a few concerns.
> - If argument.first can be trivially converted to key_type, don't alloc.
I'm concerned with this part of the change because:
- The `is_trivially_*` traits are often not available and can sometimes blow up.
- It a
EricWF added a comment.
> - Did I successfully match the coding style? (I'm kind of lost without
> clang-format TBH.)
The style looks pretty good. I'll comment on any nits I have.
> - Should I separate the change to __construct_node_hash() into a separate
> prep commit? (I would if this were
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: mclow.lists.
EricWF added a comment.
Adding @mclow.lists as a reviewer.
http://reviews.llvm.org/D16360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
rsmith added inline comments.
Comment at: lib/AST/StmtPrinter.cpp:132
@@ -131,2 +131,3 @@
SubPolicy.SuppressSpecifiers = false;
+ SubPolicy.SuppressTag = false;
Decl::printGroup(Decls.data(), Decls.size(), OS, SubPolicy, IndentLevel);
Maybe we should instea
101 - 140 of 140 matches
Mail list logo
