Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

djasper added a comment. Ping. What's the state of this? http://reviews.llvm.org/D12407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

AndyG added a comment. Richard, David, Sorry, I've added you as reviewers by proximity to recent relevant changes in SemaChecking.cpp. Hope you don't mind. Please tell me who to redirect to, if there are more applicable reviewers. Cheers Andy http://reviews.llvm.org/D15636 _

[clang-tools-extra] r256142 - Fix a false positive case in ContainerSizeEmpty check (PR25893).

Author: xazax Date: Mon Dec 21 03:43:52 2015 New Revision: 256142 URL: http://llvm.org/viewvc/llvm-project?rev=256142&view=rev Log: Fix a false positive case in ContainerSizeEmpty check (PR25893). Modified: clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp clang-t

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

I think we'll want somebody to find out whether there are simpler ways to implement this. On Mon, Dec 21, 2015, 9:16 AM Daniel Jasper wrote: > djasper added a comment. > > Ping. What's the state of this? > > > http://reviews.llvm.org/D12407 > > > > ___

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

klimek added a comment. I think we'll want somebody to find out whether there are simpler ways to implement this. http://reviews.llvm.org/D12407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

RE: r255281 - Do not generate DW_TAG_imported_module for anonymous namespaces (even nested) for all the platforms except PS4.

Hi David, Thank you so much for the review. I copied and pasted the diff file. Let me know if it’s OK to commit. >> Could/should this ^ just be: Opts.DebugExplicitImport = Triple.isPS4CPU(); ? Done. >> Extra semicolon here ^ Done. >> And is there any reason not to just use nullptr here and els

r256146 - [Driver] Pass -O* to the gold plugin via -plugin-opt

Author: jamesm Date: Mon Dec 21 04:44:36 2015 New Revision: 256146 URL: http://llvm.org/viewvc/llvm-project?rev=256146&view=rev Log: [Driver] Pass -O* to the gold plugin via -plugin-opt The gold plugin understands -O0..-O3, but these are not currently being passed to it. Modified: cfe/trunk

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

jmolloy accepted this revision. jmolloy added a reviewer: jmolloy. jmolloy added a comment. This revision is now accepted and ready to land. Hi, As we got to the bottom of why this is actually needed, I committed this with the changes suggested by Rafael in r256146. Cheers, James Repository:

[PATCH] D15686: PR25910: clang allows two var definitions with the same mangled name

andreybokhanko created this revision. andreybokhanko added reviewers: rjmccall, tra. andreybokhanko added a subscriber: cfe-commits. This patch fixes incorrect behavior described in PR25910. It is essentially the same stuff as in http://reviews.llvm.org/D11297, just for variables, not functions.

r256148 - clang-format: Extend detection of the "main" #include to use the filename

Author: djasper Date: Mon Dec 21 06:14:17 2015 New Revision: 256148 URL: http://llvm.org/viewvc/llvm-project?rev=256148&view=rev Log: clang-format: Extend detection of the "main" #include to use the filename Before, the first (non-system) header in a file was considered to be the main include. Th

r256150 - [scan-view] replace deprecated optparse with argparse

Author: alexfh Date: Mon Dec 21 06:19:13 2015 New Revision: 256150 URL: http://llvm.org/viewvc/llvm-project?rev=256150&view=rev Log: [scan-view] replace deprecated optparse with argparse Summary: scan-view migrated from optparse deprecated Python module to its replacement (argparse) and resolved

Re: [PATCH] D15370: [scan-view] replace deprecated optparse with argparse

This revision was automatically updated to reflect the committed changes. Closed by commit rL256150: [scan-view] replace deprecated optparse with argparse (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D15370?vs=42636&id=43358#toc Repository: rL LLVM http://reviews.l

Re: [PATCH] D15685: [clang-tidy] introducing cppcoreguidelines-enum-all-caps check

alexfh added a comment. There's already the readability-identifier-naming check that is highly configurable. It might miss the "use any naming style except for this one" functionality, but I'd prefer it to be add

Re: [PATCH] D15686: PR25910: clang allows two var definitions with the same mangled name

andreybokhanko added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:1235-1236 @@ -1235,8 +1234,4 @@ // different type. -// FIXME: Support for variables is not implemented yet. -if (isa(D.getDecl())) - GV = cast(GetAddrOfGlobal(D, /*IsForDefinition=*/

r256153 - clang-format: Only try to find the "main" include in the first block of

Author: djasper Date: Mon Dec 21 07:40:49 2015 New Revision: 256153 URL: http://llvm.org/viewvc/llvm-project?rev=256153&view=rev Log: clang-format: Only try to find the "main" include in the first block of includes. Modified: cfe/trunk/lib/Format/Format.cpp cfe/trunk/unittests/Format/Sort

r256154 - clang-format: [JS] Change Google-style default for aligning operands.

Author: djasper Date: Mon Dec 21 07:52:19 2015 New Revision: 256154 URL: http://llvm.org/viewvc/llvm-project?rev=256154&view=rev Log: clang-format: [JS] Change Google-style default for aligning operands. The style guide allows both, but apparently, this is the more dominant use. Modified: cf

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier added a comment. Ping. I promise this is fairly straight forward. :) http://reviews.llvm.org/D15195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15685: [clang-tidy] introducing cppcoreguidelines-enum-all-caps check

omtcyf0 created this revision. omtcyf0 added reviewers: alexfh, chapuni, klimek. omtcyf0 added a subscriber: cfe-commits. This patch introduces cppcoreguidelines-enum-all-caps, which flags all ALL_CAPS enumerations. As written in C++ Core Guidelines: enumerations should not be named using ALL_C

Re: [PATCH] D15664: Teaches clang about Exynos-M1

MinSeongKIM updated this revision to Diff 43354. MinSeongKIM added a comment. Herald added a subscriber: aemerson. Code rewritten http://reviews.llvm.org/D15664 Files: lib/Basic/Targets.cpp lib/Driver/Tools.cpp test/CodeGen/arm-target-features.c test/Driver/aarch64-cpus.c test/Driver/

Re: [PATCH] D15664: Teaches clang about Exynos-M1

christof added a comment. LGTM. But since this is my first review, I would like somebody else to sign off on this as well. http://reviews.llvm.org/D15664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

DmitryPolukhin added a comment. Friendly ping. I don't think this change makes APCS mode worse. As an alternative I could return to the variant that doesn't change anything for APCS case. Please let me know if APCS case must be resolved and TODO is not enough for committing this change. http

Re: [PATCH] D14629: [analyzer] Configuration file for scan-build.

ayartsev added a comment. Ping http://reviews.llvm.org/D14629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15691: [OpenCL] Improving OpenCL function pointer error checking to catch lone function designator

neil.hickey created this revision. neil.hickey added a reviewer: cfe-commits. An undecorated function designator implies taking the address of a function, which is illegal in OpenCL. Implementing a check for this earlier to allow the error to be reported even in the presence of other more obviou

Re: [PATCH] D15664: Teaches clang about Exynos-M1

t.p.northover added a subscriber: t.p.northover. t.p.northover accepted this revision. t.p.northover added a reviewer: t.p.northover. t.p.northover added a comment. Looks fine to me too. Thanks! Tim. http://reviews.llvm.org/D15664 ___ cfe-commits m

r256170 - clang-format: Only consider the first #include that looks right to be

Author: djasper Date: Mon Dec 21 11:28:24 2015 New Revision: 256170 URL: http://llvm.org/viewvc/llvm-project?rev=256170&view=rev Log: clang-format: Only consider the first #include that looks right to be the main #include. Modified: cfe/trunk/lib/Format/Format.cpp cfe/trunk/unittests/Form

Re: [PATCH] D14354: Add new compiler flag to enable the generation of dwarf accelerator tables

probinson added a comment. The patch to expose debugger tuning to Clang was finished in r256104. If you use the new -glldb option to clang, you should get these accelerator tables. I'm assuming you're using LLDB because I don't think any other debugger makes use of those tables, although that

Re: [PATCH] D15674: [CodeGen] Fix assignments of inline layouts into the byref structure

rjmccall added a comment. You don't need a CodeGenFunction for this; just use llvm::ConstantExpr::getBitCast. Please document the requirement that this returns an i8* in CGObjCRuntime.h. http://reviews.llvm.org/D15674 ___ cfe-commits mailing list

Re: [PATCH] D15674: [CodeGen] Fix assignments of inline layouts into the byref structure

vsk updated this revision to Diff 43384. vsk added a comment. - Update patch according to John's comments. http://reviews.llvm.org/D15674 Files: lib/CodeGen/CGObjCMac.cpp lib/CodeGen/CGObjCRuntime.h test/CodeGenObjCXX/blocks.mm Index: test/CodeGenObjCXX/blocks.mm

r256175 - clang-format: Properly set the BlockKind for more blocks.

Author: djasper Date: Mon Dec 21 12:31:15 2015 New Revision: 256175 URL: http://llvm.org/viewvc/llvm-project?rev=256175&view=rev Log: clang-format: Properly set the BlockKind for more blocks. Before: void f() { struct Dummy { }; f(); } After: void f() { struct Dummy {}; f();

Re: [PATCH] D15674: [CodeGen] Fix assignments of inline layouts into the byref structure

rjmccall added a comment. Thank you, that's great. LGTM. http://reviews.llvm.org/D15674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15674: [CodeGen] Fix assignments of inline layouts into the byref structure

vsk added a comment. Thanks for the review. Committed r256185 http://reviews.llvm.org/D15674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14877: Fix ICE on lowering of constexpr vector splats

george.burgess.iv added a comment. Ping :) http://reviews.llvm.org/D14877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r256185 - [CodeGen] Fix assignments of inline layouts into the byref structure

Author: vedantk Date: Mon Dec 21 13:30:37 2015 New Revision: 256185 URL: http://llvm.org/viewvc/llvm-project?rev=256185&view=rev Log: [CodeGen] Fix assignments of inline layouts into the byref structure When using blocks, a byref structure is created to represent the closure. The "byref.layout" f

r256186 - Revert "[CodeGen] Fix assignments of inline layouts into the byref structure"

Author: vedantk Date: Mon Dec 21 13:43:25 2015 New Revision: 256186 URL: http://llvm.org/viewvc/llvm-project?rev=256186&view=rev Log: Revert "[CodeGen] Fix assignments of inline layouts into the byref structure" This reverts commit r256185. It breaks CodeGenObjC/fragile-arc.m. Modified: cfe/

r256190 - Reapply "[CodeGen] Fix assignments of inline layouts into the byref structure"

Author: vedantk Date: Mon Dec 21 14:21:15 2015 New Revision: 256190 URL: http://llvm.org/viewvc/llvm-project?rev=256190&view=rev Log: Reapply "[CodeGen] Fix assignments of inline layouts into the byref structure" When using blocks, a byref structure is created to represent the closure. The "byref

r256191 - Tweak myriad-toolchain test.

Author: jyknight Date: Mon Dec 21 14:30:49 2015 New Revision: 256191 URL: http://llvm.org/viewvc/llvm-project?rev=256191&view=rev Log: Tweak myriad-toolchain test. The test failed when run on a SPARC host, since it was finding the native gcc installation by accident. Modified: cfe/trunk/test

[PATCH] D15699: [cfi] Cross-DSO CFI diagnostic mode (clang part)

eugenis created this revision. eugenis added reviewers: pcc, kcc. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. - Runtime diagnostic data for cfi-icall changed to match the rest of cfi checks - Layout of all CFI diagnostic data changed to put Kin

r256204 - [clang-cl] Add support for /Brepro

Author: majnemer Date: Mon Dec 21 16:09:34 2015 New Revision: 256204 URL: http://llvm.org/viewvc/llvm-project?rev=256204&view=rev Log: [clang-cl] Add support for /Brepro The /Brepro flag controls whether or not the compiler should embed timestamps into the object file. Object files which do not

Re: [PATCH] D12299: [libcxx] Fix for ALL undefined behavior in .

EricWF added a comment. Ping. http://reviews.llvm.org/D12299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15319: [Sema] Don't accept e.g. "(int *)(long)&x" as a constant expression if x is in address space != 0.

mjacob added a comment. ping http://reviews.llvm.org/D15319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r256216 - [WebAssembly] Remove the -target command-line flag from the ld commandline.

Author: djg Date: Mon Dec 21 17:30:41 2015 New Revision: 256216 URL: http://llvm.org/viewvc/llvm-project?rev=256216&view=rev Log: [WebAssembly] Remove the -target command-line flag from the ld commandline. This flag isn't needed, or permitted, with the "ld" flavor of lld. Also, add a basic ld co

[PATCH] D15704: Add some overlooked optnone tests, and tighten up an existing test

probinson created this revision. probinson added a reviewer: aaron.ballman. probinson added a subscriber: cfe-commits. Found some tests we wrote back in the day, but which never made it upstream. optnone-and-attributes.cpp is a more thorough exercise of optnone attribute interaction than we have

Re: [PATCH] D15613: Fix ARM __cxa_end_cleanup() and gc-sections.

echristo added a comment. Sure, I don't care enough either way :) -eric http://reviews.llvm.org/D15613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15705: Adding a scripted test for PR25717

ygao created this revision. ygao added subscribers: cfe-commits, rsandifo, majnemer, aaron.ballman. Hi, I am trying to add a test for PR25717. The test itself is fairly straight-forward: it generates a large .c temporary file on the fly and then runs the preprocessor over the generated file to m

Re: [PATCH] D15705: Adding a scripted test for PR25717

ygao added inline comments. Comment at: test/Preprocessor/bigoutput.py:7 @@ +6,3 @@ + +f = open("bigoutput.c", "wb") +for i in range(0, 15000): For example, it would be nice to use %t as the temporary file name (so lit will fill in with a generated name) instead

r256228 - Use -no-canonical-prefixes to make sure binaries names are easier to match.

Author: echristo Date: Mon Dec 21 19:45:45 2015 New Revision: 256228 URL: http://llvm.org/viewvc/llvm-project?rev=256228&view=rev Log: Use -no-canonical-prefixes to make sure binaries names are easier to match. Modified: cfe/trunk/test/Driver/wasm-toolchain.c Modified: cfe/trunk/test/Driver/

Re: [PATCH] D12502: [libcxx] Better constain tuples constructors -- Fix PR23256 and PR22806

ldionne added a comment. This LGTM. I also just confirmed that it fixes the original issue in Hana that caused me to report PR22806. http://reviews.llvm.org/D12502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

r256230 - Pull out a bunch of duplicated option handling code into its own

Author: echristo Date: Mon Dec 21 21:12:34 2015 New Revision: 256230 URL: http://llvm.org/viewvc/llvm-project?rev=256230&view=rev Log: Pull out a bunch of duplicated option handling code into its own function and use for the targets that can easily support it. Modified: cfe/trunk/lib/Driver/T

[PATCH] D15709: [X86] Support 'interrupt' attribute for x86

ABataev created this revision. ABataev added reviewers: aaron.ballman, rjmccall. ABataev added a subscriber: cfe-commits. This attribute may be attached to a function definition and instructs the backend to generate appropriate function entry/exit code so that it can be used directly as an interru