Re: r255848 - [WebAssembly] Initial linking support.

2015-12-16 Thread Rafael EspĂ­ndola via cfe-commits
testcase? Also, this is passing -target to ld, which is not a valid option. Cheers, Rafael On 16 December 2015 at 18:30, Dan Gohman via cfe-commits wrote: > Author: djg > Date: Wed Dec 16 17:30:41 2015 > New Revision: 255848 > > URL: http://llvm.org/viewvc/llvm-project?rev=255848&view=rev > Lo

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

2015-12-16 Thread Easwaran Raman via cfe-commits
eraman updated this revision to Diff 43089. eraman added a comment. Updated the test case. Repository: rL LLVM http://reviews.llvm.org/D15163 Files: lib/CodeGen/CodeGenModule.cpp test/Profile/Inputs/max-function-count.proftext test/Profile/max-function-count.c Index: test/Profile/max-

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

2015-12-16 Thread Easwaran Raman via cfe-commits
eraman added a comment. Justin, does this patch look ok? Repository: rL LLVM http://reviews.llvm.org/D15163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15598: [Driver] Make AddCXXStdlibLibArgs responsible for handling -static-libstdc++.

2015-12-16 Thread Alexey Samsonov via cfe-commits
samsonov created this revision. samsonov added reviewers: rafael, compnerd. samsonov added a subscriber: cfe-commits. After this change, AddCXXStdlibLibArgs will check the presence of -static-libstdc++ flag and, if necessary, wrap -lc++/-lstdc++ in -Bstatic/-Bdynamic to force static linking of C++

Re: [PATCH] D15448: [analyzer] SVal Visitor.

2015-12-16 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Are you saying that we need to rename "SymbolValKind" to "SymbolKind"? That would probably be a tiny change. http://reviews.llvm.org/D15448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

2015-12-16 Thread Kostya Serebryany via cfe-commits
kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D15363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: r255848 - [WebAssembly] Initial linking support.

2015-12-16 Thread Dan Gohman via cfe-commits
On Wed, Dec 16, 2015 at 5:20 PM, Rafael EspĂ­ndola < rafael.espind...@gmail.com> wrote: > testcase? > Also, this is passing -target to ld, which is not a valid option. > This patch is mainly setting up some minimal infrastructure. The actual link command-line will need additional changes to be us

[PATCH] D15599: [CodeGen] Fix a crash that occurs when attribute "naked" is attached to a c++ member function

2015-12-16 Thread Akira Hatanaka via cfe-commits
ahatanak created this revision. ahatanak added a subscriber: cfe-commits. clang crashes when it compiles a member function or a lambda is marked as "naked": struct S { __attribute__((naked)) S() {} } To fix this bug, this patch defines a function that cleans up the naked function removing al

r255875 - Add QualType case to operator< for DynTypedNode.

2015-12-16 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Wed Dec 16 22:46:48 2015 New Revision: 255875 URL: http://llvm.org/viewvc/llvm-project?rev=255875&view=rev Log: Add QualType case to operator< for DynTypedNode. This allows sorting DynTypedNode's which are QualType's since QualType does not have memoization. Modified: cf

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

2015-12-16 Thread Justin Bogner via cfe-commits
Easwaran Raman writes: > eraman added a comment. > > Justin, does this patch look ok? Sure. > > Repository: > rL LLVM > > http://reviews.llvm.org/D15163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

2015-12-16 Thread Alexey Bataev via cfe-commits
ABataev added a comment. In http://reviews.llvm.org/D10599#312135, @rjmccall wrote: > Richard should really be the one to sign off on this, since he's been > managing the review so far. > > I am curious why we decided to handle this separately instead of treating it > as a different attribute s

r255879 - [OPENMP] Fix for http://llvm.org/PR25142: openmp: Assertion failed: DD && "queried property of class with no definition", file AST/DeclCXX.h

2015-12-16 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Dec 17 00:55:08 2015 New Revision: 255879 URL: http://llvm.org/viewvc/llvm-project?rev=255879&view=rev Log: [OPENMP] Fix for http://llvm.org/PR25142: openmp: Assertion failed: DD && "queried property of class with no definition", file AST/DeclCXX.h Added processing for t

Re: [PATCH] D14441: [OpenCL] Pipe types support.

2015-12-16 Thread Alexey Bader via cfe-commits
bader abandoned this revision. bader added a comment. New version of this patch was uploaded by pxli168 at http://reviews.llvm.org/D15603. http://reviews.llvm.org/D14441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

<    1   2