Re: [PATCH] D15534: [CUDA] renamed cuda_runtime.h wrapper to __clang_cuda_runtime_wrapper.h

2015-12-15 Thread Jason Henline via cfe-commits
jhen added a subscriber: jhen. Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:95 @@ -78,3 +94,3 @@ #define __CUDACC__ #include_next "cuda_runtime.h" Now that the name of this header has been changed, would it be appropriate to change this #include_nex

Re: [PATCH] D15448: [analyzer] SVal Visitor.

2015-12-15 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Sorry, I forgot to read the description before commenting; I see it is intended to be used not only for debugging purposes:) http://reviews.llvm.org/D15448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

r255744 - Print qualified display names when emitting CodeView

2015-12-15 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Dec 15 20:04:40 2015 New Revision: 255744 URL: http://llvm.org/viewvc/llvm-project?rev=255744&view=rev Log: Print qualified display names when emitting CodeView This is what debuggers expect. Words towards fixing PR21528. Added: cfe/trunk/test/CodeGenCXX/debug-info-cod

Re: [PATCH] D15227: [analyzer] Valist checkers.

2015-12-15 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Looks good overall; comments below. Please, provide more information on real world code evaluation. Which codebases this has been tested on? What was the false positive rate? How many real bugs were found/fixed? What is the criteria for taking it out of alpha? Pleas

r255753 - [CodeGen] Use llvm::CmpInst::Predicate instead of unsigned for parameter types in EmitCompare to eliminate some later explicit casts. NFC.

2015-12-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Dec 16 00:24:28 2015 New Revision: 255753 URL: http://llvm.org/viewvc/llvm-project?rev=255753&view=rev Log: [CodeGen] Use llvm::CmpInst::Predicate instead of unsigned for parameter types in EmitCompare to eliminate some later explicit casts. NFC. Modified: cfe/trunk

r255754 - [Objective-c] Fix a crash that occurs when ObjCTypeParamList::back() is

2015-12-15 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Wed Dec 16 00:25:38 2015 New Revision: 255754 URL: http://llvm.org/viewvc/llvm-project?rev=255754&view=rev Log: [Objective-c] Fix a crash that occurs when ObjCTypeParamList::back() is called on an empty list. This commit makes Parser::parseObjCTypeParamListOrProtocolRefs re

Re: [PATCH] D15463: [Objective-c] Fix a crash

2015-12-15 Thread Akira Hatanaka via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255754: [Objective-c] Fix a crash that occurs when ObjCTypeParamList::back() is (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D15463?vs=42560&id=42962#toc Repository: rL LL

Re: [PATCH] D15463: [Objective-c] Fix a crash

2015-12-15 Thread Akira Hatanaka via cfe-commits
Thank you for the review. I added a test to check the "redeclaration of type parameter" error message and committed it as r255754. On Tue, Dec 15, 2015 at 4:55 PM, Justin Bogner wrote: > Akira Hatanaka writes: > > On Tue, Dec 15, 2015 at 12:55 PM, Justin Bogner > > wrote: > > > >> Akira Hatana

Re: [PATCH] D13796: [libcxx] Use "-stdlib=libc++" when possible instead of '-nodefaultlibs' in the test suite.

2015-12-15 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: test/libcxx/test/config.py:364 @@ +363,3 @@ +deduced_use_stdlib_eq_libcxx = (self.cxx.isClang() and +cxx_abi == 'none' and +not use_llvm_unwinder)

<    1   2