zaks.anna added a comment.
Hi Laszlo,
Comment at: tools/scan-build-py/libear/ear.c:281
@@ +280,3 @@
+
+DLSYM(func, fp, "execve");
+
This is not the recommended way of interposing on Darwin. All you need to do is
provide your function, which can call the fun
rsmith added a subscriber: rsmith.
Comment at: test/CodeGen/ms-inline-asm.c:536
@@ -535,3 +535,3 @@
}
- // CHECK-LABEL: define void @label1
+ // CHECK: define void @label1() [[ATTR1:#[0-9]+]] {
// CHECK: call void asm sideeffect inteldialect
"{{.*}}__MSASMLABEL_.1__label:
Author: jtsoftware
Date: Wed Dec 9 19:33:09 2015
New Revision: 255199
URL: http://llvm.org/viewvc/llvm-project?rev=255199&view=rev
Log:
There were problems if a relative path is used for an include path, the path
will be normalized to ./xxx. I don't know how to test this in a way that will
wor
hans added inline comments.
Comment at: lib/CodeGen/CGStmt.cpp:2005
@@ -1998,3 +2004,3 @@
/* IsAlignStack */ false, AsmDialect);
llvm::CallInst *Result = Builder.CreateCall(IA, Args);
Result->addAttribute(llvm::AttributeSet::FunctionIndex,
-
Author: hans
Date: Wed Dec 9 19:38:04 2015
New Revision: 255201
URL: http://llvm.org/viewvc/llvm-project?rev=255201&view=rev
Log:
Mark MS inline ASM 'nodplicate' it it has labels (PR23715)
Duplicating it can lead to labels being defined twice.
Differential revision: http://reviews.llvm.org/D153
kromanova updated the summary for this revision.
kromanova set the repository for this revision to rL LLVM.
kromanova updated this revision to Diff 42364.
kromanova added a comment.
I have made all the changes that Richard suggested. Sorry for the delay, got
distracted by other tasks.
Anything el
Author: ygao
Date: Wed Dec 9 19:37:18 2015
New Revision: 255200
URL: http://llvm.org/viewvc/llvm-project?rev=255200&view=rev
Log:
Fix a typo in the clang user manual.
-fmax-unknown-pointer-align => -fmax-type-align
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManua
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255201: Mark MS inline ASM 'nodplicate' it it has labels
(PR23715) (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D15399?vs=42353&id=42365#toc
Repository:
rL LLVM
http://review
EricWF added a reviewer: EricWF.
EricWF added a comment.
Sorry I'm late to this party. Please let me know if my concerns have already
been discussed.
First, thanks for taking on all this work. Getting the test suite passing
without exceptions is a tall order.
My two cents:
- I like the approa
martell added a comment.
hi ismail,
I will tidy up for review closer towards the weekend where i can work on out of
work stuff
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
eugenis added a dependency: D12502: [libcxx] Better constain tuples
constructors -- Fix PR23256 and PR22806.
eugenis added a comment.
Note, this breaks tuple_cat.pass.cpp test.
With -O0, replacing always_inline with internal_linkage results in less
optimization being done (namely, no inlining h
eugenis created this revision.
eugenis added reviewers: EricWF, mclow.lists.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
This is a follow-up to r252385.
For some reason, I missed a lot of cases when the visibility attribute was
applied to the
eugenis added a dependency: D15404: Cleanup: move visibility/linkage attributes
to the first declaration (part 2)..
eugenis added a comment.
This change depends on http://reviews.llvm.org/D15404.
Repository:
rL LLVM
http://reviews.llvm.org/D14411
__
rsmith added a subscriber: rsmith.
Comment at: include/__config:237
@@ +236,3 @@
+#if __has_attribute(internal_linkage)
+#define _LIBCPP_INLINE_VISIBILITY __attribute__ ((internal_linkage))
+#else
Use `__internal_linkage__` here. Users are allowed to #define
`int
EricWF added a comment.
Why does this depend on http://reviews.llvm.org/D15404?
Repository:
rL LLVM
http://reviews.llvm.org/D14411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
This looks good to me.
Once we have this in place we can think about factoring the debug-specific
flags out of `CodeGenOpts` into some kind of `DebugInfoOpts`, to be configured
by whatever de
EricWF added a comment.
In http://reviews.llvm.org/D14411#306716, @EricWF wrote:
> Why does this depend on http://reviews.llvm.org/D15404?
Woops, I meant the tuple patch but I see the other comment now. I'm curious as
to how inlininging ends up affecting which overload's SFINAE are evaluated.
kromanova added a comment.
> > Once we have this in place we can think about factoring the debug-specific
> > flags out of CodeGenOpts into some kind of DebugInfoOpts, to be configured
> > by whatever debugger tuning mechanism we end up with.
>
Good idea!
Thank you for such prompt review.
Ka
Would you mind uploading the clang-side of this patch to phabricator? It
will make it a little easier for me to perform a review. See
http://llvm.org/docs/Phabricator.html for more details.
On Mon, Nov 30, 2015 at 9:13 AM, Louis Dionne via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
kromanova accepted this revision.
kromanova added a reviewer: kromanova.
kromanova added a comment.
This revision is now accepted and ready to land.
This was committed in r238386 but I forgot to close the review.
http://reviews.llvm.org/D8762
___
cf
Author: tstellar
Date: Wed Dec 9 21:53:42 2015
New Revision: 255217
URL: http://llvm.org/viewvc/llvm-project?rev=255217&view=rev
Log:
Creating release candidate final from release_371 branch
Added:
libunwind/tags/RELEASE_371/final/ (props changed)
- copied from r255216, libunwind/bra
Author: tstellar
Date: Wed Dec 9 21:53:26 2015
New Revision: 255210
URL: http://llvm.org/viewvc/llvm-project?rev=255210&view=rev
Log:
Creating release candidate final from release_371 branch
Added:
libcxx/tags/RELEASE_371/final/ (props changed)
- copied from r255209, libcxx/branches/
Author: tstellar
Date: Wed Dec 9 21:53:28 2015
New Revision: 255211
URL: http://llvm.org/viewvc/llvm-project?rev=255211&view=rev
Log:
Creating release candidate final from release_371 branch
Added:
libcxxabi/tags/RELEASE_371/final/ (props changed)
- copied from r255210, libcxxabi/bra
ABataev marked an inline comment as done.
Comment at: lib/Sema/SemaPseudoObject.cpp:259
@@ +258,3 @@
+///
+/// If this method returns false, and the set value isn't capturable for
+/// some reason, the result of the expression will be void.
rjmccall wr
Author: abataev
Date: Wed Dec 9 22:38:18 2015
New Revision: 255218
URL: http://llvm.org/viewvc/llvm-project?rev=255218&view=rev
Log:
[MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported
correctly.
All problems described in http://llvm.org/PR25636 are implemented except
This revision was automatically updated to reflect the committed changes.
ABataev marked an inline comment as done.
Closed by commit rL255218: [MSVC] Fix for http://llvm.org/PR25636: indexed
accessor property not… (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D15174?vs
RedX2501 added a comment.
In http://reviews.llvm.org/D10833#306281, @akyrtzi wrote:
> The patch causes tests to fail, please look into it.
Where can i see the test reports? I'm having trouble running the test on my
side on windows (VS2013).
http://reviews.llvm.org/D10833
_
ABataev marked an inline comment as done.
ABataev added a comment.
Chandler, thank you very much for review!
Comment at: docs/GettingStarted.rst:58-62
@@ -57,1 +57,7 @@
+#. Checkout Libomp (required for OpenMP support) **[Optional]**:
+
+ * ``cd where-you-want-llvm-to-live``
Author: faisalv
Date: Wed Dec 9 23:36:39 2015
New Revision: 255221
URL: http://llvm.org/viewvc/llvm-project?rev=255221&view=rev
Log:
Fix PR24694 (CWG1591): Deducing array bound and element type from initializer
list
https://llvm.org/bugs/show_bug.cgi?id=24694
http://wg21.link/cwg1591
Teach Dedu
This revision was automatically updated to reflect the committed changes.
ABataev marked an inline comment as done.
Closed by commit rL255222: [OPENMP] Make -fopenmp to turn on OpenMP support by
default. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D13802?vs=38374&id=
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255223: [OPENMP] Make -fopenmp to turn on OpenMP support by
default, clang part (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D13803?vs=37574&id=42384#toc
Repository:
rL LLV
Author: abataev
Date: Wed Dec 9 23:47:10 2015
New Revision: 255223
URL: http://llvm.org/viewvc/llvm-project?rev=255223&view=rev
Log:
[OPENMP] Make -fopenmp to turn on OpenMP support by default, clang part
Patch turns on OpenMP support in clang by default after fixing OpenMP buildbots.
Differentia
RedX2501 updated this revision to Diff 42386.
RedX2501 added a comment.
Added functions to libclang.exports.
http://reviews.llvm.org/D10833
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_cursor.py
include/clang-c/Index.h
include/clang/AST/OperationKinds.h
tes
Author: compnerd
Date: Thu Dec 10 00:30:23 2015
New Revision: 255225
URL: http://llvm.org/viewvc/llvm-project?rev=255225&view=rev
Log:
libclang: correct inverted logic
The complete dtor is only emitted when there is a virtual destructor. The test
itself was incorrect, so the issue in the code wa
comex created this revision.
comex added a subscriber: cfe-commits.
When a function parameter is declared `__attribute__((cleanup))`, neither Clang
nor GCC actually executes the cleanup function, but Clang didn't warn about it.
For the sake of compatibility, add a warning rather than making the
danielmarjamaki added a comment.
In http://reviews.llvm.org/D15332#306097, @Eugene.Zelenko wrote:
> This check partially implements PR19419. Could it be extended to variables?
Yes, I don't see any technical reasons why that would not work. However
politically, some people like const variables
eugenis added a comment.
In http://reviews.llvm.org/D14411#306722, @EricWF wrote:
> In http://reviews.llvm.org/D14411#306716, @EricWF wrote:
>
> > Why does this depend on http://reviews.llvm.org/D15404?
>
>
> Woops, I meant the tuple patch but I see the other comment now. I'm curious
> as to ho
101 - 137 of 137 matches
Mail list logo
