[PATCH] D15324: [Sema] Emit warnings when comparing result of a function with `returns_nonnull` to null

2015-12-07 Thread George Burgess IV via cfe-commits
george.burgess.iv created this revision. george.burgess.iv added a reviewer: rtrieu. george.burgess.iv added a subscriber: cfe-commits. Addresses a problem brought up by Xavier here: http://permalink.gmane.org/gmane.comp.compilers.clang.devel/46163 tl;dr: We get a warning on the following code

Re: [PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

2015-12-07 Thread Alexey Bataev via cfe-commits
ABataev added a comment. I think we'd better to try to use attributes for declare target. I think it will be much easier and correct solution rather than adding a new declaration Comment at: include/clang/AST/DeclBase.h:164 @@ -163,3 +163,3 @@ /// has been declared outside

r255006 - Replace bitwise AND with logical AND in an expression that already had another logical AND. NFC

2015-12-07 Thread Craig Topper via cfe-commits
Author: ctopper Date: Tue Dec 8 00:49:15 2015 New Revision: 255006 URL: http://llvm.org/viewvc/llvm-project?rev=255006&view=rev Log: Replace bitwise AND with logical AND in an expression that already had another logical AND. NFC Modified: cfe/trunk/test/SemaCXX/constant-expression-cxx1y.cpp

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

2015-12-07 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 42140. ABataev added a comment. Update after review http://reviews.llvm.org/D15174 Files: lib/Sema/SemaPseudoObject.cpp test/CodeGenCXX/ms-property.cpp test/SemaCXX/ms-property-error.cpp test/SemaCXX/ms-property.cpp Index: lib/Sema/SemaPseudoObject

<    1   2