[PATCH] D15007: [analyzer] Improve modelling of nullptr_t in the analyzer. Fix PR25414.

xazax.hun created this revision. xazax.hun added reviewers: zaks.anna, dcoughlin. xazax.hun added subscribers: cfe-commits, dkrupp. This is a fix for https://llvm.org/bugs/show_bug.cgi?id=25414 This patch is intended to improve the modelling of std::nullptr_t. http://reviews.llvm.org/D15007 Fil

r254143 - Fix for merging decls in pragma weak

Author: amusman Date: Thu Nov 26 03:34:30 2015 New Revision: 254143 URL: http://llvm.org/viewvc/llvm-project?rev=254143&view=rev Log: Fix for merging decls in pragma weak Calling CheckFunctionDeclaration so that 2 decls for the 'weak' are merged. Differential Revision: http://reviews.llvm.org/D130

Re: [PATCH] D13048: Fix for merging decls in pragma weak

This revision was automatically updated to reflect the committed changes. Closed by commit rL254143: Fix for merging decls in pragma weak (authored by amusman). Changed prior to commit: http://reviews.llvm.org/D13048?vs=35348&id=41216#toc Repository: rL LLVM http://reviews.llvm.org/D13048

Re: [PATCH] D14919: Fix IssueHash generation

seaneveson added a comment. In http://reviews.llvm.org/D14919#296597, @o.gyorgy wrote: > I did not create a test checker for the NormalizeLine error in the patch. > Should I add a test checker for this? I was wondering what sort of source code causes the crash, but I do think it would be good

Re: [PATCH] D14919: Fix IssueHash generation

xazax.hun added a comment. In http://reviews.llvm.org/D14919#297168, @seaneveson wrote: > I was wondering what sort of source code causes the crash, but I do think it > would be good to have a regression test. It is possible to generate bug reports without associated declaration, altough it i

Re: [PATCH] D15007: [analyzer] Improve modelling of nullptr_t in the analyzer. Fix PR25414.

NoQ added a subscriber: NoQ. NoQ added a comment. Wow, useful stuff! There's a little problem with the `shouldNotCrash()` test: the first warning on `invokeF()` on line 107 generates a sink, and the rest of the function never gets executed. It's probably a good idea to split it into three separ

Re: [PATCH] D15007: [analyzer] Improve modelling of nullptr_t in the analyzer. Fix PR25414.

xazax.hun updated this revision to Diff 41221. xazax.hun added a comment. Improved test cases. http://reviews.llvm.org/D15007 Files: lib/StaticAnalyzer/Core/RegionStore.cpp test/Analysis/nullptr.cpp Index: test/Analysis/nullptr.cpp ==

Re: [PATCH] D15007: [analyzer] Improve modelling of nullptr_t in the analyzer. Fix PR25414.

xazax.hun added a comment. In http://reviews.llvm.org/D15007#297183, @NoQ wrote: > There's a little problem with the `shouldNotCrash()` test: the first warning > on `invokeF()` on line 107 generates a sink, and the rest of the function > never gets executed. It's probably a good idea to split i

Re: [PATCH] D14872: PR25575: Make GCC 4.4+ comatible layout for packed bit-fileds of char type

DmitryPolukhin updated this revision to Diff 41222. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. Changed note text message + fixed outdated comment. http://reviews.llvm.org/D14872 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

ismail added a comment. Tested on openSUSE and it works. Thanks! http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15022: [AArch64] Add command-line options for ARMv8.2-A

olista01 created this revision. olista01 added a reviewer: t.p.northover. olista01 added a subscriber: cfe-commits. olista01 set the repository for this revision to rL LLVM. Herald added subscribers: rengolin, aemerson. This adds new values for the -march option (armv8.2a and armv8.2-a, which are

[PATCH] D15023: [AArch64] Add command-line options for Statistical

olista01 created this revision. olista01 added a reviewer: t.p.northover. olista01 added a subscriber: cfe-commits. olista01 set the repository for this revision to rL LLVM. Herald added subscribers: rengolin, aemerson. This adds the "+profile" and +noprofile" suffixes for the -march and -mcpu opt

Re: [PATCH] D15022: [AArch64] Add command-line options for ARMv8.2-A

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. This looks good, too. Tim. Repository: rL LLVM http://reviews.llvm.org/D15022 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] D15023: [AArch64] Add command-line options for Statistical

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. All obviously good stuff here too. Repository: rL LLVM http://reviews.llvm.org/D15023 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

tejohnson created this revision. tejohnson added reviewers: joker.eph, dexonsmith. tejohnson added subscribers: cfe-commits, davidxl. tejohnson added a dependency: D15024: [ThinLTO] Support for specifying function index from pass manager. Herald added a subscriber: joker.eph. Adds new option -fth

r254160 - [AArch64] Add command-line options for ARMv8.2-A

Author: olista01 Date: Thu Nov 26 09:36:42 2015 New Revision: 254160 URL: http://llvm.org/viewvc/llvm-project?rev=254160&view=rev Log: [AArch64] Add command-line options for ARMv8.2-A This adds new values for the -march option (armv8.2a and armv8.2-a, which are aliases of each other), and new suf

Re: [PATCH] D15022: [AArch64] Add command-line options for ARMv8.2-A

This revision was automatically updated to reflect the committed changes. Closed by commit rL254160: [AArch64] Add command-line options for ARMv8.2-A (authored by olista01). Changed prior to commit: http://reviews.llvm.org/D15022?vs=41243&id=41257#toc Repository: rL LLVM http://reviews.llvm

r254161 - [AArch64] Add command-line options for Statistical Profiling Extension

Author: olista01 Date: Thu Nov 26 09:38:54 2015 New Revision: 254161 URL: http://llvm.org/viewvc/llvm-project?rev=254161&view=rev Log: [AArch64] Add command-line options for Statistical Profiling Extension This adds the "+profile" and +noprofile" suffixes for the -march and -mcpu options, to allo

Re: [PATCH] D15023: [AArch64] Add command-line options for Statistical

This revision was automatically updated to reflect the committed changes. Closed by commit rL254161: [AArch64] Add command-line options for Statistical Profiling Extension (authored by olista01). Changed prior to commit: http://reviews.llvm.org/D15023?vs=41244&id=41258#toc Repository: rL LLV

[A fix related to closing C++ header file descriptors on windows]

I use clang 3.6.2 with qt creator 3.5.1 on windows 7 for parsing code in this IDE. It works well. However, I can see that clang keeps a few times some file descriptors opened on c++ header files (h files) after having parsed a cpp file (that includes these h files). The effect is that we cannot sa

Re: [PATCH] Don't crash when dumping objc_bridge_related attributes

On Wed, Nov 25, 2015 at 6:13 PM, Joe Ranieri wrote: > Clang's AST dumping currently crashes when dumping objc_bridge_related > attributes where the class method and instance method fields are left > empty. The attached patch marks the two arguments as optional and > updates TableGen to understand

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro updated this revision to Diff 41261. loladiro added a comment. Rebased and made the small suggested changes to the test cases. http://reviews.llvm.org/D13330 Files: include/clang/AST/ASTContext.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/Di

Re: [PATCH] Don't crash when dumping objc_bridge_related attributes

On Thu, Nov 26, 2015 at 11:29 AM, Aaron Ballman wrote: > On Wed, Nov 25, 2015 at 6:13 PM, Joe Ranieri wrote: >> Clang's AST dumping currently crashes when dumping objc_bridge_related >> attributes where the class method and instance method fields are left >> empty. The attached patch marks the tw

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

yaron.keren added a comment. findGccDir() can return llvm::ErrorOr and then all Base assignments happen at the same if-elseif-else: if (getDriver().SysRoot.size()) Base = getDriver().SysRoot; else if (llvm::ErrorOr GPPName = findGccDir()) Base = llvm::sys::path::parent_path(

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

joker.eph added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:308 @@ +307,3 @@ +return; + } + It does not seem to be nicely integrated within the context of this function. What about all the options set just a few line below? It is not clear if `

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro updated this revision to Diff 41265. loladiro added a comment. Add support for variable templates http://reviews.llvm.org/D13330 Files: include/clang/AST/ASTContext.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td includ

r254173 - docs: Remove references to the long-defunct LLVM_USED_LIBS

Author: bogner Date: Thu Nov 26 13:52:24 2015 New Revision: 254173 URL: http://llvm.org/viewvc/llvm-project?rev=254173&view=rev Log: docs: Remove references to the long-defunct LLVM_USED_LIBS LLVM_USED_LIBS hasn't done anything since 2012, stop telling people to set it in the docs. Modified:

[PATCH] D15029: [OpenMP] Parsing and sema support for thread_limit clause

kkwli0 created this revision. kkwli0 added reviewers: ABataev, hfinkel, sfantao, fraggamuffin, rsmith. kkwli0 added a subscriber: cfe-commits. This patch is to add parsing and sema support for thread_limit clause. http://reviews.llvm.org/D15029 Files: include/clang/AST/OpenMPClause.h include

Re: [libcxx] r254119 - Add static_assert to set/multiset/map/multimap/forward_list/deque that the allocator's value_type match the container's value_type. vector/unordered/list/string already do this.

This used to build and now doesn't: std::map, std::allocator>> m; Maybe the static assert text could say something slightly more friendly that hints at the pair's first entry having to be const? This is probably difficult to figure out unless you know this already. (Real-life version: https://

Re: [PATCH] D14325: [clang-format] Do not align assignments that aren't after the same number of commas. (Closes: 25329)

berenm updated this revision to Diff 41271. berenm added a comment. [clang-format] alignConsecutiveXXX: replace the buggy paren / braces counter with a better scope tracker. http://reviews.llvm.org/D14325 Files: lib/Format/WhitespaceManager.cpp lib/Format/WhitespaceManager.h unittests/Fo

Re: [PATCH] D14325: [clang-format] Do not align assignments that aren't after the same number of commas. (Closes: 25329)

berenm added a comment. Updated the diff with a fix for the issue reported in http://lists.llvm.org/pipermail/cfe-dev/2015-November/046057.html http://reviews.llvm.org/D14325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

r254181 - Test commit

Author: pgousseau Date: Thu Nov 26 16:08:58 2015 New Revision: 254181 URL: http://llvm.org/viewvc/llvm-project?rev=254181&view=rev Log: Test commit Remove tabs. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/CheckSe

[clang-tools-extra] r254182 - [clang-tidy] cppcoreguidelines-pro-bounds-pointer-arithmetic: ignore generated pointer arithmetic

Author: mgehre Date: Thu Nov 26 16:32:11 2015 New Revision: 254182 URL: http://llvm.org/viewvc/llvm-project?rev=254182&view=rev Log: [clang-tidy] cppcoreguidelines-pro-bounds-pointer-arithmetic: ignore generated pointer arithmetic Summary: Inside a range-based for-loop over an array, the compile

Re: [PATCH] D14582: [clang-tidy] cppcoreguidelines-pro-bounds-pointer-arithmetic: ignore generated pointer arithmetic

This revision was automatically updated to reflect the committed changes. Closed by commit rL254182: [clang-tidy] cppcoreguidelines-pro-bounds-pointer-arithmetic: ignore… (authored by mgehre). Changed prior to commit: http://reviews.llvm.org/D14582?vs=40448&id=41272#toc Repository: rL LLVM

[PATCH] D15030: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

mgehre created this revision. mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman. mgehre added a subscriber: cfe-commits. This is http://reviews.llvm.org/D13746 but instead of including , a stub is provided. This check flags all array subscriptions on static arrays and std::arrays that

[PATCH] D15031: CFG: Add CFGElement for automatic variables that leave the scope

mgehre created this revision. mgehre added reviewers: krememek, jordan_rose. mgehre added a subscriber: cfe-commits. This mimics the implementation for the implicit destructors. The generation of this scope leaving elements is hidden behind a flag to the CFGBuilder, thus it should not affect exist

[PATCH] D15032: [clang-tidy] new checker cppcoreguidelines-pro-lifetime

mgehre created this revision. mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman. mgehre added a subscriber: cfe-commits. mgehre added a dependency: D15031: CFG: Add CFGElement for automatic variables that leave the scope. This checker implements the lifetime rules presented in the pa

Re: [PATCH] D15031: CFG: Add CFGElement for automatic variables that leave the scope

mgehre added a comment. The lifetime checker that needs this is at http://reviews.llvm.org/D15032 http://reviews.llvm.org/D15031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15029: [OpenMP] Parsing and sema support for thread_limit clause

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:5220-5242 @@ -5216,2 +5219,25 @@ +static bool IsNonNegativeIntegerValue(Expr *&ValExpr, Sema &SemaRef, + OpenMPClauseKind CKind) { + if (!ValExpr->isTypeDependent() && !ValEx

Re: [PATCH] D15029: [OpenMP] Parsing and sema support for thread_limit clause

kkwli0 added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:5220-5242 @@ -5216,2 +5219,25 @@ +static bool IsNonNegativeIntegerValue(Expr *&ValExpr, Sema &SemaRef, + OpenMPClauseKind CKind) { + if (!ValExpr->isTypeDependent() && !ValExp