r252114 - [modules] If we're given a module file, via -fmodule-file=, for a module, but

2015-11-04 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Nov 4 18:54:55 2015 New Revision: 252114 URL: http://llvm.org/viewvc/llvm-project?rev=252114&view=rev Log: [modules] If we're given a module file, via -fmodule-file=, for a module, but we can't load that file due to a configuration mismatch, and implicit module building i

r252115 - [Lex] Add __has_builtin support for __make_integer_seq

2015-11-04 Thread David Majnemer via cfe-commits
Author: majnemer Date: Wed Nov 4 19:01:47 2015 New Revision: 252115 URL: http://llvm.org/viewvc/llvm-project?rev=252115&view=rev Log: [Lex] Add __has_builtin support for __make_integer_seq Differential Revision: http://reviews.llvm.org/D14349 Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp

Re: [PATCH] D14349: [Lex] Add __has_builtin support for __make_integer_seq

2015-11-04 Thread David Majnemer via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL252115: [Lex] Add __has_builtin support for __make_integer_seq (authored by majnemer). Changed prior to commit: http://reviews.llvm.org/D14349?vs=39258&id=39294#toc Repository: rL LLVM http://review

r252120 - Fix build break

2015-11-04 Thread David Majnemer via cfe-commits
Author: majnemer Date: Wed Nov 4 19:10:42 2015 New Revision: 252120 URL: http://llvm.org/viewvc/llvm-project?rev=252120&view=rev Log: Fix build break Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp URL: http://llvm.org/viewvc/llvm-project/c

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

2015-11-04 Thread Adrian Prantl via cfe-commits
aprantl added a comment. Unless this is some kind of optimization that we specifically added to minimize debug info size (I have never looked at our template support in detail), this looks totally reasonable. Do other compilers do the same here? http://reviews.llvm.org/D14358 __

Re: [PATCH] D14191: Make ArgumentAdjuster aware of the current file being processed.

2015-11-04 Thread Daniel Jasper via cfe-commits
djasper added a subscriber: djasper. djasper accepted this revision. djasper added a reviewer: djasper. djasper added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D14191 ___ cfe-commits mailing list

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

2015-11-04 Thread Daniel Jasper via cfe-commits
djasper added a subscriber: djasper. Comment at: clang-tidy/ClangTidy.cpp:46 @@ +45,3 @@ + +#include "llvm/ADT/StringExtras.h" + This doesn't seem to be the right place for this #include. Comment at: clang-tidy/ClangTidyOptions.h:89-93 @@ -86,1 +

r252125 - [modules] Don't merge an anonymous enum definition into a named enum definition.

2015-11-04 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Nov 4 19:30:19 2015 New Revision: 252125 URL: http://llvm.org/viewvc/llvm-project?rev=252125&view=rev Log: [modules] Don't merge an anonymous enum definition into a named enum definition. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/test/Modules/merge-enum

r252128 - TestModuleFileExtension.cpp: Include explicitly for fprintf(3).

2015-11-04 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Wed Nov 4 19:34:19 2015 New Revision: 252128 URL: http://llvm.org/viewvc/llvm-project?rev=252128&view=rev Log: TestModuleFileExtension.cpp: Include explicitly for fprintf(3). Modified: cfe/trunk/lib/Frontend/TestModuleFileExtension.cpp Modified: cfe/trunk/lib/Frontend

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

2015-11-04 Thread Paul Robinson via cfe-commits
probinson added a comment. GCC 4.8.4 on Linux doesn't produce these, but DWARF 4 section 5.5.8 says a class template instantiation is just like the equivalent non-template class entry, with the exception of the template parameter entries. I read that as meaning an incomplete description (i.e.

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

2015-11-04 Thread Evgeniy Stepanov via cfe-commits
eugenis added inline comments. Comment at: test/SemaCXX/internal_linkage.cpp:23 @@ +22,3 @@ + +__attribute__((internal_linkage)) void A::f4() {} // expected-error{{'internal_linkage' attribute does not appear on the first declaration of 'f4'}} + Btw, this trigge

Re: [PATCH] D14191: Make ArgumentAdjuster aware of the current file being processed.

2015-11-04 Thread Alexander Kornienko via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL252134: Make ArgumentAdjuster aware of the current file being processed. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D14191?vs=38776&id=39303#toc http://reviews.llvm.org/D141

r252134 - Make ArgumentAdjuster aware of the current file being processed.

2015-11-04 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Wed Nov 4 20:19:53 2015 New Revision: 252134 URL: http://llvm.org/viewvc/llvm-project?rev=252134&view=rev Log: Make ArgumentAdjuster aware of the current file being processed. Summary: This is needed to handle per-project configurations when adding extra arguments in clang-t

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

2015-11-04 Thread Vinicius Tinti via cfe-commits
tinti updated this revision to Diff 39304. tinti added a comment. Clang format. Repository: rL LLVM http://reviews.llvm.org/D14184 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/BackendUtil.cpp lib/Driver/Tools.cpp lib/Frontend/CompilerIn

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

2015-11-04 Thread Vinicius Tinti via cfe-commits
tinti marked 2 inline comments as done. Comment at: lib/Frontend/CompilerInvocation.cpp:459 @@ +458,3 @@ +StringRef Value = A->getValue(); +bool Valid = llvm::StringSwitch(Value) + .Case("default", true) This part of the code does not i

[clang-tools-extra] r252138 - Accommodate interface change in r252134.

2015-11-04 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Wed Nov 4 20:30:21 2015 New Revision: 252138 URL: http://llvm.org/viewvc/llvm-project?rev=252138&view=rev Log: Accommodate interface change in r252134. Modified: clang-tools-extra/trunk/modularize/Modularize.cpp Modified: clang-tools-extra/trunk/modularize/Modularize.cp

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

2015-11-04 Thread Sean Silva via cfe-commits
On Sun, Nov 1, 2015 at 10:20 AM, Manuel Klimek wrote: > > > On Fri, Oct 23, 2015 at 9:31 PM Sean Silva wrote: > >> On Tue, Oct 20, 2015 at 1:52 AM, Manuel Klimek wrote: >> >>> On Tue, Oct 20, 2015 at 10:41 AM Sean Silva >>> wrote: >>> On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek w

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

2015-11-04 Thread Sean Silva via cfe-commits
On Wed, Nov 4, 2015 at 1:07 PM, Richard Smith wrote: > On Sun, Nov 1, 2015 at 10:20 AM, Manuel Klimek wrote: > >> On Fri, Oct 23, 2015 at 9:31 PM Sean Silva wrote: >> >>> On Tue, Oct 20, 2015 at 1:52 AM, Manuel Klimek >>> wrote: >>> On Tue, Oct 20, 2015 at 10:41 AM Sean Silva wrote:

Re: [PATCH] D14354: Add new compiler flag to enable the generation of dwarf accelerator tables

2015-11-04 Thread David Blaikie via cfe-commits
Test case? On Wed, Nov 4, 2015 at 3:44 PM, Tamas Berghammer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > tberghammer created this revision. > tberghammer added a reviewer: echristo. > tberghammer added a subscriber: cfe-commits. > > Add new compiler flag to enable the generation of dwar

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

2015-11-04 Thread Michael Wu via cfe-commits
michaelwu added inline comments. Comment at: test/Index/symbol-visibility.c:8 @@ +7,3 @@ +// CHECK: FunctionDecl=foo1:3:47visibility=Default +// CHECK: FunctionDecl=foo2:4:49visibility=Protected +// CHECK: FunctionDecl=foo3:5:46visibility=Hidden skalinichev wrote:

Re: [PATCH] D14352: Add diagnostics which fall under [dcl.spec.concept]p5

2015-11-04 Thread Nathan Wilson via cfe-commits
nwilson updated this revision to Diff 39314. nwilson added a comment. - Cover variadic arguments in check for no params. - Add tests to cover variadic arguments. http://reviews.llvm.org/D14352 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/CXX/concepts-ts/dcl

r252147 - Use profile data template file for covmap func record (NFC)

2015-11-04 Thread Xinliang David Li via cfe-commits
Author: davidxl Date: Wed Nov 4 23:46:39 2015 New Revision: 252147 URL: http://llvm.org/viewvc/llvm-project?rev=252147&view=rev Log: Use profile data template file for covmap func record (NFC) Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp Modified: cfe/trunk/lib/CodeGen/CoverageMap

RE: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

2015-11-04 Thread Robinson, Paul via cfe-commits
Would citing PR20455 help? It wasn't actually my primary motivation but it's not too far off. Having the template parameters there lets you know what's going on in the DWARF, without having to fetch and parse the name string of every struct you come across. Actually I'm not sure parsing the n

<    1   2