Looks like this doesn't even compile:
http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/32311/steps/compile/logs/stdio
Can you revert?
On Tue, Oct 13, 2015 at 4:40 PM, Ekaterina Romanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: kromanova
> Date: Tue Oct 13 1
On 13 October 2015 at 23:40, Ekaterina Romanova via cfe-commits
wrote:
> Author: kromanova
> Date: Tue Oct 13 18:40:02 2015
> New Revision: 250252
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250252&view=rev
> Log:
> This patch adds missing pieces to clang, including the PS4 toolchain
> defini
Author: ericwf
Date: Tue Oct 13 18:56:33 2015
New Revision: 250256
URL: http://llvm.org/viewvc/llvm-project?rev=250256&view=rev
Log:
Workaround -pedantic flag added by LLVM
Modified:
libcxx/trunk/CMakeLists.txt
Modified: libcxx/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/l
Author: kromanova
Date: Tue Oct 13 19:03:20 2015
New Revision: 250257
URL: http://llvm.org/viewvc/llvm-project?rev=250257&view=rev
Log:
reverting my patch, cause build problems
Removed:
cfe/trunk/test/Driver/Inputs/scei-ps4_tree/target/include/.keep
cfe/trunk/test/Driver/Inputs/scei-ps4_t
rnk updated this revision to Diff 37302.
rnk added a comment.
- Diagnose instance members rather than pretending to build an expr
http://reviews.llvm.org/D6700
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaExprMember.cpp
lib/Sema/TreeTransform.h
test/SemaCXX/using-decl-1.cpp
test/Sema
emaste added a subscriber: emaste.
Comment at: cfe/trunk/lib/Driver/ToolChains.cpp:4080
@@ +4079,3 @@
+ SmallString<512> PS4SDKDir;
+ if (const char *EnvValue = getenv("SCE_PS4_SDK_DIR"))
+if (!llvm::sys::fs::exists(EnvValue))
Looks like a missing { here
R
rnk updated this revision to Diff 37303.
rnk added a comment.
- Remove duplicate tests, beef them up
http://reviews.llvm.org/D6700
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaExprMember.cpp
lib/Sema/TreeTransform.h
test/SemaCXX/using-decl-1.cpp
test/SemaTemplate/instantiate-using-de
Author: ericwf
Date: Tue Oct 13 19:22:05 2015
New Revision: 250261
URL: http://llvm.org/viewvc/llvm-project?rev=250261&view=rev
Log:
Use __config_site when building libc++. Also cleanup ABI versioning doc
Added:
libcxx/trunk/docs/DesignDocs/ABIVersioning.rst
Removed:
libcxx/trunk/docs/Abi
emaste added a comment.
> Can we get this fixed or reversed out? Thanks!
It's already reverted.
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
eugenis closed this revision.
eugenis added a comment.
Landed as r250254, thanks for the review!
Repository:
rL LLVM
http://reviews.llvm.org/D11740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hi Richard,
>>
>> this commit appears to break the module self-host on Darwin.
>>
>> When
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Sema/TreeTransform.h:9131
@@ -9130,2 +9130,3 @@
// it's a normal declaration name.
- if (!Old->hasExplicitTemplateArgs() && !TemplateKWLoc.isValid())
Author: kromanova
Date: Tue Oct 13 20:09:02 2015
New Revision: 250262
URL: http://llvm.org/viewvc/llvm-project?rev=250262&view=rev
Log:
I took care of the build problem in the commit 250252.
Resubmitting the patch.
This patch adds missing pieces to clang, including the PS4 toolchain
definition,
On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva wrote:
> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Hi Richard,
>>>
>>> this co
eugenis created this revision.
eugenis added reviewers: mclow.lists, EricWF.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
Herald added a subscriber: aemerson.
ABI stability is not an issue when building for unstable ABI.
Other than that, always_
Sorry for causing the trouble with the build. I will try to look later why my
partial rebuild didn't catch the issue.
I have fixed the error, rebuilt and ran the tests.
This is a very big patch. Please be understanding, because this patch has a big
impact. I apologize in advance if it causes som
eugenis set the repository for this revision to rL LLVM.
eugenis updated this revision to Diff 37310.
eugenis added a comment.
Using new ABI version macros to enable this feature in unstable or future ABI
only.
PTAL.
Repository:
rL LLVM
http://reviews.llvm.org/D10677
Files:
include/__conf
EricWF created this revision.
EricWF added reviewers: mclow.lists, jroelofs, danalbert, eugenis, ed.
EricWF added a subscriber: cfe-commits.
This patch changes the tests to use the "__config_site" header if present
instead of manually configuring for each option. This patch also removes the
test
EricWF added a comment.
I'm not sure about this patch quite yet.
However I am sure windows still needs these even in an unstable build.
Repository:
rL LLVM
http://reviews.llvm.org/D13713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith
wrote:
> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva wrote:
>
>> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits <
>>> cfe-c
On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva wrote:
>
>
> On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith
> wrote:
>
>> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva
>> wrote:
>>
>>> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
>>>
On
EricWF added a comment.
For the most part this looks good. I'm a touch concerned though about the
changes to the static initialization. The initializer is moved from within the
function body to outside it. Could you have somebody confirm this won't affect
the existing ABI?
Co
(and assert.h probably isn't the best example, since it is textual)
On Tue, Oct 13, 2015 at 7:00 PM, Sean Silva wrote:
>
>
> On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva wrote:
>
>>
>>
>> On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith
>> wrote:
>>
>>> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva
This is breaking llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/1358/steps/test/logs/stdio
On Tue, Oct 13, 2015 at 6:09 PM, Ekaterina Romanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: kromanova
tfiala added a comment.
Ah nice. Thanks!
-Todd
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Ah nice. Thanks!
-Todd
> On Oct 13, 2015, at 5:28 PM, Ed Maste wrote:
>
> emaste added a comment.
>
>> Can we get this fixed or reversed out? Thanks!
>
>
> It's already reverted.
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D13482
>
>
>
_
tfiala added a subscriber: tfiala.
tfiala added a comment.
This change appears to have broken quite a few builders.
Can we get this fixed or reversed out? Thanks!
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_build/7935/
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmak
tfiala added a comment.
Oh no worries, just wanted to make sure wasn't missed, that's all.
-Todd
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva wrote:
> On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith
> wrote:
>
>> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva
>> wrote:
>>
>>> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
>>>
On Tue,
kromanova added a comment.
Hi,
The initial PS4 patch caused a test failure (debug-options.c) on the PS4 bot. I
suspect that I know why the problem happens, but I'm not sure what will be the
best way to handle it. If someone knows how to fix this test more "elegantly",
I would appreciate their
ABataev added a comment.
I see, no problems, thanks!
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
Intel Corp.
http://reviews.llvm.org/D13375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250265: [MSVC] Fix for http://llvm.org/PR24132:
__declspec(property): double… (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D13375?vs=36331&id=37319#toc
Repository:
rL LLVM
Author: abataev
Date: Tue Oct 13 23:05:42 2015
New Revision: 250265
URL: http://llvm.org/viewvc/llvm-project?rev=250265&view=rev
Log:
[MSVC] Fix for http://llvm.org/PR24132: __declspec(property): double
invocations of foo() when compiling foo()->propertyName
Removes extra codegen for base express
ABataev added a comment.
In http://reviews.llvm.org/D13336#257628, @rnk wrote:
> I think fundamentally we are doing too much declspec property lowering in
> Sema. We might want to back up and figure out how to do it in IRGen. Right
> now we have bugs like this, which are probably more important
Author: echristo
Date: Wed Oct 14 00:40:11 2015
New Revision: 250270
URL: http://llvm.org/viewvc/llvm-project?rev=250270&view=rev
Log:
Remove the optimization option from this test as it is unnecessary
and front end tests should avoid this if possible.
Modified:
cfe/trunk/test/CodeGen/fma-bui
Author: echristo
Date: Wed Oct 14 00:40:21 2015
New Revision: 250271
URL: http://llvm.org/viewvc/llvm-project?rev=250271&view=rev
Log:
Canonicalize some of the x86 builtin tests and either remove or comment
about optimization options.
Modified:
cfe/trunk/test/CodeGen/3dnow-builtins.c
cfe/
mgrabovsky added a comment.
In http://reviews.llvm.org/D13643#265976, @aaron.ballman wrote:
> Should there be an exception to this diagnostic for code involving Boolean
> values? e.g.,
>
> void f(bool a, bool b, bool c) {
>
> if (a == b == c)
> ;
>
> }
>
> At the very least, it seems like
On Tue, Oct 13, 2015 at 7:51 PM, Katya Romanova <
katya_roman...@playstation.sony.com> wrote:
> kromanova added a comment.
>
> Hi,
>
> The initial PS4 patch caused a test failure (debug-options.c) on the PS4
> bot. I suspect that I know why the problem happens, but I'm not sure what
> will be the
It was already reverted, but I agree, let's get this fixed first.
Thanks!
-eric
On Tue, Oct 13, 2015 at 11:33 PM Sean Silva wrote:
> On Tue, Oct 13, 2015 at 7:51 PM, Katya Romanova <
> katya_roman...@playstation.sony.com> wrote:
>
>> kromanova added a comment.
>>
>> Hi,
>>
>> The initial PS4 p
On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher
wrote:
> It was already reverted, but I agree, let's get this fixed first.
>
It was reintroduced in r250252. It is breaking
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/1362
-- Sean Silva
>
> Thanks!
>
>
On Tue, Oct 13, 2015 at 11:38 PM Sean Silva wrote:
> On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher
> wrote:
>
>> It was already reverted, but I agree, let's get this fixed first.
>>
>
> It was reintroduced in r250252. It is breaking
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-
Author: silvas
Date: Wed Oct 14 01:45:07 2015
New Revision: 250273
URL: http://llvm.org/viewvc/llvm-project?rev=250273&view=rev
Log:
Revert-to-green r250262 (PS4 toolchain patch)
It is breaking llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast
e.g.
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_6
On Tue, Oct 13, 2015 at 11:40 PM, Eric Christopher
wrote:
>
>
> On Tue, Oct 13, 2015 at 11:38 PM Sean Silva wrote:
>
>> On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher
>> wrote:
>>
>>> It was already reverted, but I agree, let's get this fixed first.
>>>
>>
>> It was reintroduced in r250252.
101 - 143 of 143 matches
Mail list logo
