Re: [PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

delena added a comment. You should add the "xsave" features to all appropriate CPUs. It can be done in a separate patch. LGTM. Repository: rL LLVM http://reviews.llvm.org/D13014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

Re: [PATCH] D13640: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

klimek added a subscriber: klimek. Comment at: clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:40 @@ +39,3 @@ + + diag(MatchedCast->getExprLoc(), "do not (implicitly) convert an array to a pointer"); +} Can't we provide a fixit? http://revi

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex added inline comments. Comment at: lib/Sema/SemaType.cpp:2654-2655 @@ -2648,4 +2653,4 @@ case Declarator::ConversionIdContext: if (!SemaRef.getLangOpts().CPlusPlus14) -Error = 12; // conversion-type-id +Error = 14; // conversion-type-id bre

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex added inline comments. Comment at: lib/Sema/SemaType.cpp:2675-2678 @@ -2671,5 +2674,6 @@ break; case Declarator::ConversionIdContext: - if (!SemaRef.getLangOpts().CPlusPlus14) -Error = 12; // conversion-type-id + if (!SemaRef.getLangOpts().CPlus

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev marked 3 inline comments as done. Comment at: include/clang/Basic/Attr.td:2098-2102 @@ +2097,7 @@ + let Documentation = [OMPDeclareSimdDocs]; + let AdditionalMembers = [{ + void printPrettyPragma(raw_ostream &OS, const PrintingPolicy &Policy) const { +OS << "\n"; +

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev updated this revision to Diff 37218. ABataev marked 3 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D10599 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticParseKinds.td include/clang

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

klimek added reviewers: aaron.ballman, rnk. klimek added a comment. +aaron, as token Windows Wizard +rnk, as I was told you might know people who are in a good position to review MS specific stuff (perhaps engineers from MS might be able to help here? :) http://reviews.llvm.org/D13549 _

Re: [PATCH] D13590: Support every kind of initialization.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: clang-tidy/modernize/MakeUniqueCheck.cpp:125-128 @@ +124,6 @@ + // Direct initialization with initialization list. + // \code + // struct S { S

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

klimek added a reviewer: milianw. klimek added a comment. +milian - can you take a look at this patch (or do you know somebody who might be in a good position to review) http://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

danielmarjamaki updated this revision to Diff 37223. danielmarjamaki added a comment. Minor cleanups and refactorings http://reviews.llvm.org/D12359 Files: include/clang/AST/Decl.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Parse/Par

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

danielmarjamaki marked 9 inline comments as done. danielmarjamaki added a comment. I will remove test/SemaCXX/warn-nonconst-parameter.cpp in the next patch since this checker does not handle C++ yet. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:201 @@ -200,1 +200,3 @@

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

klimek added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:418-419 @@ +417,4 @@ +unsigned Pos; +int Type; +int ErrorId; + }; These need to be documented. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cp

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

klimek added a subscriber: klimek. klimek added a reviewer: milianw. klimek added a comment. This LG, looping in Milian for a second opinion / to find more reviewers :) http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

klimek added reviewers: aaron.ballman, rnk. klimek added a comment. +aaron for windows specific knowledge +rnk to see whether we can get a reviewer with more MS VS experience (perhaps somebody from MS :) My main concern is that this adds a lot of things that I have no idea whether they are need

r250155 - Remove unused diagnostic. NFC.

Author: d0k Date: Tue Oct 13 05:10:03 2015 New Revision: 250155 URL: http://llvm.org/viewvc/llvm-project?rev=250155&view=rev Log: Remove unused diagnostic. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td URL:

r250158 - [X86] Add XSAVE intrinsic family

Author: aaboud Date: Tue Oct 13 07:29:35 2015 New Revision: 250158 URL: http://llvm.org/viewvc/llvm-project?rev=250158&view=rev Log: [X86] Add XSAVE intrinsic family Add intrinsics for the XSAVE instructions (XSAVE/XSAVE64/XRSTOR/XRSTOR64) XSAVEOPT instructions (XSAVEOPT/XSAVEOPT64) XSAVEC

Re: [PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

This revision was automatically updated to reflect the committed changes. Closed by commit rL250158: [X86] Add XSAVE intrinsic family (authored by aaboud). Changed prior to commit: http://reviews.llvm.org/D13014?vs=37108&id=37238#toc Repository: rL LLVM http://reviews.llvm.org/D13014 Files

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

milianw added a comment. This looks good to me, but it's missing a unit test. Take a look at http://reviews.llvm.org/D13388 for how to do that in principle. http://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

milianw added a comment. Yep, looks good to me as well - thanks! http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13643: [Sema] Warn on ternary comparison

aaron.ballman added a comment. Should there be an exception to this diagnostic for code involving Boolean values? e.g., void f(bool a, bool b, bool c) { if (a == b == c) ; } At the very least, it seems like this should also follow GCC's behavior and suggest parenthesis directly.

Re: [PATCH] D13465: Add SafeStack support for test-suite.

tharvik added a comment. In http://reviews.llvm.org/D13465#260846, @jroelofs wrote: > In http://reviews.llvm.org/D13465#260628, @tharvik wrote: > > > When running the test suite, it gives a bunch of `undefined reference to > > '__safestack_unsafe_stack_ptr'`. > > See regression results

Re: [PATCH] D13640: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:29 @@ +28,3 @@ + implicitCastExpr(unless(hasParent(arraySubscriptExpr())), + unless(hasSourceExpression(declRefExpr(to(varDecl(hasName("

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

aaron.ballman added a comment. Generally looks good to me, with a few small nits. Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:57 @@ +56,3 @@ +{ +StandardValuesCollection svc = new StandardValuesCollection(values); +

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

aaron.ballman added a comment. LGTM, but someone who understands VS plugins better should give the final sign-off. Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:309 @@ +308,3 @@ +uint _; +IVsHierarchy __; +string filenam

Re: [PATCH] D13640: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

klimek added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:40 @@ +39,3 @@ + + diag(MatchedCast->getExprLoc(), "do not (implicitly) convert an array to a pointer"); +} aaron.ballman wrote: > klimek wrote: > > Can

Re: [PATCH] D13640: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:40 @@ +39,3 @@ + + diag(MatchedCast->getExprLoc(), "do not (implicitly) convert an array to a pointer"); +} klimek wrote: > aaron.ballman wrote:

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

curdeius added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:57 @@ +56,3 @@ +{ +StandardValuesCollection svc = new StandardValuesCollection(values); +return svc; aaron.ballman wrot

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

aaron.ballman added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:82 @@ -42,1 +81,3 @@ + " - Predefined styles ('LLVM', 'Google', 'Chromium', 'Mozilla', 'WebKit').\n" + + " - 'file' to search for a Y

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

curdeius updated this revision to Diff 37253. curdeius added a comment. Applied Aaron's comments. Removed unused using. http://reviews.llvm.org/D13549 Files: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs tools/clang-format-vs/ClangFormat/Properties/AssemblyInfo.cs tools/clang-fo

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

curdeius marked 7 inline comments as done. curdeius added a comment. Applied comments and done some minor clean up. http://reviews.llvm.org/D13549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

r250164 - [Driver] Use the parent_path of the clang executable as the default InstalledDir

Author: d0k Date: Tue Oct 13 10:19:32 2015 New Revision: 250164 URL: http://llvm.org/viewvc/llvm-project?rev=250164&view=rev Log: [Driver] Use the parent_path of the clang executable as the default InstalledDir This is what most people want anyways. Clang -cc1's main() will override this but for

Re: [PATCH] D13510: [PATCH] Support C++ Core Guidelines copy assignment restrictions

aaron.ballman closed this revision. aaron.ballman added a comment. In http://reviews.llvm.org/D13510#262084, @mgehre wrote: > The user will see [cppcoreguidelines-c-copy-assignment-signature] in > warnings, but there is no > docs/clang-tidy/checks/cppcoreguidelines-c-copy-assignment-signature.r

[clang-tools-extra] r250165 - Expose the clang-tidy misc-assign-operator-signature checker as cppcoreguidelines-c-copy-assignment-signature.

Author: aaronballman Date: Tue Oct 13 10:24:33 2015 New Revision: 250165 URL: http://llvm.org/viewvc/llvm-project?rev=250165&view=rev Log: Expose the clang-tidy misc-assign-operator-signature checker as cppcoreguidelines-c-copy-assignment-signature. Modified: clang-tools-extra/trunk/clang-t

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

thakis added inline comments. Comment at: test/SemaCXX/auto-type-from-cxx.cpp:14 @@ +13,3 @@ + auto _ = [](__auto_type f) {}; // expected-error {{'__auto_type' not allowed in lambda parameter}} + __auto_type g = 2; + struct BitField { int field:2; }; comex wro

[clang-tools-extra] r250166 - Appeasing build bots by linking in the proper libraries.

Author: aaronballman Date: Tue Oct 13 10:42:06 2015 New Revision: 250166 URL: http://llvm.org/viewvc/llvm-project?rev=250166&view=rev Log: Appeasing build bots by linking in the proper libraries. Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/CMakeLists.txt Modified: clang-to

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:201 @@ -200,1 +200,3 @@ +def warn_nonconst_parameter : Warning<"parameter %0 can be const">, + InGroup, DefaultIgnore; def warn_unused_variable : Warning<"unused variable %0">, --

r250173 - Always pass a -dwarf-version argument to integrated as.

Author: dougk Date: Tue Oct 13 11:22:51 2015 New Revision: 250173 URL: http://llvm.org/viewvc/llvm-project?rev=250173&view=rev Log: Always pass a -dwarf-version argument to integrated as. This removes the default of 3 hidden in the assembler previously. Fixes breakage caused by r249655, reported

Re: [PATCH] D13375: [MSVC] Fix for http://llvm.org/PR24132: __declspec(property): double invocations of foo() when compiling foo()->propertyName

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Thanks, sorry for the delay, EH was keeping me busy. =/ http://reviews.llvm.org/D13375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [PATCH] D12922: Add support for function attribute "notail"

aaron.ballman added a comment. In http://reviews.llvm.org/D12922#265452, @ahatanak wrote: > I think there are a couple of things that have to be discussed: > > 1. Name of the attribute: Should it be "notail" or "notailcall"? Perhaps it > should be named something like "nodirecttail" to indicate

Re: [PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

NoQ updated this revision to Diff 37263. NoQ added a comment. Hmm, i think i'm ready to explain most of the stuff. - First of all, the piece of code in `EnvironmentManager::removeDeadBindings()` i mentioned above is truly useless; everything would be marked as live anyway on the next line. - T

Re: [PATCH] D5104: [analyzer] [proposal] Fix for PR20653

NoQ added a subscriber: NoQ. NoQ added a comment. While investigating http://reviews.llvm.org/D12726 , i accidentally came up with a way to test this patch; with the extension of `ExprInspectionChecker` in the aforementioned review, which allows testing SymbolReaper directly, the following test

Re: [PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

NoQ updated this revision to Diff 37266. NoQ added a comment. Whoops accidentally left out a dead code line in tests. http://reviews.llvm.org/D12726 Files: docs/analyzer/DebugChecks.rst include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h lib/StaticAnalyzer/Checkers/ExprInspect

Re: [PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

NoQ updated this revision to Diff 37267. NoQ added a comment. A, another mis-submit. Sorry for the noise. http://reviews.llvm.org/D12726 Files: docs/analyzer/DebugChecks.rst include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h lib/StaticAnalyzer/Checkers/ExprInspectionCheck

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

jroelofs added a comment. Other than that, LGTM too. Comment at: lib/Driver/ToolChains.cpp:4081 @@ +4080,3 @@ + + std::string PS4SDKDir = (EnvValue ? EnvValue : getDriver().Dir + "/../.."); + Use `llvm::sys::path::append` instead of `std::string::operator+` for

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

(Jonathan's review here is fine, don't wait on me. Thanks! :) -eric On Tue, Oct 13, 2015 at 10:32 AM Jonathan Roelofs wrote: > jroelofs added a comment. > > Other than that, LGTM too. > > > > Comment at: lib/Driver/ToolChains.cpp:4081 > @@ +4080,3 @@ > + > + std::string PS4SDK

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

echristo added a subscriber: echristo. echristo added a comment. (Jonathan's review here is fine, don't wait on me. Thanks! :) -eric Repository: rL LLVM http://reviews.llvm.org/D13482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

kromanova added a comment. Thank you! I will rebase and commit shortly Katya. Repository: rL LLVM http://reviews.llvm.org/D13482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1463 @@ +1462,3 @@ + let Spellings = [GNU<"unique_instantiation">]; + let Subjects = SubjectList<[Function, CXXRecord], ErrorDiag, "ExpectedFunctionOrClass">; + let Documentation = [UniqueInstantiatio

[clang-tools-extra] r250194 - Updating the documentation for the readability-inconsistent-declaration-parameter-name checker.

Author: aaronballman Date: Tue Oct 13 13:13:10 2015 New Revision: 250194 URL: http://llvm.org/viewvc/llvm-project?rev=250194&view=rev Log: Updating the documentation for the readability-inconsistent-declaration-parameter-name checker. Patch by Piotr Dziwinski. Modified: clang-tools-extra/t

r250196 - [CMake] When building clang as an external project we should pass through all variables that start with COMPILER_RT

Author: cbieneman Date: Tue Oct 13 13:17:30 2015 New Revision: 250196 URL: http://llvm.org/viewvc/llvm-project?rev=250196&view=rev Log: [CMake] When building clang as an external project we should pass through all variables that start with COMPILER_RT Modified: cfe/trunk/runtime/CMakeLists.t

r250202 - Add subtarget feature support for 3dnowa to the 3dnowa intrinsics.

Author: echristo Date: Tue Oct 13 13:40:17 2015 New Revision: 250202 URL: http://llvm.org/viewvc/llvm-project?rev=250202&view=rev Log: Add subtarget feature support for 3dnowa to the 3dnowa intrinsics. Modified: cfe/trunk/lib/Headers/mm3dnow.h Modified: cfe/trunk/lib/Headers/mm3dnow.h URL:

r250203 - Move the adc-builtins test to the pattern of the other builtins

Author: echristo Date: Tue Oct 13 13:40:21 2015 New Revision: 250203 URL: http://llvm.org/viewvc/llvm-project?rev=250203&view=rev Log: Move the adc-builtins test to the pattern of the other builtins tests by predefining _MM_MALLOC_H rather than use -ffreestanding. Modified: cfe/trunk/test/Cod

[PATCH] D13704: [Fix] Allow implicit conversions of the address of overloadable functions in C + docs update

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. Two smallish patches in one. Happy to split into two (for review and/or commit) if that's preferred. In C, we allow (as an extension) incompatible pointer conve

[PATCH] D13705: [libcxxabi] Set correct libc++ version in tests.

eugenis created this revision. eugenis added reviewers: mclow.lists, EricWF. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. Libcxxabi tests are built against non-installed libc++ headers, and they need to know the ABI version libc++ is configured

Re: [PATCH] D13326: [PGO]: Eliminate __llvm_profile_register calls for Linux (clang changes)

davidxl abandoned this revision. davidxl added a comment. The refactoring is done by a previous patch already. http://reviews.llvm.org/D13326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex added inline comments. Comment at: test/SemaCXX/auto-type-from-cxx.cpp:14 @@ +13,3 @@ + auto _ = [](__auto_type f) {}; // expected-error {{'__auto_type' not allowed in lambda parameter}} + __auto_type g = 2; + struct BitField { int field:2; }; thakis wro

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

thakis added inline comments. Comment at: test/SemaCXX/auto-type-from-cxx.cpp:14 @@ +13,3 @@ + auto _ = [](__auto_type f) {}; // expected-error {{'__auto_type' not allowed in lambda parameter}} + __auto_type g = 2; + struct BitField { int field:2; }; comex wro

Re: [PATCH] D6700: Instantiate UnresolvedLookupExpr to MemberExpr when appropriate

rnk added a comment. Richard suggested that maybe we formed the wrong AST while parsing the template. I'm not sure that's the case. We have this very explicit logic that controls what AST nodes we form in SemaExprMember.cpp ClassifyImplicitMemberAccess: bool isStaticContext = SemaRef.CXXThis

Re: [PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. What is preventing to add this check to Clang-tidy? Just found another piece of fresh C++ code in LLDB with (void) as argument list... http://reviews.llvm.org/D7639

Re: [PATCH] D6700: Instantiate UnresolvedLookupExpr to MemberExpr when appropriate

rnk updated this revision to Diff 37283. rnk added a comment. - Rebase http://reviews.llvm.org/D6700 Files: lib/Sema/TreeTransform.h test/SemaTemplate/instantiate-using-decl.cpp Index: test/SemaTemplate/instantiate-using-decl.cpp

Re: [PATCH] D6700: Diagnose UnresolvedLookupExprs that resolve to instance members in static methods

rnk added inline comments. Comment at: lib/Sema/TreeTransform.h:9138 @@ +9137,3 @@ + isa(D)) +return getSema().BuildPossibleImplicitMemberExpr( +SS, SourceLocation(), R, /*TemplateArgs=*/nullptr, I believe this will always fail, so one

[clang-tools-extra] r250221 - Exposing an existing checker under the name cert-err61-cpp, as it corresponds to the CERT C++ secure coding rule: https://www.securecoding.cert.org/confluence/display/cpl

Author: aaronballman Date: Tue Oct 13 15:42:41 2015 New Revision: 250221 URL: http://llvm.org/viewvc/llvm-project?rev=250221&view=rev Log: Exposing an existing checker under the name cert-err61-cpp, as it corresponds to the CERT C++ secure coding rule: https://www.securecoding.cert.org/confluenc

Re: [PATCH] D13285: Fix for bug 24196: clang fails on assertion on complex doubles multiplication when EH is enabled

rjmccall added a comment. This is an inappropriate fix for this problem. If these runtime functions can never throw, which seems to be the case, you should create the function type with a no-throw exception specification, which will make EmitCall emit the call with a CallInst. EST_BasicNoexce

Re: [libcxx] r249738 - Split out of .

Hi Richard, this commit appears to break the module self-host on Darwin. When compiling the following program generated by clang’s own cmake script: > #undef NDEBUG > #include > #define NDEBUG > #include > int main() { assert(this code is not compiled); } with clang++ -std=c++11 -fmodules -fc

Re: [libcxx] r249798 - Split out of .

I would rather not do this if possible but I understand why we need to do it. Richard is there a cost associated with the 'extern "C++"' construct? or by forcing the compiler to switch modes in general? On Mon, Oct 12, 2015 at 12:27 PM, Richard Smith wrote: > On Mon, Oct 12, 2015 at 9:41 AM,

Re: [PATCH] D12358: [Analyzer] Widening loops which do not exit

dcoughlin added a comment. > There is a loss of precision for loops that need to be executed exactly > maxBlockVisitOnPath times, as the loop body is executed with the widened > state instead of the last iteration. I think this is an acceptable loss of precision because, in general, it is unl

Re: [PATCH] D6700: Diagnose UnresolvedLookupExprs that resolve to instance members in static methods

rjmccall added inline comments. Comment at: lib/Sema/TreeTransform.h:9135 @@ +9134,3 @@ +if (NamedDecl *D = R.getAsSingle()) { + D = D->getUnderlyingDecl(); + if (isa(D) || isa(D) || getAsSingle already looks through to the underlying decl.

Re: [PATCH] D6700: Diagnose UnresolvedLookupExprs that resolve to instance members in static methods

rjmccall added a comment. As a more general comment, I believe the rule is that we try to always make a MemberExpr/UnresolvedMemberExpr whenever there *might* be a base, but that the resulting distinction between an implicit-base UnresolvedMemberExpr and an UnresolvedLookupExpr is not actually

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. Maintainers from Apple and FreeBSD gave this the thumbs up. http://reviews.llvm.org/D13407 ___ cfe-commits maili

[libcxx] r250235 - [libcxx] Capture configuration information when installing the libc++ headers

Author: ericwf Date: Tue Oct 13 17:12:02 2015 New Revision: 250235 URL: http://llvm.org/viewvc/llvm-project?rev=250235&view=rev Log: [libcxx] Capture configuration information when installing the libc++ headers Summary: Hi all, This patch is a successor to D11963. However it has changed dramatic

[libcxx] r250236 - Remove __config module to avoid #include cycle when libc headers include libc++'s headers.

Author: rsmith Date: Tue Oct 13 17:13:33 2015 New Revision: 250236 URL: http://llvm.org/viewvc/llvm-project?rev=250236&view=rev Log: Remove __config module to avoid #include cycle when libc headers include libc++'s headers. Modified: libcxx/trunk/include/module.modulemap Modified: libcxx/t

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. http://reviews.llvm.org/D13407 has landed and this is good to go. Repository: rL LLVM http://reviews.llvm.org/D11740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [libcxx] r249738 - Split out of .

On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Richard, > > this commit appears to break the module self-host on Darwin. > > When compiling the following program generated by clang’s own cmake script: > > > #undef NDEBUG > > #include > > #

Re: [libcxx] r249798 - Split out of .

On Tue, Oct 13, 2015 at 2:12 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I would rather not do this if possible but I understand why we need to do > it. > > Richard is there a cost associated with the 'extern "C++"' construct? or > by forcing the compiler to switch mod

Re: [PATCH] D13673: Add initial support for the MUSL C library.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. http://reviews.llvm.org/D13407 has landed. http://reviews.llvm.org/D13673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

This revision was automatically updated to reflect the committed changes. Closed by commit rL250237: [analyzer] Don’t invalidate CXXThis when conservatively evaluating const… (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D13099?vs=37084&id=37291#toc Repository: rL

[libcxx] r250238 - Fix whitespace in doc

Author: ericwf Date: Tue Oct 13 17:22:42 2015 New Revision: 250238 URL: http://llvm.org/viewvc/llvm-project?rev=250238&view=rev Log: Fix whitespace in doc Modified: libcxx/trunk/docs/DesignDocs/CapturingConfigInfo.rst Modified: libcxx/trunk/docs/DesignDocs/CapturingConfigInfo.rst URL: http:

Re: [libcxx] r249798 - Split out of .

This change LGTM. Let's hold off on the using "_Static_assert" until we understand how that would work with "-pedantic" when the macro is expanded in user code. /Eric On Tue, Oct 13, 2015 at 4:19 PM, Richard Smith wrote: > On Tue, Oct 13, 2015 at 2:12 PM, Eric Fiselier via cfe-commits < > cfe-c

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

kromanova updated this revision to Diff 37292. kromanova added a comment. Updated the patch based on Jonathan's comments. Jonathan, if you have a minute, please review. Repository: rL LLVM http://reviews.llvm.org/D13482 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/B

Re: [PATCH] D13673: Add initial support for the MUSL C library.

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. I don't think this is ready to go. Please don't commit yet. Sorry @jroelofs. Comment at: CMakeLists.txt:309 @@ -307,1 +308,3 @@ +config_define_if(LIBCXX_LIBC_IS_MU

Re: [PATCH] D11740: ABI versioning macros for libc++

eugenis added inline comments. Comment at: include/__config:252 @@ -246,1 +251,3 @@ +defined(_LIBCPP_ALTERNATE_STRING_LAYOUT) +#define _LIBCPP_ABI_ALTERNATE_STRING_LAYOUT #endif EricWF wrote: > I think he's demonstrating the patches functionality and intended

Re: [PATCH] D11740: ABI versioning macros for libc++

eugenis updated this revision to Diff 37293. eugenis marked an inline comment as done. Repository: rL LLVM http://reviews.llvm.org/D11740 Files: CMakeLists.txt cmake/Modules/HandleLibcxxFlags.cmake docs/Abi.rst docs/BuildingLibcxx.rst include/__config include/__config_site.in inc

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. One small suggestion. Otherwise, this still LGTM. Comment at: lib/Driver/ToolChains.cpp:4078 @@ +4077,3 @@ + // should be /host_tools/bin. + const char *EnvValue = getenv("SCE_PS4_S

Re: [PATCH] D13673: Add initial support for the MUSL C library.

jroelofs added inline comments. Comment at: include/__config:370 @@ -369,2 +369,3 @@ #elif defined(__linux__) -#include +#if defined(__GLIBC__) +# include EricWF wrote: > Where does the `__GLIBC__` macro definition come from? I thought it came > from the C li

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. Please address the inline comment. I think with that change we can hold off modifying libc++abi. Comment at: test/libcxx/test/config.py:444 @@ -442,1 +443,3 @@ +def configure_compile_flags_abi_version(self): +abi_version = self.get_lit_conf

Re: [PATCH] D13705: [libcxxabi] Set correct libc++ version in tests.

EricWF added a comment. This is fine as a temporary workaround but it's not complete. I would rather do something better. Repository: rL LLVM http://reviews.llvm.org/D13705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

r250246 - [CMake]Getting rid of references to LLVM_SUBMIT_VERSION and LLVM_SUBMIT_SUBVERSION in favor of LLVM_VERSION_MAJOR and LLVM_VERSION_MINOR.

Author: cbieneman Date: Tue Oct 13 18:03:54 2015 New Revision: 250246 URL: http://llvm.org/viewvc/llvm-project?rev=250246&view=rev Log: [CMake]Getting rid of references to LLVM_SUBMIT_VERSION and LLVM_SUBMIT_SUBVERSION in favor of LLVM_VERSION_MAJOR and LLVM_VERSION_MINOR. LLVM_SUBMIT_VERSION an

Re: [PATCH] D13673: Add initial support for the MUSL C library.

EricWF added inline comments. Comment at: include/__config:370 @@ -369,2 +369,3 @@ #elif defined(__linux__) -#include +#if defined(__GLIBC__) +# include jroelofs wrote: > EricWF wrote: > > Where does the `__GLIBC__` macro definition come from? I thought it cam

Re: [PATCH] D11740: ABI versioning macros for libc++

jroelofs added a subscriber: jroelofs. Comment at: include/__config_site.in:13 @@ -12,1 +12,3 @@ +#cmakedefine _LIBCPP_ABI_VERSION @_LIBCPP_ABI_VERSION@ +#cmakedefine _LIBCPP_ABI_UNSTABLE This doesn't look right to me. What do you want this to expand to when it

[libcxx] r250247 - Fix use of libc++ headers from within an 'extern "C"' context in C++98.

Author: rsmith Date: Tue Oct 13 18:12:22 2015 New Revision: 250247 URL: http://llvm.org/viewvc/llvm-project?rev=250247&view=rev Log: Fix use of libc++ headers from within an 'extern "C"' context in C++98. Previously, this resulted in us declaring a template for static_assert emulation within th

Re: [PATCH] D11740: ABI versioning macros for libc++

jroelofs added inline comments. Comment at: include/__config_site.in:13 @@ -12,1 +12,3 @@ +#cmakedefine _LIBCPP_ABI_VERSION @_LIBCPP_ABI_VERSION@ +#cmakedefine _LIBCPP_ABI_UNSTABLE jroelofs wrote: > This doesn't look right to me. What do you want this to expand

r250250 - [Sema/objc] When checking for unimplemented methods treat methods from class extensions as continuation of the class interface.

Author: akirtzidis Date: Tue Oct 13 18:27:34 2015 New Revision: 250250 URL: http://llvm.org/viewvc/llvm-project?rev=250250&view=rev Log: [Sema/objc] When checking for unimplemented methods treat methods from class extensions as continuation of the class interface. Modified: cfe/trunk/lib/Sem

Re: [libcxx] r249798 - Split out of .

On Tue, Oct 13, 2015 at 3:26 PM, Eric Fiselier wrote: > This change LGTM. Let's hold off on the using "_Static_assert" until we > understand how that would work with "-pedantic" when the macro is expanded > in user code. > Committed as r250247, thanks. > /Eric > > On Tue, Oct 13, 2015 at 4:19

Re: [PATCH] D11740: ABI versioning macros for libc++

eugenis added inline comments. Comment at: test/libcxx/test/config.py:444 @@ -442,1 +443,3 @@ +def configure_compile_flags_abi_version(self): +abi_version = self.get_lit_conf('abi_version', '').strip() EricWF wrote: > Please allow abi_version to be o

Re: [PATCH] D11740: ABI versioning macros for libc++

eugenis updated this revision to Diff 37299. Repository: rL LLVM http://reviews.llvm.org/D11740 Files: CMakeLists.txt cmake/Modules/HandleLibcxxFlags.cmake docs/Abi.rst docs/BuildingLibcxx.rst include/__config include/__config_site.in include/string lib/CMakeLists.txt test/CM

r250252 - This patch adds missing pieces to clang, including the PS4 toolchain

Author: kromanova Date: Tue Oct 13 18:40:02 2015 New Revision: 250252 URL: http://llvm.org/viewvc/llvm-project?rev=250252&view=rev Log: This patch adds missing pieces to clang, including the PS4 toolchain definition, added warnings, PS4 defaults, and Driver changes needed for our compiler. A patc

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL250252: This patch adds missing pieces to clang, including the PS4 toolchain (authored by kromanova). Changed prior to commit: http://reviews.llvm.org/D13482?vs=37292&id=37301#toc Repository: rL LLVM

RE: [PATCH] D13482: Revised Initial patch for PS4 toolchain

Thanks! I just committed the patch. Katya. > -Original Message- > From: Jonathan Roelofs [mailto:jonat...@codesourcery.com] > Sent: Tuesday, October 13, 2015 3:40 PM > To: Romanova, Katya; al...@leftfield.org; Robinson, Paul; > echri...@gmail.com; filcab+llvm.phabrica...@gmail.com; > jonat

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. LGTM. We'll fix the libc++abi issue later. Repository: rL LLVM http://reviews.llvm.org/D11740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r250254 - ABI versioning macros for libc++.

Author: eugenis Date: Tue Oct 13 18:48:28 2015 New Revision: 250254 URL: http://llvm.org/viewvc/llvm-project?rev=250254&view=rev Log: ABI versioning macros for libc++. C++ macros and CMake options that specify the default ABI version of the library, and can be overridden to pick up new ABI-changi

  1   2   >