Re: [PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

2015-10-07 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 36812. sfantao added a comment. Rebase and fix typo in regression test directive. http://reviews.llvm.org/D12614 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Basic/LangOptions.def include/clang/Basic/LangOptions.h include/clang/

r249640 - Don't emit exceptional stackrestore cleanups around inalloca functions

2015-10-07 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Oct 7 19:17:45 2015 New Revision: 249640 URL: http://llvm.org/viewvc/llvm-project?rev=249640&view=rev Log: Don't emit exceptional stackrestore cleanups around inalloca functions The backend restores the stack pointer after recovering from an exception. This is similar to r

r249641 - When pretty-printing a C++11 literal operator, don't insert whitespace between

2015-10-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Oct 7 19:17:59 2015 New Revision: 249641 URL: http://llvm.org/viewvc/llvm-project?rev=249641&view=rev Log: When pretty-printing a C++11 literal operator, don't insert whitespace between the "" and the suffix; that breaks names such as 'operator""if'. For symmetry, also re

Re: [PATCH] D13453: Always generate cmake config files

2015-10-07 Thread NAKAMURA Takumi via cfe-commits
chapuni requested changes to this revision. chapuni added a comment. This revision now requires changes to proceed. This change requires cmake-3. With CMake-2.8.12.2, CMake Error at /home/tnakamura/fio/ninja/llvm-project/clang/CMakeLists.txt:560 (export): export called with target "clangB

Re: [PATCH] D13399: [CMake] Bug 14109 - CMake build for compiler-rt should use just-built clang

2015-10-07 Thread Alexey Samsonov via cfe-commits
samsonov added inline comments. Comment at: runtime/CMakeLists.txt:41 @@ +40,3 @@ + + add_custom_target(compiler-rt-clear +DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/compiler-rt-cleared So, that's the target that you can invoke manually to clean compiler-rt build?

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

2015-10-07 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 36816. sfantao added a comment. Make the offloading ELF sections consistent with what is in http://reviews.llvm.org/D12614. Fix bug in AtTopLevel flag, so that the bundling job is considered always top level job. Fix several typos. http://reviews.llvm.or

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

2015-10-07 Thread Samuel Antao via cfe-commits
sfantao added a comment. Art, Jonas, Thanks for the comments! In http://reviews.llvm.org/D9888#261434, @Hahnfeld wrote: > Currently trying to test, but > > 1. Offloading to the same target isn't supported (`x86_64-unknown-linux-gnu` > as host and device) - this was working with `clang-omp` The

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

2015-10-07 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/rename_check.py:53 @@ +52,3 @@ + return newFileName + +def getListOfFiles(clang_tidy_path): ClockMan wrote: > Not sure what you mean... I meant that after that patch the module file name can be more complex. H

r249647 - [WinEH] Remove NewMSEH and enable its behavior by default

2015-10-07 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Oct 7 20:13:52 2015 New Revision: 249647 URL: http://llvm.org/viewvc/llvm-project?rev=249647&view=rev Log: [WinEH] Remove NewMSEH and enable its behavior by default Testing has shown that it is at least as reliable as the old landingpad pattern matching code. Removed:

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

2015-10-07 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: include/clang/Basic/Attr.td:2098-2102 @@ +2097,7 @@ + let Documentation = [OMPDeclareSimdDocs]; + let AdditionalMembers = [{ + void printPrettyPragma(raw_ostream &OS, const PrintingPolicy &Policy) const { +OS << "\n"; + } + }]; +}

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

2015-10-07 Thread Samuel Antao via cfe-commits
sfantao added a comment. In http://reviews.llvm.org/D9888#262325, @tra wrote: > In http://reviews.llvm.org/D9888#257904, @sfantao wrote: > > > This diff refactors the original patch and is rebased on top of the latests > > offloading changes inserted for CUDA. > > > > Here I don't touch the CUDA

[libcxxabi] r249649 - Fix incorrect parsing of arguments for nested functions. Reviewed as http://reviews.llvm.org/D13192. Thanks to Anseny Kapoulkine for the patch.

2015-10-07 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Oct 7 22:02:09 2015 New Revision: 249649 URL: http://llvm.org/viewvc/llvm-project?rev=249649&view=rev Log: Fix incorrect parsing of arguments for nested functions. Reviewed as http://reviews.llvm.org/D13192. Thanks to Anseny Kapoulkine for the patch. Modified: lib

Re: [PATCH] D13375: [MSVC] Fix for http://llvm.org/PR24132: __declspec(property): double invocations of foo() when compiling foo()->propertyName

2015-10-07 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Ping http://reviews.llvm.org/D13375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

2015-10-07 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:323 @@ +322,3 @@ + /// far. + struct OffloadEntriesInfoManagerTy { +CodeGenModule &CGM; Maybe it is better to make it a class if it has some non-public members? http://reviews.llvm.or

r249652 - Fix a -Wdeclaration-after-statement warning.

2015-10-07 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Oct 7 22:37:36 2015 New Revision: 249652 URL: http://llvm.org/viewvc/llvm-project?rev=249652&view=rev Log: Fix a -Wdeclaration-after-statement warning. Modified: cfe/trunk/tools/c-index-test/c-index-test.c Modified: cfe/trunk/tools/c-index-test/c-index-test.c URL:

Re: r249639 - Make clang_Cursor_getMangling not mangle if the declaration isn't mangled

2015-10-07 Thread Craig Topper via cfe-commits
FYI, this caused a -Wdeclaration-after-statement warning that I fixed in r249652. On Wed, Oct 7, 2015 at 5:01 PM, Ehsan Akhgari via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ehsan > Date: Wed Oct 7 19:01:20 2015 > New Revision: 249639 > > URL: http://llvm.org/viewvc/llvm-project

r249656 - [MSVC Compat] Enable ABI impacting non-conforming behavior independently of -fms-compatibility

2015-10-07 Thread David Majnemer via cfe-commits
Author: majnemer Date: Wed Oct 7 23:53:31 2015 New Revision: 249656 URL: http://llvm.org/viewvc/llvm-project?rev=249656&view=rev Log: [MSVC Compat] Enable ABI impacting non-conforming behavior independently of -fms-compatibility No ABI for C++ currently makes it possible to implement the standa

r249657 - Unbreak 'debug-options' test when builder is Darwin

2015-10-07 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Thu Oct 8 00:02:24 2015 New Revision: 249657 URL: http://llvm.org/viewvc/llvm-project?rev=249657&view=rev Log: Unbreak 'debug-options' test when builder is Darwin Modified: cfe/trunk/test/Driver/debug-options.c Modified: cfe/trunk/test/Driver/debug-options.c URL: http:/

r249658 - Use itostr(), not std::to_string() because of Android.

2015-10-07 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Thu Oct 8 00:25:03 2015 New Revision: 249658 URL: http://llvm.org/viewvc/llvm-project?rev=249658&view=rev Log: Use itostr(), not std::to_string() because of Android. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/v

Re: [clang-tools-extra] r249399 - Add a new module for the C++ Core Guidelines, and the first checker for those guidelines: cppcoreguidelines-pro-type-reinterpret-cast.

2015-10-07 Thread Manuel Klimek via cfe-commits
On Wed, Oct 7, 2015 at 7:34 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, Oct 7, 2015 at 12:05 PM, Joerg Sonnenberger via cfe-commits > wrote: > > On Tue, Oct 06, 2015 at 01:31:01PM -, Aaron Ballman via cfe-commits > wrote: > >> Log: > >> Add a new module for

r249660 - Update tests touched by r249656

2015-10-07 Thread David Majnemer via cfe-commits
Author: majnemer Date: Thu Oct 8 01:31:22 2015 New Revision: 249660 URL: http://llvm.org/viewvc/llvm-project?rev=249660&view=rev Log: Update tests touched by r249656 These test updates almost exclusively around the change in behavior around enum: enums without a definition are considered incompl

Re: Implict casts disappeared from syntactic init list expressions in C++

2015-10-07 Thread Abramo Bagnara via cfe-commits
Ping^2 Il 12/09/2015 09:40, Abramo Bagnara ha scritto: > Ping... > > Il 29/08/2015 10:01, Abramo Bagnara ha scritto: >> Il 28/08/2015 23:27, Richard Smith ha scritto: >>> On Tue, Aug 25, 2015 at 10:27 AM, Abramo Bagnara >>> mailto:abramo.bagn...@bugseng.com>> wrote: >>> >>> Comparing the resu

<    1   2