Re: [PATCH] D13406: [Clang] Fix Clang-tidy modernize-use-nullptr warnings in source directories; other minor cleanups.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/Sema/SemaDeclObjC.cpp:510 @@ -509,3 +509,3 @@ -if (PrevDecl && SuperClassDecl == 0) { +if (PrevDecl && (!SuperClassDecl)) { // The previous d

Re: [PATCH] D13406: [Clang] Fix Clang-tidy modernize-use-nullptr warnings in source directories; other minor cleanups.

This revision was automatically updated to reflect the committed changes. Closed by commit rL249484: Fix Clang-tidy modernize-use-nullptr warnings in source directories; other… (authored by hans). Changed prior to commit: http://reviews.llvm.org/D13406?vs=36425&id=36680#toc Repository: rL LL

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF updated this revision to Diff 36682. EricWF added a comment. Use `type` instead of `cat` on windows as suggested by @rnk. @eugenis does this address your concern? http://reviews.llvm.org/D13407 Files: CMakeLists.txt cmake/Modules/HandleLibcxxFlags.cmake docs/DesignDocs/CapturingCo

[PATCH] D13488: [analyzer] Assume escape is possible through system functions taking void*

zaks.anna created this revision. zaks.anna added a reviewer: dcoughlin. zaks.anna added subscribers: xazax.hun, cfe-commits. Herald added a subscriber: aemerson. The analyzer assumes that system functions will not free memory or modify the arguments in other ways, so we assume that arguments do n

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

eugenis added a comment. In http://reviews.llvm.org/D13407#261228, @EricWF wrote: > Use `type` instead of `cat` on windows as suggested by @rnk. @eugenis does > this address your concern? Absolutely! LGTM http://reviews.llvm.org/D13407 ___ cfe-c

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF added a comment. Cool. I've reached out to some platform maintainers to make sure they don't see any problems. I'll commit this once I hear back. http://reviews.llvm.org/D13407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D12747: Implement [depr.c.headers]

On Tue, Oct 6, 2015 at 4:16 PM, Sean Silva wrote: > On Tue, Oct 6, 2015 at 4:13 PM, Richard Smith > wrote: > >> On Tue, Oct 6, 2015 at 4:11 PM, Sean Silva wrote: >> >>> +extern "C++" { >>> +#include <__nullptr> >>> +using std::nullptr_t; >>> +} >>> >>> Does this even compile with modules? >>> >

Re: [PATCH] D9898: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D9898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [clang-tools-extra] r249235 - Replace double negation of !FileID.isInvalid() with FileID.isValid().

I'd say that the SourceLocation::isInvalid is more confusing than useful. Not sure why it was added in the first place. On Sat, Oct 3, 2015 at 12:46 PM, Yaron Keren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: yrnkrn > Date: Sat Oct 3 05:46:20 2015 > New Revision: 249235 > > UR

Re: [PATCH] D12644: Using -isysroot on Apple platform

EricWF added a comment. You need to use the CMake option `CMAKE_OSX_SYSROOT` to manage the system root because `lib/CMakeLists.txt` uses "CMAKE_OSX_SYSROOT" to find the correct libc++abi.dylib. Have you tried that? It is unfortunate that Linux and OS X use different options for the same thing t

r249497 - [SEH] Fix x64 __exception_code in __except blocks

Author: rnk Date: Tue Oct 6 20:07:13 2015 New Revision: 249497 URL: http://llvm.org/viewvc/llvm-project?rev=249497&view=rev Log: [SEH] Fix x64 __exception_code in __except blocks Use llvm.eh.exceptioncode to get the code out of EAX for x64. For 32-bit, the filter is responsible for storing it to

Re: [PATCH] D13488: [analyzer] Assume escape is possible through system functions taking void*

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Has a typo but otherwise LGTM. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:258 @@ +257,3 @@ + /// the condition. + bool hasNonNullArguments

r249499 - clang/test/CodeGen/exceptions-seh-leave-new.c: Use "opt -instnamer" for branch-sensitive checks.

Author: chapuni Date: Tue Oct 6 20:29:26 2015 New Revision: 249499 URL: http://llvm.org/viewvc/llvm-project?rev=249499&view=rev Log: clang/test/CodeGen/exceptions-seh-leave-new.c: Use "opt -instnamer" for branch-sensitive checks. Modified: cfe/trunk/test/CodeGen/exceptions-seh-leave-new.c

r249501 - clang-format: Fix false positive in pointer/reference detection.

Author: djasper Date: Tue Oct 6 20:41:14 2015 New Revision: 249501 URL: http://llvm.org/viewvc/llvm-project?rev=249501&view=rev Log: clang-format: Fix false positive in pointer/reference detection. Before: return options != nullptr &&operator==(*options); After: return options != nullptr &&

r249502 - clang-format: Understand array reference types.

Author: djasper Date: Tue Oct 6 20:41:22 2015 New Revision: 249502 URL: http://llvm.org/viewvc/llvm-project?rev=249502&view=rev Log: clang-format: Understand array reference types. Before: void f(Type(¶meter)[10]) {} void f(Type (*parameter)[10]) {} After: void f(Type (¶meter)[10]) {} v

Re: [PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

ksuther added a comment. Do I need to do anything else about this and http://reviews.llvm.org/D12489, or do they eventually get committed by someone else? Thanks! http://reviews.llvm.org/D12501 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

Re: [PATCH] D13398: [clang-tidy] add check cppcoreguidelines-pro-type-const-cast

alexfh added a comment. It looks like potentially we're going to have tens of checks in this module. I wonder whether we should start organizing the checks somehow right away. For example, create a directory (and a namespace) for each profile. We'd need to adapt the add_new_check.py script to s

r249517 - clang-format: Fix false ObjC block detection.

Author: djasper Date: Tue Oct 6 22:43:10 2015 New Revision: 249517 URL: http://llvm.org/viewvc/llvm-project?rev=249517&view=rev Log: clang-format: Fix false ObjC block detection. Before: inline A operator^(const A &lhs, const A &rhs) {} int i; After: inline A operator^(const A &lhs, const A

r249519 - Make clang-format actually respect custom brace wrapping flags.

Author: djasper Date: Tue Oct 6 23:06:10 2015 New Revision: 249519 URL: http://llvm.org/viewvc/llvm-project?rev=249519&view=rev Log: Make clang-format actually respect custom brace wrapping flags. This fixes llvm.org/PR25073. Modified: cfe/trunk/lib/Format/Format.cpp cfe/trunk/unittests

Re: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy

randomcppprogrammer updated this revision to Diff 36700. randomcppprogrammer marked 17 inline comments as done. randomcppprogrammer added a comment. reworked code to include the changes suggested by Aaron Ballman main changes - will not diagnose on throwing catch variables by value/pointer - wil

<    1   2