Re: [PATCH] D13326: [PGO]: Eliminate __llvm_profile_register calls for Linux (clang changes)

David Li writes: > davidxl updated this revision to Diff 36316. > davidxl added a comment. > > I have modified the implementation to not use linker script, so this > clang patch becomes strictly refactoring with NFC. I think it is still > a good thing to have this in so that similar tunings like t

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

xazax.hun marked 2 inline comments as done. xazax.hun added a comment. In http://reviews.llvm.org/D10305#258671, @zaks.anna wrote: > > Generating mangled names requires ASTContext which is not available during > > the error reporting. BugReporter does have the ASTContext, so it would not > > >

Re: [PATCH] D13100: [mips] Separated mips specific -Wa options, so that they are not checked on other platforms.

dsanders accepted this revision. dsanders added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

seaneveson updated this revision to Diff 36600. seaneveson added a comment. Updated to latest revision. Moved tests into their own file. Added (RegionAndSymbolInvalidationTraits *ETraits) parameter to CallEvent::getExtraInvalidatedValues and overrides. Prevent invalidation by using TK_PreserveCon

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

xazax.hun added inline comments. Comment at: test/Analysis/const-method-call.cpp:26 @@ +25,3 @@ + +struct Derived : Base { + mutable int mut; Please add a test case, where only base have a mutable field. http://reviews.llvm.org/D13099 __

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

seaneveson marked 6 inline comments as done. seaneveson added a comment. There is an issue where pointers to the object (this) should cause it to be invalidated, but don't since TK_PreserveContents has been set. For example: class B; class A { B b; const foo(); }; class B {

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

seaneveson updated this revision to Diff 36604. seaneveson added a comment. Removed mutable field from derived class in inheritance test case. http://reviews.llvm.org/D13099 Files: include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h lib/StaticAnalyzer/Core/CallEvent.cpp test/Analy

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

seaneveson marked an inline comment as done. seaneveson added a comment. http://reviews.llvm.org/D13099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r249385 - [VFS] Transition clang-format to use an in-memory FS.

Author: d0k Date: Tue Oct 6 05:04:08 2015 New Revision: 249385 URL: http://llvm.org/viewvc/llvm-project?rev=249385&view=rev Log: [VFS] Transition clang-format to use an in-memory FS. Apart from being cleaner this also means that clang-format no longer has access to the host file system. This isn

r249388 - [VFS] Port applyAllReplacements to InMemoryFileSystem.

Author: d0k Date: Tue Oct 6 05:23:17 2015 New Revision: 249388 URL: http://llvm.org/viewvc/llvm-project?rev=249388&view=rev Log: [VFS] Port applyAllReplacements to InMemoryFileSystem. Modified: cfe/trunk/lib/Tooling/Core/Replacement.cpp Modified: cfe/trunk/lib/Tooling/Core/Replacement.cpp U

r249389 - [VFS] Port SimpleFormatContext to InMemoryFileSystem.

Author: d0k Date: Tue Oct 6 05:23:34 2015 New Revision: 249389 URL: http://llvm.org/viewvc/llvm-project?rev=249389&view=rev Log: [VFS] Port SimpleFormatContext to InMemoryFileSystem. Modified: cfe/trunk/lib/Index/SimpleFormatContext.h Modified: cfe/trunk/lib/Index/SimpleFormatContext.h URL:

Re: [PATCH] D13318: Add a utility function to add target information to a command line

klimek closed this revision. klimek added a comment. Submitted as r249391. http://reviews.llvm.org/D13318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r249391 - Adds a way for tools to deduce the target config from a compiler name.

Author: klimek Date: Tue Oct 6 05:45:03 2015 New Revision: 249391 URL: http://llvm.org/viewvc/llvm-project?rev=249391&view=rev Log: Adds a way for tools to deduce the target config from a compiler name. Adds `addTargetAndModeForProgramName`, a utility function that will add appropriate `-target

r249392 - clang-format: Make IncludeCategories configurable in .clang-format file.

Author: djasper Date: Tue Oct 6 06:54:18 2015 New Revision: 249392 URL: http://llvm.org/viewvc/llvm-project?rev=249392&view=rev Log: clang-format: Make IncludeCategories configurable in .clang-format file. This was made much easier by introducing an IncludeCategory struct to replace the previous

r249394 - clang-format: Add empty line before code-blocks in Docs.

Author: djasper Date: Tue Oct 6 07:11:51 2015 New Revision: 249394 URL: http://llvm.org/viewvc/llvm-project?rev=249394&view=rev Log: clang-format: Add empty line before code-blocks in Docs. Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst cfe/trunk/docs/tools/dump_format_style.py Mo

r249395 - BasicTests: Suppress InMemoryFileSystemTest.WindowsPath on win32 while investigating.

Author: chapuni Date: Tue Oct 6 07:16:27 2015 New Revision: 249395 URL: http://llvm.org/viewvc/llvm-project?rev=249395&view=rev Log: BasicTests: Suppress InMemoryFileSystemTest.WindowsPath on win32 while investigating. Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp Modified:

Re: [PATCH] D13383: [clang] Add flag to DeclContext to distinguish between qualified and unqualified name lookups

evgeny777 added a comment. Hello Jim and Sean, Greg suggested adding you for this review. Can you please take a look? http://reviews.llvm.org/D13383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D13386: PR24115: Don't instantiate constexpr function templates in decltype

sberg abandoned this revision. sberg added a comment. Ah, I see. I'll wait for that approach to be implemented then. http://reviews.llvm.org/D13386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D13444: [clang-tidy] Clocky module and multiple check from my repository

ClockMan abandoned this revision. ClockMan added a comment. As a 'corporation' in which I work has doubts that checks developed by my after work, but tested on copyright protected code should be released to public under my 'name'. I will drop "push request", until everything will clarify. As fo

[PATCH] D13469: Create interfaces and tests for the overlapping replacements fix in clang-tidy.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: cfe-commits, alexfh. No changes in clang-tidy yet. http://reviews.llvm.org/D13469 Files: unittests/clang-tidy/CMakeLists.txt unittests/clang-tidy/ClangTidyTest.h unittests/clang-tidy/Ove

Re: [PATCH] D13469: Create interfaces and tests for the overlapping replacements fix in clang-tidy.

klimek added inline comments. Comment at: unittests/clang-tidy/OverlappingReplacementsTest.cpp:133 @@ +132,3 @@ + +TEST(OverlappingReplacementsTest, TestingChecksWorkAsExpected) { + const char Code[] = I'd split it up and give the tests better names. TestingCheck

Re: [PATCH] D13469: Create interfaces and tests for the overlapping replacements fix in clang-tidy.

angelgarcia updated this revision to Diff 36615. angelgarcia added a comment. This test was intended to ensure that we don't have a bug in the mock checks. I've split it up into one test for each mock check, I hope it is more descriptive now. http://reviews.llvm.org/D13469 Files: unittests/

[clang-tools-extra] r249399 - Add a new module for the C++ Core Guidelines, and the first checker for those guidelines: cppcoreguidelines-pro-type-reinterpret-cast.

Author: aaronballman Date: Tue Oct 6 08:31:00 2015 New Revision: 249399 URL: http://llvm.org/viewvc/llvm-project?rev=249399&view=rev Log: Add a new module for the C++ Core Guidelines, and the first checker for those guidelines: cppcoreguidelines-pro-type-reinterpret-cast. Patch by Matthias Gehr

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've committed it in r249399. ~Aaron http://reviews.llvm.org/D13313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [PATCH] D13469: Create interfaces and tests for the overlapping replacements fix in clang-tidy.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Comment at: unittests/clang-tidy/OverlappingReplacementsTest.cpp:21 @@ +20,3 @@ +const char BoundIf[] = "if"; + +class UseCharCheck : public ClangTidyCheck { --

Re: [PATCH] D13469: Create interfaces and tests for the overlapping replacements fix in clang-tidy.

angelgarcia updated this revision to Diff 36620. angelgarcia added a comment. Explain why we have defined these mocks. http://reviews.llvm.org/D13469 Files: unittests/clang-tidy/CMakeLists.txt unittests/clang-tidy/ClangTidyTest.h unittests/clang-tidy/OverlappingReplacementsTest.cpp unit

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

aaron.ballman added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-bounds-pointer-arithmetic.cpp:37 @@ +36,3 @@ + q -= i; + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: do not use pointer arithmetic + q -= ENUM_LITERAL; I don't think this co

[clang-tools-extra] r249402 - Create interfaces and tests for the overlapping replacements fix in clang-tidy.

Author: angelgarcia Date: Tue Oct 6 08:52:51 2015 New Revision: 249402 URL: http://llvm.org/viewvc/llvm-project?rev=249402&view=rev Log: Create interfaces and tests for the overlapping replacements fix in clang-tidy. Summary: No changes in clang-tidy yet. Reviewers: klimek Subscribers: alexfh,

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

aaron.ballman added a comment. On Mon, Oct 5, 2015 at 6:14 PM, Matthias Gehre wrote: > mgehre marked an inline comment as done. > > > Comment at: > clang-tidy/cppcoreguidelines/ProTypeStaticCastDowncastCheck.cpp:53 > @@ +52,3 @@ > + } else { > +diag(MatchedCast-

r249403 - ToolingTests: Tweak getAnyTarget() to match "x86_64".

Author: chapuni Date: Tue Oct 6 08:58:13 2015 New Revision: 249403 URL: http://llvm.org/viewvc/llvm-project?rev=249403&view=rev Log: ToolingTests: Tweak getAnyTarget() to match "x86_64". Both "x86" and "x86-64" are incompatible to triple's arch. Modified: cfe/trunk/unittests/Tooling/Tooling

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

klimek added a subscriber: klimek. klimek added a comment. In http://reviews.llvm.org/D13368#260669, @aaron.ballman wrote: > This wasn't a comment on the rule so much as a comment on the diagnostic not > being very helpful.In this case, you're telling the user to not do something, > but it is u

Re: [PATCH] D13383: [clang] Add flag to DeclContext to distinguish between qualified and unqualified name lookups

aaron.ballman added a comment. I'm uncertain whether this change is good or not (Richard is more likely to have thoughts on that), but the patch is missing tests. Comment at: clang/lib/Sema/SemaLookup.cpp:208 @@ +207,3 @@ + + class Deinitializer { +std::function Deinit; --

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

aaron.ballman added a comment. In http://reviews.llvm.org/D13368#260672, @klimek wrote: > In http://reviews.llvm.org/D13368#260669, @aaron.ballman wrote: > > > This wasn't a comment on the rule so much as a comment on the diagnostic > > not being very helpful.In this case, you're telling the use

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

On Tue, Oct 6, 2015 at 4:12 PM Aaron Ballman wrote: > aaron.ballman added a comment. > > In http://reviews.llvm.org/D13368#260672, @klimek wrote: > > > In http://reviews.llvm.org/D13368#260669, @aaron.ballman wrote: > > > > > This wasn't a comment on the rule so much as a comment on the > diagnos

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

On Tue, Oct 6, 2015 at 10:15 AM, Manuel Klimek wrote: > On Tue, Oct 6, 2015 at 4:12 PM Aaron Ballman > wrote: >> >> aaron.ballman added a comment. >> >> In http://reviews.llvm.org/D13368#260672, @klimek wrote: >> >> > In http://reviews.llvm.org/D13368#260669, @aaron.ballman wrote: >> > >> > > Thi

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

On Tue, Oct 6, 2015 at 4:18 PM Aaron Ballman wrote: > On Tue, Oct 6, 2015 at 10:15 AM, Manuel Klimek wrote: > > On Tue, Oct 6, 2015 at 4:12 PM Aaron Ballman > > wrote: > >> > >> aaron.ballman added a comment. > >> > >> In http://reviews.llvm.org/D13368#260672, @klimek wrote: > >> > >> > In http

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

On Tue, Oct 6, 2015 at 10:19 AM, Manuel Klimek wrote: > On Tue, Oct 6, 2015 at 4:18 PM Aaron Ballman > wrote: >> >> On Tue, Oct 6, 2015 at 10:15 AM, Manuel Klimek wrote: >> > On Tue, Oct 6, 2015 at 4:12 PM Aaron Ballman >> > wrote: >> >> >> >> aaron.ballman added a comment. >> >> >> >> In http:

r249410 - [Tooling] Reuse FileManager in ASTUnit.

Author: d0k Date: Tue Oct 6 09:45:20 2015 New Revision: 249410 URL: http://llvm.org/viewvc/llvm-project?rev=249410&view=rev Log: [Tooling] Reuse FileManager in ASTUnit. ASTUnit was creating multiple FileManagers and throwing them away. Reuse the one from Tooling. No functionality change now but

r249409 - [VFS] Put the incoming name in the file status to make InMemoryFS behave more like a real FS.

Author: d0k Date: Tue Oct 6 09:45:16 2015 New Revision: 249409 URL: http://llvm.org/viewvc/llvm-project?rev=249409&view=rev Log: [VFS] Put the incoming name in the file status to make InMemoryFS behave more like a real FS. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp cfe/trunk/un

r249408 - [Tooling] Remove dead code.

Author: d0k Date: Tue Oct 6 09:45:13 2015 New Revision: 249408 URL: http://llvm.org/viewvc/llvm-project?rev=249408&view=rev Log: [Tooling] Remove dead code. It took me some time to figure out why this is not working as expected: std:error_code converts to true if there is an error. This means we

[PATCH] D13474: [VFS] Port tooling to use the in-memory file system.

bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. This means file remappings can now be managed by ClangTool (or a ToolInvocation user) instead of by ToolInvocation itself. The ToolInvocation remapping is st

r249413 - [Tooling] Don't run a tool invocation without a FileManager.

Author: d0k Date: Tue Oct 6 10:04:13 2015 New Revision: 249413 URL: http://llvm.org/viewvc/llvm-project?rev=249413&view=rev Log: [Tooling] Don't run a tool invocation without a FileManager. Fixes a crash regression from r249410. Modified: cfe/trunk/lib/Tooling/Tooling.cpp Modified: cfe/tru

Re: r249395 - BasicTests: Suppress InMemoryFileSystemTest.WindowsPath on win32 while investigating.

What was the error? On 6 October 2015 at 08:16, NAKAMURA Takumi via cfe-commits wrote: > Author: chapuni > Date: Tue Oct 6 07:16:27 2015 > New Revision: 249395 > > URL: http://llvm.org/viewvc/llvm-project?rev=249395&view=rev > Log: > BasicTests: Suppress InMemoryFileSystemTest.WindowsPath on win

Re: [PATCH] D13444: [clang-tidy] Clocky module and multiple check from my repository

On Tue, Oct 6, 2015 at 8:56 AM, Piotr Zegar wrote: > ClockMan abandoned this revision. > ClockMan added a comment. > > As a 'corporation' in which I work has doubts that checks developed by my > after work, but tested on copyright protected code should be released to > public under my 'name'. I

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you have commit access, or would you like me to commit on your behalf? http://reviews.llvm.org/D12839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

Re: [PATCH] D13474: [VFS] Port tooling to use the in-memory file system.

bkramer updated this revision to Diff 36632. bkramer added a comment. - Don't rebuild VFS for every compile command - Still have to guard against multiple runs of one Tool, ClangToolTest.ArgumentAdjusters does that. http://reviews.llvm.org/D13474 Files: include/clang/Tooling/Tooling.h lib/

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

flx added a comment. I don't have access, so that'd be great if you or Alex could submit the patch, thanks! Comment at: clang-tidy/misc/MoveConstructorInitCheck.cpp:11 @@ -10,2 +10,3 @@ #include "MoveConstructorInitCheck.h" +#include "../utils/Matchers.h" #include "clang/AST/

Re: [PATCH] D13465: Add SafeStack support for test-suite.

jroelofs added a subscriber: jroelofs. jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13465 ___ cfe-commits mailing list

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've commit in r249429. http://reviews.llvm.org/D12839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[clang-tools-extra] r249429 - Improved the misc-move-constructor-init check to identify arguments that are passed by value but copy assigned to class data members when the non-deleted move constructor

Author: aaronballman Date: Tue Oct 6 11:27:03 2015 New Revision: 249429 URL: http://llvm.org/viewvc/llvm-project?rev=249429&view=rev Log: Improved the misc-move-constructor-init check to identify arguments that are passed by value but copy assigned to class data members when the non-deleted mov

[clang-tools-extra] r249430 - Attempting to appease the CMake build bots after r249429.

Author: aaronballman Date: Tue Oct 6 11:32:50 2015 New Revision: 249430 URL: http://llvm.org/viewvc/llvm-project?rev=249430&view=rev Log: Attempting to appease the CMake build bots after r249429. Modified: clang-tools-extra/trunk/clang-tidy/misc/CMakeLists.txt Modified: clang-tools-extra/tr

Re: [PATCH] D13383: [clang] Add flag to DeclContext to distinguish between qualified and unqualified name lookups

aaron.ballman added a comment. In http://reviews.llvm.org/D13383#260815, @evgeny777 wrote: > What kind of tests do you propose for this? It doesn't introduce any new > features to clang, only to lldb where the separate review exists It modifies the behavior of all qualified lookups in Clang, s

Re: [PATCH] D13383: [clang] Add flag to DeclContext to distinguish between qualified and unqualified name lookups

evgeny777 added a comment. What kind of tests do you propose for this? It doesn't introduce any new features to clang, only to lldb where the separate review exists http://reviews.llvm.org/D13383 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D13383: [clang] Add flag to DeclContext to distinguish between qualified and unqualified name lookups

aaron.ballman added a comment. In http://reviews.llvm.org/D13383#260821, @evgeny777 wrote: > In case of qualified lookup it raises flag in DeclContext, which is not used > anywhere else in clang, only in lldb (clang expression parser is linked to > lldb). Hah, good point, the test case is in

Re: [PATCH] D13383: [clang] Add flag to DeclContext to distinguish between qualified and unqualified name lookups

evgeny777 added a comment. In case of qualified lookup it raises flag in DeclContext, which is not used anywhere else in clang, only in lldb (clang expression parser is linked to lldb). http://reviews.llvm.org/D13383 ___ cfe-commits mailing list c

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thanks for working on this! LGTM, Anna. http://reviews.llvm.org/D10305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

Re: [PATCH] D13444: [clang-tidy] Clocky module and multiple check from my repository

Splinting a patch into separate check it's not a problem. I have organized commits in that way. About a 'author' in name, organization is also a author, so clocky is a 'one man organization' :D. It's much more simple, I have no benefits in 'anonymous' contribution, in that case I would rather go

Re: [PATCH] D13465: Add SafeStack support for test-suite.

jroelofs added a comment. In http://reviews.llvm.org/D13465#260628, @tharvik wrote: > When running the test suite, it gives a bunch of `undefined reference to > '__safestack_unsafe_stack_ptr'`. > See regression results . Sounds like it's missing the safestack run

r249437 - Make clang_Cursor_getMangling don't mangle if the declaration isn't mangled

Author: ehsan Date: Tue Oct 6 13:24:33 2015 New Revision: 249437 URL: http://llvm.org/viewvc/llvm-project?rev=249437&view=rev Log: Make clang_Cursor_getMangling don't mangle if the declaration isn't mangled Right now clang_Cursor_getMangling will attempt to mangle any declaration, even if the de

Re: [PATCH] D13317: clang_Cursor_getMangling shouldn't mangle if the declaration isn't mangled

ehsan closed this revision. ehsan added a comment. Landed in r249437. http://reviews.llvm.org/D13317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13326: [PGO]: Eliminate __llvm_profile_register calls for Linux (clang changes)

Clang FE refactoring change is not needed anymore. In commit 0d32e7d952bc80830183e0c2c6ec5027ca6b1450, Vasileios Kalintiris did the same thing for multi-lib support. David On Tue, Oct 6, 2015 at 12:13 AM, Justin Bogner wrote: > David Li writes: >> davidxl updated this revision to Diff 36316. >

r249440 - Revert r249437

Author: ehsan Date: Tue Oct 6 13:53:12 2015 New Revision: 249440 URL: http://llvm.org/viewvc/llvm-project?rev=249440&view=rev Log: Revert r249437 Modified: cfe/trunk/test/Index/print-mangled-name.cpp cfe/trunk/tools/c-index-test/c-index-test.c cfe/trunk/tools/libclang/CIndex.cpp Mod

[clang-tools-extra] r249444 - Change the write modes to "binary" so that line endings do not get munged on Windows. Otherwise, when this script is run, all files created on Windows have CRLF instead o

Author: aaronballman Date: Tue Oct 6 14:11:12 2015 New Revision: 249444 URL: http://llvm.org/viewvc/llvm-project?rev=249444&view=rev Log: Change the write modes to "binary" so that line endings do not get munged on Windows. Otherwise, when this script is run, all files created on Windows have C

[libclc] r249445 - integer: remove explicit casts from _MIN definitions

Author: awatry Date: Tue Oct 6 14:12:12 2015 New Revision: 249445 URL: http://llvm.org/viewvc/llvm-project?rev=249445&view=rev Log: integer: remove explicit casts from _MIN definitions The spec says (section 6.12.3, CL version 1.2): The macro names given in the following list must use the valu

Re: [PATCH] D13317: clang_Cursor_getMangling shouldn't mangle if the declaration isn't mangled

michaelwu updated this revision to Diff 36645. michaelwu added a comment. Turns out clang_isUnexposed is what I wanted, rather than clang_isInvalid. I remember seeing clang_isInvalid work though.. http://reviews.llvm.org/D13317 Files: test/Index/print-mangled-name.cpp tools/c-index-test/c-

Re: r249413 - [Tooling] Don't run a tool invocation without a FileManager.

On Tue, Oct 6, 2015 at 8:04 AM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Tue Oct 6 10:04:13 2015 > New Revision: 249413 > > URL: http://llvm.org/viewvc/llvm-project?rev=249413&view=rev > Log: > [Tooling] Don't run a tool invocation without a FileM

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

eugenis added a comment. Looks great! Comment at: include/CMakeLists.txt:31 @@ +30,3 @@ +# by prepending __config_site to the current __config header. +# TODO(EricWF) Is it portable to use "cat" and ">>"? +add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_c

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

On Mon, Oct 05, 2015 at 07:36:08PM +, Aaron Ballman via cfe-commits wrote: > C-style variadic functions (using an ellipsis) can be dangerous in C++ > due to the inherit lack of type safety with argument passing. Better > alternatives exist, such as function currying (like STL stream objects > u

Re: [libclc] r249445 - integer: remove explicit casts from _MIN definitions

On Tue, Oct 06, 2015 at 07:12:12PM -, Aaron Watry via cfe-commits wrote: > Author: awatry > Date: Tue Oct 6 14:12:12 2015 > New Revision: 249445 > > URL: http://llvm.org/viewvc/llvm-project?rev=249445&view=rev > Log: > integer: remove explicit casts from _MIN definitions Why do this definiti

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

On Tue, Oct 6, 2015 at 4:12 PM, Joerg Sonnenberger via cfe-commits wrote: > On Mon, Oct 05, 2015 at 07:36:08PM +, Aaron Ballman via cfe-commits wrote: >> C-style variadic functions (using an ellipsis) can be dangerous in C++ >> due to the inherit lack of type safety with argument passing. Bett

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF added inline comments. Comment at: include/CMakeLists.txt:31 @@ +30,3 @@ +# by prepending __config_site to the current __config header. +# TODO(EricWF) Is it portable to use "cat" and ">>"? +add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_config

[PATCH] D13482: Revised Initial patch for PS4 toolchain

kromanova created this revision. kromanova added reviewers: filcab, echristo, alexr, probinson. kromanova added subscribers: silvas, cfe-commits, chapuni, jroelofs, asl, pgousseau, gbedwell. kromanova set the repository for this revision to rL LLVM. Initial patch for PS4 toolchain was created her

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

eugenis added inline comments. Comment at: include/CMakeLists.txt:31 @@ +30,3 @@ +# by prepending __config_site to the current __config header. +# TODO(EricWF) Is it portable to use "cat" and ">>"? +add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_config ---

[libcxx] r249458 - Our test allocators support move/copy construction; they should support move/copy assignment as well

Author: marshall Date: Tue Oct 6 15:30:56 2015 New Revision: 249458 URL: http://llvm.org/viewvc/llvm-project?rev=249458&view=rev Log: Our test allocators support move/copy construction; they should support move/copy assignment as well Modified: libcxx/trunk/test/support/allocators.h Modifi

[libcxx] r249461 - Updated issue 2476

Author: marshall Date: Tue Oct 6 15:35:15 2015 New Revision: 249461 URL: http://llvm.org/viewvc/llvm-project?rev=249461&view=rev Log: Updated issue 2476 Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/www/kona.

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

On Tue, Oct 06, 2015 at 04:20:05PM -0400, Aaron Ballman via cfe-commits wrote: > On Tue, Oct 6, 2015 at 4:12 PM, Joerg Sonnenberger via cfe-commits > wrote: > > On Mon, Oct 05, 2015 at 07:36:08PM +, Aaron Ballman via cfe-commits > > wrote: > >> C-style variadic functions (using an ellipsis) c

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

On Tue, Oct 6, 2015 at 4:49 PM, Joerg Sonnenberger via cfe-commits wrote: > On Tue, Oct 06, 2015 at 04:20:05PM -0400, Aaron Ballman via cfe-commits wrote: >> On Tue, Oct 6, 2015 at 4:12 PM, Joerg Sonnenberger via cfe-commits >> wrote: >> > On Mon, Oct 05, 2015 at 07:36:08PM +, Aaron Ballman v

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF added inline comments. Comment at: include/CMakeLists.txt:31 @@ +30,3 @@ +# by prepending __config_site to the current __config header. +# TODO(EricWF) Is it portable to use "cat" and ">>"? +add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_config

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

rnk added a subscriber: rnk. Comment at: include/CMakeLists.txt:31 @@ +30,3 @@ +# by prepending __config_site to the current __config header. +# TODO(EricWF) Is it portable to use "cat" and ">>"? +add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_config -

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

mgehre marked 2 inline comments as done. Comment at: test/clang-tidy/cppcoreguidelines-pro-bounds-pointer-arithmetic.cpp:37 @@ +36,3 @@ + q -= i; + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: do not use pointer arithmetic + q -= ENUM_LITERAL; aaron.ballman wro

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

mgehre updated this revision to Diff 36664. mgehre added a comment. Remove trailing [cppcoreguidelines-pro-type-static-cast-downcast] on tests http://reviews.llvm.org/D13368 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp cla

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

mgehre marked an inline comment as done. mgehre added a comment. I cannot think of any way to improve the usefulness of the diagnostic in the non-polymorphic case. For now, this patch has a link to the CppCoreGuidelines document in the docs/**/*.rst file. Also, this check is not enabled by defa

Re: [PATCH] D13398: [clang-tidy] add check cppcoreguidelines-pro-type-const-cast

mgehre updated this revision to Diff 36668. mgehre added a comment. Rebased http://reviews.llvm.org/D13398 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/cppcoreguidelines/ProTypeConstCastCheck.cpp clang-tidy/cp

Re: [PATCH] D12747: Implement [depr.c.headers]

On Mon, Oct 5, 2015 at 7:10 PM, Eric Fiselier wrote: > EricWF added a comment. > > I think thing change will help us close a number out outstanding bugs. I > don't have any fundamental objections to this approach. However the size > of this patch scares me. I understand the changes are mostly m

Re: [PATCH] D12747: Implement [depr.c.headers]

LGTM. On Tue, Oct 6, 2015 at 3:58 PM, Richard Smith wrote: > On Mon, Oct 5, 2015 at 7:10 PM, Eric Fiselier wrote: >> >> EricWF added a comment. >> >> I think thing change will help us close a number out outstanding bugs. I >> don't have any fundamental objections to this approach. However the s

[libcxx] r249475 - Remove unnecessary inline functions capturing the contents of C library macros.

Author: rsmith Date: Tue Oct 6 17:03:22 2015 New Revision: 249475 URL: http://llvm.org/viewvc/llvm-project?rev=249475&view=rev Log: Remove unnecessary inline functions capturing the contents of C library macros. The C standard requires that these be provided as functions even if they're also pro

Re: [PATCH] D12747: Implement [depr.c.headers]

Next: factoring the definition of std::nullptr_t out into a separate file, so that and can both use it, without including and without providing a ::nullptr_t like does. On Tue, Oct 6, 2015 at 3:02 PM, Eric Fiselier wrote: > LGTM. > > On Tue, Oct 6, 2015 at 3:58 PM, Richard Smith > wrote:

cfe-commits@lists.llvm.org

rjmccall added a comment. LGTM. http://reviews.llvm.org/D13325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12747: Implement [depr.c.headers]

Split header out of On Tue, Oct 6, 2015 at 3:07 PM, Richard Smith wrote: > Next: factoring the definition of std::nullptr_t out into a separate file, > so that and can both use it, without > including and without providing a ::nullptr_t like > does. > > On Tue, Oct 6, 2015 at 3:02 PM, Er

Re: [PATCH] D12747: Implement [depr.c.headers]

Likewise for , , On Tue, Oct 6, 2015 at 3:20 PM, Richard Smith wrote: > Split header out of > > On Tue, Oct 6, 2015 at 3:07 PM, Richard Smith > wrote: > >> Next: factoring the definition of std::nullptr_t out into a separate >> file, so that and can both use it, without >> including and

Re: [libcxx] r249475 - Remove unnecessary inline functions capturing the contents of C library macros.

On 10/6/15 4:03 PM, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue Oct 6 17:03:22 2015 New Revision: 249475 URL: http://llvm.org/viewvc/llvm-project?rev=249475&view=rev Log: Remove unnecessary inline functions capturing the contents of C library macros. The C standard requires

Re: [PATCH] D12747: Implement [depr.c.headers]

, an easy one. We guarantee a setjmp macro exists even if this header is somehow included from C (the C standard allows that, so it's not worth checking for __cplusplus). On Tue, Oct 6, 2015 at 3:36 PM, Richard Smith wrote: > Split out of . This is a big change, but the same pattern > as the pr

Re: [PATCH] D12747: Implement [depr.c.headers]

On Tue, Oct 6, 2015 at 3:07 PM, Richard Smith wrote: > Next: factoring the definition of std::nullptr_t out into a separate file, > so that and can both use it, without > including and without providing a ::nullptr_t like > does. > Sorry, missed a couple of the hunks for this patch. > On

Re: r249395 - BasicTests: Suppress InMemoryFileSystemTest.WindowsPath on win32 while investigating.

On Wed, Oct 7, 2015 at 12:29 AM Rafael Espíndola wrote: > What was the error? > http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/5683 http://bb.pgr.jp/builders/ninja-clang-i686-msc18-R/builds/3409 http://bb.pgr.jp/builders/ninja-clang-x64-mingw64-RA/builds/8047 I guessed behavior

Re: [PATCH] D12747: Implement [depr.c.headers]

. This one is tricky: 1) There's an (undocumented) interface between the C standard library and this header, where the macros __need_ptrdiff_t, __need_size_t, __need_wchar_t, __need_NULL, __need_wint_t request just a piece of this header rather than the whole thing. If we see any of those, just go

Re: [PATCH] D12747: Implement [depr.c.headers]

+extern "C++" { +#include <__nullptr> +using std::nullptr_t; +} Does this even compile with modules? -- Sean Silva On Tue, Oct 6, 2015 at 3:57 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > . This one is tricky: > > 1) There's an (undocumented) interface between the C

Re: [PATCH] D12747: Implement [depr.c.headers]

: like , this provides only pieces if __need_FILE or __need___FILE is defined : likewise, but for __need_malloc_and_calloc and are straightforward is tricky: C libraries that don't implement the right interface provide non-const-correct functions like "wchar_t *wmemchr(const wchar_t*, wchar_t, s

Re: [PATCH] D12747: Implement [depr.c.headers]

On Tue, Oct 6, 2015 at 4:11 PM, Sean Silva wrote: > +extern "C++" { > +#include <__nullptr> > +using std::nullptr_t; > +} > > Does this even compile with modules? > Yes. You're allowed to import a C++ module within an 'extern "C++"' block. > On Tue, Oct 6, 2015 at 3:57 PM, Richard Smith via cf

Re: [PATCH] D12747: Implement [depr.c.headers]

On Tue, Oct 6, 2015 at 4:13 PM, Richard Smith wrote: > On Tue, Oct 6, 2015 at 4:11 PM, Sean Silva wrote: > >> +extern "C++" { >> +#include <__nullptr> >> +using std::nullptr_t; >> +} >> >> Does this even compile with modules? >> > > Yes. You're allowed to import a C++ module within an 'extern "C

r249484 - Fix Clang-tidy modernize-use-nullptr warnings in source directories; other minor cleanups

Author: hans Date: Tue Oct 6 18:40:43 2015 New Revision: 249484 URL: http://llvm.org/viewvc/llvm-project?rev=249484&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in source directories; other minor cleanups Patch by Eugene Zelenko! Differential Revision: http://reviews.llvm.org/D1

  1   2   >