Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl wrote: > > On Oct 2, 2015, at 2:58 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl wrote: > >> >> On Oct 2, 2015, at 2:18 PM, David Blaikie wrote: >> >> This seems a little curious, so you'll have code like this: >> >

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

djasper added a comment. No. I really don't want to have these two completely independent flags, so the patch needs changes, before it can go in. http://reviews.llvm.org/D10370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

r249197 - Emiting invariant.group.barrier for ctors bugfix

Author: prazek Date: Fri Oct 2 17:12:40 2015 New Revision: 249197 URL: http://llvm.org/viewvc/llvm-project?rev=249197&view=rev Log: Emiting invariant.group.barrier for ctors bugfix Ensure that the vptr store in the most-derived constructor is not behind an invariant group barrier. Previously, th

Re: [PATCH] D13331: [libcxx] Use newest supported language dialect when running the test suite.

danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D13331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

> On Oct 2, 2015, at 3:01 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl > wrote: > >> On Oct 2, 2015, at 2:58 PM, David Blaikie > > wrote: >> >> >> >> On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl >

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

On Fri, Oct 2, 2015 at 3:21 PM, Adrian Prantl wrote: > > On Oct 2, 2015, at 3:01 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl wrote: > >> >> On Oct 2, 2015, at 2:58 PM, David Blaikie wrote: >> >> >> >> On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl wrote: >> >

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

mgehre updated this revision to Diff 36403. mgehre marked 7 inline comments as done. mgehre added a comment. Incorporated comments Simplied matcher: Instead of checking argument types, just check that the result of the arithmetic operation is a pointer http://reviews.llvm.org/D13311 Files: c

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

mgehre added a comment. Thank you for the review comments! Comment at: clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp:38 @@ +37,3 @@ + Finder->addMatcher( + arraySubscriptExpr(hasBase(implicitCastExpr(hasSourceExpression( + has

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

mgehre updated this revision to Diff 36404. mgehre added a comment. Fix typo http://reviews.llvm.org/D13311 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp cl

r249205 - Don't nil check non-nil class receiver of AArch64 stret calls.

Author: ab Date: Fri Oct 2 17:41:59 2015 New Revision: 249205 URL: http://llvm.org/viewvc/llvm-project?rev=249205&view=rev Log: Don't nil check non-nil class receiver of AArch64 stret calls. I randomly came across this difference between AArch64 and other targets: on the latter, we don't emit ni

[PATCH] D13398: [clang-tidy] add check cppcoreguidelines-pro-type-const-cast

mgehre created this revision. mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman. mgehre added a subscriber: cfe-commits. mgehre added a dependency: D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast. This check flags all uses of const_cast in C++ code. Modify

r249213 - [Headers][X86] Fix stream_load (movntdqa) to accept const*.

Author: ab Date: Fri Oct 2 18:29:26 2015 New Revision: 249213 URL: http://llvm.org/viewvc/llvm-project?rev=249213&view=rev Log: [Headers][X86] Fix stream_load (movntdqa) to accept const*. Per Intel intrinsics guide: - _mm256_stream_load_si256 takes `__m256i const *' - _mm_stream_load_si128 takes

Re: [PATCH] D7297: [clang][Headers] _mm_stream_load_si128 should accept const arguments.

ab closed this revision. ab added a comment. Stumbled upon this while looking for the intel guide! Fixed in r249213. http://reviews.llvm.org/D7297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

dougk added a comment. A few more remarks: - The code which emits line-tables-only seems to understand dwarf2 versus dwarf4, but due solely to the way that arguments were parsed, the dwarf version did not propagate through to the compiler invocation if you also specified line-tables-only. The

r249215 - [libFuzzer] make LLVMFuzzerTestOneInput (the fuzzer target function) return int instead of void. (following llvm r249214)

Author: kcc Date: Fri Oct 2 18:34:37 2015 New Revision: 249215 URL: http://llvm.org/viewvc/llvm-project?rev=249215&view=rev Log: [libFuzzer] make LLVMFuzzerTestOneInput (the fuzzer target function) return int instead of void. (following llvm r249214) Modified: cfe/trunk/tools/clang-format/f

Re: [PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

sfantao updated this revision to Diff 36410. sfantao added a comment. Fix bug for when no offloading triples are specified. http://reviews.llvm.org/D12614 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Basic/LangOptions.def include/clang/Basic/LangOptions.h include/cl

r249223 - Fix clang/test/CodeGenCXX/strict-vtable-pointers.cpp for -Asserts. It missed something. :)

Author: chapuni Date: Fri Oct 2 19:50:12 2015 New Revision: 249223 URL: http://llvm.org/viewvc/llvm-project?rev=249223&view=rev Log: Fix clang/test/CodeGenCXX/strict-vtable-pointers.cpp for -Asserts. It missed something. :) Modified: cfe/trunk/test/CodeGenCXX/strict-vtable-pointers.cpp Mod

Re: [PATCH] D13373: Emiting invariant.group.barrier for ctors bugfix

chapuni added a subscriber: chapuni. Comment at: test/CodeGenCXX/strict-vtable-pointers.cpp:145 @@ +144,3 @@ +// CHECK-CTORS: %[[THIS3:.*]] = bitcast i8* %[[THIS2]] to %[[DynamicDerived]]* +// CHECK-CTORS: %[[THIS4:.*]] = bitcast %[[DynamicDerived]]* %2 to %[[DynamicBase:.*]]* +/

[PATCH] D13406: [Clang] Fix Clang-tidy modernize-use-nullptr warnings in source directories; other minor cleanups.

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Please check it in if it's OK, because

Re: [PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

jyknight added a comment. This certainly seems a big improvement. However, I don't think that you actually fixed specifying both -gline-tables-only and a Dwarf version, because that requires actually handling multiple options from g_group, instead of just the last one. E.g. "-gdwarf-2 -g1" sho

Re: [PATCH] D13373: Emiting invariant.group.barrier for ctors bugfix

Thank you! On Fri, Oct 2, 2015 at 5:54 PM, NAKAMURA Takumi wrote: > chapuni added a subscriber: chapuni. > > > Comment at: test/CodeGenCXX/strict-vtable-pointers.cpp:145 > @@ +144,3 @@ > +// CHECK-CTORS: %[[THIS3:.*]] = bitcast i8* %[[THIS2]] to > %[[DynamicDerived]]* > +// CHEC

Re: [libcxx] r248313 - Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

On Fri, Oct 2, 2015 at 1:58 PM, Eric Fiselier wrote: > Hi Tom, > > I would like this patch merged into 3.7.1. > Marshall can you please approve this? > Looks fine to me. -- Marshall > > /Eric > > On Tue, Sep 22, 2015 at 12:55 PM, Dimitry Andric via cfe-commits > wrote: > > Author: dim > > Da

[PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF created this revision. EricWF added reviewers: mclow.lists, danalbert, jroelofs. EricWF added a subscriber: cfe-commits. Hi all, This patch is a successor to D11963. However it has changed dramatically and I felt it would be best to start a new review thread. Please read the design docum

Re: [PATCH] D13217: [ARM] The Driver does not set the +strict-align flag when targeting armv6m + netbsd

labrinea added inline comments. Comment at: lib/Basic/Targets.cpp:4456 @@ -4455,3 +4455,1 @@ -if (ArchVersion < 6 || - (ArchVersion == 6 && ArchProfile == llvm::ARM::PK_M)) rengolin wrote: > Why is this not necessary any more? The logic is still nece

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF added a comment. Oh, but don't review the design doc too closely. I'm still working on it. http://reviews.llvm.org/D13407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r249226 - [libcxx] Use newest supported language dialect when running the test suite.

Author: ericwf Date: Fri Oct 2 21:32:23 2015 New Revision: 249226 URL: http://llvm.org/viewvc/llvm-project?rev=249226&view=rev Log: [libcxx] Use newest supported language dialect when running the test suite. Summary: Currently the test suite defaults to C++11 mode if no standard version is supp

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF added subscribers: eugenis, asl, espositofulvio, ed. EricWF added a comment. Adding subscribes from the old patch to this one. http://reviews.llvm.org/D13407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF abandoned this revision. EricWF added a comment. Abandoning in favor of http://reviews.llvm.org/D13407. http://reviews.llvm.org/D11963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D13331: [libcxx] Use newest supported language dialect when running the test suite.

mclow.lists added a comment. Works for me. Now we need to do the same for clang. http://reviews.llvm.org/D13331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12502: [libcxx] Better constain tuples constructors -- Fix PR23256 and PR22806

eugenis added a comment. FYI, I ran some tests and did not find any regressions and also confirmed that this change fixes the problem PR23256 was minimized from. Thanks for working on this! http://reviews.llvm.org/D12502 ___ cfe-commits mailing lis

Re: r248953 - [Sema] Don't crash when friending an unqualified templated constructor

On Wed, Sep 30, 2015 at 3:07 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: majnemer > Date: Wed Sep 30 17:07:43 2015 > New Revision: 248953 > > URL: http://llvm.org/viewvc/llvm-project?rev=248953&view=rev > Log: > [Sema] Don't crash when friending an unqualified

Re: [PATCH] D11908: Clang support for -fthinlto.

> On 2015-Oct-02, at 08:59, Teresa Johnson wrote: > > On Fri, Oct 2, 2015 at 8:53 AM, Manuel Klimek wrote: >> klimek added a comment. >> >> In http://reviews.llvm.org/D11908#258570, @tejohnson wrote: >> >>> Sorry for the duplicate - my previous response didn't go to Duncan or Mehdi >>> for s

r249227 - Driver: follow WoA ABI recommendations

Author: compnerd Date: Fri Oct 2 22:39:28 2015 New Revision: 249227 URL: http://llvm.org/viewvc/llvm-project?rev=249227&view=rev Log: Driver: follow WoA ABI recommendations The Windows on ARM ABI recommends that FPO be disabled. This is since the Windows on ARM ABI uses the FP for fast stack wa

r249228 - Replace double-negated !SourceLocation.isInvalid() with SourceLocation.isValid().

Author: yrnkrn Date: Sat Oct 3 00:15:57 2015 New Revision: 249228 URL: http://llvm.org/viewvc/llvm-project?rev=249228&view=rev Log: Replace double-negated !SourceLocation.isInvalid() with SourceLocation.isValid(). Modified: cfe/trunk/lib/ARCMigrate/ObjCMT.cpp cfe/trunk/lib/AST/TypeLoc.

Re: [PATCH] D12854: [SourceManager] Support buffers that are not null-terminated

loladiro added a comment. Hmm, you're right. And I am actually constructing it in such a way that it's supposed to have it, so I wonder why it ran off the rails here. Will take another look. Repository: rL LLVM http://reviews.llvm.org/D12854 __

Re: [PATCH] D12854: [SourceManager] Support buffers that are not null-terminated

loladiro abandoned this revision. loladiro added a comment. Oh, I see it checks for the null terminator past the end of the given memory block on construction, but if the memory after changes later this just keeps running. Well, that's quite a trap, but I guess that's what you get for not under

r249229 - try to fix the ARM self host bots

Author: compnerd Date: Sat Oct 3 01:37:38 2015 New Revision: 249229 URL: http://llvm.org/viewvc/llvm-project?rev=249229&view=rev Log: try to fix the ARM self host bots The default target is ARM on the ARM self host bots. This is problematic since the behaviour on x86, x64 is different from ARM.

<    1   2