mgehre updated this revision to Diff 36294.
mgehre added a comment.
Fix add_new_check.py for capitalization of CppCoreGuidelinesTidyModule.cpp
http://reviews.llvm.org/D13313
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/add_new_check.py
clang-tidy/cppcoreguidelines/CMa
alexr added a subscriber: alexr.
alexr added a comment.
PowerPC has floating point hardware by definition. Is this some new variant?
http://reviews.llvm.org/D13351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
mgehre updated this revision to Diff 36296.
mgehre added a comment.
Read 'Check' suffix on ProTypeReinterpretCastCheck
http://reviews.llvm.org/D13313
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/add_new_check.py
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy
alexr added a subscriber: alexr.
alexr added a comment.
I realize that we've all been referring to this as ThinLTO, but is that
necessarily descriptive for users? What about inlineonly or something similar?
http://reviews.llvm.org/D11908
___
cfe-co
I'm in favor of keeping the asserts around. Several times, I've seen Clang
crashers than languish in the bug tracker with an assert in a generic
casting function. And no one fixes it until someone pokes at the backtrace
to find the source of the bad pointer, at which point it gets fixed quickly.
davidxl added a comment.
ThinLTO is a perfectly good term to indicate what it tries to accomplish.
InlineOnly will narrow its scope. For instance, there is no reason why thinLTO
can not do fast summary based WPA in the future.
http://reviews.llvm.org/D11908
_
mgehre updated this revision to Diff 36300.
mgehre added a comment.
Port to cppcoreguidelines module.
Add checks for post/pre increment/decrement and array access.
http://reviews.llvm.org/D13311
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/add_new_check.py
clang-tidy/
wristow added inline comments.
Comment at: include/clang/Basic/LangOptions.def:93
@@ -92,2 +92,3 @@
LANGOPT(WChar , 1, CPlusPlus, "wchar_t keyword")
+LANGOPT(DeclSpecKeyword , 1, 0, "Microsoft __declspec keyword support")
BENIGN_LANGOPT(DollarIdents , 1, 1, "'$'
mgehre updated this revision to Diff 36305.
mgehre added a comment.
Remove inclusion of misc-no-reinterpret-cast in this patch set
http://reviews.llvm.org/D13311
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppc
wristow updated this revision to Diff 36307.
wristow added a comment.
Updated patch to change the Group of the diagnostic from f_Group to
f_clang_Group, and to change the string associated with the LANGOPT definition
of the flag. Also fixed a minor typo in a comment.
http://reviews.llvm.org/D
zaks.anna added a comment.
Could you address this:
Could you ask on the open source list if people are using "issue_hash" and if
they are Ok with us renaming it.
I'd suggest to suffix each issue hash field with the description of that hash.
For example, we would remove "issue_hash" and replace
majnemer added a comment.
It seems our infrastructure is not up to the task of making this testable via
Clang, please commit.
http://reviews.llvm.org/D13276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
dcoughlin added a comment.
Sean, I've committed this patch. You can update to trunk to get it.
Repository:
rL LLVM
http://reviews.llvm.org/D12993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
mgehre created this revision.
mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman.
mgehre added a subscriber: cfe-commits.
mgehre added a dependency: D13313: [clang-tidy] new check
cppcoreguidelines-pro-type-reinterpret-cast.
This check flags all usages of static_cast, where a base cla
Author: rikka
Date: Thu Oct 1 17:38:51 2015
New Revision: 249090
URL: http://llvm.org/viewvc/llvm-project?rev=249090&view=rev
Log:
Don't try to get a CXXRecordDecl from a non-class TemplateSpecializationType.
With -fms-extensions it is possible to have a non-class record that is a
template speci
davidxl updated this revision to Diff 36316.
davidxl added a comment.
I have modified the implementation to not use linker script, so this clang
patch becomes strictly refactoring with NFC. I think it is still a good thing
to have this in so that similar tunings like this can be done in the futu
sfantao updated this revision to Diff 36317.
sfantao added a comment.
Address Alexey's remarks from last review.
http://reviews.llvm.org/D12871
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunction.h
test/OpenMP/t
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+Sizes.push_back(Size);
+MapTypes.push_back(MapType);
+ }
+
+ // Keep track on whether the host function has to be executed.
+ auto OffloadErrorQType =
+ CGF.getCont
Author: chandlerc
Date: Thu Oct 1 18:40:12 2015
New Revision: 249097
URL: http://llvm.org/viewvc/llvm-project?rev=249097&view=rev
Log:
Fix the SSE4 byte sign extension in a cleaner way, and more thoroughly
test that our intrinsics behave the same under -fsigned-char and
-funsigned-char.
This fur
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249097: Fix the SSE4 byte sign extension in a cleaner way,
and more thoroughly (authored by chandlerc).
Changed prior to commit:
http://reviews.llvm.org/D13324?vs=36178&id=36321#toc
Repository:
rL LL
Author: chapuni
Date: Thu Oct 1 18:50:06 2015
New Revision: 249100
URL: http://llvm.org/viewvc/llvm-project?rev=249100&view=rev
Log:
Fix the *unchecked* commit.
Modified:
clang-tools-extra/trunk/CMakeLists.txt
Modified: clang-tools-extra/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llv
zaks.anna added a comment.
This checker produces a lot of warnings! Have you analyzed how many are false
positives? Have you tried reporting these warnings?
It's hard to make use of the results you posted from the debian packages. For
most of them, I cannot tell if they are valid reports or fal
Author: rsmith
Date: Thu Oct 1 19:46:58 2015
New Revision: 249113
URL: http://llvm.org/viewvc/llvm-project?rev=249113&view=rev
Log:
Explicitly delete a function that is supposed to never be called.
Modified:
cfe/trunk/include/clang/AST/TemplateBase.h
Modified: cfe/trunk/include/clang/AST/Te
Author: rsmith
Date: Thu Oct 1 19:49:37 2015
New Revision: 249114
URL: http://llvm.org/viewvc/llvm-project?rev=249114&view=rev
Log:
PR24921: checking explicitly-specified template arguments when matching a
partial specialization can perform conversions on the argument. Be sure we
start again from
Author: cbieneman
Date: Thu Oct 1 19:56:53 2015
New Revision: 249115
URL: http://llvm.org/viewvc/llvm-project?rev=249115&view=rev
Log:
[CMake] Fixing clang bootstrap to use LLVM_RUNTIME_OUTPUT_INTDIR instead of
CMAKE_BINARY_DIR.
This should make bootstrap builds work with multi-configuration ge
Author: bwilson
Date: Thu Oct 1 20:05:29 2015
New Revision: 249116
URL: http://llvm.org/viewvc/llvm-project?rev=249116&view=rev
Log:
Be slightly more permissive when checking for type-erased blocks.
This is a patch from Doug that was inadvertently omitted from r241543.
Modified:
cfe/trunk/l
On Thu, Oct 1, 2015 at 6:01 AM, Renato Golin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Right, I reverted both commits on r249005. Please, let me know if you
> need help testing on ARM before the next commit. This looks like it
> could be tested on any 32-bit platform, though, so you s
Prazek created this revision.
Prazek added reviewers: rsmith, nlewycky, rjmccall, majnemer.
Prazek added a subscriber: cfe-commits.
Please review asap
http://reviews.llvm.org/D13373
Files:
lib/CodeGen/CGClass.cpp
test/CodeGenCXX/invariant.group-for-vptrs.cpp
test/CodeGenCXX/strict-vtable-p
nlewycky added a comment.
I can't meaningfully review this, but I see nothing wrong here.
Comment at: lib/CodeGen/CGClass.cpp:1378
@@ -1377,3 +1377,3 @@
- bool BaseVPtrsInitialized = false;
+ llvm::Value* const OldThis = CXXThisValue;
// Virtual base initializers first.
-
compnerd added inline comments.
Comment at: lib/Driver/Tools.cpp:4663
@@ +4662,3 @@
+ else if (Args.hasArg(options::OPT_fno_declspec))
+CmdArgs.push_back("-fno-declspec"); // Explicitly disabling __declspec.
+
@rsmith, so they are. I misread something and wa
Author: zturner
Date: Thu Oct 1 17:08:02 2015
New Revision: 249085
URL: http://llvm.org/viewvc/llvm-project?rev=249085&view=rev
Log:
Don't adjust field offsets when using external record layout.
This was already being done when injecting the VBPtr, but not
when injecting the VFPtr. This fixes a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249085: Don't adjust field offsets when using external
record layout. (authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D13276?vs=36054&id=36310#toc
Repository:
rL LLVM
http://
hubert.reinterpretcast added inline comments.
Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.concept/p7.cpp:13
@@ +12,3 @@
+template concept bool FCEI() { return true; }
+template concept bool FCEI(); // expected-error {{function concept cannot
be explicitly instantiated}}
hubert.reinterpretcast added inline comments.
Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.concept/p7.cpp:4
@@ +3,3 @@
+template concept bool VCEI { true };
+template concept bool VCEI; // expected-error {{variable concept cannot
be explicitly instantiated}}
+
--
michaelwu updated this revision to Diff 36330.
michaelwu added a comment.
Thanks for the review. I switched to shouldMangleDeclName instead of
shouldMangleCXXName, and made it skip the frontend mangling instead of
returning an empty string. I tried making mangleName do that instead, but it
seem
ABataev created this revision.
ABataev added a reviewer: rnk.
ABataev added a subscriber: cfe-commits.
Removes extra codegen for base expression of MS property call
http://reviews.llvm.org/D13375
Files:
lib/Sema/SemaPseudoObject.cpp
test/CodeGenCXX/ms-property.cpp
Index: lib/Sema/SemaPseudo
loladiro added inline comments.
Comment at: include/clang/Basic/Attr.td:1462
@@ +1461,3 @@
+def UniqueInstantiation : InheritableAttr {
+ let Spellings = [GCC<"unique_instantiation">];
+ let Subjects = SubjectList<[CXXRecord]>;
loladiro wrote:
> aaron.ballman wr
101 - 137 of 137 matches
Mail list logo
