DavidEGrayson removed rL LLVM as the repository for this revision.
DavidEGrayson updated this revision to Diff 35592.
DavidEGrayson added a comment.
I have changed the patch to incorporate most of John McCall's feedback. The
only thing I didn't act on was the suggestion to change the names of t
DavidEGrayson marked 18 inline comments as done.
DavidEGrayson added a comment.
http://reviews.llvm.org/D12793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun added a comment.
Hi!
Thanks for this patch! I think this would be a great addition! I have some
comments inline.
Comment at: lib/StaticAnalyzer/Core/CallEvent.cpp:409
@@ +408,3 @@
+ if (const CXXMethodDecl *D = cast_or_null(getDecl())) {
+if(D->getCanonicalDecl(
Visual C++ 2013 update 5 (latest) does not appear to compile this, mainly
due to missing support for constexpr.
https://msdn.microsoft.com/en-us/library/vstudio/hh567368.aspx
Visual C++ 2013 CTP has constexpr, but MS did not further update this
branch since Nov 2013.
The "regular" branch of 201
alexfh added a subscriber: cfe-commits.
alexfh added a comment.
Test test test.
Let's see how adding subscribers from the comments form in Diffusion works.
/clang-tools-extra/trunk/test/clang-tidy/modernize-loop-convert-basic.cpp:621
Testtesttest
Users:
klimek (Author)
http://reviews.llvm.
xazax.hun added a comment.
One more note. Do we want to support const_cast for this? A possible way to do
that is to invalidate this, when a const cast appears in the body of the
function. (However the body might not be available. It is only my opinion, but
I would be ok to accept this patch wi
On Thu, Sep 24, 2015 at 10:24 AM, Alexander Kornienko
wrote:
> alexfh added a subscriber: cfe-commits.
> alexfh added a comment.
>
> Test test test.
>
> Let's see how adding subscribers from the comments form in Diffusion works.
>
>
> /clang-tools-extra/trunk/test/clang-tidy/modernize-loop-conver
danielmarjamaki created this revision.
danielmarjamaki added a reviewer: zaks.anna.
danielmarjamaki added a subscriber: cfe-commits.
This is a new static analyzer checker that warns when there is loss of sign and
loss of precision.
It is similar in spirit to Wsign-compare/Wsign-conversion etc. B
seaneveson added a comment.
Thank you for looking at the patch and all your comments.
In http://reviews.llvm.org/D13099#252492, @xazax.hun wrote:
> One more note. Do we want to support const_cast for this? A possible way to
> do that is to invalidate this, when a const cast appears in the body
Author: vsukharev
Date: Thu Sep 24 04:55:08 2015
New Revision: 248479
URL: http://llvm.org/viewvc/llvm-project?rev=248479&view=rev
Log:
[ARM] Follow-up to fix crash "-target arm -mcpu=generic", without "-march="
Fix of dangling StringRef after temporary std::string is destroyed
Follow-up to: htt
Author: vsukharev
Date: Thu Sep 24 05:06:44 2015
New Revision: 248480
URL: http://llvm.org/viewvc/llvm-project?rev=248480&view=rev
Log:
[ARM] Follow-up to fix crash "-target arm -mcpu=generic", without "-march="
Fix of dangling StringRef after temporary std::string is destroyed
Follow-up to: htt
Author: dsanders
Date: Thu Sep 24 05:22:17 2015
New Revision: 248481
URL: http://llvm.org/viewvc/llvm-project?rev=248481&view=rev
Log:
[mips] Relax -mnan=2008 acceptance to permit MIPS32R2 and MIPS64R2.
Summary:
Strictly speaking, the MIPS*R2 ISA's should not permit -mnan=2008 since this
feature
dsanders added subscribers: rengolin, joerg.
dsanders added a comment.
+Renato and Joerg
I was going to say I think it's ok and the optimizer should be smart enough to
factor out the common IsMips check but I've just realized there may be a better
way. The current code is using an else after an
jketema created this revision.
jketema added a reviewer: sbaranga.
jketema added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
This if the clang companion patch for http://reviews.llvm.org/D12985, which
upgrades the vld[234] and vst[234] to take pointers annotated with
alexfh added a comment.
Test-test-test.
/clang-tools-extra/trunk/test/clang-tidy/modernize-loop-convert-extra.cpp:669
Test3
/clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertCheck.cpp:501 Test2.
Users:
klimek (Author)
http://reviews.llvm.org/rL248438
__
pgousseau updated this revision to Diff 35604.
pgousseau added a comment.
Following Gabor's review:
Add a test factoring 'index + 1' in an extra variable.
Let me know if this looks reasonable ?
Regards,
Pierre
http://reviews.llvm.org/D12901
Files:
lib/StaticAnalyzer/Core/RangeConstraintMa
alexfh added inline comments.
/clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertCheck.cpp:573 test6
/clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertCheck.cpp:509 test5
Users:
klimek (Author)
http://reviews.llvm.org/rL248438
___
cfe
MyDeveloperDay added a comment.
Having installed the VS2010 C++ compilers the format on save does work BUT...
you have to disable and enable the setting in tools->options->LLVM/Clang first,
its as if the setting is NOT read on startup
http://reviews.llvm.org/D12407
_
alexfh added subscribers: angelgarcia, klimek, cfe-commits.
alexfh added a comment.
One trivial comment. Angel can probably fix this faster.
/clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertCheck.cpp:394 ```
// Handle references to containers.
CType = CType->getNonReferenceType();
```
U
angelgarcia updated this revision to Diff 35608.
angelgarcia added a comment.
> No need to check the length. `endswith` handles this itself.
I am checking that it is strictly greater than one, because we don't want an
empty identifier after removing the "s".
http://reviews.llvm.org/D13052
Fi
berenm added a comment.
Well, the format on save setting is disabled by default, do you mean you had to
enable it twice? Or you had it enabled without the C++ development tools, and
after the installation you had to disable and enable it again?
http://reviews.llvm.org/D12407
___
ABataev created this revision.
ABataev added a reviewer: chandlerc.
ABataev added a subscriber: cfe-commits.
If stdout is used as an output file for several outputs (like dep file, output
file, etc.) , it causes a crash in llvm::raw_fd_ostream::~raw_fd_ostream(),
when destructor tries to close f
On Thu, Sep 24, 2015 at 10:22:29AM +, Daniel Sanders via cfe-commits wrote:
> I'm thinking something like:
I think we really want to have an outer case, platform specific -Wa
options are quite common. Only x86 is mostly getting by without them so
far. I also think the switch is not that diffic
angelgarcia added a comment.
I sent a patch with that.
Users:
klimek (Author)
http://reviews.llvm.org/rL248418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: klimek, cfe-commits.
Solve comment on rL248418.
http://reviews.llvm.org/D13129
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
Index: clang-tidy/modernize/LoopConvertCheck.cpp
yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.
When stdout goes elsewhere the console, the shell creates the the output file
(pipe) and will close it when clang terminates so so why clang should close it
at all ? it did not open it.
Practically, we have been running
seaneveson updated this revision to Diff 35617.
seaneveson added a comment.
Removed unnecessary call to getCanonical.
Changed if statement checking getting ThisRegion to an assert.
Added code to handle mutable members of base classes.
http://reviews.llvm.org/D13099
Files:
lib/StaticAnalyzer/C
The biggest problem is that those comments don't go on the cfe-commmits
thread that gets auto-triggered by commits, and we really want to not add
new threads.
On Thu, Sep 24, 2015 at 4:28 AM Alexander Kornienko
wrote:
> alexfh added inline comments.
>
> /clang-tools-extra/trunk/clang-tidy/modern
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D13129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: angelgarcia
Date: Thu Sep 24 08:26:28 2015
New Revision: 248489
URL: http://llvm.org/viewvc/llvm-project?rev=248489&view=rev
Log:
Solve comment on rL248418.
Summary: Solve comment on rL248418.
Reviewers: alexfh
Subscribers: cfe-commits, klimek
Differential Revision: http://reviews.llvm
xazax.hun added a comment.
A general style comment: you could decrease the level of indentation using
early returns. I have one more comment inline, otherwise it looks good to me.
Comment at: lib/StaticAnalyzer/Core/CallEvent.cpp:422
@@ +421,3 @@
+ // Check if this is a call t
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: klimek, cfe-commits.
Remove parenthesis surrounding the new loop index.
http://reviews.llvm.org/D13133
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
test/clang-tidy/modernize-loop-conve
ABataev added a comment.
In http://reviews.llvm.org/D13128#252630, @yaron.keren wrote:
> When stdout goes elsewhere the console, the shell creates the the output file
> (pipe) and will close it when clang terminates so so why clang should close
> it at all ? it did not open it.
>
> Practicall
Too bad. Making these two kinds of mails go to the same thread is hardly a
trivial thing. And completely switching commit notifications to Phabricator
is something not very realistic, I guess (at least, at this point).
Giving up.
On Thu, Sep 24, 2015 at 3:24 PM, Manuel Klimek wrote:
> The bigge
Yep, as I said, I would love to do that, but it would require significant
effort :(
On Thu, Sep 24, 2015 at 7:03 AM Alexander Kornienko
wrote:
> Too bad. Making these two kinds of mails go to the same thread is hardly a
> trivial thing. And completely switching commit notifications to Phabricato
klimek added a comment.
Can you add a test where we need the parens? (where the element is of ** type
or something)
http://reviews.llvm.org/D13133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
yaron.keren added a subscriber: sunfish.
yaron.keren added a comment.
The original commit
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20100816/106268.html
by Dan Ghoman says:
"Make raw_fd_ostream consider itself the owner of STDOUT_FILENO when
constructed with an output filename of
angelgarcia updated this revision to Diff 35626.
angelgarcia added a comment.
Added a test where the parenthesis must not be removed, and one where they
should.
http://reviews.llvm.org/D13133
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
test/clang-tidy/modernize-loop-convert-basic.cpp
aaron.ballman added a reviewer: rsmith.
aaron.ballman added a comment.
Thank you for continuing to work on this, I think it's a good diagnostic to
have.
There are still quite a few unanswered questions in the phab thread. Also, the
patch appears to be missing tests, which might help to clarify
skomski created this revision.
skomski added reviewers: dcoughlin, krememek, jordan_rose.
skomski added a subscriber: cfe-commits.
skomski set the repository for this revision to rL LLVM.
Adds three keyboard shortcuts to report.html
to make navigation faster:
Jump to next path: j
Jump to prev
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:482
@@ +481,3 @@
+auto Parents = Context->getParents(*Usage.Expression);
+if (Parents.size() == 1) {
+ if (const auto *Paren = Parents[0].get())
Perhaps ad
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a comment. Thank you!
Comment at: test/clang-tidy/modernize-loop-convert-uppercase.cpp:48
@@ +47,3 @@
+ // CHECK-FIXES: for (auto & NUMS_ELEM : NUMS)
+ // CH
Author: d0k
Date: Thu Sep 24 09:48:37 2015
New Revision: 248495
URL: http://llvm.org/viewvc/llvm-project?rev=248495&view=rev
Log:
[Driver] Don't implicitly copy std::strings in for-range loop.
Found by -Wrange-loop-analysis.
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
Modified: cfe/trunk/
angelgarcia added a comment.
Usage.Expression can be:
-CXXMemberCallExpr: "container.at(i)"
-CXXOperatorCallExpr: "*it" or "container[i]"
-ArraySubscripExpr: "Arr[i]"
-UnaryOperator: "*ptr"
-MemberExpr: "it->member" (we only replace "it->" with "elem." in this
case).
The point is that all of them
labrinea updated this revision to Diff 35628.
labrinea added a comment.
@t.p.northover I think we should not be defining _ARM_FP_FENV_ROUNDING on
neither of ARM and AArch64 targets since "-frounding-math" is not available on
clang: clang/llvm don't support C99 FP rounding mode pragmas (FENV_ACCE
Author: d0k
Date: Thu Sep 24 09:48:49 2015
New Revision: 248496
URL: http://llvm.org/viewvc/llvm-project?rev=248496&view=rev
Log:
Drop useless const in for-range loops.
StringRefs always point to immutable memory so the const doesn't add value
here. Also quiets clang's -Wrange-loop-analysis which
pgousseau added a comment.
In http://reviews.llvm.org/D12571#252366, @dcoughlin wrote:
> Looks good to me! Thanks Pierre! I will commit.
Much appreciated thanks !
http://reviews.llvm.org/D12571
___
cfe-commits mailing list
cfe-commits@lists.llvm.
angelgarcia updated this revision to Diff 35629.
angelgarcia added a comment.
Add comment.
http://reviews.llvm.org/D13133
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
test/clang-tidy/modernize-loop-convert-basic.cpp
test/clang-tidy/modernize-loop-convert-extra.cpp
Index: test/clang-t
richard.barton.arm added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1711
@@ -1710,1 +1710,3 @@
Args.hasArg(OPT_cl_fast_relaxed_math);
+ Opts.UnsafeFPMath = Args.hasArg(OPT_menable_unsafe_fp_math) ||
+ Args.hasArg(OPT_cl_unsafe_mat
angelgarcia updated this revision to Diff 35630.
angelgarcia added a comment.
Done!
http://reviews.llvm.org/D13052
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
clang-tidy/modernize/LoopConvertCheck.h
clang-tidy/modernize/LoopConvertUtils.cpp
clang-tidy/modernize/LoopConvertUtils.h
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D13133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
labrinea added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1711
@@ -1710,1 +1710,3 @@
Args.hasArg(OPT_cl_fast_relaxed_math);
+ Opts.UnsafeFPMath = Args.hasArg(OPT_menable_unsafe_fp_math) ||
+ Args.hasArg(OPT_cl_unsafe_math_optimiza
richard.barton.arm added a comment.
In the overall approach, whilst this is the pragmatic approach to get the job
done, it clearly takes liberties with the definition of LangOpt as this your
new flag is most certainly a CodeGenOpt rather than a LangOpt. I'd like to see
what the others say as I
Author: angelgarcia
Date: Thu Sep 24 10:29:46 2015
New Revision: 248507
URL: http://llvm.org/viewvc/llvm-project?rev=248507&view=rev
Log:
Remove dangling parenthesis.
Summary: Remove parenthesis surrounding the new loop index.
Reviewers: klimek
Subscribers: cfe-commits, klimek
Differential Rev
jroelofs added a comment.
Oh, yeah, true.
http://reviews.llvm.org/D12996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: adrian
Date: Thu Sep 24 11:10:00 2015
New Revision: 248509
URL: http://llvm.org/viewvc/llvm-project?rev=248509&view=rev
Log:
Refactor ASTSourceDescriptor to not store copies of all strings. (NFC)
Modified:
cfe/trunk/include/clang/AST/ExternalASTSource.h
cfe/trunk/lib/AST/ExternalA
Author: adrian
Date: Thu Sep 24 11:10:04 2015
New Revision: 248510
URL: http://llvm.org/viewvc/llvm-project?rev=248510&view=rev
Log:
Debug Info: Use the module pointer as key for the module cache.
This way we don't need to rebuild the full module name for every decl.
Modified:
cfe/trunk/inclu
Author: adrian
Date: Thu Sep 24 11:10:10 2015
New Revision: 248511
URL: http://llvm.org/viewvc/llvm-project?rev=248511&view=rev
Log:
Module Debugging: Emit submodules as nested DW_TAG_modules.
Added:
cfe/trunk/test/Modules/DebugInfoSubmoduleImport.c
Modified:
cfe/trunk/include/clang/AST/E
alexfh added a comment.
Still looks good.
http://reviews.llvm.org/D13052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Thu, Sep 24, 2015 at 4:20 AM, Yaron Keren via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Visual C++ 2013 update 5 (latest) does not appear to compile this, mainly
> due to missing support for constexpr.
>
> https://msdn.microsoft.com/en-us/library/vstudio/hh567368.aspx
>
> Visual C++
alexfh added a comment.
Please add more context to the diffs.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:508
@@ +507,3 @@
+ auto &Failure = Failures[Decl];
+ for (const auto &R : Failure.Usages) {
+if (R == Range)
berenm wrote:
> Hopefull
Author: dcoughlin
Date: Thu Sep 24 11:52:56 2015
New Revision: 248516
URL: http://llvm.org/viewvc/llvm-project?rev=248516&view=rev
Log:
[analyzer] When memcpy'ing into a fixed-size array, do not invalidate entire
region.
Change the analyzer's modeling of memcpy to be more precise when copying in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248516: [analyzer] When memcpy'ing into a fixed-size array,
do not invalidate entire… (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D12571?vs=35505&id=35644#toc
Repository:
Thank you for the fix.
--Artem
On Wed, Sep 23, 2015 at 9:32 PM, NAKAMURA Takumi
wrote:
> chapuni added a subscriber: chapuni.
>
>
> Comment at: cfe/trunk/lib/Driver/ToolChains.cpp:1492
> @@ +1491,3 @@
> +const llvm::opt::ArgList
> &Ar
pekka.jaaskelainen requested changes to this revision.
pekka.jaaskelainen added a comment.
This revision now requires changes to proceed.
Could only find style nitpicks in this one.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7473
@@ -7470,3 +7472,3 @@
def err_opencl
Author: eugenis
Date: Thu Sep 24 12:22:46 2015
New Revision: 248518
URL: http://llvm.org/viewvc/llvm-project?rev=248518&view=rev
Log:
Enable SafeStack on all Linux platforms.
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/test/Driver/fsanitize.c
Modified: cfe/trunk/lib/Driver/To
eugenis added a comment.
Thanks, committed as r248518 with a test.
Repository:
rL LLVM
http://reviews.llvm.org/D13122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
berenm updated this revision to Diff 35651.
berenm added a comment.
Changed Usages to RawUsageLocs, as DenseMap storing the raw encoding of
SourceLocation instead of a vector or SourceRange.
http://reviews.llvm.org/D13079
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
clang-tidy/r
berenm marked 2 inline comments as done.
berenm added a comment.
http://reviews.llvm.org/D13079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: askrobov
Date: Thu Sep 24 12:34:05 2015
New Revision: 248521
URL: http://llvm.org/viewvc/llvm-project?rev=248521&view=rev
Log:
Recommit r248154: [ARM] Handle DSP feature as an ArchExtKind
Currently, the availability of DSP instructions (ACLE 6.4.7) is handled in
a hand-rolled tricky condi
berenm updated this revision to Diff 35652.
berenm added a comment.
Update the diff with more context, thanks to arcanist.
http://reviews.llvm.org/D13090
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming.cpp
Index: test/clang-tidy/readabi
berenm updated this revision to Diff 35655.
berenm added a comment.
Update the diff with more context.
http://reviews.llvm.org/D13081
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming.cpp
Index: test/clang-tidy/readability-identifier-nami
Ah, OK. Maybe it would compile with VC 2013 by using LLVM_CONSTEXPR instead
of constexpr. It's not available now in libcxx but the definition from
Compiler.h is trivial.
2015-09-24 19:28 GMT+03:00 Nico Weber :
> On Thu, Sep 24, 2015 at 4:20 AM, Yaron Keren via cfe-commits <
> cfe-commits@lists
On 24 September 2015 at 07:53, Alexandros Lamprineas
wrote:
> @t.p.northover I think we should not be defining _ARM_FP_FENV_ROUNDING on
> neither of ARM and AArch64 targets since "-frounding-math" is not available
> on clang: clang/llvm don't support C99 FP rounding mode pragmas (FENV_ACCESS
>
bruno updated this revision to Diff 35664.
bruno added a comment.
Added test per Duncan's comment.
Repository:
rL LLVM
http://reviews.llvm.org/D13117
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/Tools.cpp
test/Driver/darwin-ld.c
Index: test/Driver/darwin-ld.c
===
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
berenm updated this revision to Diff 35669.
berenm added a comment.
Reformatting with clang-format
http://reviews.llvm.org/D13079
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
clang-tidy/readability/IdentifierNamingCheck.h
test/clang-tidy/readability-identifier-naming.cpp
Index
tra created this revision.
tra added a reviewer: echristo.
tra added a subscriber: cfe-commits.
Propagates AuxTriple throughout job pipeline construction in driver and on to
Tool::ConstructJob().
It in turn passes target triple of opposite side of CUDA compilation as
-aux-triple option to sub-co
berenm added a comment.
This will also disable all warnings for declaration / usages outside of the
main file.
It might be better to disable the warnings and fixes whenever a macro is
involved (in the declaration or any usage), but at least keep the warning
across files, even if we don't offer
Sorry for the review fragmentation, but I just noticed there's no test
for the new warning. Can you add one? After that, LGTM.
> On 2015-Sep-24, at 11:57, Bruno Cardoso Lopes wrote:
>
> bruno updated this revision to Diff 35664.
> bruno added a comment.
>
> Added test per Duncan's comment.
>
dexonsmith added a comment.
Sorry for the review fragmentation, but I just noticed there's no test
for the new warning. Can you add one? After that, LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D13117
___
cfe-commits mailing list
cfe-commi
bader added a subscriber: bader.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7472-7473
@@ -7469,4 +7471,4 @@
"sampler type cannot be used with the __local and __global address space
qualifiers">;
def err_opencl_global_invalid_addr_space : Error<
- "global variable
george.burgess.iv added a comment.
Friendly ping :)
http://reviews.llvm.org/D12821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MyDeveloperDay added a comment.
I went back and retested VS2010, VS2013 and VS2015. so in all cases I
1. start Visual studio
2. open a .h file (with incorrect style) - (via the recent file menu)
3. make a minor edit of whitespace
4. hit save file
In allcases it does NOT reformat the file
Now do
berenm updated this revision to Diff 35672.
berenm added a comment.
- Do not check for identifier names from system headers
- Check for SourceLocation validity before modifying them
http://reviews.llvm.org/D13081
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readab
Author: spatel
Date: Thu Sep 24 16:11:52 2015
New Revision: 248537
URL: http://llvm.org/viewvc/llvm-project?rev=248537&view=rev
Log:
fix typos; NFC
Modified:
cfe/trunk/include/clang/Lex/PPCallbacks.h
Modified: cfe/trunk/include/clang/Lex/PPCallbacks.h
URL:
http://llvm.org/viewvc/llvm-projec
Author: echristo
Date: Thu Sep 24 16:17:04 2015
New Revision: 248539
URL: http://llvm.org/viewvc/llvm-project?rev=248539&view=rev
Log:
Move the darwin define static function to be close to the OS define.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
Author: echristo
Date: Thu Sep 24 16:17:02 2015
New Revision: 248538
URL: http://llvm.org/viewvc/llvm-project?rev=248538&view=rev
Log:
Use just one larger anonymous namespace instead of a lot of smaller ones.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
Author: kromanova
Date: Thu Sep 24 17:06:52 2015
New Revision: 248546
URL: http://llvm.org/viewvc/llvm-project?rev=248546&view=rev
Log:
This patch adds missing pieces to clang, including the PS4 toolchain
definition, added warnings, PS4 defaults, and Driver changes needed for
our compiler.
A patc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248546: This patch adds missing pieces to clang, including
the PS4 toolchain (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D11279?vs=34522&id=35681#toc
Repository:
rL LLVM
zaks.anna added a comment.
The analyzer has a notion of ConstPointerEscape, see checkConstPointerEscape
callback.
All the pointers to const parameters are escaped this way. The implementation
for that is in CallEvent::invalidateRegions, right below the code you've added:
for (unsigned Idx = 0,
dcoughlin added inline comments.
Comment at:
tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPICheckerPathSensitive.cpp:34
@@ +33,3 @@
+ if (MR->getBaseRegion()->getAs())
+return;
+
You may be able to use `StoreManager::iterBindings()`, which iterates o
dcoughlin added a comment.
Sean,
One important difference between what you are proposing and what Cousot and
Cousot describe in the paper you cite is that they don't drop coverage. They
widen for termination on infinite-height lattices and their narrowing still
maintains an over-approximation
ABataev updated the summary for this revision.
ABataev updated this revision to Diff 35698.
ABataev added a comment.
Reworked patch after some discussion
http://reviews.llvm.org/D13128
Files:
lib/Support/raw_ostream.cpp
test/Other/empty.ll
Index: lib/Support/raw_ostream.cpp
===
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: rtrieu.
george.burgess.iv added a subscriber: cfe-commits.
Currently, -Wtautological-overlap-compare only emits warnings if the
comparisons are between integer literals and variables. This patch adds support
for compari
95 matches
Mail list logo
