r248459 - cuda-path: StringRef cannot be used here.

2015-09-23 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Wed Sep 23 22:15:44 2015 New Revision: 248459 URL: http://llvm.org/viewvc/llvm-project?rev=248459&view=rev Log: cuda-path: StringRef cannot be used here. Modified: cfe/trunk/lib/Driver/ToolChains.cpp Modified: cfe/trunk/lib/Driver/ToolChains.cpp URL: http://llvm.org/vi

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

2015-09-23 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. It would fail to link previously anyways, since as Renato correctly explained, you would have objects that were built with the soft float attribute, and then were linking against hard float built object. http://reviews.llvm.org/D12996 __

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

2015-09-23 Thread NAKAMURA Takumi via cfe-commits
chapuni added a subscriber: chapuni. Comment at: cfe/trunk/lib/Driver/ToolChains.cpp:1492 @@ +1491,3 @@ +const llvm::opt::ArgList &Args) { + SmallVector CudaPathCandidates; + Fixed in r248459. Comment

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

2015-09-23 Thread Eric Christopher via cfe-commits
echristo added a subscriber: echristo. echristo added a comment. Aha, nice catch! -eric Repository: rL LLVM http://reviews.llvm.org/D12989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

2015-09-23 Thread Eric Christopher via cfe-commits
Aha, nice catch! -eric On Wed, Sep 23, 2015 at 9:32 PM NAKAMURA Takumi wrote: > chapuni added a subscriber: chapuni. > > > Comment at: cfe/trunk/lib/Driver/ToolChains.cpp:1492 > @@ +1491,3 @@ > +const llvm::opt::ArgList > &Args) { > +

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-09-23 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054 @@ +3043,13 @@ +Sizes.push_back(Size); +MapTypes.push_back(MapType); + } + + // Keep track on whether the host function has to be executed. + auto OffloadErrorQType = + CGF.getCont

Re: [PATCH] D12832: [Driver] Add support for Windows 10 SDK

2015-09-23 Thread Igor Kudrin via cfe-commits
ikudrin updated this revision to Diff 35585. ikudrin added a comment. - Rebased to the top of history - Made pathes local to clang subtree http://reviews.llvm.org/D12832 Files: lib/Driver/MSVCToolChain.cpp lib/Driver/ToolChains.h Index: lib/Driver/ToolChains.h =

r248463 - [Driver] Add support for Windows 10 SDK

2015-09-23 Thread Igor Kudrin via cfe-commits
Author: ikudrin Date: Thu Sep 24 00:16:36 2015 New Revision: 248463 URL: http://llvm.org/viewvc/llvm-project?rev=248463&view=rev Log: [Driver] Add support for Windows 10 SDK Summary: With Windows 10 SDK, Include and Lib directories now contain an additional subfolder with the name that correspon

Re: [PATCH] D13122: Enable SafeStack on all Linux platforms

2015-09-23 Thread Alexey Samsonov via cfe-commits
samsonov accepted this revision. samsonov added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D13122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

<    1   2