Author: majnemer
Date: Mon Sep 14 02:05:00 2015
New Revision: 247535
URL: http://llvm.org/viewvc/llvm-project?rev=247535&view=rev
Log:
[Sema] Reject value-initialization of function types
T in the expression T() must be a non-array complete object type or
the void type. Function types are neithe
Author: chapuni
Date: Mon Sep 14 06:13:39 2015
New Revision: 247541
URL: http://llvm.org/viewvc/llvm-project?rev=247541&view=rev
Log:
Prune CRLF.
Modified:
clang-tools-extra/trunk/modularize/Modularize.cpp
Modified: clang-tools-extra/trunk/modularize/Modularize.cpp
URL:
http://llvm.org/view
Alexander_Droste updated this revision to Diff 34664.
Alexander_Droste added a comment.
- corrected some typos
http://reviews.llvm.org/D12761
Files:
tools/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt
tools/clang/lib/StaticAnalyzer/Checkers/Checkers.td
tools/clang/lib/StaticAnalyzer/Ch
Author: atanasyan
Date: Mon Sep 14 06:23:02 2015
New Revision: 247548
URL: http://llvm.org/viewvc/llvm-project?rev=247548&view=rev
Log:
[mips] Add test case to check ABI flag emissions in case of inline assembler
Follow up to r247546. The test case reproduces the problem fixed by this commit.
Ad
djasper added a comment.
Ping?
http://reviews.llvm.org/D11240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Alexander_Droste marked 3 inline comments as done.
Alexander_Droste added a comment.
http://reviews.llvm.org/D12761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Alexander_Droste added inline comments.
Comment at: tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/Utility.cpp:71
@@ +70,3 @@
+ if (FR) {
+VariableName = VR->getDecl()->getNameAsString() + "." +
+ FR->getDecl()->getNameAsString();
This
Why is it tested in clang?
FYI, update CLANG_TEST_DEPS in clang/test/CMakeLists.txt, if it would
remain in clang/test.
On Mon, Sep 14, 2015 at 8:24 PM Simon Atanasyan via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: atanasyan
> Date: Mon Sep 14 06:23:02 2015
> New Revision: 247548
On Mon, Sep 14, 2015 at 3:24 PM, NAKAMURA Takumi wrote:
> Why is it tested in clang?
Because the problem fixed by r247546 can be reproduced only in case of
using inline assembler. And the problem is in the incorrect ELF header
flag. So this test cannot be in llvm/test because there is no inline
a
Author: chapuni
Date: Mon Sep 14 07:41:53 2015
New Revision: 247553
URL: http://llvm.org/viewvc/llvm-project?rev=247553&view=rev
Log:
[CMake] Reformat CLANG_TEST_DEPS.
Modified:
cfe/trunk/test/CMakeLists.txt
Modified: cfe/trunk/test/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/cf
Author: chapuni
Date: Mon Sep 14 07:42:52 2015
New Revision: 247554
URL: http://llvm.org/viewvc/llvm-project?rev=247554&view=rev
Log:
[CMake] r247548 introduced llvm-readobj.
Modified:
cfe/trunk/test/CMakeLists.txt
Modified: cfe/trunk/test/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-pro
Makes sense. I have updated CLANG_TEST_DEPS in r247554.
On Mon, Sep 14, 2015 at 9:38 PM Simon Atanasyan wrote:
> On Mon, Sep 14, 2015 at 3:24 PM, NAKAMURA Takumi
> wrote:
> > Why is it tested in clang?
>
> Because the problem fixed by r247546 can be reproduced only in case of
> using inline ass
Thanks a lot!
On Mon, Sep 14, 2015 at 3:49 PM, NAKAMURA Takumi wrote:
> Makes sense. I have updated CLANG_TEST_DEPS in r247554.
>
> On Mon, Sep 14, 2015 at 9:38 PM Simon Atanasyan wrote:
>>
>> On Mon, Sep 14, 2015 at 3:24 PM, NAKAMURA Takumi
>> wrote:
>> > Why is it tested in clang?
>>
>> Becau
Author: mkurdej
Date: Mon Sep 14 03:05:12 2015
New Revision: 247536
URL: http://llvm.org/viewvc/llvm-project?rev=247536&view=rev
Log:
Test commit.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp
Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticCons
Author: alexfh
Date: Mon Sep 14 08:55:29 2015
New Revision: 247559
URL: http://llvm.org/viewvc/llvm-project?rev=247559&view=rev
Log:
[clang-tidy] misc-sizeof-container: whitelist std::array
Modified:
clang-tools-extra/trunk/clang-tidy/misc/SizeofContainerCheck.cpp
clang-tools-extra/trunk/
mclow.lists added a comment.
I have two concerns about this patch (w/o commenting on the actual code).
1. Until very recently, I was under the impression that C libraries _either_
defined a macro, or had a function. I was quite surprised to find that glibc
did both. Have you checked other C lib
Author: rcraik
Date: Mon Sep 14 09:08:18 2015
New Revision: 247560
URL: http://llvm.org/viewvc/llvm-project?rev=247560&view=rev
Log:
Test commit
Remove some trailing whitespace
Modified:
cfe/trunk/lib/Basic/Builtins.cpp
Modified: cfe/trunk/lib/Basic/Builtins.cpp
URL:
http://llvm.org/viewvc
Ping
> Gently ping.
>
>> On Aug 26, 2015, at 2:40 PM, Ettore Speziale
>> wrote:
>>
>> Forward to the right ML:
>>
Sorry about the extreme delay. This patch slipped through the cracks, and
I only noticed it again when searching my email for enable_if. Committed
in r245985! In
flx created this revision.
flx added reviewers: alexfh, sbenza, aaron.ballman.
flx added a subscriber: cfe-commits.
Add matcher that identifies arguments that are passed by value, are copy
assigned to a class field and have a non-deleted move constructor. If the type
is also expensive to copy is
sepavloff updated this revision to Diff 34673.
sepavloff added a comment.
Updated diagnostics according to Sean's notes ('textual module' -> 'textual
header')
http://reviews.llvm.org/D11844
Files:
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Basic/DiagnosticSemaKinds.td
incl
simoatze created this revision.
simoatze added reviewers: kbarton, nemanjai, wschmidt.
simoatze added a subscriber: cfe-commits.
Enabling ThreadSanitizer on PPC64(BE/LE) platforms. The current patch will
enable the flag "-fsanitize=thread" on Clang on PPC64 systems.
http://reviews.llvm.org/D1284
On Sat, Sep 12, 2015 at 11:06 PM, Manuel Klimek wrote:
>
>
> On Sat, Sep 12, 2015, 9:25 PM Aaron Ballman wrote:
>>
>> On Sat, Sep 12, 2015 at 8:22 AM, Manuel Klimek wrote:
>> >
>> >
>> > On Fri, Sep 11, 2015 at 10:39 PM Aaron Ballman
>> > wrote:
>> >>
>> >> On Fri, Sep 11, 2015 at 4:30 PM, Rich
On Mon, Sep 14, 2015, 8:40 AM Aaron Ballman wrote:
> On Sat, Sep 12, 2015 at 11:06 PM, Manuel Klimek wrote:
> >
> >
> > On Sat, Sep 12, 2015, 9:25 PM Aaron Ballman
> wrote:
> >>
> >> On Sat, Sep 12, 2015 at 8:22 AM, Manuel Klimek
> wrote:
> >> >
> >> >
> >> > On Fri, Sep 11, 2015 at 10:39 PM A
dougk updated the summary for this revision.
dougk updated this revision to Diff 34682.
dougk added a comment.
Changes per review - but only a minimally correct change to finding the
libraries. Using multilibs remains as a future task.
Also renamed SHAVE::Linker to Myriad::Linker.
http://review
berenm added a comment.
I don't have credentials to commit it, anybody could do it for me if the diff
is ok?
Thanks!
http://reviews.llvm.org/D12369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
dougk created this revision.
dougk added reviewers: jyknight, chandlerc.
dougk added a subscriber: cfe-commits.
Herald added a subscriber: jyknight.
Avoid generating spurious complaints from moviDebug.
Incidental change: rename 'test/Driver/shave-toolchain.c' to
'myriad-toolchain.c'
http://revi
Author: alexfh
Date: Mon Sep 14 11:51:52 2015
New Revision: 247578
URL: http://llvm.org/viewvc/llvm-project?rev=247578&view=rev
Log:
[clang-tidy] misc-sizeof-container: remove fix-it hints
This turned out to be a rather noisy check, so automated fixes will only do
harm. Remove them completely.
M
dougk added a comment.
This patch is wrong. Fixes are pending.
http://reviews.llvm.org/D12845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Mon Sep 14 11:56:57 2015
New Revision: 247580
URL: http://llvm.org/viewvc/llvm-project?rev=247580&view=rev
Log:
[clang-tidy] updated misc-sizeof-container docs.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/misc-sizeof-container.rst
Modified:
clang-tools-extr
xazax.hun created this revision.
xazax.hun added reviewers: dcoughlin, zaks.anna, jordan_rose.
xazax.hun added a subscriber: cfe-commits.
Right now the nullability checker only tracks symbolic regions. For this reason
if there are no dead symbols it is safe to skip the precondition checking. I
a
On Mon, Sep 14, 2015 at 11:49 AM, Manuel Klimek wrote:
>
>
> On Mon, Sep 14, 2015, 8:40 AM Aaron Ballman wrote:
>>
>> On Sat, Sep 12, 2015 at 11:06 PM, Manuel Klimek wrote:
>> >
>> >
>> > On Sat, Sep 12, 2015, 9:25 PM Aaron Ballman
>> > wrote:
>> >>
>> >> On Sat, Sep 12, 2015 at 8:22 AM, Manuel
This is the full patch that corrects all the compile errors MSVC was
generating. If we have any platform-specific checkers, they may have
been missed. But this should give an idea of the scope of the changes
we're asking folks to make.
~Aaron
On Mon, Sep 14, 2015 at 1:03 PM, Aaron Ballman wrote:
So, back in the day when we implemented the matchers, we decided on
actually wanting to remove all the CXX... AST nodes (there are more of
them). I don't know how this would work as recordDecl already exists. But
I'd be somewhat hesitant to introduce a cxxRecordDecl matcher if there is
still a chan
On Mon, Sep 14, 2015 at 10:21 AM Daniel Jasper wrote:
> So, back in the day when we implemented the matchers, we decided on
> actually wanting to remove all the CXX... AST nodes (there are more of
> them).
>
Note that Richard has paddled back on this and now says the CXX... AST
nodes are the rig
On Mon, Sep 14, 2015 at 7:24 PM, Manuel Klimek wrote:
> On Mon, Sep 14, 2015 at 10:21 AM Daniel Jasper wrote:
>
>> So, back in the day when we implemented the matchers, we decided on
>> actually wanting to remove all the CXX... AST nodes (there are more of
>> them).
>>
>
> Note that Richard has
On Mon, Sep 14, 2015 at 10:30 AM Daniel Jasper wrote:
> On Mon, Sep 14, 2015 at 7:24 PM, Manuel Klimek wrote:
>
>> On Mon, Sep 14, 2015 at 10:21 AM Daniel Jasper
>> wrote:
>>
>>> So, back in the day when we implemented the matchers, we decided on
>>> actually wanting to remove all the CXX... AS
Author: sfantao
Date: Mon Sep 14 12:41:32 2015
New Revision: 247584
URL: http://llvm.org/viewvc/llvm-project?rev=247584&view=rev
Log:
Update cxx-irgen.cpp test to allow signext in alwaysinline functions.
This was causing an error in Power8 targets.
Modified:
cfe/trunk/test/Modules/cxx-irgen.
Hi Evgeniy,
I commit a small change to one of the regression tests to allow a signext
to be generated: http://reviews.llvm.org/rL247584.
It was causing an error in Power8 targets. In my view is an harmless change
but you may want to take a look and see if that is fine by you.
Thanks!
Samuel
201
xazax.hun created this revision.
xazax.hun added reviewers: zaks.anna, dcoughlin, jordan_rose.
xazax.hun added a subscriber: cfe-commits.
This patch is a preparation to enabling some of the nullability checks by
default.
1. Moved nullability checkers to a top level package. The core package is n
xazax.hun updated this revision to Diff 34705.
xazax.hun added a comment.
Removed an unintended comment formatting change.
http://reviews.llvm.org/D12852
Files:
lib/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp
test/Analysis/nullability.mm
test/A
Author: dblaikie
Date: Mon Sep 14 13:02:04 2015
New Revision: 247586
URL: http://llvm.org/viewvc/llvm-project?rev=247586&view=rev
Log:
Revert "[opaque pointer type] update for LLVM API change"
This was the wrong direction to take anyway (because ultimately the
GlobalValue needed the pointee type
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Please, explain in code why you are doing this. Otherwise, LGTM.
Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:139
@@ -138,2 +138,3 @@
NullabilityChe
On Mon, Sep 14, 2015 at 1:37 PM, Manuel Klimek wrote:
> On Mon, Sep 14, 2015 at 10:30 AM Daniel Jasper wrote:
>>
>> On Mon, Sep 14, 2015 at 7:24 PM, Manuel Klimek wrote:
>>>
>>> On Mon, Sep 14, 2015 at 10:21 AM Daniel Jasper
>>> wrote:
So, back in the day when we implemented the match
loladiro created this revision.
loladiro added a reviewer: bkramer.
loladiro added a subscriber: cfe-commits.
loladiro set the repository for this revision to rL LLVM.
I feed custom buffers to clang, and since the buffers store an explicit length,
I did not think to null-terminate them.
However,
Author: xazax
Date: Mon Sep 14 13:31:34 2015
New Revision: 247590
URL: http://llvm.org/viewvc/llvm-project?rev=247590&view=rev
Log:
[Static Analyzer] Moving nullability checkers to a top level package.
Differential Revision: http://reviews.llvm.org/D12852
Added:
cfe/trunk/test/Analysis/null
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247590: [Static Analyzer] Moving nullability checkers to a
top level package. (authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D12852?vs=34705&id=34713#toc
Repository:
rL LLVM
h
bader created this revision.
bader added a reviewer: pekka.jaaskelainen.
bader added a subscriber: cfe-commits.
Patch by Pedro Ferreira.
This patch was reviewed here:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20150629/thread.html#131992,
but wasn't submitted into the tree.
Rebased
Author: dblaikie
Date: Mon Sep 14 13:38:22 2015
New Revision: 247593
URL: http://llvm.org/viewvc/llvm-project?rev=247593&view=rev
Log:
[opaque pointer type] Fix a few uses of PointerType::getElementType in favor of
uses of types already available elsewhere
These are a few cleanups I happened to
By this point, I see that change might be profitable overall. However, lets
completely map this out. Changing just cxxRecordDecl() can actually
increase confusion in other areas. Right now, not a single AST matcher has
the cxx prefix (although a total of 28 stand for the corresponding CXX..
AST nod
george.burgess.iv updated this revision to Diff 34710.
george.burgess.iv marked 4 inline comments as done.
george.burgess.iv added a comment.
Addressed all feedback -- added a walk of the Designator as suggested.
Regarding `isDesignatorAtObjectEnd`: I'm assuming that the Index returned by
`Field
george.burgess.iv added inline comments.
Comment at: lib/AST/ExprConstant.cpp:4457-4460
@@ -4434,1 +4456,6 @@
+// Because we set the Base to be the MemberExpr instead of E->getBase(),
the
+// Offset should be from the MemberExpr instead of the MemberExpr's base.
+if
Author: xazax
Date: Mon Sep 14 13:48:55 2015
New Revision: 247595
URL: http://llvm.org/viewvc/llvm-project?rev=247595&view=rev
Log:
[Static Analyzer] Moving nullability checkers out of alpha.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/Checkers.td
cfe/trunk/test/Analysis/nullability.m
Author: rjmccall
Date: Mon Sep 14 13:57:08 2015
New Revision: 247597
URL: http://llvm.org/viewvc/llvm-project?rev=247597&view=rev
Log:
Fix a nasty bug with the partial destruction of nested arrays;
it escaped notice because it's only used for heterogeneous
initialization.
rdar://21397946
Modifie
Author: xazax
Date: Mon Sep 14 14:00:08 2015
New Revision: 247598
URL: http://llvm.org/viewvc/llvm-project?rev=247598&view=rev
Log:
[Static Analyzer] Relaxing a caching out related assert.
Differential Revision: http://reviews.llvm.org/D12818
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/Expr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247598: [Static Analyzer] Relaxing a caching out related
assert. (authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D12818?vs=34579&id=34719#toc
Repository:
rL LLVM
http://reviews
Thanks!
On Mon, Sep 14, 2015 at 10:50 AM, Samuel F Antao wrote:
> Hi Evgeniy,
>
> I commit a small change to one of the regression tests to allow a signext to
> be generated: http://reviews.llvm.org/rL247584.
>
> It was causing an error in Power8 targets. In my view is an harmless change
> but yo
xazax.hun created this revision.
xazax.hun added reviewers: zaks.anna, dcoughlin, jordan_rose.
xazax.hun added a subscriber: cfe-commits.
This patch turns on some of the nullability related patches by default. These
checks has low false positive rate.
http://reviews.llvm.org/D12858
Files:
li
On Mon, Sep 14, 2015 at 11:45 AM Daniel Jasper wrote:
> By this point, I see that change might be profitable overall. However,
> lets completely map this out. Changing just cxxRecordDecl() can actually
> increase confusion in other areas. Right now, not a single AST matcher has
> the cxx prefix (
On Mon, Sep 14, 2015 at 2:45 PM, Daniel Jasper wrote:
> By this point, I see that change might be profitable overall. However, lets
> completely map this out. Changing just cxxRecordDecl() can actually increase
> confusion in other areas. Right now, not a single AST matcher has the cxx
> prefix (a
Author: rafael
Date: Mon Sep 14 14:30:53 2015
New Revision: 247603
URL: http://llvm.org/viewvc/llvm-project?rev=247603&view=rev
Log:
[Solaris] Add -lc also when linking shared libraries
This is actually needed, otherwise libc won't be added at all. For
instance when building libclang.so all the l
r247603
On 7 September 2015 at 13:22, Xan López via cfe-commits
wrote:
> On Mon, Sep 07, 2015 at 09:07:41AM -0700, Saleem Abdulrasool wrote:
>> > Basically check that -lc is present when clang is called in a certain
>> > way I guess? Or something more sophisticated?
>>
>>
>> Yeah, that it is pres
zaks.anna added inline comments.
Comment at: test/Analysis/free.c:1
@@ -1,2 +1,2 @@
-// RUN: %clang_cc1 -analyze -analyzer-store=region
-analyzer-checker=core,unix.Malloc -fblocks -verify %s
+// RUN: %clang_cc1 -analyze -analyzer-store=region
-analyzer-checker=core,unix.Malloc -
echristo accepted this revision.
echristo added a comment.
One set of inline comments, and also:
test/Driver/Inputs/scei-ps4_tree/target/include_common/.keep
eh?
-eric
Comment at: lib/Driver/Tools.cpp:10025-10029
@@ +10024,7 @@
+ const char *Exec =
+#ifdef LLVM_ON_WIN32
+
dirty added a comment.
Ping?
http://reviews.llvm.org/D12774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dougk
Date: Mon Sep 14 15:31:28 2015
New Revision: 247611
URL: http://llvm.org/viewvc/llvm-project?rev=247611&view=rev
Log:
Driver should forward at most one gdwarf-N flag to cc1as.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/integrated-as.s
Modified: cfe/trunk
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247612: [Static Analyzer] Nullability checker optimization.
(authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D12848?vs=34693&id=34725#toc
Repository:
rL LLVM
http://reviews.llvm
Author: xazax
Date: Mon Sep 14 15:31:46 2015
New Revision: 247612
URL: http://llvm.org/viewvc/llvm-project?rev=247612&view=rev
Log:
[Static Analyzer] Nullability checker optimization.
Differential Revision: http://reviews.llvm.org/D12848
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/Nulla
Author: xazax
Date: Mon Sep 14 15:34:06 2015
New Revision: 247614
URL: http://llvm.org/viewvc/llvm-project?rev=247614&view=rev
Log:
[Static Analyzer] Turn on some nullability checks by default.
Differential Revision: http://reviews.llvm.org/D12858
Modified:
cfe/trunk/lib/Driver/Tools.cpp
M
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247614: [Static Analyzer] Turn on some nullability checks by
default. (authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D12858?vs=34720&id=34726#toc
Repository:
rL LLVM
http://re
cdavis5x updated this revision to Diff 34728.
cdavis5x added a comment.
Address review comments.
- Pull out `va_arg` emission on `__builtin_ms_va_arg` to its own method on
`ABIInfo`. That way, ABI implementers don't need to care that this extension
even exists.
- Attempt to push repeated `va_ar
sunfish created this revision.
sunfish added a reviewer: jfb.
sunfish added a subscriber: cfe-commits.
sunfish set the repository for this revision to rL LLVM.
Herald added subscribers: dschuff, jfb.
This makes int_fast64_t and int_least64_t the same type as int64_t, and
eliminates a difference b
cdavis5x added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3598
@@ -3599,1 +3597,3 @@
+Address CodeGenFunction::EmitVAArg(Address VAListAddr, QualType Ty, bool IsMS)
{
+ return CGM.getTypes().getABIInfo().EmitVAArg(*this, VAListAddr, Ty, IsMS);
}
rjmcca
On Mon, Sep 14, 2015 at 12:26 PM Aaron Ballman
wrote:
> On Mon, Sep 14, 2015 at 2:45 PM, Daniel Jasper wrote:
> > By this point, I see that change might be profitable overall. However,
> lets
> > completely map this out. Changing just cxxRecordDecl() can actually
> increase
> > confusion in othe
dougk updated this revision to Diff 34729.
dougk added a comment.
Delete the overrides of getTool() and buildAssembler() in MyriadToolChain.
http://reviews.llvm.org/D12541
Files:
lib/Driver/Driver.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
lib/Driver/To
sunfish created this revision.
sunfish added a reviewer: jfb.
sunfish added a subscriber: cfe-commits.
sunfish set the repository for this revision to rL LLVM.
Herald added subscribers: dschuff, jfb.
WebAssembly's spec has now been updated to specify some [guarantees about lock
free atomic access
jfb accepted this revision.
jfb added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D12861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
jfb accepted this revision.
jfb added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D12862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
klimek added a comment.
First round of comments; some things are still a bit confusing, so I hope
another round will help to weed them out.
Comment at: include/clang/Tooling/Core/Replacement.h:223-224
@@ -222,1 +222,4 @@
+/// \brief Merges to sets of replacements with the sec
Author: dcoughlin
Date: Mon Sep 14 16:22:24 2015
New Revision: 247617
URL: http://llvm.org/viewvc/llvm-project?rev=247617&view=rev
Log:
[analyzer] Update SATestBuild.py to set -isysroot for preprocessed files
Update the static analyzer buildbot script to set -isysroot to the OS X SDK path
when an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247617: [analyzer] Update SATestBuild.py to set -isysroot
for preprocessed files (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D12769?vs=34471&id=34733#toc
Repository:
rL
On Mon, Sep 14, 2015 at 4:38 PM, Manuel Klimek wrote:
>
>
> On Mon, Sep 14, 2015 at 12:26 PM Aaron Ballman
> wrote:
>>
>> On Mon, Sep 14, 2015 at 2:45 PM, Daniel Jasper wrote:
>> > By this point, I see that change might be profitable overall. However,
>> > lets
>> > completely map this out. Chan
Author: rcraik
Date: Mon Sep 14 16:27:36 2015
New Revision: 247618
URL: http://llvm.org/viewvc/llvm-project?rev=247618&view=rev
Log:
C11 _Bool bitfield diagnostic
Summary: Implement DR262 (for C). This patch will mainly affect bitfields of
type _Bool
Reviewers: fraggamuffin, rsmith
Subscribers
Author: asbokhan
Date: Mon Sep 14 16:29:57 2015
New Revision: 247619
URL: http://llvm.org/viewvc/llvm-project?rev=247619&view=rev
Log:
PR24595: Ignore calling convention modifiers for structors in MS ABI.
MS compiler ignores calling convention modifiers for structors. This patch makes
clang do th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247619: PR24595: Ignore calling convention modifiers for
structors in MS ABI. (authored by asbokhan).
Changed prior to commit:
http://reviews.llvm.org/D12402?vs=34477&id=34735#toc
Repository:
rL LLVM
andreybokhanko added a comment.
OK -- I removed the check in Itanium ABI part, restored back the test and
committed the patch.
Thanks for reviewing!
Repository:
rL LLVM
http://reviews.llvm.org/D12402
___
cfe-commits mailing list
cfe-commits@lis
Author: eugenis
Date: Mon Sep 14 16:35:16 2015
New Revision: 247620
URL: http://llvm.org/viewvc/llvm-project?rev=247620&view=rev
Log:
Revert "Always_inline codegen rewrite" and 2 follow-ups.
Revert "Update cxx-irgen.cpp test to allow signext in alwaysinline functions."
Revert "[CodeGen] Remove wr
On Mon, Sep 14, 2015 at 2:29 PM Aaron Ballman
wrote:
> On Mon, Sep 14, 2015 at 4:38 PM, Manuel Klimek wrote:
> >
> >
> > On Mon, Sep 14, 2015 at 12:26 PM Aaron Ballman
> > wrote:
> >>
> >> On Mon, Sep 14, 2015 at 2:45 PM, Daniel Jasper
> wrote:
> >> > By this point, I see that change might be
Ok. I am happy with this then.
(Just personally grumpy having to write
cxxRecordDecl(has(cxxConstructorDecl(..))) in the future ;-) ).
On Mon, Sep 14, 2015 at 11:41 PM, Manuel Klimek wrote:
>
>
> On Mon, Sep 14, 2015 at 2:29 PM Aaron Ballman
> wrote:
>
>> On Mon, Sep 14, 2015 at 4:38 PM, Manue
Feel free to rename the AST nodes :)
On Mon, Sep 14, 2015, 2:44 PM Daniel Jasper wrote:
> Ok. I am happy with this then.
>
> (Just personally grumpy having to write
> cxxRecordDecl(has(cxxConstructorDecl(..))) in the future ;-) ).
>
> On Mon, Sep 14, 2015 at 11:41 PM, Manuel Klimek wrote:
>
>>
Btw, I think generating them, potentially into several different headers to
work around the compile time issue isn't such a bad idea.
On Mon, Sep 14, 2015 at 11:45 PM, Manuel Klimek wrote:
> Feel free to rename the AST nodes :)
>
> On Mon, Sep 14, 2015, 2:44 PM Daniel Jasper wrote:
>
>> Ok. I a
On Mon, Sep 14, 2015 at 5:44 PM, Daniel Jasper wrote:
> Ok. I am happy with this then.
>
> (Just personally grumpy having to write
> cxxRecordDecl(has(cxxConstructorDecl(..))) in the future ;-) ).
I share your grumpiness about the cxxConstructorDecl, but probably
won't share it when we add objcCo
On Mon, Sep 14, 2015 at 5:47 PM, Daniel Jasper wrote:
> Btw, I think generating them, potentially into several different headers to
> work around the compile time issue isn't such a bad idea.
I'm not going to start with this approach, but think it may be worth
exploring at some point. ;-)
~Aaron
Author: djg
Date: Mon Sep 14 16:49:41 2015
New Revision: 247622
URL: http://llvm.org/viewvc/llvm-project?rev=247622&view=rev
Log:
[WebAssembly] Use "long long" for int_fast64_t and int_least64_t on wasm64
This makes int_fast64_t and int_least64_t the same type as int64_t, and
eliminates a differe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247622: [WebAssembly] Use "long long" for int_fast64_t and
int_least64_t on wasm64 (authored by djg).
Changed prior to commit:
http://reviews.llvm.org/D12861?vs=34727&id=34738#toc
Repository:
rL LLVM
Author: djg
Date: Mon Sep 14 16:54:32 2015
New Revision: 247623
URL: http://llvm.org/viewvc/llvm-project?rev=247623&view=rev
Log:
[WebAssembly] Simplify code by avoiding duplicating the default behavior.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInf
Author: djg
Date: Mon Sep 14 16:56:37 2015
New Revision: 247624
URL: http://llvm.org/viewvc/llvm-project?rev=247624&view=rev
Log:
[WebAssembly] Define the atomic type sizes
WebAssembly's spec has now been updated to specify some guarantees
about lock free atomic accesses. Update clang to match.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247624: [WebAssembly] Define the atomic type sizes (authored
by djg).
Changed prior to commit:
http://reviews.llvm.org/D12862?vs=34731&id=34739#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12862
MyDeveloperDay updated this revision to Diff 34741.
MyDeveloperDay added a comment.
Handle subsequent catch statements
http://reviews.llvm.org/D12492
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineParser.cpp
unittest
jyknight added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3929
@@ +3928,3 @@
+: Generic_GCC(D, Triple, Args) {
+ // If a target of 'sparc-myriad-elf' is specified to clang, it wants to use
+ // 'sparc-myriad--elf' (note the unknown OS) as the canonical triple.
--
Prazek created this revision.
Prazek added reviewers: rsmith, rjmccall, hans, majnemer.
Prazek added a subscriber: cfe-commits.
http://reviews.llvm.org/D12865
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/vtable-assume-load.
1 - 100 of 148 matches
Mail list logo
