r246619, thanks!
About createEliminateAvailableExternallyPass for LTO, I'm missing
something. At link time, aren't available externally function supposed to
be, well, available as external linkage? Won't the link fail without these
versions?
if so, why keep the available externally versions at all
matto1990 requested changes to this revision.
matto1990 added a comment.
This revision now requires changes to proceed.
This looks much better than the code I wrote. If all the unit tests are
passing, the one change I can see to make is a misspelling in one of the
comments. The rest looks excell
berenm updated this revision to Diff 33783.
berenm added a comment.
Here it is, with the typos in comments corrected, and rebased over the latest
trunk.
Thanks for the review!
http://reviews.llvm.org/D12369
Files:
lib/Format/WhitespaceManager.cpp
unittests/Format/FormatTest.cpp
Index: un
berenm marked 5 inline comments as done.
berenm added a comment.
http://reviews.llvm.org/D12369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
skalinichev retitled this revision from "[libclang] Expose the ElaboratedType"
to "[LIbClang] Report the named type for ElaboratedType".
skalinichev updated the summary for this revision.
skalinichev updated this revision to Diff 33787.
skalinichev added a comment.
It just occured to me, why do w
ABataev added a comment.
LGTM
http://reviews.llvm.org/D12262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: klimek, cfe-commits.
Fix a bug where use-auto check would crash when the definition of a type is in
the same statement than its instantiation with new.
http://reviews.llvm.org/D12551
Files:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you!
http://reviews.llvm.org/D12551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: angelgarcia
Date: Wed Sep 2 05:20:00 2015
New Revision: 246638
URL: http://llvm.org/viewvc/llvm-project?rev=246638&view=rev
Log:
Fix use-auto-check.
Summary: Fix a bug where use-auto check would crash when the definition of a
type is in the same statement than its instantiation with new
kuhar added a comment.
ping
Repository:
rL LLVM
http://reviews.llvm.org/D12400
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jwillemsen added a comment.
Just tested 3.7.0, this issue is not fixed in this new release of today
Repository:
rL LLVM
http://reviews.llvm.org/D3583
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
labrinea added a comment.
Could I have some feedback please?
http://reviews.llvm.org/D12244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Wed Sep 2 07:01:51 2015
New Revision: 246643
URL: http://llvm.org/viewvc/llvm-project?rev=246643&view=rev
Log:
[clang-tidy] Updated the check name in the doc.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-shrink-to-fit.rst
Modified:
clang-tools-ext
vkalintiris added a comment.
In http://reviews.llvm.org/D11815#237541, @ahatanak wrote:
> In http://reviews.llvm.org/D11815#236368, @vkalintiris wrote:
>
> > In http://reviews.llvm.org/D11815#235394, @ahatanak wrote:
> >
> > >
> >
>
>
>
>
> > For example, on a Mips target, where the O32 ABI requi
aadg added a subscriber: aadg.
aadg added a comment.
Just a minor nitpick (see below)
Comment at: lib/CodeGen/CGCall.cpp:2332
@@ -2331,2 +2331,3 @@
if (!store) return nullptr;
+ if (store->getPointerOperand() != CGF.ReturnValue) return nullptr;
It might be
Author: aaronballman
Date: Wed Sep 2 07:50:12 2015
New Revision: 246646
URL: http://llvm.org/viewvc/llvm-project?rev=246646&view=rev
Log:
Silence a -Wsign-compare warning; NFC.
Modified:
cfe/trunk/lib/Serialization/MultiOnDiskHashTable.h
Modified: cfe/trunk/lib/Serialization/MultiOnDiskHash
aadg added a comment.
Yet another comment (see below).
Comment at: lib/CodeGen/CGCall.cpp:2332
@@ -2331,2 +2331,3 @@
if (!store) return nullptr;
+ if (store->getPointerOperand() != CGF.ReturnValue) return nullptr;
aadg wrote:
> It might be worth stating in
Hi Yaron,
This is to handle the case of pre-built (real .o) files.
The available externally functions are kept in the -c -flto compile
(the pass isn't run) so that they are available for inlining in the
LTO pipeline. If the available externally function is in a pre-built
object file it wouldn't be
Author: dougk
Date: Wed Sep 2 08:33:42 2015
New Revision: 246650
URL: http://llvm.org/viewvc/llvm-project?rev=246650&view=rev
Log:
[Sparc]: GCCInstallationDetector should not care if little-endian
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
Modified: cfe/trunk/lib/Driver/ToolChains.cpp
UR
Author: dougk
Date: Wed Sep 2 08:42:43 2015
New Revision: 246652
URL: http://llvm.org/viewvc/llvm-project?rev=246652&view=rev
Log:
[Shave]: pass through more clang options to moviCompile
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/shave-toolchain.c
Modified: cfe/trunk
I ran into an issue with the runCheckOnCode() function from
clang-tidy's unit tests, and I am not familiar enough with the way
tool invocation works to suggest a correct fix.
ClangTidyContext::setASTContext() is what sets up the language options
for the ClangTidyContext object currently. However,
> On 02.09.2015, at 02:12, Eric Christopher via cfe-commits
> wrote:
>
> Author: echristo
> Date: Tue Sep 1 19:12:02 2015
> New Revision: 246610
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246610&view=rev
> Log:
> Migrate the target attribute parsing code into an extension off of
> the m
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: klimek, cfe-commits.
loop-convert no longer crashes when calling a member function using a member
pointer which is a member of another record.
http://reviews.llvm.org/D12555
Files:
clang-ti
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:894
@@ -893,1 +893,3 @@
+def DisableTailCalls : InheritableAttr {
+ let Spellings = [GNU<"disable_tail_calls">];
We already have an attribute that is tangentially related: OptimizeNone
A few nits in addition to what Ben pointed out...
On Tue, Sep 1, 2015 at 8:12 PM, Eric Christopher via cfe-commits
wrote:
> Author: echristo
> Date: Tue Sep 1 19:12:02 2015
> New Revision: 246610
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246610&view=rev
> Log:
> Migrate the target attribu
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D12555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: angelgarcia
Date: Wed Sep 2 09:25:08 2015
New Revision: 246655
URL: http://llvm.org/viewvc/llvm-project?rev=246655&view=rev
Log:
Fix loop-convert crash.
Summary: loop-convert no longer crashes when calling a member function using a
member pointer which is a member of another record.
Re
On Wed, Sep 2, 2015 at 2:19 AM, Daniel Marjamäki
wrote:
> danielmarjamaki added a comment.
>
>> > > The checker isn't currently path sensitive as it doesn't pay attention
>
>>
>
>> >
>
>>
>
>> > > to control flow graphs or how pointer values flow through a function
>
>>
>
>> >
>
>>
>
>> > > body
Looks like we need to call both ClangTidyContext::setASTContext,
ClangTidyCheck::registerMatchers and ClangTidyContext::setCurrentFile
in TestClangTidyAction::CreateASTConsumer. Maybe something else will need
to move there as well.
-- Alex
On Wed, Sep 2, 2015 at 4:09 PM, Aaron Ballman
wrote:
>
On Wed, Sep 2, 2015 at 10:44 AM, Alexander Kornienko wrote:
> Looks like we need to call both ClangTidyContext::setASTContext,
> ClangTidyCheck::registerMatchers and ClangTidyContext::setCurrentFile in
> TestClangTidyAction::CreateASTConsumer. Maybe something else will need to
> move there as well
seaneveson added a comment.
In http://reviews.llvm.org/D12358#237099, @krememek wrote:
> To get the conservative invalidation that Anna suggests (actually, a little
> less conservative), I think you can just pass in a two MemRegions as the
> input to that method and get a new ProgramState with
Author: d0k
Date: Wed Sep 2 10:31:05 2015
New Revision: 246657
URL: http://llvm.org/viewvc/llvm-project?rev=246657&view=rev
Log:
[OpenMP] Make helper functoin static. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
URL:
http://ll
Author: majnemer
Date: Wed Sep 2 10:50:38 2015
New Revision: 246659
URL: http://llvm.org/viewvc/llvm-project?rev=246659&view=rev
Log:
[MS ABI] Number unnamed TagDecls which aren't externally visible
TagDecls (structs, enums, etc.) may have the same name for linkage
purposes of one another; to di
Thanks!
On 2 September 2015 at 11:50, David Majnemer via cfe-commits
wrote:
> Author: majnemer
> Date: Wed Sep 2 10:50:38 2015
> New Revision: 246659
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246659&view=rev
> Log:
> [MS ABI] Number unnamed TagDecls which aren't externally visible
>
> Tag
Author: aaronballman
Date: Wed Sep 2 11:04:15 2015
New Revision: 246660
URL: http://llvm.org/viewvc/llvm-project?rev=246660&view=rev
Log:
Move some more functionality into the AST consumer creation factory function,
before registering matchers with the MatchFinder object. This allows us to set
Author: aaronballman
Date: Wed Sep 2 11:05:21 2015
New Revision: 246661
URL: http://llvm.org/viewvc/llvm-project?rev=246661&view=rev
Log:
Disable clang-tidy readability checkers when not compiling in C++ mode. None of
the checkers require additional testing as the tests will not compile for othe
Author: aaronballman
Date: Wed Sep 2 11:20:42 2015
New Revision: 246663
URL: http://llvm.org/viewvc/llvm-project?rev=246663&view=rev
Log:
Disable clang-tidy Google checkers when not compiling in C++ mode. None of the
checkers require additional testing as the tests will not compile for other
la
I happened to notice that CODE_OWNERS.TXT for clang-tools-extra is
rather sparse. These tools are starting to get more attention from the
community, and I am wondering whether it would make sense to populate
that somewhat? If so, I would nominate:
Alexander Kornienko for clang-tidy
Peter Collingbo
LG for clang-tidy.
On Wed, Sep 2, 2015 at 6:38 PM, Aaron Ballman
wrote:
> I happened to notice that CODE_OWNERS.TXT for clang-tools-extra is
> rather sparse. These tools are starting to get more attention from the
> community, and I am wondering whether it would make sense to populate
> that som
I think that basically encodes what the current state is, and we should
have kept that file in a better shape. +Edwin in case he still has a stake
in clang-modernize, or knows who might have.
On Wed, Sep 2, 2015 at 6:38 PM Aaron Ballman wrote:
> I happened to notice that CODE_OWNERS.TXT for clan
On Sep 2, 2015 9:38 AM, "Aaron Ballman via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> I happened to notice that CODE_OWNERS.TXT for clang-tools-extra is
> rather sparse. These tools are starting to get more attention from the
> community, and I am wondering whether it would make sense to
On Wed, Sep 2, 2015 at 7:24 AM Aaron Ballman wrote:
> A few nits in addition to what Ben pointed out...
>
> On Tue, Sep 1, 2015 at 8:12 PM, Eric Christopher via cfe-commits
> wrote:
> > Author: echristo
> > Date: Tue Sep 1 19:12:02 2015
> > New Revision: 246610
> >
> > URL: http://llvm.org/view
On Wed, Sep 2, 2015 at 1:07 PM, Eric Christopher wrote:
>
>
> On Wed, Sep 2, 2015 at 7:24 AM Aaron Ballman wrote:
>>
>> A few nits in addition to what Ben pointed out...
>>
>> On Tue, Sep 1, 2015 at 8:12 PM, Eric Christopher via cfe-commits
>> wrote:
>> > Author: echristo
>> > Date: Tue Sep 1 1
I don't know of anyone who has a stake in clang-modernize and I probably
should be removed from the code-owner role.
On 2 September 2015 at 12:48, Manuel Klimek wrote:
> I think that basically encodes what the current state is, and we should
> have kept that file in a better shape. +Edwin in cas
Author: rsmith
Date: Wed Sep 2 12:45:54 2015
New Revision: 246680
URL: http://llvm.org/viewvc/llvm-project?rev=246680&view=rev
Log:
[modules] Don't waste time reading in the names the module file writer gave to
blocks. We don't need these names, and decoding the corresponding bitcode has a
sign
pekka.jaaskelainen added a comment.
Is there a matching HLC-HSAIL branch for the latest version of the patch? It
doesn't work with with hsail-stable-3.7 anymore.
http://reviews.llvm.org/D10586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dcoughlin updated this revision to Diff 33836.
dcoughlin added a comment.
I've updated ExprEngine::VisitObjCMessage to create a pre-statement program
point node for the ObjCMessageExpr when the receiver is definitely nil and
changed the MessageNil checker handlers to run on a post-statement prog
pgousseau created this revision.
pgousseau added reviewers: ayartsev, zaks.anna, dcoughlin, xazax.hun, ClockMan.
pgousseau added a subscriber: cfe-commits.
Fix assertions kindly reported by Gabor Horvath and Piotr Zegar caused by
commit r246345 and reverted in r246479.
Original review in http://r
SGTM.
Peter
On Wed, Sep 02, 2015 at 12:38:41PM -0400, Aaron Ballman wrote:
> I happened to notice that CODE_OWNERS.TXT for clang-tools-extra is
> rather sparse. These tools are starting to get more attention from the
> community, and I am wondering whether it would make sense to populate
> that s
Author: aaronballman
Date: Wed Sep 2 15:00:41 2015
New Revision: 246698
URL: http://llvm.org/viewvc/llvm-project?rev=246698&view=rev
Log:
Updating the code owners list.
Modified:
clang-tools-extra/trunk/CODE_OWNERS.TXT
Modified: clang-tools-extra/trunk/CODE_OWNERS.TXT
URL:
http://llvm.org/
I've updated the code owners list in r246698. Thanks!
~Aaron
On Wed, Sep 2, 2015 at 3:33 PM, Peter Collingbourne wrote:
> SGTM.
>
> Peter
>
> On Wed, Sep 02, 2015 at 12:38:41PM -0400, Aaron Ballman wrote:
>> I happened to notice that CODE_OWNERS.TXT for clang-tools-extra is
>> rather sparse. The
krasin updated this revision to Diff 33849.
krasin added a comment.
Addressed a nit.
http://reviews.llvm.org/D12544
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
lib/Driver/SanitizerArgs.cpp
lib/Frontend/CompilerInvocation.cpp
test/Driver/Inputs/resource_
Author: spatel
Date: Wed Sep 2 15:01:30 2015
New Revision: 246699
URL: http://llvm.org/viewvc/llvm-project?rev=246699&view=rev
Log:
add __builtin_unpredictable and convert to metadata
This patch depends on r246688 (D12341).
The goal is to make LLVM generate different code for these functions fo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246699: add __builtin_unpredictable and convert to metadata
(authored by spatel).
Changed prior to commit:
http://reviews.llvm.org/D12458?vs=33491&id=33850#toc
Repository:
rL LLVM
http://reviews.llv
krasin added inline comments.
Comment at: test/Driver/fsanitize-blacklist.c:25
@@ -18,2 +24,3 @@
+// CHECK-DEFAULT-BLACKLIST: -fsanitize-blacklist={{.*}}asan_blacklist.txt
// Ignore -fsanitize-blacklist flag if there is no -fsanitize flag.
Good idea. Done.
ht
Author: krasin
Date: Wed Sep 2 15:02:38 2015
New Revision: 246700
URL: http://llvm.org/viewvc/llvm-project?rev=246700&view=rev
Log:
Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.
Summary:
Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.
Introduc
Thanks for the cleanup!
On Wed, Sep 2, 2015 at 10:02 PM Aaron Ballman
wrote:
> I've updated the code owners list in r246698. Thanks!
>
> ~Aaron
>
> On Wed, Sep 2, 2015 at 3:33 PM, Peter Collingbourne
> wrote:
> > SGTM.
> >
> > Peter
> >
> > On Wed, Sep 02, 2015 at 12:38:41PM -0400, Aaron Ballma
Author: echristo
Date: Wed Sep 2 15:13:41 2015
New Revision: 246701
URL: http://llvm.org/viewvc/llvm-project?rev=246701&view=rev
Log:
Update comment for AdditionalMembers with a note to avoid using
additional data members in attributes as they'll leak and provide
some guidance as to where they sh
On Wed, Sep 2, 2015 at 4:13 PM, Eric Christopher via cfe-commits
wrote:
> Author: echristo
> Date: Wed Sep 2 15:13:41 2015
> New Revision: 246701
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246701&view=rev
> Log:
> Update comment for AdditionalMembers with a note to avoid using
> additional
On Wed, Sep 2, 2015 at 10:11 AM Aaron Ballman
wrote:
> On Wed, Sep 2, 2015 at 1:07 PM, Eric Christopher
> wrote:
> >
> >
> > On Wed, Sep 2, 2015 at 7:24 AM Aaron Ballman
> wrote:
> >>
> >> A few nits in addition to what Ben pointed out...
> >>
> >> On Tue, Sep 1, 2015 at 8:12 PM, Eric Christoph
Author: silvas
Date: Wed Sep 2 15:16:09 2015
New Revision: 246702
URL: http://llvm.org/viewvc/llvm-project?rev=246702&view=rev
Log:
[modules] Tighten up this test a bit.
Modified:
cfe/trunk/test/Modules/module-map-path-hash.cpp
Modified: cfe/trunk/test/Modules/module-map-path-hash.cpp
URL:
Author: echristo
Date: Wed Sep 2 15:40:12 2015
New Revision: 246706
URL: http://llvm.org/viewvc/llvm-project?rev=246706&view=rev
Log:
Migrate the target attribute parsing code to returning an instance
every time it's called rather than attempting to cache the result.
It's unlikely to be called fr
And I think I've fixed the other bits in
dzur:~/sources/llvm/tools/clang> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/cfe/trunk ...
M include/clang/Basic/Attr.td
M lib/CodeGen/CGCall.cpp
Committed r246706
We could eventually cache the parsing etc, but I don't think it's hugely
rsmith added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:485
@@ +484,3 @@
+ std::string Name = Fn->getName();
+ std::string InlineName = Name + ".inlinefunction";
+ Fn->setName(InlineName);
I have a slight preference for ".alwaysinline" over ".in
Author: ayartsev
Date: Wed Sep 2 16:01:59 2015
New Revision: 246710
URL: http://llvm.org/viewvc/llvm-project?rev=246710&view=rev
Log:
[analyzer] Refactoring: bring together scan-build options and environment
variables.
Full list of changes:
- all scan-build command-line arguments are now kept i
mclow.lists abandoned this revision.
mclow.lists added a comment.
There are other suggested fixes for this problem, and this has gotten stale.
http://reviews.llvm.org/D3197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
ayartsev added a comment.
Removed trailing whitespaces and committed as r246710.
Thanks for reviews and assistance!
http://reviews.llvm.org/D6551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: dougk
Date: Wed Sep 2 16:14:53 2015
New Revision: 246714
URL: http://llvm.org/viewvc/llvm-project?rev=246714&view=rev
Log:
Use new utility function to clean leading junk from pathnames. NFC
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/lib/Frontend/DependencyFile.cpp
Modifi
Author: dougk
Date: Wed Sep 2 16:18:10 2015
New Revision: 246715
URL: http://llvm.org/viewvc/llvm-project?rev=246715&view=rev
Log:
Remove inadvertent debug output from prior change.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
http://llvm.org/viewv
jyknight added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3936
@@ -3914,9 +3935,3 @@
-SHAVEToolChain::SHAVEToolChain(const Driver &D, const llvm::Triple &Triple,
- const ArgList &Args)
-: Generic_GCC(D, Triple, Args) {}
-
-SHAVEToolC
eugenis updated this revision to Diff 33868.
eugenis marked 6 inline comments as done.
Repository:
rL LLVM
http://reviews.llvm.org/D12087
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
l
george.burgess.iv updated this revision to Diff 33875.
george.burgess.iv marked 16 inline comments as done.
george.burgess.iv added a comment.
Addressed all feedback; backed out support for more questionable features
(negative indices, non-object-boundary offsets, etc), added logic to ignore
poi
kromanova added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:325-344
@@ +324,22 @@
+ case llvm::Triple::PS4: {
+// gets prepended later in AddPath().
+std::string BaseSDKPath = "";
+if (!HasSysroot) {
+ const char *envValue = getenv("SCE_PS4_SD
echristo added a comment.
Replying to the inline comments. I know we're waiting on the linker stuff, but
Katya made me realize I hadn't replied to your comments.
-eric
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:203-208
@@ +202,8 @@
+ InGroup;
+def warn_drv_ps4_s
kromanova added inline comments.
Comment at: include/clang/Driver/Options.td:1853-1854
@@ -1853,2 +1852,4 @@
+def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, HelpText<"Use linker ">,
Group;
+def linker_EQ : Joined<["-"], "linker=">, Alias,
MetaVarName<"">;
defm align_functions :
kromanova added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:325-344
@@ +324,22 @@
+ case llvm::Triple::PS4: {
+// gets prepended later in AddPath().
+std::string BaseSDKPath = "";
+if (!HasSysroot) {
+ const char *envValue = getenv("SCE_PS4_SD
ahatanak updated this revision to Diff 33882.
http://reviews.llvm.org/D12547
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/CGCall.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGen/attr-disable-tail-calls.c
Index: test/CodeGen/attr-disable-tail-calls.c
ahatanak added inline comments.
Comment at: include/clang/Basic/Attr.td:894
@@ -893,1 +893,3 @@
+def DisableTailCalls : InheritableAttr {
+ let Spellings = [GNU<"disable_tail_calls">];
aaron.ballman wrote:
> We already have an attribute that is tangentially rel
jroelofs added a subscriber: jroelofs.
Comment at: lib/Frontend/InitHeaderSearch.cpp:340
@@ +339,3 @@
+BaseSDKPath = P.str();
+ }
+}
The lifetime of `P` ends here, yet a reference to it lives on because of the `=
P.str()`. Using it later on line
eugenis added inline comments.
Comment at: lib/CodeGen/CGCXX.cpp:45
@@ +44,3 @@
+ // destructors.
+ if (getCodeGenOpts().SanitizeMemoryUseAfterDtor)
+return true;
This simply suppresses all dtor alias under UseAfterDtor, effectively disabling
the second che
kromanova added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:340
@@ +339,3 @@
+BaseSDKPath = P.str();
+ }
+}
jroelofs wrote:
> The lifetime of `P` ends here, yet a reference to it lives on because of the
> `= P.str()`. Using it
compnerd created this revision.
compnerd added reviewers: rafael, rnk.
compnerd added a subscriber: cfe-commits.
Simplify the mangling handling. This allows for the correct handling of extern
"C" symbols in C++ input. The observable difference with this simplification
that additional symbols ar
compnerd added inline comments.
Comment at: lib/AST/Mangle.cpp:191
@@ -199,3 +190,3 @@
else
-Out << "_block_invoke_" << discriminator+1;
+Out << "_block_invoke_" << discriminator + 1;
}
Drive by reformat.
Comment at: test/CodeGen/pr96
nmusgrave updated this revision to Diff 33887.
nmusgrave marked 4 inline comments as done.
nmusgrave added a comment.
- Update comments, consistent style for attribute checking.
http://reviews.llvm.org/D12022
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenModule.h
eugenis added a comment.
LGTM but please wait for Richard's answer
Comment at: lib/CodeGen/CGClass.cpp:1551
@@ +1550,3 @@
+ // Prevent the current stack frame from disappearing from the stack
trace.
+ CGF.CurFn->addFnAttr("disable-tail-calls", "true");
+
-
rsmith added a comment.
I'd like to see some tests for poisoning bitfields, and particularly anonymous
bitfields (I think the code works fine in those cases, but they're a bit
special so explicitly testing them is useful).
Comment at: lib/CodeGen/CGCXX.cpp:151
@@ +150,3 @@
+
Prazek created this revision.
Prazek added reviewers: rsmith, rjmccall, majnemer, nlewycky.
Prazek added a subscriber: cfe-commits.
Generates code like this
!llvm.module.flags = !{!0, !1}
!0 = !{i32 1, !"StrictVTablePointers", i32 1}
!1 = !{i32 3, !"StrictVTablePointersRequirement", !2}
!2 = !{!
Gently ping.
> On Aug 26, 2015, at 2:40 PM, Ettore Speziale
> wrote:
>
> Forward to the right ML:
>
>>> Sorry about the extreme delay. This patch slipped through the cracks, and I
>>> only noticed it again when searching my email for enable_if. Committed in
>>> r245985! In the future, please
rsmith added a comment.
Functionally LGTM, but please add a test case. Is there any precedent for how
to spell these module flags (StrictVTablePointers / strict_vtable_pointers /
strict.vtable.pointers)?
http://reviews.llvm.org/D12580
___
cfe-comm
piotrdz updated this revision to Diff 33879.
piotrdz added a comment.
In this third version I did the following:
- fixed problems which I noticed with template specializations,
- changed output diagnostics to be more detailed, covering multiple declarations
- added FixIt hints to refactor inconsi
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
A couple things inline that need changing, but feel free to commit after
without a repost.
-eric
Comment at: lib/Basic/Targets.cpp:6943-6944
@@ +6942,4 @@
+
+ Diags.Report(diag
Hello!
In general I am scared of such fixes.
I assume we know that Info::MaxTables is never a negative value now. However if
it would (by mistake) get a negative value in the future then you are hiding an
important TP warning here.
I assume we know that Info::MaxTables is never larger than in
majnemer added a subscriber: majnemer.
Comment at: lib/AST/Mangle.cpp:130
@@ +129,3 @@
+ // ObjectiveC/C++ cannot support alternate calling conventions due to method
+ // dispatch. Honour the mangling irrespective of the annotations.
+ if (const ObjCMethodDecl *OMD = dyn_cast(
compnerd added inline comments.
Comment at: lib/AST/Mangle.cpp:139
@@ -149,2 +138,3 @@
- Out << '\01';
+ // shouldMangleCXXName lies sometimes for the MS-ABI, so check the CC
mangling
+ // when targeting MS-ABI (it doesnt consider CC which take precedence over
--
krememek added a comment.
In http://reviews.llvm.org/D12358#238303, @seaneveson wrote:
> In http://reviews.llvm.org/D12358#237099, @krememek wrote:
>
> > To get the conservative invalidation that Anna suggests (actually, a little
> > less conservative), I think you can just pass in a two MemRegi
95 matches
Mail list logo
