On Thu, Aug 27, 2015 at 7:19 PM, Eric Christopher
wrote:
> Hi Ahmed,
>
> A quick note: I think this is going to fail in the presence of the target
> attribute. I.e. if someone decorates a function with
> __attribute__((target("avx512"))) this is unlikely to catch that.
>
You're right; any ideas
Aha. This is what's causing Siva Chandra's problem.
Hrm, I'll see what I can figure out. I'll revert until then or talk to
Richard.
-eric
On Mon, Aug 31, 2015 at 4:02 PM Hans Wennborg wrote:
> This change makes Basic depend on AST.
>
> The immediate problem I'm hitting is clang-format (which u
Author: echristo
Date: Mon Aug 31 18:19:55 2015
New Revision: 246508
URL: http://llvm.org/viewvc/llvm-project?rev=246508&view=rev
Log:
Revert "Pull the target attribute parsing out of CGCall and onto TargetInfo."
This reverts commit r246468 while we figure out what to do about Basic and AST.
Mod
On Mon, Aug 31, 2015 at 11:39 AM, Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Mon Aug 31 13:39:22 2015
> New Revision: 246468
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246468&view=rev
> Log:
> Pull the target attribute parsing out of CGCa
On Mon, Aug 31, 2015 at 4:34 PM Richard Smith wrote:
> On Mon, Aug 31, 2015 at 11:39 AM, Eric Christopher via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: echristo
>> Date: Mon Aug 31 13:39:22 2015
>> New Revision: 246468
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=24646
EricWF created this revision.
EricWF added reviewers: mclow.lists, danalbert, jroelofs, rsmith.
EricWF added a subscriber: cfe-commits.
Currently on most platforms you have to manually link the c++ abi library used
with libc++ whenever you use libc++. So your typical libc++ command like
invocati
Author: hfinkel
Date: Mon Aug 31 18:55:19 2015
New Revision: 246510
URL: http://llvm.org/viewvc/llvm-project?rev=246510&view=rev
Log:
[PowerPC] Support __builtin_ppc_get_timebase
GCC 4.8+ has a PowerPC-specific intrinsic, __builtin_ppc_get_timebase, to do
what Clang's __builtin_readcyclecounter d
tra added inline comments.
Comment at: include/clang/Sema/Sema.h:8599
@@ +8598,3 @@
+CFP_Never, // Invalid caller/callee combination.
+CFP_LastResort, // same as CFP_Never or CFP_Fallback, depending on
+// -fcuda-disable-target-call-checks option
-
tra updated this revision to Diff 33654.
tra marked 2 inline comments as done.
tra added a comment.
addressed eliben@'s comments.
http://reviews.llvm.org/D12453
Files:
include/clang/Basic/Builtins.h
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
include/clang/Sem
silvas added a comment.
ping?
http://reviews.llvm.org/D11844
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak created this revision.
ahatanak added reviewers: echristo, dexonsmith.
ahatanak added a subscriber: cfe-commits.
Clang driver option -fno-zero-initialized-in-bss is used to prevent global
variables that are initialized to zero from being placed in the bss section,
but is currently ignor
Author: ericwf
Date: Mon Aug 31 20:02:06 2015
New Revision: 246516
URL: http://llvm.org/viewvc/llvm-project?rev=246516&view=rev
Log:
Convert LIBCXXABI_BUILD_32_BITS to LLVM_BUILD_32_BITS.
Modified:
libcxxabi/trunk/test/CMakeLists.txt
libcxxabi/trunk/test/lit.site.cfg.in
Modified: libcxxa
EricWF created this revision.
EricWF added reviewers: mclow.lists, danalbert, compnerd, majnemer.
EricWF added a subscriber: cfe-commits.
In 32 bit builds the __cxa_exception class has an alignment requirement greater
than the maximal alignment supported by malloc. If this is the case we need to
Author: yrnkrn
Date: Mon Aug 31 20:29:13 2015
New Revision: 246520
URL: http://llvm.org/viewvc/llvm-project?rev=246520&view=rev
Log:
Fix path seperator for Windows.
Modified:
cfe/trunk/test/Driver/solaris-ld.c
Modified: cfe/trunk/test/Driver/solaris-ld.c
URL:
http://llvm.org/viewvc/llvm-pr
Looks like something that should be in the bitcode, no? What happens if one
compile unit has it and another one doesn't?
On Aug 31, 2015 8:50 PM, "Akira Hatanaka via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> ahatanak created this revision.
> ahatanak added reviewers: echristo, dexonsmith
rafael added a subscriber: rafael.
rafael added a comment.
Looks like something that should be in the bitcode, no? What happens if one
compile unit has it and another one doesn't?
http://reviews.llvm.org/D12511
___
cfe-commits mailing list
cfe-commi
Author: rsmith
Date: Mon Aug 31 20:37:34 2015
New Revision: 246521
URL: http://llvm.org/viewvc/llvm-project?rev=246521&view=rev
Log:
[modules] Preserve DeclID order when merging lookup tables to give a more
predictable diagnostic experience. The hash-of-DeclID order we were using
before gave diffe
majnemer added a comment.
Wouldn't this change be problematic if you threw to code which was statically
linked with a prior version of libcxxabi?
http://reviews.llvm.org/D12512
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Author: majnemer
Date: Mon Aug 31 20:53:07 2015
New Revision: 246523
URL: http://llvm.org/viewvc/llvm-project?rev=246523&view=rev
Log:
[MS ABI] Cleanup get*ForUnnamedTagDecl
Use "lookup" instead of operator[], it will not perform unnecessary
insertions. No functionality change is intended.
Modi
EricWF added a comment.
In http://reviews.llvm.org/D12512#236984, @majnemer wrote:
> Wouldn't this change be problematic if you threw to code which was statically
> linked with a prior version of libcxxabi?
How do you mean? As in you have two different versions of libc++abi linked into
one ex
Author: rsmith
Date: Mon Aug 31 21:02:09 2015
New Revision: 246524
URL: http://llvm.org/viewvc/llvm-project?rev=246524&view=rev
Log:
Use a more appropriate way of writing 1.
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
Modified: cfe/trunk/lib/Serialization/ASTReader.cpp
URL:
http://l
majnemer added a comment.
In http://reviews.llvm.org/D12512#236987, @EricWF wrote:
> In http://reviews.llvm.org/D12512#236984, @majnemer wrote:
>
> > Wouldn't this change be problematic if you threw to code which was
> > statically linked with a prior version of libcxxabi?
>
>
> How do you mean?
EricWF added a comment.
In http://reviews.llvm.org/D12512#236988, @majnemer wrote:
> In http://reviews.llvm.org/D12512#236987, @EricWF wrote:
>
> > In http://reviews.llvm.org/D12512#236984, @majnemer wrote:
> >
> > > Wouldn't this change be problematic if you threw to code which was
> > > static
compnerd added a comment.
While I can see the argument you raise, the saving grace here is that this is
buried in libc++abi. The only real piece of libc++abi of real use to users is
`__cxa_demangle` (which is only relevant for Windows, and Darwin where you have
two level namespaces). For ever
Author: rsmith
Date: Mon Aug 31 21:35:58 2015
New Revision: 246526
URL: http://llvm.org/viewvc/llvm-project?rev=246526&view=rev
Log:
Don't use fprintf to emit this diagnostic!
Added:
cfe/trunk/test/PCH/datetime.c
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
ahatanak added a comment.
If it's important to be able to compile one file with
-fno-zero-initialized-in-bss and another without the option, we could add a bit
to GlobalVariable that indicates it shouldn't be go into the bss section. Is
that what you are suggesting?
If we are going to take tha
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:479
@@ +478,3 @@
+ /// that may occur. The intent of this mode is to determine an LValue's
+ /// Offset, so things not ordinarily allowed in constexprs
+ /// (reinterpret_casts, OOB array indices, et
On 31 August 2015 at 22:45, Akira Hatanaka wrote:
> ahatanak added a comment.
>
> If it's important to be able to compile one file with
> -fno-zero-initialized-in-bss and another without the option, we could add a
> bit to GlobalVariable that indicates it shouldn't be go into the bss section.
>
Author: compnerd
Date: Mon Aug 31 23:29:03 2015
New Revision: 246528
URL: http://llvm.org/viewvc/llvm-project?rev=246528&view=rev
Log:
unwind: cleanup -Wunused-parameter
Cleanup a number of `-Wunused-parameter` warnings. NFC.
Modified:
libunwind/trunk/src/Registers.hpp
Modified: libunwind/
kastiglione updated this revision to Diff 33665.
kastiglione added a comment.
Add test case for numSelectorArgs(0)
http://reviews.llvm.org/D12471
Files:
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittests/ASTMatchers/ASTMatchersTest.cpp
==
kastiglione marked 2 inline comments as done.
kastiglione added a comment.
http://reviews.llvm.org/D12471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krememek added a comment.
In http://reviews.llvm.org/D12358#235142, @seaneveson wrote:
> If I refactor this patch in its current state into a separate file and put it
> behind a flag, would it then be acceptable? I would then like to take some
> time to look at the invalidation improvements as
101 - 132 of 132 matches
Mail list logo
