[libunwind] r246143 - [libunwind] Remove unused includes.

Author: whitequark Date: Thu Aug 27 01:58:31 2015 New Revision: 246143 URL: http://llvm.org/viewvc/llvm-project?rev=246143&view=rev Log: [libunwind] Remove unused includes. Modified: libunwind/trunk/src/DwarfParser.hpp libunwind/trunk/src/Registers.hpp libunwind/trunk/src/libunwind.cp

Re: [PATCH] D12366: Avoid unnecessarily storing vtable pointers in more destructor cases

scott-0 added a comment. Thanks for the review and advice; I'll give `undef` a try. It's a much simpler approach. http://reviews.llvm.org/D12366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D12400: Fix store detection for return value in CGCall

kuhar created this revision. kuhar added a subscriber: cfe-commits. kuhar set the repository for this revision to rL LLVM. Herald added subscribers: srhines, danalbert, tberghammer. `findDominatingStoreToReturn` in CGCall.cpp didn't check if a candidate store instruction used the ReturnValue as p

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

danielmarjamaki updated this revision to Diff 33307. danielmarjamaki added a comment. Thanks! I fixed that FP. http://reviews.llvm.org/D12359 Files: include/clang/AST/DeclBase.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Parse/Parser

[PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

andreybokhanko created this revision. andreybokhanko added a reviewer: rnk. andreybokhanko added a subscriber: cfe-commits. As described in PR24595, clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode. This patch fixes this. More on vswriter.h is here: https://msdn.m

Re: [PATCH] D12163: [Patch] [Analyzer] BugReporter.cpp:2869: Assertion failed: !RemainingNodes.empty() && "No error node found in the trimmed graph" (PR 24184)

MaggieYi added a comment. Ping http://reviews.llvm.org/D12163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12401: Handling i686 architecture in makefiles for clang.

nishanth-kottary created this revision. nishanth-kottary added reviewers: samsonov, loladiro. nishanth-kottary added a subscriber: cfe-commits. nishanth-kottary set the repository for this revision to rL LLVM. This is a part of D12316. Added i686 names for 32bit runtime configs so that built file

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

danielmarjamaki added a comment. I saw a FP when I looked through the logs today... Example code: void dostuff(int *); void f(int *p) { #ifdef X dostuff(p); #endif if (*p == 0) {} } As far as I know there is nothing I can do about this in the checker. A user could f

r246146 - clang-format: Don't let a leading "template <..>" lead to wrapped initializers.

Author: djasper Date: Thu Aug 27 06:59:31 2015 New Revision: 246146 URL: http://llvm.org/viewvc/llvm-project?rev=246146&view=rev Log: clang-format: Don't let a leading "template <..>" lead to wrapped initializers. Before: Constructor() : initializer(0) {} template Constructor() : in

Re: [PATCH] D11297: PR17829: Functions declared extern "C" with a name matching a mangled C++ function are allowed

andreybokhanko updated this revision to Diff 33316. andreybokhanko added a comment. All (but one) of John McCall's comments fixed. http://reviews.llvm.org/D11297 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CGCXX.cpp lib/CodeGen/C

[PATCH] D12405: [clang-format-vs] Format the whole document if nothing is selected

berenm created this revision. berenm added a reviewer: djasper. berenm added a subscriber: cfe-commits. By default, clang-format VS plugin only reformats the selected code. To reformat the whole document, the user has to select everything before calling the reformat shortcut. http://reviews.ll

Re: [PATCH] D12375: [PATCH] Relax parse ordering rules for attributes

aaron.ballman updated this revision to Diff 33318. aaron.ballman added a comment. I've updated the patch to disallow reordering of C++11 attributes with relation to other attribute syntaxes. Additionally, if there is a reordering issue found, we now warn the user. http://reviews.llvm.org/D1237

Re: [PATCH] D11297: PR17829: Functions declared extern "C" with a name matching a mangled C++ function are allowed

andreybokhanko marked 3 inline comments as done. andreybokhanko added a comment. John, Thank you for the review! All your comments but one are fixed. See below for details on the single one I didn't manage to get fixed. Andrey Comment at: lib/CodeGen/CodeGenModule.h:354 @@ +

Re: [PATCH] D12405: [clang-format-vs] Format the whole document if nothing is selected

If nothing is selected, clang-format should format the current line.. At least that's the intended behavior. Doesn't it do that? On Aug 27, 2015 3:21 PM, "Beren Minor" wrote: > berenm created this revision. > berenm added a reviewer: djasper. > berenm added a subscriber: cfe-commits. > > By defau

Re: [PATCH] D12405: [clang-format-vs] Format the whole document if nothing is selected

On Thu, Aug 27, 2015 at 9:34 AM, Daniel Jasper via cfe-commits wrote: > If nothing is selected, clang-format should format the current line.. At > least that's the intended behavior. Doesn't it do that? It currently reformats the current line (possibly extended if the expression spans multiple li

Re: [PATCH] D12405: [clang-format-vs] Format the whole document if nothing is selected

Alright, my bad. It does indeed. I was trying to add a "Reformat all on save" feature in the plugin, and after struggling with VSSDK I thought this would be an easy first step. -- Beren Minor On Thu, Aug 27, 2015 at 3:36 PM, Aaron Ballman wrote: > On Thu, Aug 27, 2015 at 9:34 AM, Daniel Jasper

Re: [PATCH] D12405: [clang-format-vs] Format the whole document if nothing is selected

I see.. I think we'll want to keep the current behavior there.. On Aug 27, 2015 3:38 PM, "Beren Minor" wrote: > Alright, my bad. It does indeed. > > I was trying to add a "Reformat all on save" feature in the plugin, and > after struggling with VSSDK I thought this would be an easy first step. >

Re: [PATCH] D12368: Add a clang release note about raising the minimum Windows version for the next major release

gbedwell added a comment. In http://reviews.llvm.org/D12368#233680, @hans wrote: > Committed in r246090. Thanks! Repository: rL LLVM http://reviews.llvm.org/D12368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D12406: [Analyzer] Add -analyzer-config option for function size the inliner considers as large

seaneveson created this revision. seaneveson added a subscriber: cfe-commits. Dear All, I would like to propose a small patch to add an option (-analyzer-config min-blocks-for-inline-large=14) to control the function size the inliner considers as large, in relation to "max-times-inline-large".

[libcxx] r246150 - Remove a switch statement, and replace with a bunch of ifs to silence a warning about 'all the enumeration values covered'. No functional change.

Author: marshall Date: Thu Aug 27 09:37:22 2015 New Revision: 246150 URL: http://llvm.org/viewvc/llvm-project?rev=246150&view=rev Log: Remove a switch statement, and replace with a bunch of ifs to silence a warning about 'all the enumeration values covered'. No functional change. Modified: l

Re: [PATCH] D12355: [libcxx] Optimize away unneeded length calculation in basic_string::compare(const char*)

mclow.lists added inline comments. Comment at: include/string:3801 @@ -3799,1 +3800,3 @@ +if (__lhs_len != __rhs.size()) return false; +return _Traits::compare(__rhs.data(), __lhs, _VSTD::min(__lhs_len, __rhs.size())) == 0; } If the lengths are the same

Re: [PATCH] D11832: [Patch] [Analyzer] false positive: Potential leak connected with memcpy (PR 22954)

pgousseau updated this revision to Diff 33326. pgousseau added a comment. Following Devin's review: Modified 'IsFirstBufInBound()' to return a bool instead of a state. Removed redundant checks in 'IsFirstBufInBound'. Added tests to exercise 'IsFirstBufInBound' more. Removed if/else to avoid inden

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

jroelofs added a comment. @blastrock have you committed this yet? http://reviews.llvm.org/D9639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r246150 - Remove a switch statement, and replace with a bunch of ifs to silence a warning about 'all the enumeration values covered'. No functional change.

On Aug 27, 2015 7:38 AM, "Marshall Clow via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > > Author: marshall > Date: Thu Aug 27 09:37:22 2015 > New Revision: 246150 > > URL: http://llvm.org/viewvc/llvm-project?rev=246150&view=rev > Log: > Remove a switch statement, and replace with a bunch of

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

seaneveson added a comment. In http://reviews.llvm.org/D12358#233983, @zaks.anna wrote: > This will leave us in a state that is wrong and will likely lead to false > positives and inconsistencies, avoiding which is extremely important. I accept that my current patch is not a comprehensive solu

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

djasper added a comment. I know nothing of Visual Studio, so I have added better reviewers. http://reviews.llvm.org/D12407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

rnk added a comment. MSVC appears to ignore __stdcall on virtual destructors, and I think the correct fix is for us to do the same. See this test case: $ cat t.cpp struct A { virtual __stdcall ~A(); }; A::~A() {} $ cl -c t.cpp Microsoft (R) C/C++ Optimizing Compiler Version 18.00.3110

Re: [PATCH] D12278: [X86] Add MSVC-compatible intrinsics for clac, stac, lgdt and sgdt

rnk added inline comments. Comment at: lib/Headers/Intrin.h:961 @@ +960,3 @@ +static __inline__ void __DEFAULT_FN_ATTRS _lgdt(void *__ptr) { + __builtin_ia32_lgdt(__ptr); +} compnerd wrote: > mkuper wrote: > > compnerd wrote: > > > Why does this need a builtin?

Re: [PATCH] D11433: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference events.

xazax.hun updated this revision to Diff 5. xazax.hun added a comment. - Updated to latest trunk. - Added a new field to the event with documentation. - Rebased the patch on the top of nullability checker. - Added covered cases to the nullability checker tests. http://reviews.llvm.org/D11433

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

> On Aug 27, 2015, at 8:57 AM, Sean Eveson wrote: > > I accept that my current patch is not a comprehensive solution to the problem > and that it may introduce false positives, however I do think it is an > improvement, where it is preferable to have false positives over doing no > analysi

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

blastrock added a comment. Sorry, I'm not sure I got what is the workflow on this platform. This patch is now "accepted", but do I need to do something else here? The only relevant action I can do seems to be "close revision", should I do that? The developper policy page

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

jroelofs added a comment. Ah, usually the process is that you get your patch through review, and when someone accepts it, then you can commit it. If you do not have commit rights, then you can get someone else to commit it for you. Accepted => "ok to commit" Closed => "I've committed it" Do yo

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

blastrock added a comment. Oh I see! Indeed, I don't have commit rights, so I would help me if you could do it :) http://reviews.llvm.org/D9639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: r245779 - [modules] Rearrange how redeclaration chains are loaded, to remove a walk over

Richard Smith via cfe-commits writes: > Author: rsmith > Date: Fri Aug 21 20:47:18 2015 > New Revision: 245779 > > URL: http://llvm.org/viewvc/llvm-project?rev=245779&view=rev > Log: > [modules] Rearrange how redeclaration chains are loaded, to remove a walk over > all modules and reduce the numbe

[libcxx] r246168 - Do not include pthread.h and sched.h when threads are disabled

Author: jroelofs Date: Thu Aug 27 12:47:34 2015 New Revision: 246168 URL: http://llvm.org/viewvc/llvm-project?rev=246168&view=rev Log: Do not include pthread.h and sched.h when threads are disabled Patch by Philippe Daouadi! http://reviews.llvm.org/D9639 Modified: libcxx/trunk/include/__mut

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

jroelofs accepted this revision. jroelofs added a comment. r246168 http://reviews.llvm.org/D9639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r246169 - [clang-tidy] Update docs for clang-tidy checks. NFC

Author: alexfh Date: Thu Aug 27 13:01:58 2015 New Revision: 246169 URL: http://llvm.org/viewvc/llvm-project?rev=246169&view=rev Log: [clang-tidy] Update docs for clang-tidy checks. NFC Changes mostly address formatting and unification of the style. Use MarkDown style for inline code snippets and

[clang-tools-extra] r246170 - [clang-tidy] Renamed a test file to .cpp.

Author: alexfh Date: Thu Aug 27 13:03:37 2015 New Revision: 246170 URL: http://llvm.org/viewvc/llvm-project?rev=246170&view=rev Log: [clang-tidy] Renamed a test file to .cpp. Added: clang-tools-extra/trunk/test/clang-tidy/misc-argument-comment.cpp - copied unchanged from r245699, clang

[clang-tools-extra] r246173 - [clang-tidy] Move clang-tidy docs to a separate directory. Create doc files for checks

Author: alexfh Date: Thu Aug 27 13:10:07 2015 New Revision: 246173 URL: http://llvm.org/viewvc/llvm-project?rev=246173&view=rev Log: [clang-tidy] Move clang-tidy docs to a separate directory. Create doc files for checks The doc files for checks have been generated from the corresponding header f

r246174 - [CUDA] Improve CUDA compilation pipeline creation.

Author: tra Date: Thu Aug 27 13:10:41 2015 New Revision: 246174 URL: http://llvm.org/viewvc/llvm-project?rev=246174&view=rev Log: [CUDA] Improve CUDA compilation pipeline creation. Current implementation tries to guess which Action will result in a job which needs to incorporate device-side GPU b

Re: [PATCH] D11280: [CUDA] Improve CUDA compilation pipeline creation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL246174: [CUDA] Improve CUDA compilation pipeline creation. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D11280?vs=29947&id=33341#toc Repository: rL LLVM http://reviews.llvm.or

Re: [PATCH] D12134: Improve debug info for implicitly captured vars in lambdas

On Tue, Aug 25, 2015 at 10:50 AM, Bataev, Alexey wrote: > Guys, talking about implicitly captured variables we have to deal with 2 > locations: 1) point of real capturing (it is the point of '=' or '&' > symbols in lambda capture-list); I'm not sure that's "the point of real capturing" if it's

Re: [PATCH] D11297: PR17829: Functions declared extern "C" with a name matching a mangled C++ function are allowed

rjmccall added inline comments. Comment at: lib/CodeGen/CodeGenModule.h:354 @@ +353,3 @@ + /// call). + llvm::DenseSet ExplicitDefinitions; + andreybokhanko wrote: > Checking that a GlobalDecl is not in ExplicitDefinitions yet is actually > required to avoid pr

Re: [PATCH] D12389: Conditionalize X86 Darwin MaxVectorAlign on the presence of AVX.

rjmccall added a comment. Okay, and you're doing the avx512 part of this in a separate commit? LGTM. http://reviews.llvm.org/D12389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

blastrock added a comment. Thank you! http://reviews.llvm.org/D9639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11433: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference events.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thanks! http://reviews.llvm.org/D11433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

r246180 - const-ify TargetInfo::handleUserFeatures.

Author: echristo Date: Thu Aug 27 13:42:57 2015 New Revision: 246180 URL: http://llvm.org/viewvc/llvm-project?rev=246180&view=rev Log: const-ify TargetInfo::handleUserFeatures. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/includ

Re: [PATCH] D12390: Also enable the avx/avx512 ABIs for i386, not just x86_64.

rjmccall added a comment. This gives no-MMX priority over turning on SSE, which sounds like a major change in behavior to me. There are definitely clients that specifically never want to use MMX but do care deeply about SSE; my understanding is that modern microarchitectures heavily punish cas

Re: [PATCH] D11433: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference events.

This revision was automatically updated to reflect the committed changes. Closed by commit rL246182: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference… (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D11433?vs=5&id=33344#toc Repository: rL LL

r246183 - [Tests] Modified Lit Tests to be C++11 compatibile

Author: lcharles Date: Thu Aug 27 13:49:15 2015 New Revision: 246183 URL: http://llvm.org/viewvc/llvm-project?rev=246183&view=rev Log: [Tests] Modified Lit Tests to be C++11 compatibile This 2nd patch should not change the test results, but it is useful if clang's default C++ language is ever cha

r246182 - [Static Analyzer] Make NonNullParamChecker emit implicit null dereference events.

Author: xazax Date: Thu Aug 27 13:49:07 2015 New Revision: 246182 URL: http://llvm.org/viewvc/llvm-project?rev=246182&view=rev Log: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference events. Differential Revision: http://reviews.llvm.org/D11433 Modified: cfe/trunk/inc

r246188 - [Static Analyzer] BugReporter.cpp:2869: Assertion failed: !RemainingNodes.empty() && "No error node found in the trimmed graph"

Author: xazax Date: Thu Aug 27 13:57:00 2015 New Revision: 246188 URL: http://llvm.org/viewvc/llvm-project?rev=246188&view=rev Log: [Static Analyzer] BugReporter.cpp:2869: Assertion failed: !RemainingNodes.empty() && "No error node found in the trimmed graph" The assertion is caused by reusing a

r246189 - Improve options printed on vectorization analysis diagnostics.

Author: tnowicki Date: Thu Aug 27 13:58:34 2015 New Revision: 246189 URL: http://llvm.org/viewvc/llvm-project?rev=246189&view=rev Log: Improve options printed on vectorization analysis diagnostics. The LLVM patch changes the analysis diagnostics produced when loops with floating-poin

Re: [PATCH] D12163: [Patch] [Analyzer] BugReporter.cpp:2869: Assertion failed: !RemainingNodes.empty() && "No error node found in the trimmed graph" (PR 24184)

xazax.hun added a subscriber: xazax.hun. xazax.hun closed this revision. xazax.hun added a comment. Committed in http://reviews.llvm.org/rL246188. Thanks for the patch. http://reviews.llvm.org/D12163 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D12411: [PATCH] Expose AST language options to checkers

aaron.ballman created this revision. aaron.ballman added reviewers: alexfh, djasper. aaron.ballman added a subscriber: cfe-commits. Some of the checkers need to know what language options are enabled in order to behave sensibly. For instance, the modernize-use-nullptr checker should not suggest

r246192 - Add a -gmodules option to the driver and a -dwarf-ext-refs to cc1

Author: adrian Date: Thu Aug 27 14:46:20 2015 New Revision: 246192 URL: http://llvm.org/viewvc/llvm-project?rev=246192&view=rev Log: Add a -gmodules option to the driver and a -dwarf-ext-refs to cc1 to enable the use of external type references in the debug info (a.k.a. module debugging). The dri

Re: [PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

hfinkel added a comment. I also like this intrinsic approach better than the type attribute. The fact that it does not work with builtin vector types, however, is quite unfortunate. Plus, I don't understand why you're implementing another place in CodeGen that generates IR to load and store sca

[PATCH] D12412: [CodeGen] Point empty %invoke.cont block to successor

vsk created this revision. vsk added reviewers: ygao, rsmith. vsk added a subscriber: cfe-commits. When partially initializing a global, exception-handling code in the frontend emits a placeholder `%invoke.cont` block with no terminator. This commit adds a suitable BranchInst to the block to pre

Re: [PATCH] D11950: [CUDA] Check register names on appropriate side of cuda compilation only.

This revision was automatically updated to reflect the committed changes. Closed by commit rL246193: [CUDA] Check register names on appropriate side of cuda compilation only. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D11950?vs=32611&id=33348#toc Repository: rL LLVM

r246193 - [CUDA] Check register names on appropriate side of cuda compilation only.

Author: tra Date: Thu Aug 27 14:54:21 2015 New Revision: 246193 URL: http://llvm.org/viewvc/llvm-project?rev=246193&view=rev Log: [CUDA] Check register names on appropriate side of cuda compilation only. Differential Revision: http://reviews.llvm.org/D11950 Modified: cfe/trunk/lib/Sema/SemaD

r246195 - Rewrite the code generation handling for function feature and cpu attributes.

Author: echristo Date: Thu Aug 27 14:59:34 2015 New Revision: 246195 URL: http://llvm.org/viewvc/llvm-project?rev=246195&view=rev Log: Rewrite the code generation handling for function feature and cpu attributes. A couple of changes here: a) Do less work in the case where we don't have a target

Re: [PATCH] D12385: Generating Assumption loads fix

Prazek marked an inline comment as done. Prazek added a comment. http://reviews.llvm.org/D12385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12390: Also enable the avx/avx512 ABIs for i386, not just x86_64.

ab added a comment. Unless I'm misunderstanding, I believe this has much less impact than you're thinking; there are three cases: - x86_64: no change (-mno-mmx is guarded by x86) - x86, with -mno-mmx: no change (because previously, we'd only set avx/avx512 for x86_64) - x86, without -mno-mmx: t

Re: [PATCH] D12389: Conditionalize X86 Darwin MaxVectorAlign on the presence of AVX.

ab accepted this revision. ab added a reviewer: ab. ab added a comment. This revision is now accepted and ready to land. Yep, thanks! http://reviews.llvm.org/D12389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

r246197 - Target attribute syntax compatibility fix - gcc uses no- rather than mno-.

Author: echristo Date: Thu Aug 27 15:05:48 2015 New Revision: 246197 URL: http://llvm.org/viewvc/llvm-project?rev=246197&view=rev Log: Target attribute syntax compatibility fix - gcc uses no- rather than mno-. Modified: cfe/trunk/lib/CodeGen/CGCall.cpp cfe/trunk/test/CodeGen/attr-target-p

r246196 - Rename this file to have a processor suffix to help identify.

Author: echristo Date: Thu Aug 27 15:05:46 2015 New Revision: 246196 URL: http://llvm.org/viewvc/llvm-project?rev=246196&view=rev Log: Rename this file to have a processor suffix to help identify. Added: cfe/trunk/test/CodeGen/attr-target-x86.c - copied, changed from r246195, cfe/trunk/

Re: [PATCH] D12163: [Patch] [Analyzer] BugReporter.cpp:2869: Assertion failed: !RemainingNodes.empty() && "No error node found in the trimmed graph" (PR 24184)

MaggieYi added a comment. Thanks for helping me review and submit the patch. http://reviews.llvm.org/D12163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12401: Handling i686 architecture in makefiles for clang.

samsonov added a comment. See my comment in a different CL - I would strongly prefer to not touch autoconf build system unless absolutely necessary. Repository: rL LLVM http://reviews.llvm.org/D12401 ___ cfe-commits mailing list cfe-commits@list

Re: r246027 - Convert a bunch of loops to ranged-for and clean up accordingly.

Eric Christopher via cfe-commits writes: > Author: echristo > Date: Wed Aug 26 03:21:55 2015 > New Revision: 246027 > > URL: http://llvm.org/viewvc/llvm-project?rev=246027&view=rev > Log: > Convert a bunch of loops to ranged-for and clean up accordingly. > > Modified: > cfe/trunk/lib/Basic/Tar

Re: r246027 - Convert a bunch of loops to ranged-for and clean up accordingly.

> > > > -assert(Features[i][0] == '+' && "Invalid target feature!"); > > +assert(Feature[0] == '+' && "Invalid target feature!"); > > This assert is kind of pointless now, since we'll have continued in that > case and the following code will DTRT anyway. > > Was fairly pointless to begin wi

r246200 - [X86] Add __builtin_ia32_undef* intrinsics to test

Author: rksimon Date: Thu Aug 27 15:29:13 2015 New Revision: 246200 URL: http://llvm.org/viewvc/llvm-project?rev=246200&view=rev Log: [X86] Add __builtin_ia32_undef* intrinsics to test Minor tweak to rL246083 Modified: cfe/trunk/test/CodeGen/builtins-x86.c Modified: cfe/trunk/test/CodeGen/b

r246202 - Remove a dead assert, we'd have gotten the case above.

Author: echristo Date: Thu Aug 27 15:32:24 2015 New Revision: 246202 URL: http://llvm.org/viewvc/llvm-project?rev=246202&view=rev Log: Remove a dead assert, we'd have gotten the case above. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL: http://llvm.

Re: r246027 - Convert a bunch of loops to ranged-for and clean up accordingly.

On Thu, Aug 27, 2015 at 1:29 PM Eric Christopher wrote: > >> > -assert(Features[i][0] == '+' && "Invalid target feature!"); >> > +assert(Feature[0] == '+' && "Invalid target feature!"); >> >> This assert is kind of pointless now, since we'll have continued in that >> case and the followin

r246204 - [X86][F16C] Added debug codegen test for F16C intrinsics

Author: rksimon Date: Thu Aug 27 15:34:02 2015 New Revision: 246204 URL: http://llvm.org/viewvc/llvm-project?rev=246204&view=rev Log: [X86][F16C] Added debug codegen test for F16C intrinsics Part of PR24590 Modified: cfe/trunk/test/CodeGen/f16c-builtins.c Modified: cfe/trunk/test/CodeGen/f1

r246206 - [X86][FMA4] Added debug codegen test for FMA4 intrinsics

Author: rksimon Date: Thu Aug 27 15:41:45 2015 New Revision: 246206 URL: http://llvm.org/viewvc/llvm-project?rev=246206&view=rev Log: [X86][FMA4] Added debug codegen test for FMA4 intrinsics Part of PR24590 Modified: cfe/trunk/test/CodeGen/fma4-builtins.c Modified: cfe/trunk/test/CodeGen/fm

Re: [PATCH] D12390: Also enable the avx/avx512 ABIs for i386, not just x86_64.

rjmccall added a comment. In http://reviews.llvm.org/D12390#234458, @ab wrote: > Unless I'm misunderstanding, I believe this has much less impact than you're > thinking; there are three cases: > > - x86_64: no change (-mno-mmx is guarded by x86) > - x86, with -mno-mmx: no change (because previou

Re: [PATCH] D12411: [PATCH] Expose AST language options to checkers

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good .Thanks for fixing this! BTW, there are other checks that use LangOpts in the check() method. IIRC, misc-use-override, google-readabiity-casting and maybe something else. We need t

[clang-tools-extra] r246209 - Expose language options to the checkers; disable UseNullptrCheck when not compiling in C++11 mode.

Author: aaronballman Date: Thu Aug 27 16:17:47 2015 New Revision: 246209 URL: http://llvm.org/viewvc/llvm-project?rev=246209&view=rev Log: Expose language options to the checkers; disable UseNullptrCheck when not compiling in C++11 mode. Added: clang-tools-extra/trunk/test/clang-tidy/moderni

Re: [PATCH] D12411: [PATCH] Expose AST language options to checkers

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r246209. I plan to do a more thorough search of clang-tidy to see what else can make use of this feature, this just happened to be low-hanging fruit that I found today by accident. ~Aaron http://reviews

r246210 - CGDebugInfo: Factor out a getOrCreateStandaloneType() method.

Author: adrian Date: Thu Aug 27 16:21:19 2015 New Revision: 246210 URL: http://llvm.org/viewvc/llvm-project?rev=246210&view=rev Log: CGDebugInfo: Factor out a getOrCreateStandaloneType() method. Usually debug info is created on the fly while during codegen. With this API it becomes possible to cr

Re: r246210 - CGDebugInfo: Factor out a getOrCreateStandaloneType() method.

On Thu, Aug 27, 2015 at 2:21 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Thu Aug 27 16:21:19 2015 > New Revision: 246210 > > URL: http://llvm.org/viewvc/llvm-project?rev=246210&view=rev > Log: > CGDebugInfo: Factor out a getOrCreateStandaloneType

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

EricWF added a comment. So this patch LGTM. Sorry for being slow to understand it. However I want to see two things before it lands. 1. I would like to see a test of some sort that the resulting type has the same size and alignment requirements it did before the change. I'm not sure what the b

r246211 - [X86][XOP] Added debug codegen test for XOP intrinsics

Author: rksimon Date: Thu Aug 27 16:32:03 2015 New Revision: 246211 URL: http://llvm.org/viewvc/llvm-project?rev=246211&view=rev Log: [X86][XOP] Added debug codegen test for XOP intrinsics Part of PR24590 Modified: cfe/trunk/test/CodeGen/xop-builtins.c Modified: cfe/trunk/test/CodeGen/xop-b

Re: [PATCH] D12375: [PATCH] Relax parse ordering rules for attributes

rsmith added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:3923 @@ +3922,3 @@ + +void Parser::MaybeParseAttributes(unsigned WhichAttrKinds, + ParsedAttributesWithRange &Attrs, Please provide an inlineable wrapper for this

Re: r246210 - CGDebugInfo: Factor out a getOrCreateStandaloneType() method.

> On Aug 27, 2015, at 2:25 PM, David Blaikie wrote: > > > > On Thu, Aug 27, 2015 at 2:21 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Thu Aug 27 16:21:19 2015 > New Revision: 246210 > > URL: http://llvm.org/viewvc/llvm-project?rev=24

r246213 - Generating assumption loads of vptr after ctor call (fixed)

Author: prazek Date: Thu Aug 27 16:35:37 2015 New Revision: 246213 URL: http://llvm.org/viewvc/llvm-project?rev=246213&view=rev Log: Generating assumption loads of vptr after ctor call (fixed) Generating call assume(icmp %vtable, %global_vtable) after constructor call for devirtualization purpose

r246214 - Assume loads fix #2

Author: prazek Date: Thu Aug 27 16:35:41 2015 New Revision: 246214 URL: http://llvm.org/viewvc/llvm-project?rev=246214&view=rev Log: Assume loads fix #2 There was linker problem, and it turns out that it is not always safe to refer to vtable. If the vtable is used, then we can refer to it without

Re: r245779 - [modules] Rearrange how redeclaration chains are loaded, to remove a walk over

On Thu, Aug 27, 2015 at 10:47 AM, Justin Bogner wrote: > Richard Smith via cfe-commits writes: > > Author: rsmith > > Date: Fri Aug 21 20:47:18 2015 > > New Revision: 245779 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=245779&view=rev > > Log: > > [modules] Rearrange how redeclaration ch

r246215 - Don't call a member function on a null pointer.

Author: rsmith Date: Thu Aug 27 16:38:25 2015 New Revision: 246215 URL: http://llvm.org/viewvc/llvm-project?rev=246215&view=rev Log: Don't call a member function on a null pointer. Modified: cfe/trunk/lib/Serialization/ASTWriterDecl.cpp Modified: cfe/trunk/lib/Serialization/ASTWriterDecl.cpp

Re: r245779 - [modules] Rearrange how redeclaration chains are loaded, to remove a walk over

On Sat, Aug 22, 2015 at 1:16 AM, Vassil Vassilev wrote: > On 22/08/15 03:47, Richard Smith via cfe-commits wrote: > >> Author: rsmith >> Date: Fri Aug 21 20:47:18 2015 >> New Revision: 245779 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=245779&view=rev >> Log: >> [modules] Rearrange how red

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. Thanks for doing all of this work. It's really appreciated. First, I don't really think we should have the notion of a "minor" ABI version. It will be hard enough to maintain 2 major versions and I don't understand what a minor ABI version buys us. In my opinion libc++

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. In http://reviews.llvm.org/D11740#234552, @EricWF wrote: > Thanks for doing all of this work. It's really appreciated. > > First, I don't really think we should have the notion of a "minor" ABI > version. It will be hard enough to maintain 2 major versions and I don't >

Re: [PATCH] D12312: Emiting invariant.group.barrier and adding -fstrict-vptrs

Prazek added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1279 @@ +1278,3 @@ + if (CGM.getCodeGenOpts().StrictVPtrs && BaseVPtrsInitialized) +CXXThisValue = Builder.CreateInvariantGroupBarrier(LoadCXXThis()); + rjmccall wrote: > Should this just be in

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

yiranwang added a comment. In http://reviews.llvm.org/D12247#234533, @EricWF wrote: > So this patch LGTM. Sorry for being slow to understand it. However I want to > see two things before it lands. > > 1. I would like to see a test of some sort that the resulting type has the > same size and ali

Re: [PATCH] D11740: ABI versioning macros for libc++

eugenis added a comment. Yes, not being able to use headers in the libcxx source tree is quite unpleasant. It can be fixed by providing a __config_version in libcxx/include with the default version values. Or, in the approach of http://reviews.llvm.org/D11963, do something smart in __config to

Re: [PATCH] D12181: [sanitizer] Add -fsanitize-trap-function.

jmgao added a comment. Ping, I think @samsonov was waiting on @rsmith's feedback on the following: In http://reviews.llvm.org/D12181#229493, @jmgao wrote: > In http://reviews.llvm.org/D12181#229467, @rsmith wrote: > > > In http://reviews.llvm.org/D12181#229358, @rsmith wrote: > > > > > Can you p

Re: r246210 - CGDebugInfo: Factor out a getOrCreateStandaloneType() method.

On Thu, Aug 27, 2015 at 2:35 PM, Adrian Prantl wrote: > > On Aug 27, 2015, at 2:25 PM, David Blaikie wrote: > > > > On Thu, Aug 27, 2015 at 2:21 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: adrian >> Date: Thu Aug 27 16:21:19 2015 >> New Revision: 246210

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

On Thu, Aug 27, 2015 at 2:57 PM, Yiran Wang wrote: > yiranwang added a comment. > > In http://reviews.llvm.org/D12247#234533, @EricWF wrote: > >> So this patch LGTM. Sorry for being slow to understand it. However I want to >> see two things before it lands. >> >> 1. I would like to see a test of

Re: [PATCH] D11832: [Patch] [Analyzer] false positive: Potential leak connected with memcpy (PR 22954)

dcoughlin added a comment. Other than one teeny nit, looks good to me. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:863 @@ +862,3 @@ + + const ElementRegion *ER = dyn_cast(R); + // Cast is safe as BufVal's region is a FieldRegion. You can use cas

r246223 - [X86][3DNow] Added debug codegen test for 3DNow! intrinsics

Author: rksimon Date: Thu Aug 27 17:18:09 2015 New Revision: 246223 URL: http://llvm.org/viewvc/llvm-project?rev=246223&view=rev Log: [X86][3DNow] Added debug codegen test for 3DNow! intrinsics Part of PR24590 Modified: cfe/trunk/test/CodeGen/3dnow-builtins.c Modified: cfe/trunk/test/CodeGe

  1   2   >