eugenis added inline comments.
Comment at: lib/CodeGen/CGCXX.cpp:44
@@ +43,3 @@
+ // destructors.
+ const ASTRecordLayout &Layout = Context.getASTRecordLayout(D->getParent());
+
This is unused.
Comment at: lib/CodeGen/CGCXX.cpp:47
@@ +46,3 @@
+
Author: echristo
Date: Mon Aug 24 19:59:11 2015
New Revision: 245914
URL: http://llvm.org/viewvc/llvm-project?rev=245914&view=rev
Log:
Reimplement the PPC explicit option checking to be a bit more obvious
that we're looking for conflicting options and give an explanation.
Modified:
cfe/trunk/
sfantao created this revision.
sfantao added reviewers: ABataev, rjmccall, hfinkel.
sfantao added a subscriber: cfe-commits.
All the offloading information is bundled into a descriptor that is passed to
the runtime library so that it can extract all the binaries and map variables
properly. This
Author: ab
Date: Mon Aug 24 20:00:05 2015
New Revision: 245915
URL: http://llvm.org/viewvc/llvm-project?rev=245915&view=rev
Log:
[ARM NEON] Remove the old AArch64 vset_lane tests. NFC.
They are now properly tested, since r245901.
Removed:
cfe/trunk/test/CodeGen/arm64_vset_lane.c
Removed: cf
LGTM
On Mon, Aug 10, 2015 at 7:08 PM, Nick Lewycky via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> This simple-minded patch extends the case where we report "no viable
> conversion from 'X' to 'Y'" to emit a more useful diagnostic "no viable
> conversion from returned value of type 'X' to
zaks.anna added a comment.
Another partial review.
Thanks!
Anna.
Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:312
@@ +311,3 @@
+ CheckerContext &C) const {
+ auto RetExpr = S->getRetValue();
+ if (!RetExpr)
--
Author: ericwf
Date: Mon Aug 24 20:28:52 2015
New Revision: 245918
URL: http://llvm.org/viewvc/llvm-project?rev=245918&view=rev
Log:
Refactor and fix more flaky shared_mutex tests
Modified:
libcxx/trunk/test/std/thread/thread.mutex/thread.mutex.requirements/thread.sharedtimedmutex.requiremen
On Mon, Aug 24, 2015 at 5:50 PM, Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> echristo added inline comments.
>
>
> Comment at: include/clang/Driver/Options.td:1853
> @@ -1853,1 +1852,3 @@
> +def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, HelpText<"Use link
zaks.anna added a comment.
Gabor, there is a lot of the same steps that all callbacks go through. I think
refactoring those into subroutines will help with readability of the checker.
Looking forward to seeing a new version soon!
Anna.
Comment at: lib/StaticAnalyzer/Checkers/N
nmusgrave updated this revision to Diff 33037.
nmusgrave marked 4 inline comments as done.
nmusgrave added a comment.
- Simplify function invocations
http://reviews.llvm.org/D12022
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGenCXX/sanitize-
compnerd added a subscriber: compnerd.
Comment at: lib/Headers/Intrin.h:961
@@ +960,3 @@
+static __inline__ void __DEFAULT_FN_ATTRS _lgdt(void *__ptr) {
+ __builtin_ia32_lgdt(__ptr);
+}
Why does this need a builtin? Is an inline assembly block using lgdt
insuff
Prazek created this revision.
Prazek added reviewers: rsmith, rjmccall, majnemer, nlewycky.
Prazek added a subscriber: cfe-commits.
Keep in mind, that I will not push it untill I will update GVN for using
!invariant.group metadata
http://reviews.llvm.org/D12312
Files:
include/clang/Driver/Opt
Prazek added a comment.
@rsmith I wonder If we have to put invariant.group.barrier when we call regular
new expression
http://reviews.llvm.org/D12312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: ericwf
Date: Mon Aug 24 23:35:55 2015
New Revision: 245922
URL: http://llvm.org/viewvc/llvm-project?rev=245922&view=rev
Log:
Mark test as XFAIL with MSAN until D12311 gets committed
Modified:
libcxx/trunk/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.co
krememek added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:444-448
@@ +443,7 @@
+
+ SymbolRef
+ getSymbolFromStmt(const Stmt *S, const LocationContext *LCtx) const;
+
+ const MemRegion*
+ getRegionFromStmt(const Stmt *S, const L
krememek added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:444-448
@@ +443,7 @@
+
+ SymbolRef
+ getSymbolFromStmt(const Stmt *S, const LocationContext *LCtx) const;
+
+ const MemRegion*
+ getRegionFromStmt(const Stmt *S, const L
On Sun, Aug 23, 2015 at 8:33 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Sun Aug 23 22:33:22 2015
> New Revision: 245821
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245821&view=rev
> Log:
> [modules] Stop updating all identifiers when writin
mzolotukhin created this revision.
mzolotukhin added reviewers: rsmith, aaron.ballman, doug.gregor, t.p.northover,
ab, mcrosier, hfinkel, majnemer.
mzolotukhin added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
Currently clang provides no general way to generate nontemporal loa
echristo added a comment.
How about:
13. [apple,
14. banana,
15. cherry]{
16. printf("apple = %d\n",apple);
17. printf("banana = %d\n",banana);
18. printf("cherry = %d\n",cherry);
Should be 13, 14, 15 yes?
-eric
http://reviews.llvm.org/D12134
___
silvas added a subscriber: silvas.
silvas added a comment.
In http://reviews.llvm.org/D12271#231204, @rnk wrote:
> This looks good.
>
> As a larger issue, LLVM fast isel definitely won't pattern match this series
> of shifts and selects to rotl at -O0. There are some users who want
> branchless
mkuper added inline comments.
Comment at: lib/Headers/Intrin.h:961
@@ +960,3 @@
+static __inline__ void __DEFAULT_FN_ATTRS _lgdt(void *__ptr) {
+ __builtin_ia32_lgdt(__ptr);
+}
compnerd wrote:
> Why does this need a builtin? Is an inline assembly block using lgd
101 - 121 of 121 matches
Mail list logo
