rjmccall added a comment.
Mostly LGTM. Are you going to emit assumptions for vbptrs in a separate patch?
Comment at: lib/CodeGen/CGCXXABI.h:349-357
@@ -348,1 +348,11 @@
+ /// Checks if ABI requires extra virtual offset for vtable field.
+ virtual bool
+ isVirtualOffsetNeed
AlexDenisov added a subscriber: AlexDenisov.
AlexDenisov added a comment.
Why do you think it's a cruft? Seems it's a bit more verbose than it should be,
but what is missing in your test is inheritance, which is important.
P.S. I think the code for the initial test was just extracted from a real
majnemer added inline comments.
Comment at: test/CodeGenCXX/vtable-assume-load.cpp:40
@@ +39,3 @@
+// CHECK1: call void @llvm.assume(i1 %cmp.vtables)
+// CHECK1-LABLE: }
+
This check line looks misspelled.
http://reviews.llvm.org/D11859
__
Looks fixed now, thanks!
On Sat, Aug 15, 2015 at 8:41 AM, Alexander Kornienko wrote:
> ... or this may have been fixed by r245144. In any case, please check again
> and report if anything is still broken.
>
>
> On Sat, Aug 15, 2015 at 7:39 AM, Alexander Kornienko
> wrote:
>>
>> Sorry for not pos
> On 14 Aug 2015, at 19:10, Hans Wennborg wrote:
>
> On Fri, Aug 14, 2015 at 2:09 AM, John McCall wrote:
>>> On Aug 10, 2015, at 12:40 PM, Hans Wennborg wrote:
>>> On Fri, Aug 7, 2015 at 11:57 AM, Simon Pilgrim
>>> wrote:
On 06/08/2015 18:05, Hans Wennborg wrote:
>
> On Sun, Au
modocache added a comment.
> Why do you think it's a cruft? Seems it's a bit more verbose than it should be
The verbosity is the cruft, in my opinion. Why spend thirty lines of code to
demonstrate behavior that could be demonstrated in just five?
> but what is missing in your test is inheritan
modocache added a comment.
Cool, thanks @compnerd!
http://reviews.llvm.org/D11772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AlexDenisov added a comment.
s/which is important/which is might be important'/
;)
IMHO, the purpose of the test is not just prove that functionality is working
as expected, but also prevent from regression, I completely agree that this
test can be cleaned up a bit, but I'd cover at least two
Author: davide
Date: Sat Aug 15 10:23:14 2015
New Revision: 245162
URL: http://llvm.org/viewvc/llvm-project?rev=245162&view=rev
Log:
[Sema] Be consistent about diagnostic wording: always use "cannot".
Discussed with Richard Smith.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.t
RKSimon created this revision.
RKSimon added reviewers: craig.topper, echristo, mkuper.
RKSimon added a subscriber: cfe-commits.
RKSimon set the repository for this revision to rL LLVM.
Adds missing SSE/AVX 'undefined' intrinsics (PR24040):
_mm_undefined_pd + _mm256_undefined_pd
_mm_undefined_ps
kimgr added inline comments.
Comment at: lib/Driver/Tools.cpp:398
@@ +397,3 @@
+ FoundPTH = !UsePCH;
+}
+ }
kimgr wrote:
> kimgr wrote:
> > kimgr wrote:
> > > Add a `break;` here so we don't continue searching after a valid path h
hfinkel added a subscriber: hfinkel.
hfinkel added a comment.
In http://reviews.llvm.org/D11932#222515, @ismail wrote:
> Tests pass but, now when I tried to compile a file with -fopenmp I get:
>
> LINK: fatal error LNK1104: cannot open file 'libomp.lib'
>
> libomp.lib does exist in "C:\Program Fi
nwilson updated this revision to Diff 32228.
nwilson added a comment.
Patch addressing comments; fix comment/documentation wording, scoping of
diagnostic and setting invalid declaration, and fix test.
I also modified the location of the diagnostic indicating an exception
specification is not al
ismail added a comment.
In http://reviews.llvm.org/D11932#225158, @hfinkel wrote:
> What library path should be passed (where did you build the OpenMP runtime
> library)?
This is a default installation so the lib path is $PATH_TO_CLANG_EXE/../lib
which in my case is C:\Program Files\LLVM\lib
14 matches
Mail list logo
