This revision was automatically updated to reflect the committed changes.
Closed by commit rL245139: Delay emitting members of dllexport classes until
the class is fully parsed… (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D11850?vs=32201&id=32207#toc
Repository:
rL L
Author: hans
Date: Fri Aug 14 20:18:16 2015
New Revision: 245139
URL: http://llvm.org/viewvc/llvm-project?rev=245139&view=rev
Log:
Delay emitting members of dllexport classes until the class is fully parsed
(PR23542)
This enables Clang to correctly handle code such as:
struct __declspec(dllex
Chris Bieneman writes:
> Ok… I wrote some CMake goop to enable sanitizers on a bootstrap build
> (I’ll clean up the patches and send those out separately). check-clang
> worked with asan and ubsan enabled.
>
> Is that sufficient pre-commit testing?
Yes, I'd expect that to shake out any problems.
Author: chapuni
Date: Fri Aug 14 20:32:15 2015
New Revision: 245144
URL: http://llvm.org/viewvc/llvm-project?rev=245144&view=rev
Log:
clangTidyModernizeModule: Update libdeps.
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/CMakeLists.txt
Modified: clang-tools-extra/trunk/clang-tidy/m
On Fri, Aug 14, 2015 at 2:02 PM, Hans Wennborg wrote:
> On Fri, Aug 14, 2015 at 1:55 PM, John McCall wrote:
>>> On Aug 14, 2015, at 1:25 PM, Hans Wennborg wrote:
>>> Reid and Nico suggested this should be merged to 3.7 together with
>>> r244468 as it fixes an issue with libc++ when compiled with
zaks.anna requested changes to this revision.
zaks.anna added a comment.
This revision now requires changes to proceed.
This patch needs tests.
We should treat the improvements to HTML uniquing separately from this patch.
> But I think it's not a critical issue as of now and it can be considered
Author: chapuni
Date: Fri Aug 14 20:56:49 2015
New Revision: 245145
URL: http://llvm.org/viewvc/llvm-project?rev=245145&view=rev
Log:
clangStaticAnalyzerCheckers: Update libdesp.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/CMakeLists.txt
Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/CM
Author: chapuni
Date: Fri Aug 14 21:05:49 2015
New Revision: 245146
URL: http://llvm.org/viewvc/llvm-project?rev=245146&view=rev
Log:
clang-tools-extra/test/clang-tidy/modernize-pass-by-value.cpp: Appease
targeting MS to give -fno-delayed-template-parsing.
Modified:
clang-tools-extra/trunk/t
Author: chapuni
Date: Fri Aug 14 21:27:22 2015
New Revision: 245147
URL: http://llvm.org/viewvc/llvm-project?rev=245147&view=rev
Log:
clang-tools-extra/test/clang-tidy/modernize-pass-by-value.cpp: Tweak not to
override -std=c++11.
Modified:
clang-tools-extra/trunk/test/clang-tidy/modernize-p
sfantao updated this revision to Diff 32211.
sfantao added a comment.
This patch tries to avoid as much as possible changing the common
infrastructure, by adapting the CapturedDecl creation in SEMA and by adding
support to a second type of capture - ImplicitParamDecl (on top of the existent
Fie
sfantao added a comment.
Alexey, John,
Thanks for the review! I've tried to address your concerns in the last diff.
Please, check the inlined comments to find answers for the remarks of the
previous diff.
Thanks again!
Samuel
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:863-8
modocache created this revision.
modocache added a reviewer: cfe-commits.
The tests that verify that accessing a property without using the result
emits a warning were needlessly complicated. Remove several layers of
abstraction to make the tests much simpler to read and reason about.
http://revi
modocache created this revision.
modocache added a reviewer: cfe-commits.
Depends on http://reviews.llvm.org/D12047.
Add a unit test which demonstrates the bug reported in
https://llvm.org/bugs/show_bug.cgi?id=24404.
If the macro is enclosed within parentheses, the warning is reported as
expecte
Author: majnemer
Date: Fri Aug 14 22:21:08 2015
New Revision: 245153
URL: http://llvm.org/viewvc/llvm-project?rev=245153&view=rev
Log:
[MS ABI] Switch catchpad/cleanuppad to use tokens
Modified:
cfe/trunk/lib/CodeGen/CGCleanup.cpp
cfe/trunk/lib/CodeGen/CGException.cpp
cfe/trunk/lib/Co
Author: jyknight
Date: Fri Aug 14 22:45:25 2015
New Revision: 245154
URL: http://llvm.org/viewvc/llvm-project?rev=245154&view=rev
Log:
Tiny cleanup: move some Triple variables up to the top of the
function, and remove a duplicate var.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/tr
jyknight added inline comments.
Comment at: lib/Driver/Tools.cpp:2928
@@ +2927,3 @@
+/// Parses the various -fpic/-fPIC/-fpie/-fPIE arguments. Then,
+/// smooshes them together with platform defaults, to decide with
+/// whether this compile should be using PIC mode or not. Retur
jyknight updated this revision to Diff 32216.
jyknight added a comment.
Updated for review comments
http://reviews.llvm.org/D11845
Files:
include/clang/Driver/CC1Options.td
lib/Driver/Tools.cpp
test/Driver/integrated-as.s
Index: test/Driver/integrated-as.s
===
Dear Nikhil,
The errors you are seeing are from trying to compile lib/PoolAllocate in
the poolalloc SVN module. As stated previously, you don't need the
Automatic Pool Allocation transform. You can comment out PoolAllocate
from the DIRS variable in poolalloc/lib/Makefile as Peter has done in
modocache created this revision.
modocache added a subscriber: cfe-commits.
r159483 changed the canonical name of the Clang test target from
'clang-test' to 'check-clang'. Although the old name is still a valid
alias, update the documentation to use the new, canonical target name.
http://reviews.
Sorry for not posting an update earlier.
I can't reproduce the build failure, and I see no build bots failing in a
similar way. Must be something with your local configuration.
On Fri, Aug 14, 2015 at 7:47 PM, Alexander Kornienko
wrote:
> Strange. No build bots complained about this so far. I'l
... or this may have been fixed by r245144. In any case, please check again
and report if anything is still broken.
On Sat, Aug 15, 2015 at 7:39 AM, Alexander Kornienko
wrote:
> Sorry for not posting an update earlier.
>
> I can't reproduce the build failure, and I see no build bots failing in a
thakis added a subscriber: thakis.
Comment at: Makefile:68
@@ -67,3 +67,3 @@
# http://gcc.gnu.org/PR41874
# http://gcc.gnu.org/PR41838
#
The first of these is marked fixed, the second has a "works on trunk" comment
(from 2010). Maybe this isn't needed with
101 - 122 of 122 matches
Mail list logo