Re: [PATCH] D12002: Initial WebAssembly support in clang

sunfish updated this revision to Diff 32109. sunfish added a comment. - use more default values in WebAssemblyTargetInfo etc. - add a comment about using ARM-C++-ABI-style guard variables (for now) - fix diff to include context for Phabricator Repository: rL LLVM http://reviews.llvm.org/D1200

Re: [PATCH] D11859: Generating vptr assume loads

hfinkel added a subscriber: hfinkel. Comment at: lib/CodeGen/CGClass.cpp:1832 @@ +1831,3 @@ + // Generate vtable assumptions if we are calling dynamic class ctor + // and we are not in another ctor. + if (CGM.getCodeGenOpts().OptimizationLevel > 0 && I think th

Re: r244912 - [Modules] Add Darwin-specific compatibility module map parsing hacks

This was the last thing blocking http://reviews.llvm.org/D10423, right? -- Sean Silva On Thu, Aug 13, 2015 at 10:13 AM, Ben Langmuir via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: benlangmuir > Date: Thu Aug 13 12:13:33 2015 > New Revision: 244912 > > URL: http://llvm.org/viewvc/

[libclc] r244987 - Remove files accidentally not removed in r244310

Author: jketema Date: Thu Aug 13 18:43:12 2015 New Revision: 244987 URL: http://llvm.org/viewvc/llvm-project?rev=244987&view=rev Log: Remove files accidentally not removed in r244310 Removed: libclc/trunk/generic/lib/LLVM3.6/ libclc/trunk/generic/lib/SOURCES_LLVM3.6 Removed: libclc/trunk

Re: r244912 - [Modules] Add Darwin-specific compatibility module map parsing hacks

This was the last thing blocking http://reviews.llvm.org/D10423 on your side, right? -- Sean Silva On Thu, Aug 13, 2015 at 10:13 AM, Ben Langmuir via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: benlangmuir > Date: Thu Aug 13 12:13:33 2015 > New Revision: 244912 > > URL: http://llv

Re: r244961 - [SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD.

On 08/13/15 18:01, Hans Wennborg wrote: On Thu, Aug 13, 2015 at 2:45 PM, Brad Smith via cfe-commits wrote: Author: brad Date: Thu Aug 13 16:45:57 2015 New Revision: 244961 URL: http://llvm.org/viewvc/llvm-project?rev=244961&view=rev Log: [SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on

Re: r244912 - [Modules] Add Darwin-specific compatibility module map parsing hacks

Yep, that should be it! > On Aug 13, 2015, at 4:45 PM, Sean Silva wrote: > > This was the last thing blocking http://reviews.llvm.org/D10423 > on your side, right? > > -- Sean Silva > > On Thu, Aug 13, 2015 at 10:13 AM, Ben Langmuir via cfe-commits > mailto:c

r244988 - [modules] When writing a module file built with -fmodule-map-file-home-is-cwd,

Author: rsmith Date: Thu Aug 13 18:47:44 2015 New Revision: 244988 URL: http://llvm.org/viewvc/llvm-project?rev=244988&view=rev Log: [modules] When writing a module file built with -fmodule-map-file-home-is-cwd, via a module map found by -fmodule-map-file=, the home directory of the module is the

Re: [PATCH] D11629: APValues and Constants and MaterializedTemporaryExpr need to have stable maps

This revision was automatically updated to reflect the committed changes. Closed by commit rL244989: Avoid iteration invalidation issues around MaterializedTemporaryExpr (authored by majnemer). Changed prior to commit: http://reviews.llvm.org/D11629?vs=32106&id=32111#toc Repository: rL LLVM

r244989 - Avoid iteration invalidation issues around MaterializedTemporaryExpr

Author: majnemer Date: Thu Aug 13 18:50:15 2015 New Revision: 244989 URL: http://llvm.org/viewvc/llvm-project?rev=244989&view=rev Log: Avoid iteration invalidation issues around MaterializedTemporaryExpr We risk iterator invalidation issues if we use a DenseMap to hold the backing storage for an

r244990 - Wdeprecated: ByrefHelpers are copy constructed by the ::buildByrefHelpers helper, make sure they're safely copyable

Author: dblaikie Date: Thu Aug 13 18:53:09 2015 New Revision: 244990 URL: http://llvm.org/viewvc/llvm-project?rev=244990&view=rev Log: Wdeprecated: ByrefHelpers are copy constructed by the ::buildByrefHelpers helper, make sure they're safely copyable Make the copy/move ctors protected and defaul

Re: [PATCH] D12002: Initial WebAssembly support in clang

sunfish marked 2 inline comments as done. Comment at: lib/Basic/Targets.cpp:6935 @@ +6934,3 @@ + +public: + explicit WebAssemblyTargetInfo(const llvm::Triple &T) : TargetInfo(T) { I've now removed this (for now; we can discuss what to do in a later patch). Repo

Re: r244912 - [Modules] Add Darwin-specific compatibility module map parsing hacks

On Thu, Aug 13, 2015 at 4:47 PM, Ben Langmuir wrote: > Yep, that should be it! > Great! -- Sean Silva > > On Aug 13, 2015, at 4:45 PM, Sean Silva wrote: > > This was the last thing blocking http://reviews.llvm.org/D10423 on your > side, right? > > -- Sean Silva > > On Thu, Aug 13, 2015 at 10

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

hfinkel added a subscriber: hfinkel. hfinkel requested changes to this revision. hfinkel added a reviewer: hfinkel. hfinkel added a comment. This revision now requires changes to proceed. As I've said in the review for http://reviews.llvm.org/D11814, this should be added to TargetOptions, and con

Re: r244923 - [modules] Change the way we deal with .d output for explicitly-specified module

On Thu, Aug 13, 2015 at 10:57 AM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Aug 13 12:57:10 2015 > New Revision: 244923 > > URL: http://llvm.org/viewvc/llvm-project?rev=244923&view=rev > Log: > [modules] Change the way we deal with .d output fo

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

echristo added a comment. Hi Hal, No, TargetOptions is exactly the wrong place to handle this due to wanting to have various functions compiled with and without a force aligned stack at the IR level that might not hold up at LTO time. -eric http://reviews.llvm.org/D11815 _

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

hfinkel added a comment. In http://reviews.llvm.org/D11815#224161, @echristo wrote: > Hi Hal, > > No, TargetOptions is exactly the wrong place to handle this due to wanting to > have various functions compiled with and without a force aligned stack at the > IR level that might not hold up at LT

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

echristo added a comment. No, RESET_OPTION isn't the right way to do this either. For exactly this sort of reason. You can't actually represent all of the code and options this way in the IR. If you can't do that then it's a non-starter. -eric http://reviews.llvm.org/D11815 ___

r244991 - This test was still failing for me after r244925, fix it harder.

Author: rsmith Date: Thu Aug 13 19:16:05 2015 New Revision: 244991 URL: http://llvm.org/viewvc/llvm-project?rev=244991&view=rev Log: This test was still failing for me after r244925, fix it harder. Modified: cfe/trunk/test/CodeGenCXX/new.cpp Modified: cfe/trunk/test/CodeGenCXX/new.cpp URL:

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

hfinkel added a comment. In http://reviews.llvm.org/D11815#224169, @echristo wrote: > No, RESET_OPTION isn't the right way to do this either. For exactly this sort > of reason. You can't actually represent all of the code and options this way > in the IR. If you can't do that then it's a non-st

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

On Thu, Aug 13, 2015 at 5:16 PM hfin...@anl.gov wrote: > hfinkel added a comment. > > In http://reviews.llvm.org/D11815#224169, @echristo wrote: > > > No, RESET_OPTION isn't the right way to do this either. For exactly this > sort of reason. You can't actually represent all of the code and option

Re: [PATCH] D11859: Generating vptr assume loads

Prazek added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1832 @@ +1831,3 @@ + // Generate vtable assumptions if we are calling dynamic class ctor + // and we are not in another ctor. + if (CGM.getCodeGenOpts().OptimizationLevel > 0 && hfinkel wrote: >

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

- Original Message - > From: "Eric Christopher" > To: reviews+d11815+public+324fadcdaae02...@reviews.llvm.org, > ahata...@gmail.com, dexonsm...@apple.com, > hfin...@anl.gov > Cc: cfe-commits@lists.llvm.org > Sent: Thursday, August 13, 2015 7:39:53 PM > Subject: Re: [PATCH] D11815: Pass su

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

Perhaps the comments I left weren't very clear, but the plan was to add a subtarget feature to all targets for now and remove it later when we add support for "generic" subtarget features, which I believe will be something that will belong to TargetSubtargetInfo (Eric has probably spent more time t

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

> > > > Apologies, I'm really resistant to more things being used in > > TargetOptions and I was (perhaps mistakenly) under the impression > > that you wanted to move it to TargetOptions without an IR > > serialization. We need all options to have that sort of > > serialization right? :) > > Absolu

Re: [PATCH] D11859: Generating vptr assume loads

rsmith added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1832 @@ +1831,3 @@ + // Generate vtable assumptions if we are calling dynamic class ctor + // and we are not in another ctor. + if (CGM.getCodeGenOpts().OptimizationLevel > 0 && Prazek wrote: > h

Re: [PATCH] D11832: [Patch] [Analyzer] false positive: Potential leak connected with memcpy (PR 22954)

dcoughlin added a comment. I'm still looking at this. Higher-level comments coming soon. Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1110 @@ +1109,3 @@ + assert(RO.getOffset() >= 0 && "Offset should not be negative"); + uint64_t LowerOffset = RO.getOffset(); +

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked 5 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D11859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r244998 - unique_ptrify ConsumedBlockInfo analysis to make it move assignable

Author: dblaikie Date: Thu Aug 13 20:26:19 2015 New Revision: 244998 URL: http://llvm.org/viewvc/llvm-project?rev=244998&view=rev Log: unique_ptrify ConsumedBlockInfo analysis to make it move assignable ConsumedBlockInfo objects were move assigned, but only in a state where the dtor was a no-op a

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked an inline comment as done. Comment at: lib/CodeGen/CGClass.cpp:1832 @@ +1831,3 @@ + // Generate vtable assumptions if we are calling dynamic class ctor + // and we are not in another ctor. + if (CGM.getCodeGenOpts().OptimizationLevel > 0 && rsmith

Re: [PATCH] D7642: Introduce the idea of a minimum libc version

compnerd added a comment. AIUI, ucrt is absolutely relevant since msvcrt itself has been split out into the ucrt. msvcrt is the "shared" common bits, while the ucrt is more "platform" specific bits. But really, the point is: supporting an older version with a newer compiler is what doing this

Re: [PATCH] D11859: Generating vptr assume loads

rsmith added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1832 @@ +1831,3 @@ + // Generate vtable assumptions if we are calling dynamic class ctor + // and we are not in another ctor. + if (CGM.getCodeGenOpts().OptimizationLevel > 0 && Prazek wrote: > r

Re: [PATCH] D11297: PR17829: Functions declared extern "C" with a name matching a mangled C++ function are allowed

rjmccall added a comment. In http://reviews.llvm.org/D11297#223622, @andreybokhanko wrote: > John, > > Thank you for the quick reply! > > Let me make sure I understand what you said, using my test as an example > (BTW, sorry if this is a dumb question -- I asked our local Clang experts, > but n

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked 3 inline comments as done. Comment at: lib/CodeGen/CGClass.cpp:1832 @@ +1831,3 @@ + // Generate vtable assumptions if we are calling dynamic class ctor + // and we are not in another ctor. + if (CGM.getCodeGenOpts().OptimizationLevel > 0 && rsmith

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 32122. Prazek marked an inline comment as done. http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGen/available-

Re: [PATCH] D7642: Introduce the idea of a minimum libc version

We could support that by allowing the MSVC version in the triple to be different from the -fms-compatibility-version on the command line. Today, this might even with with --target. That said, I don't imagine many people are doing this. Microsoft makes it hard for you to do this, and lots of code a

Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

Hi Hans, Is this bugfix something that can be merged into 3.7 ? Kind Regards Martell On Thu, Aug 13, 2015 at 4:42 PM, Martell Malone wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL244902: Driver: Fix include directories when not using >

Re: [PATCH] D7642: Introduce the idea of a minimum libc version

majnemer added a comment. In http://reviews.llvm.org/D7642#224225, @compnerd wrote: > AIUI, ucrt is absolutely relevant since msvcrt itself has been split out into > the ucrt. msvcrt is the "shared" common bits, while the ucrt is more > "platform" specific bits. > > But really, the point is: s

r245028 - [modules] Add an experimental -cc1 feature to embed the contents of an input

Author: rsmith Date: Fri Aug 14 00:02:58 2015 New Revision: 245028 URL: http://llvm.org/viewvc/llvm-project?rev=245028&view=rev Log: [modules] Add an experimental -cc1 feature to embed the contents of an input file in the .pcm files. This allows a smaller set of files to be sent to a remote build

[PATCH] D12026: Decorating vptr load & stores with !invariant.group

Prazek created this revision. Prazek added reviewers: rsmith, majnemer, pcc. Prazek added a subscriber: cfe-commits. Adding !invariant.group to vptr load/stores for devirtualization purposes. For more goto: http://lists.llvm.org/pipermail/cfe-dev/2015-July/044227.htm http://reviews.llvm.org/D120

Re: [PATCH] D10365: Add cmd to compilation database file format

klimek added a comment. Cool, looks good! If you need me to land it let me know. http://reviews.llvm.org/D10365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2